205225 2019-12-13 16:10:34 -0800 WebSWServerConnection::startFetch() should never fail synchronously 2019-12-16 02:54:16 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=205261 InRadar P2 Normal --- 1 cdumez cdumez beidson commit-queue ggaren webkit-bug-importer youennf oldest_to_newest 1598543 0 cdumez 2019-12-13 16:10:34 -0800 WebSWServerConnection::startFetch() should never fail synchronously. If it does, it will confuse the NetworkResourceLoader. NetworkResourceLoader::serviceWorkerDidNotHandle() will get called *before* NetworkResourceLoader::m_serviceWorkerFetchTask has been sent, which means that we would not properly deal with redirects. Worse, the call site which creates the ServiceWorkerFetchTask would then null out m_networkLoad, which would silently cancel the load that WebSWServerConnection::startFetch() started synchronously. 1598544 1 cdumez 2019-12-13 16:10:47 -0800 <rdar://problem/57490508> 1598549 2 385654 cdumez 2019-12-13 16:21:25 -0800 Created attachment 385654 Patch 1598659 3 ggaren 2019-12-14 11:59:10 -0800 r=me 1598667 4 385654 commit-queue 2019-12-14 13:49:18 -0800 Comment on attachment 385654 Patch Clearing flags on attachment: 385654 Committed r253528: <https://trac.webkit.org/changeset/253528> 1598668 5 commit-queue 2019-12-14 13:49:19 -0800 All reviewed patches have been landed. Closing bug. 1598817 6 youennf 2019-12-16 02:26:59 -0800 http/wpt/service-workers/postMessage-fetch-order.https.html fails consistently. The spec does not mandate the order between fetch and postMessage since these are different sources so we could update the test accordingly. An alternative would be to only delay the didNotHandle case, which would remove an unnecessary dispatch in the usual case. 385654 2019-12-13 16:21:25 -0800 2019-12-14 13:49:18 -0800 Patch bug-205225-20191213162124.patch text/plain 5605 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE1NGQzOTczNDJiOWM0ZDlh NWUyYzVhYjAxZTJiNmJhYWNmZDVkNjIuLjI4NzM0NDdhNGNlOWU3OWI4NThhMWNmYmZmYjQyN2I5 ZjBkNWM5ZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMTktMTItMTMgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBXZWJTV1NlcnZlckNvbm5lY3Rpb246 OnN0YXJ0RmV0Y2goKSBzaG91bGQgbmV2ZXIgZmFpbCBzeW5jaHJvbm91c2x5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDUyMjUKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzU3NDkwNTA4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlYlNXU2VydmVyQ29ubmVjdGlvbjo6c3RhcnRGZXRjaCgpIHNob3Vs ZCBuZXZlciBmYWlsIHN5bmNocm9ub3VzbHkuIElmIGl0IGRvZXMsIGl0IHdpbGwKKyAgICAgICAg Y29uZnVzZSB0aGUgTmV0d29ya1Jlc291cmNlTG9hZGVyLiBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6 OnNlcnZpY2VXb3JrZXJEaWROb3RIYW5kbGUoKSB3aWxsCisgICAgICAgIGdldCBjYWxsZWQgKmJl Zm9yZSogTmV0d29ya1Jlc291cmNlTG9hZGVyOjptX3NlcnZpY2VXb3JrZXJGZXRjaFRhc2sgaGFz IGJlZW4gc2VudCwgd2hpY2gKKyAgICAgICAgbWVhbnMgdGhhdCB3ZSB3b3VsZCBub3QgcHJvcGVy bHkgZGVhbCB3aXRoIHJlZGlyZWN0cy4gV29yc2UsIHRoZSBjYWxsIHNpdGUgd2hpY2ggY3JlYXRl cworICAgICAgICB0aGUgU2VydmljZVdvcmtlckZldGNoVGFzayB3b3VsZCB0aGVuIG51bGwgb3V0 IG1fbmV0d29ya0xvYWQsIHdoaWNoIHdvdWxkIHNpbGVudGx5IGNhbmNlbAorICAgICAgICB0aGUg bG9hZCB0aGF0IFdlYlNXU2VydmVyQ29ubmVjdGlvbjo6c3RhcnRGZXRjaCgpIHN0YXJ0ZWQgc3lu Y2hyb25vdXNseS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIEkgYW0gbm90IHN1cmUgaG93IHRv IHRlc3QgdGhpcy4gSXQgd291bGQgaGF2ZSB0byBjYXVzZSBhIHJlZGlyZWN0IGRvIGEgVVJMCisg ICAgICAgIHRoYXQgaGFzIGEgc2VydmljZSB3b3JrZXIgYW5kIHRoZW4gd2Ugd291bGQgaGF2ZSB0 byBnZXQgV2ViU1dTZXJ2ZXJDb25uZWN0aW9uOjpzdGFydEZldGNoKCkKKyAgICAgICAgdG8gZmFp bCBzeW5jaHJvbm91c2x5LiBJIHRoaW5rIHRoYXQgdG8gZmFpbCBzeW5jaHJvbm91c2x5LCB3ZSB3 b3VsZCBoYXZlIHRvIG5vdCBmaW5kIGEKKyAgICAgICAgU2VydmljZVdvcmtlciB3aXRoIHRoZSBn aXZlbiBJRCwgb3IgdGhlIFNlcnZpY2VXb3JrZXIncyBoYXNUaW1lZE91dEFueUZldGNoVGFza3Mg d291bGQgaGF2ZQorICAgICAgICB0byBiZSBzZXQuCisKKyAgICAgICAgSSBhZGRlZCBhIFJFTEVB U0VfQVNTRVJUKCkgaW4gTmV0d29ya1Jlc291cmNlTG9hZGVyOjpzZXJ2aWNlV29ya2VyRGlkTm90 SGFuZGxlKCkgdGhhdCB3b3VsZAorICAgICAgICBoYXZlIGNhdWdodCB0aGlzLgorCisgICAgICAg ICogTmV0d29ya1Byb2Nlc3MvU2VydmljZVdvcmtlci9XZWJTV1NlcnZlckNvbm5lY3Rpb24uY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJTV1NlcnZlckNvbm5lY3Rpb246OnN0YXJ0RmV0Y2gpOgor CiAyMDE5LTEyLTEzICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAg ICAgQWRkIE1FU1NBR0VfQ0hFQ0soKSBmb3Igc2VsZWN0ZWRJbmRleCBpbiBNZXNzYWdlczo6V2Vi UGFnZVByb3h5OjpTaG93UG9wdXBNZW51CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAKaW5kZXggNGJhNWY5ZWEwYjk3OGJk Mzc3ZGIyYzkxN2RlMWM4YzE3NjliNTIyYS4uYzYxZWU5ODllNWUwMzMyZGNlNTE1ZjU0ODMyZWM2 MWFmNTI2MDQ0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrUmVzb3VyY2VMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv TmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcApAQCAtMTI2NSwxMSArMTI2NSwxMiBAQCB2b2lkIE5l dHdvcmtSZXNvdXJjZUxvYWRlcjo6c3RhcnRXaXRoU2VydmljZVdvcmtlcigpCiAgICAgaWYgKG1f c2VydmljZVdvcmtlckZldGNoVGFzaykKICAgICAgICAgcmV0dXJuOwogCi0gICAgc2VydmljZVdv cmtlckRpZE5vdEhhbmRsZSgpOworICAgIHNlcnZpY2VXb3JrZXJEaWROb3RIYW5kbGUobnVsbHB0 cik7CiB9CiAKLXZvaWQgTmV0d29ya1Jlc291cmNlTG9hZGVyOjpzZXJ2aWNlV29ya2VyRGlkTm90 SGFuZGxlKCkKK3ZvaWQgTmV0d29ya1Jlc291cmNlTG9hZGVyOjpzZXJ2aWNlV29ya2VyRGlkTm90 SGFuZGxlKFNlcnZpY2VXb3JrZXJGZXRjaFRhc2sqIGZldGNoVGFzaykKIHsKKyAgICBSRUxFQVNF X0FTU0VSVChtX3NlcnZpY2VXb3JrZXJGZXRjaFRhc2suZ2V0KCkgPT0gZmV0Y2hUYXNrKTsKICAg ICBpZiAobV9wYXJhbWV0ZXJzLnNlcnZpY2VXb3JrZXJzTW9kZSA9PSBTZXJ2aWNlV29ya2Vyc01v ZGU6Ok9ubHkpIHsKICAgICAgICAgc2VuZChNZXNzYWdlczo6V2ViUmVzb3VyY2VMb2FkZXI6OlNl cnZpY2VXb3JrZXJEaWROb3RIYW5kbGUgeyB9LCBpZGVudGlmaWVyKCkpOwogICAgICAgICBhYm9y dCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVz b3VyY2VMb2FkZXIuaCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291 cmNlTG9hZGVyLmgKaW5kZXggMzExNWU5MTFlNThjZDJjOTJmNGE1ZTMyNDk1ODA5YjRmMmM5MWMz Ni4uMGE4Y2M0YjBjZjI4YmU5ZDM5ZjFjY2EwYjU3ZTcwMDMwZmE0MzI2MCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5oCkBA IC0xMjksNyArMTI5LDcgQEAgcHVibGljOgogCiAjaWYgRU5BQkxFKFNFUlZJQ0VfV09SS0VSKQog ICAgIHZvaWQgc3RhcnRXaXRoU2VydmljZVdvcmtlcigpOwotICAgIHZvaWQgc2VydmljZVdvcmtl ckRpZE5vdEhhbmRsZSgpOworICAgIHZvaWQgc2VydmljZVdvcmtlckRpZE5vdEhhbmRsZShTZXJ2 aWNlV29ya2VyRmV0Y2hUYXNrKik7CiAjZW5kaWYKIAogcHJpdmF0ZToKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvU2VydmljZVdvcmtlci9TZXJ2aWNlV29ya2VyRmV0 Y2hUYXNrLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvU2VydmljZVdvcmtlci9T ZXJ2aWNlV29ya2VyRmV0Y2hUYXNrLmNwcAppbmRleCAzMTU5NzAyZTY3NTczYTRmMzgzM2I2Mjk2 ZDUwYTBhZjYwZjU3YjJjLi4xYmUwNDIwZDc1Nzc4Y2VkZjZiMzRmNDQwYzQ2YjUwZjI4NDI0MzU1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1NlcnZpY2VXb3JrZXIv U2VydmljZVdvcmtlckZldGNoVGFzay5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy9TZXJ2aWNlV29ya2VyL1NlcnZpY2VXb3JrZXJGZXRjaFRhc2suY3BwCkBAIC0xNjUsNyAr MTY1LDcgQEAgdm9pZCBTZXJ2aWNlV29ya2VyRmV0Y2hUYXNrOjpkaWROb3RIYW5kbGUoKQogICAg IG1fdGltZW91dFRpbWVyLnN0b3AoKTsKICAgICBzb2Z0VXBkYXRlSWZOZWVkZWQoKTsKIAotICAg IG1fbG9hZGVyLnNlcnZpY2VXb3JrZXJEaWROb3RIYW5kbGUoKTsKKyAgICBtX2xvYWRlci5zZXJ2 aWNlV29ya2VyRGlkTm90SGFuZGxlKHRoaXMpOwogfQogCiB2b2lkIFNlcnZpY2VXb3JrZXJGZXRj aFRhc2s6OmNhbmNlbEZyb21DbGllbnQoKQpAQCAtMTgzLDcgKzE4Myw3IEBAIHZvaWQgU2Vydmlj ZVdvcmtlckZldGNoVGFzazo6Y29udGludWVGZXRjaFRhc2tXaXRoKFJlc291cmNlUmVxdWVzdCYm IHJlcXVlc3QpCiB7CiAgICAgbV90aW1lb3V0VGltZXIuc3RhcnRPbmVTaG90KG1fbG9hZGVyLmNv bm5lY3Rpb25Ub1dlYlByb2Nlc3MoKS5uZXR3b3JrUHJvY2VzcygpLnNlcnZpY2VXb3JrZXJGZXRj aFRpbWVvdXQoKSk7CiAgICAgaWYgKCFtX3NlcnZpY2VXb3JrZXJDb25uZWN0aW9uKSB7Ci0gICAg ICAgIG1fbG9hZGVyLnNlcnZpY2VXb3JrZXJEaWROb3RIYW5kbGUoKTsKKyAgICAgICAgbV9sb2Fk ZXIuc2VydmljZVdvcmtlckRpZE5vdEhhbmRsZSh0aGlzKTsKICAgICAgICAgcmV0dXJuOwogICAg IH0KICAgICBtX2N1cnJlbnRSZXF1ZXN0ID0gV1RGTW92ZShyZXF1ZXN0KTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvU2VydmljZVdvcmtlci9XZWJTV1NlcnZlckNv bm5lY3Rpb24uY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9TZXJ2aWNlV29ya2Vy L1dlYlNXU2VydmVyQ29ubmVjdGlvbi5jcHAKaW5kZXggOWMyNGMyODA2YWMwMDM5NDM5OTk5YTRl ZjUxZDQ2ZDhkNDgyYzBmZC4uYTU5MTE0Y2EyNjhlOWFmNDM1OWFjMjkyMTRiODQwYTkwZjkzYjE0 MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9TZXJ2aWNlV29ya2Vy L1dlYlNXU2VydmVyQ29ubmVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy9TZXJ2aWNlV29ya2VyL1dlYlNXU2VydmVyQ29ubmVjdGlvbi5jcHAKQEAgLTI0Miw3ICsy NDIsMTAgQEAgdm9pZCBXZWJTV1NlcnZlckNvbm5lY3Rpb246OnN0YXJ0RmV0Y2goU2VydmljZVdv cmtlckZldGNoVGFzayYgdGFzaywgU1dTZXJ2ZXJXb3IKICAgICB9CiAKICAgICBBU1NFUlQod29y a2VyLnN0YXRlKCkgPT0gU2VydmljZVdvcmtlclN0YXRlOjpBY3RpdmF0ZWQpOwotICAgIHJ1blNl cnZlcldvcmtlckFuZFN0YXJ0RmV0Y2godHJ1ZSk7CisgICAgLy8gTWFrZSBzdXJlIHdlIHN0YXJ0 IHRoZSBmZXRjaCBhc3luY2hyb25vdXNseSBiZWNhdXNlIGZhaWxpbmcgc3luY2hyb25vdXNseSB3 b3VsZCBnZXQgdGhlIE5ldHdvcmtSZXNvdXJjZUxvYWRlciBpbiBhIGJhZCBzdGF0ZS4KKyAgICBS dW5Mb29wOjptYWluKCkuZGlzcGF0Y2goW3J1blNlcnZlcldvcmtlckFuZFN0YXJ0RmV0Y2ggPSBX VEZNb3ZlKHJ1blNlcnZlcldvcmtlckFuZFN0YXJ0RmV0Y2gpXSgpIG11dGFibGUgeworICAgICAg ICBydW5TZXJ2ZXJXb3JrZXJBbmRTdGFydEZldGNoKHRydWUpOworICAgIH0pOwogfQogCiB2b2lk IFdlYlNXU2VydmVyQ29ubmVjdGlvbjo6cG9zdE1lc3NhZ2VUb1NlcnZpY2VXb3JrZXIoU2Vydmlj ZVdvcmtlcklkZW50aWZpZXIgZGVzdGluYXRpb25JZGVudGlmaWVyLCBNZXNzYWdlV2l0aE1lc3Nh Z2VQb3J0cyYmIG1lc3NhZ2UsIGNvbnN0IFNlcnZpY2VXb3JrZXJPckNsaWVudElkZW50aWZpZXIm IHNvdXJjZUlkZW50aWZpZXIpCg==