205221 2019-12-13 15:27:27 -0800 Add NS_UNAVAILABLE tags to prevent alloc inits for _WKResourceLoadStatistics* classes 2019-12-16 09:11:04 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney achristensen andersca commit-queue darin webkit-bug-importer oldest_to_newest 1598526 0 katherine_cheney 2019-12-13 15:27:27 -0800 _WKResourceLoadStatistics* classes should only be created via API::ResourceLoadStatistics*::create 1598527 1 webkit-bug-importer 2019-12-13 15:28:09 -0800 <rdar://problem/57927809> 1598530 2 385649 katherine_cheney 2019-12-13 15:30:51 -0800 Created attachment 385649 Patch 1598779 3 385649 darin 2019-12-15 17:15:46 -0800 Comment on attachment 385649 Patch This prevents accidental init at compile time if someone has the appropriate SDK headers, but to prevent it at runtime I believe the typical technique is to override init with a method that throws an exception. 1598907 4 katherine_cheney 2019-12-16 08:33:58 -0800 (In reply to Darin Adler from comment #3) > Comment on attachment 385649 [details] > Patch > > This prevents accidental init at compile time if someone has the appropriate > SDK headers, but to prevent it at runtime I believe the typical technique is > to override init with a method that throws an exception. Good to know, I will address this in a future patch. 1598920 5 385649 commit-queue 2019-12-16 09:11:02 -0800 Comment on attachment 385649 Patch Clearing flags on attachment: 385649 Committed r253557: <https://trac.webkit.org/changeset/253557> 1598921 6 commit-queue 2019-12-16 09:11:04 -0800 All reviewed patches have been landed. Closing bug. 385649 2019-12-13 15:30:51 -0800 2019-12-16 09:11:02 -0800 Patch bug-205221-20191213153051.patch text/plain 2484 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNDk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRkYzY3NTA1MjY4NWQyNDFh ODJjZjM2MTk0NGNmMzA3YjEzYTgwOTQuLjI2YjQ2Mzc0ZDIyM2FiZmE3NzYxMDcwYjljNjU3MWZm ZGUxODVlMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMTItMTMgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIE5TX1VOQVZB SUxBQkxFIHRhZ3MgdG8gcHJldmVudCBhbGxvYyBpbml0cyBmb3IgX1dLUmVzb3VyY2VMb2FkU3Rh dGlzdGljcyogY2xhc3NlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA1MjIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhpcyBwYXRjaCBlbnN1cmVzIHRoYXQgbm8gb25lIHRyaWVzIHRvIGFsbG9jIGlu aXQKKyAgICAgICAgX1dLUmVzb3VyY2VMb2FkU3RhdGlzdGljc0ZpcnN0UGFydHkgb3IKKyAgICAg ICAgX1dLUmVzb3VyY2VMb2FkU3RhdGlzdGljc1RoaXJkUGFydHkuIFRoZXkgc2hvdWxkIG9ubHkg YmUgY3JlYXRlZCB2aWEKKyAgICAgICAgdGhlIEFQSSBjYWxsIHRvIGNyZWF0ZSgpLgorCisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRmlyc3RQ YXJ0eS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLUmVzb3VyY2VMb2FkU3Rh dGlzdGljc1RoaXJkUGFydHkuaDoKKwogMjAxOS0xMi0xMyAgV2Vuc29uIEhzaWVoICA8d2Vuc29u X2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgZW5jb2RpbmcvZGVjb2Rpbmcg Zm9yIERpc3BsYXlMaXN0OjpEcmF3TmF0aXZlSW1hZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRmlyc3RQYXJ0 eS5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1Jlc291cmNlTG9hZFN0 YXRpc3RpY3NGaXJzdFBhcnR5LmgKaW5kZXggZGE5ZmE0ODFiMzZlNTlmMWIzOTE4YWQxY2U3ZTQ5 MWEyMmM5YWUxNi4uY2Q2ZjQ3N2I4OWFkNzU2YjZlZGE2ZTYzYzYzNDNiZWVjMzU5ZTI5MiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1Jlc291cmNlTG9h ZFN0YXRpc3RpY3NGaXJzdFBhcnR5LmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L0NvY29hL19XS1Jlc291cmNlTG9hZFN0YXRpc3RpY3NGaXJzdFBhcnR5LmgKQEAgLTI3LDYgKzI3 LDkgQEAgTlNfQVNTVU1FX05PTk5VTExfQkVHSU4KIAogQGludGVyZmFjZSBfV0tSZXNvdXJjZUxv YWRTdGF0aXN0aWNzRmlyc3RQYXJ0eSA6IE5TT2JqZWN0CiAKKysgKGluc3RhbmNldHlwZSluZXcg TlNfVU5BVkFJTEFCTEU7CistIChpbnN0YW5jZXR5cGUpaW5pdCBOU19VTkFWQUlMQUJMRTsKKwog QHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBOU1N0cmluZyAqZmlyc3RQYXJ0eURvbWFp bjsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgQk9PTCB0aGlyZFBhcnR5U3RvcmFn ZUFjY2Vzc0dyYW50ZWQ7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS9Db2NvYS9fV0tSZXNvdXJjZUxvYWRTdGF0aXN0aWNzVGhpcmRQYXJ0eS5oIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1Jlc291cmNlTG9hZFN0YXRpc3RpY3NUaGlyZFBh cnR5LmgKaW5kZXggZjQzNjhlOWUyNTc0MDRjZTc1ZjI3ZTlkNmY3ZDI4ZjdkZTIwNDgyMC4uNmNk ZTg3ZmI2OWY5ZTQyNGQ5ZmQwZTc3MDkyMDAyMTUyM2ViNjlhMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1Jlc291cmNlTG9hZFN0YXRpc3RpY3NUaGly ZFBhcnR5LmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1Jlc291 cmNlTG9hZFN0YXRpc3RpY3NUaGlyZFBhcnR5LmgKQEAgLTI5LDYgKzI5LDkgQEAgTlNfQVNTVU1F X05PTk5VTExfQkVHSU4KIAogQGludGVyZmFjZSBfV0tSZXNvdXJjZUxvYWRTdGF0aXN0aWNzVGhp cmRQYXJ0eSA6IE5TT2JqZWN0CiAKKysgKGluc3RhbmNldHlwZSluZXcgTlNfVU5BVkFJTEFCTEU7 CistIChpbnN0YW5jZXR5cGUpaW5pdCBOU19VTkFWQUlMQUJMRTsKKwogQHByb3BlcnR5IChub25h dG9taWMsIHJlYWRvbmx5KSBOU1N0cmluZyAqdGhpcmRQYXJ0eURvbWFpbjsKIEBwcm9wZXJ0eSAo bm9uYXRvbWljLCByZWFkb25seSkgTlNBcnJheTxfV0tSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRmly c3RQYXJ0eSAqPiAqdW5kZXJGaXJzdFBhcnRpZXM7CiAK