205202 2019-12-13 01:04:14 -0800 Make ServiceWorkerSoftUpdateLoader::loadWithCacheEntry more robust 2019-12-16 13:14:40 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen cdumez commit-queue webkit-bug-importer oldest_to_newest 1598279 0 youennf 2019-12-13 01:04:14 -0800 Make ServiceWorkerSoftUpdateLoader::loadWithCacheEntry more robust, in particular if didReceiveResponse ends up in an error. 1598280 1 youennf 2019-12-13 01:05:00 -0800 <rdar://problem/57852910> 1598282 2 385584 youennf 2019-12-13 01:09:52 -0800 Created attachment 385584 Patch 1598919 3 youennf 2019-12-16 09:10:43 -0800 Ping review 1599058 4 385584 commit-queue 2019-12-16 13:14:38 -0800 Comment on attachment 385584 Patch Clearing flags on attachment: 385584 Committed r253573: <https://trac.webkit.org/changeset/253573> 1599059 5 commit-queue 2019-12-16 13:14:40 -0800 All reviewed patches have been landed. Closing bug. 385584 2019-12-13 01:09:52 -0800 2019-12-16 13:14:38 -0800 Patch bug-205202-20191213100950.patch text/plain 5325 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMzYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU3YTExYjA3MWQ2Y2ViOGQz NGZhOTc0MDM0ZjQyZWI0MmY3MWQ3OTkuLjViNzQyNDU2NjBlOGM5MDZiN2JiNWZkMTE2Y2E3MTUx NmM0NTQzOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTktMTItMTMgIHlvdWVubiBm YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgU2VydmljZVdvcmtlclNv ZnRVcGRhdGVMb2FkZXI6OmxvYWRXaXRoQ2FjaGVFbnRyeSBtb3JlIHJvYnVzdAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1MjAyCisgICAgICAgIHJk YXI6Ly9wcm9ibGVtLzU3ODUyOTEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgSW4gY2FzZSBsb2FkaW5nIGFuIGVudHJ5IGZyb20gdGhlIGNhY2hlLCB3 ZSB3ZXJlIGNhbGxpbmcgZGlkUmVjZWl2ZVJlc3BvbnNlLAorICAgICAgICB3aGljaCBtYXkgZGVz dHJveSB0aGUgbG9hZGVyIGFuZCB0aGVuIGNvbnRpbnVlIHByb2Nlc3NpbmcuCisgICAgICAgIElu c3RlYWQsIGFkZCBhIHByb2Nlc3NSZXNwb25zZSBtZXRob2QgdGhhdCBjaGVja3MgdGhlIHJlc3Bv bnNlIGFuZCByZXR1cm5zIGFuIGVycm9yIGlmIG5lZWRlZC4KKyAgICAgICAgZGlkUmVjZWl2ZVJl c3BvbnNlIGNhbGxzIHRoaXMgbWV0aG9kIGFuZCByZXR1cm5zIGVhcmx5IGluIGNhc2Ugb2YgZXJy b3IuCisgICAgICAgIFNvIGRvZXMgdGhlIG1ldGhvZCBsb2FkaW5nIGRhdGEgZnJvbSB0aGUgY2Fj aGUuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIE5l dHdvcmtQcm9jZXNzL1NlcnZpY2VXb3JrZXIvU2VydmljZVdvcmtlclNvZnRVcGRhdGVMb2FkZXIu Y3BwOgorICAgICAgICAoV2ViS2l0OjpTZXJ2aWNlV29ya2VyU29mdFVwZGF0ZUxvYWRlcjo6bG9h ZFdpdGhDYWNoZUVudHJ5KToKKyAgICAgICAgKFdlYktpdDo6U2VydmljZVdvcmtlclNvZnRVcGRh dGVMb2FkZXI6OmRpZFJlY2VpdmVSZXNwb25zZSk6CisgICAgICAgIChXZWJLaXQ6OlNlcnZpY2VX b3JrZXJTb2Z0VXBkYXRlTG9hZGVyOjpwcm9jZXNzUmVzcG9uc2UpOgorICAgICAgICAqIE5ldHdv cmtQcm9jZXNzL1NlcnZpY2VXb3JrZXIvU2VydmljZVdvcmtlclNvZnRVcGRhdGVMb2FkZXIuaDoK KwogMjAxOS0xMi0xMCAgeW91ZW5uIGZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAg ICAgUmVzZXQgY2FjaGVkIGdldFVzZXJNZWRpYSBxdWVyaWVzIHdoZW4gY2FsbGluZyBzdG9wTWVk aWFDYXB0dXJlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1NlcnZp Y2VXb3JrZXIvU2VydmljZVdvcmtlclNvZnRVcGRhdGVMb2FkZXIuY3BwIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9TZXJ2aWNlV29ya2VyL1NlcnZpY2VXb3JrZXJTb2Z0VXBkYXRlTG9h ZGVyLmNwcAppbmRleCBiNzRkYTI3ZGQzMDM3YjYzODMyMjhjYzhmODA2MmY3Mjg1ZjdhYzQ0Li5m MTg2M2FkNTFhYzlhNzM1OGZhNWYzNzZlYjM5NTY3NjllYjM1OGFhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1NlcnZpY2VXb3JrZXIvU2VydmljZVdvcmtlclNvZnRV cGRhdGVMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvU2Vydmlj ZVdvcmtlci9TZXJ2aWNlV29ya2VyU29mdFVwZGF0ZUxvYWRlci5jcHAKQEAgLTEwOCwxMiArMTA4 LDE1IEBAIHZvaWQgU2VydmljZVdvcmtlclNvZnRVcGRhdGVMb2FkZXI6OmZhaWwoUmVzb3VyY2VF cnJvciYmIGVycm9yKQogCiB2b2lkIFNlcnZpY2VXb3JrZXJTb2Z0VXBkYXRlTG9hZGVyOjpsb2Fk V2l0aENhY2hlRW50cnkoTmV0d29ya0NhY2hlOjpFbnRyeSYgZW50cnkpCiB7Ci0gICAgZGlkUmVj ZWl2ZVJlc3BvbnNlKFJlc291cmNlUmVzcG9uc2UgeyBlbnRyeS5yZXNwb25zZSgpIH0sIFtdKGF1 dG8pIHsgfSk7Ci0gICAgaWYgKG1fY29tcGxldGlvbkhhbmRsZXIgJiYgZW50cnkuYnVmZmVyKCkp CisgICAgYXV0byBlcnJvciA9IHByb2Nlc3NSZXNwb25zZShlbnRyeS5yZXNwb25zZSgpKTsKKyAg ICBpZiAoIWVycm9yLmlzTnVsbCgpKSB7CisgICAgICAgIGZhaWwoV1RGTW92ZShlcnJvcikpOwor ICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgaWYgKGVudHJ5LmJ1ZmZlcigpKQogICAgICAg ICBkaWRSZWNlaXZlQnVmZmVyKG1ha2VSZWYoKmVudHJ5LmJ1ZmZlcigpKSwgMCk7Ci0gICAgaWYg KG1fY29tcGxldGlvbkhhbmRsZXIpCi0gICAgICAgIGRpZEZpbmlzaExvYWRpbmcoeyB9KTsKLSAg ICBkaWRDb21wbGV0ZSgpOworICAgIGRpZEZpbmlzaExvYWRpbmcoeyB9KTsKIH0KIAogdm9pZCBT ZXJ2aWNlV29ya2VyU29mdFVwZGF0ZUxvYWRlcjo6bG9hZEZyb21OZXR3b3JrKE5ldHdvcmtTZXNz aW9uJiBzZXNzaW9uLCBSZXNvdXJjZVJlcXVlc3QmJiByZXF1ZXN0KQpAQCAtMTMxLDcgKzEzNCw2 IEBAIHZvaWQgU2VydmljZVdvcmtlclNvZnRVcGRhdGVMb2FkZXI6OndpbGxTZW5kUmVkaXJlY3Rl ZFJlcXVlc3QoUmVzb3VyY2VSZXF1ZXN0JiYsCiAgICAgZmFpbChSZXNvdXJjZUVycm9yIHsgUmVz b3VyY2VFcnJvcjo6VHlwZTo6Q2FuY2VsbGF0aW9uIH0pOwogfQogCi0vLyBodHRwczovL3czYy5n aXRodWIuaW8vU2VydmljZVdvcmtlci8jdXBkYXRlLWFsZ29yaXRobSwgc3RlcHMgOS43IHRvIDku MTcKIHZvaWQgU2VydmljZVdvcmtlclNvZnRVcGRhdGVMb2FkZXI6OmRpZFJlY2VpdmVSZXNwb25z ZShSZXNvdXJjZVJlc3BvbnNlJiYgcmVzcG9uc2UsIFJlc3BvbnNlQ29tcGxldGlvbkhhbmRsZXIm JiBjb21wbGV0aW9uSGFuZGxlcikKIHsKICAgICBpZiAocmVzcG9uc2UuaHR0cFN0YXR1c0NvZGUo KSA9PSAzMDQgJiYgbV9jYWNoZUVudHJ5KSB7CkBAIC0xMzksMjUgKzE0MSwzMSBAQCB2b2lkIFNl cnZpY2VXb3JrZXJTb2Z0VXBkYXRlTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2UoUmVzb3VyY2VS ZXNwb25zZSYmIHJlc3BvbgogICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihQb2xpY3lBY3Rpb246 Oklnbm9yZSk7CiAgICAgICAgIHJldHVybjsKICAgICB9Ci0KLSAgICBhdXRvIGVycm9yID0gV29y a2VyU2NyaXB0TG9hZGVyOjp2YWxpZGF0ZVdvcmtlclJlc3BvbnNlKHJlc3BvbnNlLCBGZXRjaE9w dGlvbnM6OkRlc3RpbmF0aW9uOjpTZXJ2aWNld29ya2VyKTsKKyAgICBhdXRvIGVycm9yID0gcHJv Y2Vzc1Jlc3BvbnNlKHJlc3BvbnNlKTsKICAgICBpZiAoIWVycm9yLmlzTnVsbCgpKSB7CiAgICAg ICAgIGZhaWwoV1RGTW92ZShlcnJvcikpOwogICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihQb2xp Y3lBY3Rpb246Oklnbm9yZSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CisgICAgY29tcGxldGlv bkhhbmRsZXIoUG9saWN5QWN0aW9uOjpVc2UpOworfQorCisvLyBodHRwczovL3czYy5naXRodWIu aW8vU2VydmljZVdvcmtlci8jdXBkYXRlLWFsZ29yaXRobSwgc3RlcHMgOS43IHRvIDkuMTcKK1Jl c291cmNlRXJyb3IgU2VydmljZVdvcmtlclNvZnRVcGRhdGVMb2FkZXI6OnByb2Nlc3NSZXNwb25z ZShjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSkKK3sKKyAgICBhdXRvIGVycm9yID0g V29ya2VyU2NyaXB0TG9hZGVyOjp2YWxpZGF0ZVdvcmtlclJlc3BvbnNlKHJlc3BvbnNlLCBGZXRj aE9wdGlvbnM6OkRlc3RpbmF0aW9uOjpTZXJ2aWNld29ya2VyKTsKKyAgICBpZiAoIWVycm9yLmlz TnVsbCgpKQorICAgICAgICByZXR1cm4gZXJyb3I7CisKICAgICBlcnJvciA9IFNlcnZpY2VXb3Jr ZXJKb2I6OnZhbGlkYXRlU2VydmljZVdvcmtlclJlc3BvbnNlKG1fam9iRGF0YSwgcmVzcG9uc2Up OwotICAgIGlmICghZXJyb3IuaXNOdWxsKCkpIHsKLSAgICAgICAgZmFpbChXVEZNb3ZlKGVycm9y KSk7Ci0gICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKFBvbGljeUFjdGlvbjo6SWdub3JlKTsKLSAg ICAgICAgcmV0dXJuOwotICAgIH0KKyAgICBpZiAoIWVycm9yLmlzTnVsbCgpKQorICAgICAgICBy ZXR1cm4gZXJyb3I7CiAKICAgICBtX2NvbnRlbnRTZWN1cml0eVBvbGljeSA9IENvbnRlbnRTZWN1 cml0eVBvbGljeVJlc3BvbnNlSGVhZGVycyB7IHJlc3BvbnNlIH07CiAgICAgbV9yZWZlcnJlclBv bGljeSA9IHJlc3BvbnNlLmh0dHBIZWFkZXJGaWVsZChIVFRQSGVhZGVyTmFtZTo6UmVmZXJyZXJQ b2xpY3kpOwogICAgIG1fcmVzcG9uc2VFbmNvZGluZyA9IHJlc3BvbnNlLnRleHRFbmNvZGluZ05h bWUoKTsKIAotICAgIGNvbXBsZXRpb25IYW5kbGVyKFBvbGljeUFjdGlvbjo6VXNlKTsKKyAgICBy ZXR1cm4geyB9OwogfQogCiB2b2lkIFNlcnZpY2VXb3JrZXJTb2Z0VXBkYXRlTG9hZGVyOjpkaWRS ZWNlaXZlQnVmZmVyKFJlZjxTaGFyZWRCdWZmZXI+JiYgYnVmZmVyLCBpbnQgcmVwb3J0ZWRFbmNv ZGVkRGF0YUxlbmd0aCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv U2VydmljZVdvcmtlci9TZXJ2aWNlV29ya2VyU29mdFVwZGF0ZUxvYWRlci5oIGIvU291cmNlL1dl YktpdC9OZXR3b3JrUHJvY2Vzcy9TZXJ2aWNlV29ya2VyL1NlcnZpY2VXb3JrZXJTb2Z0VXBkYXRl TG9hZGVyLmgKaW5kZXggNDIyYjEyNTBhYTdlNWJhM2IxYzkyMmM1YjcxNDQ2MjdkOTFjYTllNy4u ZGEyOTM5MTc4NDRiY2YzMzQ2NWQ5MDdjNDY1ZDU4ZmJkNTIwYTY3YSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9TZXJ2aWNlV29ya2VyL1NlcnZpY2VXb3JrZXJTb2Z0 VXBkYXRlTG9hZGVyLmgKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9TZXJ2aWNl V29ya2VyL1NlcnZpY2VXb3JrZXJTb2Z0VXBkYXRlTG9hZGVyLmgKQEAgLTcxLDYgKzcxLDcgQEAg cHJpdmF0ZToKICAgICB2b2lkIGxvYWRGcm9tTmV0d29yayhOZXR3b3JrU2Vzc2lvbiYsIFdlYkNv cmU6OlJlc291cmNlUmVxdWVzdCYmKTsKICAgICB2b2lkIGZhaWwoV2ViQ29yZTo6UmVzb3VyY2VF cnJvciYmKTsKICAgICB2b2lkIGRpZENvbXBsZXRlKCk7CisgICAgV2ViQ29yZTo6UmVzb3VyY2VF cnJvciBwcm9jZXNzUmVzcG9uc2UoY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZSYpOwog CiAgICAgSGFuZGxlciBtX2NvbXBsZXRpb25IYW5kbGVyOwogICAgIFdlYkNvcmU6OlNlcnZpY2VX b3JrZXJKb2JEYXRhIG1fam9iRGF0YTsK