<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>205187</bug_id>
          
          <creation_ts>2019-12-12 16:12:23 -0800</creation_ts>
          <short_desc>[GTK] WebKitTestRunner should enable gtk-xft-rgba</short_desc>
          <delta_ts>2019-12-12 16:14:04 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=54763</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>204671</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Alberto Lopez Perez">clopez</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1598183</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2019-12-12 16:12:23 -0800</bug_when>
    <thetext>When starting WebKitTestRunner we are disabling gtk-xft-rgba, and it seems that without this setting enabled Cairo ignores the fontconfig setting regarding subpixel rendering and prefers to use CAIRO_ANTIALIAS_GRAY instead of CAIRO_ANTIALIAS_SUBPIXEL.

That means that when running layout tests, the rendered of all the fonts that don&apos;t force a specific antialiasing via -webkit-font-smoothing are antialiased with CAIRO_ANTIALIAS_GRAY. However on a real use case (a desktop of a user) those fonts would be antialiased with CAIRO_ANTIALIAS_SUBPIXEL.

Other platforms (Mac) also default to CAIRO_ANTIALIAS_SUBPIXEL.

This causes the test compositing/contents-format/subpixel-antialiased-text.html to fail (after enabling support for -webkit-font-smoothing in bug 54763). Before that this test was doing nothing (passing, but not actually testing anything).

The issue is that simply flipping the bit to enable gtk-xft-rgba is problematic since it causes news thousands of failures related to the Ahem font, that seems were passing with CAIRO_ANTIALIAS_GRAY but would fail with CAIRO_ANTIALIAS_SUBPIXEL.

So, before enabling this we should always disable antialiasing for Ahem font in bug 204671</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1598184</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2019-12-12 16:14:04 -0800</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #0)
&gt; This causes the test
&gt; compositing/contents-format/subpixel-antialiased-text.html to fail (after
&gt; enabling support for -webkit-font-smoothing in bug 54763). Before that this
&gt; test was doing nothing (passing, but not actually testing anything).

Sorry, I mean the test: fast/text/font-antialiasing-save-restore.html</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>