205176 2019-12-12 13:19:50 -0800 Fix missing exception in JSValue::toWTFStringSlowCase(). 2019-12-12 17:12:59 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1598116 0 mark.lam 2019-12-12 13:19:50 -0800 Also fix all the new exception check failures that fall out of change. Also replaced some ASSERTs with EXCEPTION_ASSERT so that we can run the exception check validation on a release build. <rdar://problem/57871899> 1598126 1 385543 mark.lam 2019-12-12 13:40:14 -0800 Created attachment 385543 proposed patch. 1598130 2 385543 ysuzuki 2019-12-12 13:45:29 -0800 Comment on attachment 385543 proposed patch. r=me 1598210 3 mark.lam 2019-12-12 17:12:59 -0800 Thanks for the review. Landed in r253458: <http://trac.webkit.org/r253458>. 385543 2019-12-12 13:40:14 -0800 2019-12-12 13:45:29 -0800 proposed patch. bug-205176.patch text/plain 7580 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTM0NDEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTEyLTEyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggbWlzc2luZyBleGNlcHRpb24gaW4gSlNWYWx1ZTo6dG9XVEZTdHJp bmdTbG93Q2FzZSgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjA1MTc2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81Nzg3MTg5OT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9taXNzaW5n LWV4Y2VwdGlvbi1jaGVjay1pbi1KU1ZhbHVlLXRvV1RGU3RyaW5nU2xvd0Nhc2UuanM6IEFkZGVk LgorCiAyMDE5LTEyLTEyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAg ICBGaXggbWlzc2luZyBleGNlcHRpb24gY2hlY2sgaW4gSlNPTiBTdHJpbmdpZmllcidzIGdhcCBm dW5jdGlvbi4KSW5kZXg6IEpTVGVzdHMvc3RyZXNzL21pc3NpbmctZXhjZXB0aW9uLWNoZWNrLWlu LUpTVmFsdWUtdG9XVEZTdHJpbmdTbG93Q2FzZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0 cmVzcy9taXNzaW5nLWV4Y2VwdGlvbi1jaGVjay1pbi1KU1ZhbHVlLXRvV1RGU3RyaW5nU2xvd0Nh c2UuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvbWlzc2luZy1leGNlcHRpb24t Y2hlY2staW4tSlNWYWx1ZS10b1dURlN0cmluZ1Nsb3dDYXNlLmpzCSh3b3JraW5nIGNvcHkpCkBA IC0wLDAgKzEsMTEgQEAKKy8vQCBza2lwIGlmICRtZW1vcnlMaW1pdGVkCisvL0AgcnVuRGVmYXVs dAorCit0cnkgeworICAgIFJlZ0V4cCh7dG9TdHJpbmc6ICgpPT4gJycucGFkRW5kKDIqKjMxLTEs IDEwIC50b0xvY2FsZVN0cmluZygpKSB9KTsKK30gY2F0Y2ggKGUpIHsKKyAgICBleGNlcHRpb24g PSBlOworfQorCitpZiAoZXhjZXB0aW9uICE9ICJFcnJvcjogT3V0IG9mIG1lbW9yeSIpCisgICAg dGhyb3cgIkZBSUxFRCI7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1 MzQ0MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwyNSBAQAorMjAxOS0xMi0xMiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5j b20+CisKKyAgICAgICAgRml4IG1pc3NpbmcgZXhjZXB0aW9uIGluIEpTVmFsdWU6OnRvV1RGU3Ry aW5nU2xvd0Nhc2UoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwNTE3NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTc4NzE4OTk+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxzbyBmaXggYWxsIHRo ZSBuZXcgZXhjZXB0aW9uIGNoZWNrIGZhaWx1cmVzIHRoYXQgZmFsbCBvdXQgb2YgY2hhbmdlLgor ICAgICAgICBBbHNvIHJlcGxhY2VkIHNvbWUgQVNTRVJUcyB3aXRoIEVYQ0VQVElPTl9BU1NFUlQg c28gdGhhdCB3ZSBjYW4gcnVuIHRoZSBleGNlcHRpb24KKyAgICAgICAgY2hlY2sgdmFsaWRhdGlv biBvbiBhIHJlbGVhc2UgYnVpbGQuCisKKyAgICAgICAgKiBkZmcvREZHT3BlcmF0aW9ucy5jcHA6 CisgICAgICAgICoganNjLmNwcDoKKyAgICAgICAgKGR1bXBFeGNlcHRpb24pOgorICAgICAgICAq IHJ1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwOgorICAgICAgICAoSlNDOjphcnJheVByb3RvRnVu Y1B1c2gpOgorICAgICAgICAqIHJ1bnRpbWUvRXhjZXB0aW9uSGVscGVycy5jcHA6CisgICAgICAg IChKU0M6OmNyZWF0ZUVycm9yKToKKyAgICAgICAgKiBydW50aW1lL0pTQ0pTVmFsdWUuY3BwOgor ICAgICAgICAoSlNDOjpKU1ZhbHVlOjp0b1dURlN0cmluZ1Nsb3dDYXNlIGNvbnN0KToKKwogMjAx OS0xMi0xMiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IG1p c3NpbmcgZXhjZXB0aW9uIGNoZWNrIGluIEpTT04gU3RyaW5naWZpZXIncyBnYXAgZnVuY3Rpb24u CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAkocmV2aXNpb24gMjUzNDQxKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2pzYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI1MTUsNiArMjUxNSw3IEBA IHN0YXRpYyB2b2lkIGR1bXBFeGNlcHRpb24oR2xvYmFsT2JqZWN0KiAKICAgICB9IHdoaWxlIChm YWxzZSkKIAogICAgIGF1dG8gZXhjZXB0aW9uU3RyaW5nID0gZXhjZXB0aW9uLnRvV1RGU3RyaW5n KGdsb2JhbE9iamVjdCk7CisgICAgQ0hFQ0tfRVhDRVBUSU9OKCk7CiAgICAgRXhwZWN0ZWQ8Q1N0 cmluZywgVVRGOENvbnZlcnNpb25FcnJvcj4gZXhwZWN0ZWRDU3RyaW5nID0gZXhjZXB0aW9uU3Ry aW5nLnRyeUdldFV0ZjgoKTsKICAgICBpZiAoZXhwZWN0ZWRDU3RyaW5nKQogICAgICAgICBwcmlu dGYoIkV4Y2VwdGlvbjogJXNcbiIsIGV4cGVjdGVkQ1N0cmluZy52YWx1ZSgpLmRhdGEoKSk7CkBA IC0yNTM5LDE2ICsyNTQwLDIwIEBAIHN0YXRpYyB2b2lkIGR1bXBFeGNlcHRpb24oR2xvYmFsT2Jq ZWN0KiAKICAgICBKU1ZhbHVlIHN0YWNrVmFsdWUgPSBleGNlcHRpb24uZ2V0KGdsb2JhbE9iamVj dCwgc3RhY2tJRCk7CiAgICAgQ0hFQ0tfRVhDRVBUSU9OKCk7CiAgICAgCi0gICAgaWYgKG5hbWVW YWx1ZS50b1dURlN0cmluZyhnbG9iYWxPYmplY3QpID09ICJTeW50YXhFcnJvciIKLSAgICAgICAg JiYgKCFmaWxlTmFtZVZhbHVlLmlzVW5kZWZpbmVkT3JOdWxsKCkgfHwgIWxpbmVOdW1iZXJWYWx1 ZS5pc1VuZGVmaW5lZE9yTnVsbCgpKSkgewotICAgICAgICBwcmludGYoCi0gICAgICAgICAgICAi YXQgJXM6JXNcbiIsCi0gICAgICAgICAgICBmaWxlTmFtZVZhbHVlLnRvV1RGU3RyaW5nKGdsb2Jh bE9iamVjdCkudXRmOCgpLmRhdGEoKSwKLSAgICAgICAgICAgIGxpbmVOdW1iZXJWYWx1ZS50b1dU RlN0cmluZyhnbG9iYWxPYmplY3QpLnV0ZjgoKS5kYXRhKCkpOworICAgIGF1dG8gbmFtZVN0cmlu ZyA9IG5hbWVWYWx1ZS50b1dURlN0cmluZyhnbG9iYWxPYmplY3QpOworICAgIENIRUNLX0VYQ0VQ VElPTigpOworCisgICAgaWYgKG5hbWVTdHJpbmcgPT0gIlN5bnRheEVycm9yIiAmJiAoIWZpbGVO YW1lVmFsdWUuaXNVbmRlZmluZWRPck51bGwoKSB8fCAhbGluZU51bWJlclZhbHVlLmlzVW5kZWZp bmVkT3JOdWxsKCkpKSB7CisgICAgICAgIGF1dG8gZmlsZU5hbWVTdHJpbmcgPSBmaWxlTmFtZVZh bHVlLnRvV1RGU3RyaW5nKGdsb2JhbE9iamVjdCk7CisgICAgICAgIENIRUNLX0VYQ0VQVElPTigp OworICAgICAgICBhdXRvIGxpbmVOdW1iZXJTdHJpbmcgPSBsaW5lTnVtYmVyVmFsdWUudG9XVEZT dHJpbmcoZ2xvYmFsT2JqZWN0KTsKKyAgICAgICAgQ0hFQ0tfRVhDRVBUSU9OKCk7CisgICAgICAg IHByaW50ZigiYXQgJXM6JXNcbiIsIGZpbGVOYW1lU3RyaW5nLnV0ZjgoKS5kYXRhKCksIGxpbmVO dW1iZXJTdHJpbmcudXRmOCgpLmRhdGEoKSk7CiAgICAgfQogICAgIAogICAgIGlmICghc3RhY2tW YWx1ZS5pc1VuZGVmaW5lZE9yTnVsbCgpKSB7CiAgICAgICAgIGF1dG8gc3RhY2tTdHJpbmcgPSBz dGFja1ZhbHVlLnRvV1RGU3RyaW5nKGdsb2JhbE9iamVjdCk7CisgICAgICAgIENIRUNLX0VYQ0VQ VElPTigpOwogICAgICAgICBpZiAoc3RhY2tTdHJpbmcubGVuZ3RoKCkpCiAgICAgICAgICAgICBw cmludGYoIiVzXG4iLCBzdGFja1N0cmluZy51dGY4KCkuZGF0YSgpKTsKICAgICB9CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAJKHJldmlzaW9uIDI1 MzQ0MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTIzNzUsNyArMjM3NSw3IEBAIEVuY29kZWRKU1ZhbHVlIEpJVF9PUEVS QVRJT04gb3BlcmF0aW9uSGEKICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc0Jvb2xl YW4oZmFsc2UpKTsKIAogICAgIEpTT2JqZWN0KiBiYXNlID0gYmFzZVZhbHVlLnRvT2JqZWN0KGds b2JhbE9iamVjdCk7Ci0gICAgQVNTRVJUKCFzY29wZS5leGNlcHRpb24oKSB8fCAhYmFzZSk7Cisg ICAgRVhDRVBUSU9OX0FTU0VSVCghc2NvcGUuZXhjZXB0aW9uKCkgfHwgIWJhc2UpOwogICAgIGlm ICghYmFzZSkKICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShKU1ZhbHVlKCkpOwogICAg IGF1dG8gcHJvcGVydHlOYW1lID0gYXNTdHJpbmcocHJvcGVydHkpLT50b0lkZW50aWZpZXIoZ2xv YmFsT2JqZWN0KTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5UHJv dG90eXBlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9B cnJheVByb3RvdHlwZS5jcHAJKHJldmlzaW9uIDI1MzQ0MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODg5LDcg Kzg4OSw5IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgYXJyYXlQcm90b0YKICAgICAg ICAgICAgIHRoaXNPYmotPm1ldGhvZFRhYmxlKHZtKS0+cHV0QnlJbmRleCh0aGlzT2JqLCBnbG9i YWxPYmplY3QsIGxlbmd0aCArIG4sIGNhbGxGcmFtZS0+dW5jaGVja2VkQXJndW1lbnQobiksIHRy dWUpOwogICAgICAgICBlbHNlIHsKICAgICAgICAgICAgIFB1dFByb3BlcnR5U2xvdCBzbG90KHRo aXNPYmopOwotICAgICAgICAgICAgSWRlbnRpZmllciBwcm9wZXJ0eU5hbWUgPSBJZGVudGlmaWVy Ojpmcm9tU3RyaW5nKHZtLCBKU1ZhbHVlKHN0YXRpY19jYXN0PGludDY0X3Q+KGxlbmd0aCkgKyBz dGF0aWNfY2FzdDxpbnQ2NF90PihuKSkudG9XVEZTdHJpbmcoZ2xvYmFsT2JqZWN0KSk7CisgICAg ICAgICAgICBhdXRvIHN0cmluZyA9IEpTVmFsdWUoc3RhdGljX2Nhc3Q8aW50NjRfdD4obGVuZ3Ro KSArIHN0YXRpY19jYXN0PGludDY0X3Q+KG4pKS50b1dURlN0cmluZyhnbG9iYWxPYmplY3QpOwor ICAgICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZW5jb2RlZEpTVmFsdWUoKSk7 CisgICAgICAgICAgICBJZGVudGlmaWVyIHByb3BlcnR5TmFtZSA9IElkZW50aWZpZXI6OmZyb21T dHJpbmcodm0sIHN0cmluZyk7CiAgICAgICAgICAgICB0aGlzT2JqLT5tZXRob2RUYWJsZSh2bSkt PnB1dCh0aGlzT2JqLCBnbG9iYWxPYmplY3QsIHByb3BlcnR5TmFtZSwgY2FsbEZyYW1lLT51bmNo ZWNrZWRBcmd1bWVudChuKSwgc2xvdCk7CiAgICAgICAgIH0KICAgICAgICAgUkVUVVJOX0lGX0VY Q0VQVElPTihzY29wZSwgZW5jb2RlZEpTVmFsdWUoKSk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9FeGNlcHRpb25IZWxwZXJzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGNlcHRpb25IZWxwZXJzLmNwcAkocmV2aXNpb24gMjUz NDQxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhjZXB0aW9uSGVscGVycy5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTI2Niw3ICsyNjYsNyBAQCBKU09iamVjdCogY3JlYXRlRXJy b3IoSlNHbG9iYWxPYmplY3QqIGdsCiAgICAgYXV0byBzY29wZSA9IERFQ0xBUkVfQ0FUQ0hfU0NP UEUodm0pOwogCiAgICAgU3RyaW5nIHZhbHVlRGVzY3JpcHRpb24gPSBlcnJvckRlc2NyaXB0aW9u Rm9yVmFsdWUoZ2xvYmFsT2JqZWN0LCB2YWx1ZSk7Ci0gICAgQVNTRVJUKHNjb3BlLmV4Y2VwdGlv bigpIHx8ICEhdmFsdWVEZXNjcmlwdGlvbik7CisgICAgRVhDRVBUSU9OX0FTU0VSVChzY29wZS5l eGNlcHRpb24oKSB8fCAhIXZhbHVlRGVzY3JpcHRpb24pOwogICAgIGlmICghdmFsdWVEZXNjcmlw dGlvbikgewogICAgICAgICBzY29wZS5jbGVhckV4Y2VwdGlvbigpOwogICAgICAgICByZXR1cm4g Y3JlYXRlT3V0T2ZNZW1vcnlFcnJvcihnbG9iYWxPYmplY3QpOwpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSlNDSlNWYWx1ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDSlNWYWx1ZS5jcHAJKHJldmlzaW9uIDI1MzQ0MSkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ0pTVmFsdWUuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC00MDQsNiArNDA0LDcgQEAgSlNTdHJpbmcqIEpTVmFsdWU6OnRvU3RyaW5nU2xvd0Nh c2UoSlNHbAogU3RyaW5nIEpTVmFsdWU6OnRvV1RGU3RyaW5nU2xvd0Nhc2UoSlNHbG9iYWxPYmpl Y3QqIGdsb2JhbE9iamVjdCkgY29uc3QKIHsKICAgICBWTSYgdm0gPSBnbG9iYWxPYmplY3QtPnZt KCk7CisgICAgYXV0byBzY29wZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOwogICAgIGlmIChp c0ludDMyKCkpCiAgICAgICAgIHJldHVybiB2bS5udW1lcmljU3RyaW5ncy5hZGQoYXNJbnQzMigp KTsKICAgICBpZiAoaXNEb3VibGUoKSkKQEAgLTQxNiw3ICs0MTcsOSBAQCBTdHJpbmcgSlNWYWx1 ZTo6dG9XVEZTdHJpbmdTbG93Q2FzZShKU0dsCiAgICAgICAgIHJldHVybiB2bS5wcm9wZXJ0eU5h bWVzLT5udWxsS2V5d29yZC5zdHJpbmcoKTsKICAgICBpZiAoaXNVbmRlZmluZWQoKSkKICAgICAg ICAgcmV0dXJuIHZtLnByb3BlcnR5TmFtZXMtPnVuZGVmaW5lZEtleXdvcmQuc3RyaW5nKCk7Ci0g ICAgcmV0dXJuIHRvU3RyaW5nKGdsb2JhbE9iamVjdCktPnZhbHVlKGdsb2JhbE9iamVjdCk7Cisg ICAgSlNTdHJpbmcqIHN0cmluZyA9IHRvU3RyaW5nKGdsb2JhbE9iamVjdCk7CisgICAgUkVUVVJO X0lGX0VYQ0VQVElPTihzY29wZSwgeyB9KTsKKyAgICBSRUxFQVNFX0FORF9SRVRVUk4oc2NvcGUs IHN0cmluZy0+dmFsdWUoZ2xvYmFsT2JqZWN0KSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIEpTQwo=