205165 2019-12-12 09:05:14 -0800 Uninitialized variables in RenderLayer 2019-12-13 00:41:17 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bfulgham esprehn+autocc ews-watchlist fred.wang glenn kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1598010 0 cgarcia 2019-12-12 09:05:14 -0800 Caught by valgrind: ==134047== Conditional jump or move depends on uninitialised value(s) ==134047== at 0x7DD9B96: WebCore::RenderLayer::setIsCSSStackingContext(bool) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==134047== by 0x7DE8F7D: WebCore::RenderLayer::RenderLayer(WebCore::RenderLayerModelObject&) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==134047== by 0x7E34150: WebCore::RenderLayerModelObject::createLayer() (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==134047== by 0x7E34B1B: WebCore::RenderLayerModelObject::styleDidChange(WebCore::StyleDifference, WebCore::RenderStyle const*) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==134047== by 0x7D5BD36: WebCore::RenderBox::styleDidChange(WebCore::StyleDifference, WebCore::RenderStyle const*) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==134047== by 0x7D5D0AD: WebCore::RenderBlock::styleDidChange(WebCore::StyleDifference, WebCore::RenderStyle const*) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==134047== by 0x7D5D417: WebCore::RenderBlockFlow::styleDidChange(WebCore::StyleDifference, WebCore::RenderStyle const*) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==134047== by 0x7FBA6D2: WebCore::RenderTreeUpdater::createRenderer(WebCore::Element&, WebCore::RenderStyle&&) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==134047== by 0x7FBA961: WebCore::RenderTreeUpdater::updateElementRenderer(WebCore::Element&, WebCore::Style::ElementUpdate const&) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==134047== by 0x7FBBFCE: WebCore::RenderTreeUpdater::updateRenderTree(WebCore::ContainerNode&) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==134047== by 0x7FBC70A: WebCore::RenderTreeUpdater::commit(std::unique_ptr<WebCore::Style::Update const, std::default_delete<WebCore::Style::Update const> >) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==134047== by 0x750BDB5: WebCore::Document::resolveStyle(WebCore::Document::ResolveStyleType) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==134047== ==133221== Conditional jump or move depends on uninitialised value(s) ==133221== at 0x7DD9CCF: WebCore::RenderLayer::setIsNormalFlowOnly(bool) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==133221== by 0x7DE8F6A: WebCore::RenderLayer::RenderLayer(WebCore::RenderLayerModelObject&) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==133221== by 0x7E34150: WebCore::RenderLayerModelObject::createLayer() (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==133221== by 0x7E34B1B: WebCore::RenderLayerModelObject::styleDidChange(WebCore::StyleDifference, WebCore::RenderStyle const*) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==133221== by 0x7D5BD36: WebCore::RenderBox::styleDidChange(WebCore::StyleDifference, WebCore::RenderStyle const*) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==133221== by 0x7D5D0AD: WebCore::RenderBlock::styleDidChange(WebCore::StyleDifference, WebCore::RenderStyle const*) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==133221== by 0x7D5D417: WebCore::RenderBlockFlow::styleDidChange(WebCore::StyleDifference, WebCore::RenderStyle const*) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==133221== by 0x7FBA6D2: WebCore::RenderTreeUpdater::createRenderer(WebCore::Element&, WebCore::RenderStyle&&) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==133221== by 0x7FBA961: WebCore::RenderTreeUpdater::updateElementRenderer(WebCore::Element&, WebCore::Style::ElementUpdate const&) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==133221== by 0x7FBBFCE: WebCore::RenderTreeUpdater::updateRenderTree(WebCore::ContainerNode&) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==133221== by 0x7FBC70A: WebCore::RenderTreeUpdater::commit(std::unique_ptr<WebCore::Style::Update const, std::default_delete<WebCore::Style::Update const> >) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==133221== by 0x750BDB5: WebCore::Document::resolveStyle(WebCore::Document::ResolveStyleType) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.42.0) ==133221== 1598011 1 385499 cgarcia 2019-12-12 09:07:04 -0800 Created attachment 385499 Patch 1598277 2 cgarcia 2019-12-13 00:41:01 -0800 Committed r253466: <https://trac.webkit.org/changeset/253466> 1598278 3 webkit-bug-importer 2019-12-13 00:41:17 -0800 <rdar://problem/57905791> 385499 2019-12-12 09:07:04 -0800 2019-12-12 11:04:34 -0800 Patch wcore-uninitialized-render-layer.diff text/plain 1351 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyNWQxNDMzZmE1YS4uMWE1NmJkMGM1MDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOS0xMi0xMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgVW5pbml0aWFsaXplZCB2YXJpYWJsZXMgaW4gUmVuZGVyTGF5 ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTE2 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpS ZW5kZXJMYXllcik6IEluaXRpYWxpemUgbV9pc05vcm1hbEZsb3dPbmx5IGFuZCBtX2lzQ1NTU3Rh Y2tpbmdDb250ZXh0LgorCiAyMDE5LTEyLTEyICB5b3Vlbm4gZmFibGV0ICA8eW91ZW5uQGFwcGxl LmNvbT4KIAogICAgICAgICBSZW1vdmUgZGVidWcgQVNTRVJUIGluIFBlZXJDb25uZWN0aW9uQmFj a2VuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggZDg0YWQx YTFkYWUuLjU0NGYyMDY0OTU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ci5jcHAKQEAgLTI4Niw2ICsyODYsOCBAQCBzdGF0aWMgVGV4dFN0cmVhbSYgb3BlcmF0b3I8PChU ZXh0U3RyZWFtJiB0cywgY29uc3QgQ2xpcFJlY3RzJiBjbGlwUmVjdHMpCiBSZW5kZXJMYXllcjo6 UmVuZGVyTGF5ZXIoUmVuZGVyTGF5ZXJNb2RlbE9iamVjdCYgcmVuZGVyZXJMYXllck1vZGVsT2Jq ZWN0KQogICAgIDogbV9pc1JlbmRlclZpZXdMYXllcihyZW5kZXJlckxheWVyTW9kZWxPYmplY3Qu aXNSZW5kZXJWaWV3KCkpCiAgICAgLCBtX2ZvcmNlZFN0YWNraW5nQ29udGV4dChyZW5kZXJlckxh eWVyTW9kZWxPYmplY3QuaXNNZWRpYSgpKQorICAgICwgbV9pc05vcm1hbEZsb3dPbmx5KGZhbHNl KQorICAgICwgbV9pc0NTU1N0YWNraW5nQ29udGV4dChmYWxzZSkKICAgICAsIG1faXNPcHBvcnR1 bmlzdGljU3RhY2tpbmdDb250ZXh0KGZhbHNlKQogICAgICwgbV96T3JkZXJMaXN0c0RpcnR5KGZh bHNlKQogICAgICwgbV9ub3JtYWxGbG93TGlzdERpcnR5KHRydWUpCg==