205155 2019-12-12 00:31:22 -0800 REGRESSION(r252979): Avoid unnecessary work when searching for the flow when constructing line layout iterator 2019-12-12 07:18:14 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham commit-queue esprehn+autocc ews-watchlist glenn kondapallykalyan pdr simon.fraser zalan oldest_to_newest 1597949 0 koivisto 2019-12-12 00:31:22 -0800 It may be slow. 1597950 1 koivisto 2019-12-12 00:32:08 -0800 <rdar://problem/57846936> 1597952 2 385484 koivisto 2019-12-12 00:39:10 -0800 Created attachment 385484 patch 1597987 3 385484 commit-queue 2019-12-12 07:18:13 -0800 Comment on attachment 385484 patch Clearing flags on attachment: 385484 Committed r253427: <https://trac.webkit.org/changeset/253427> 1597988 4 commit-queue 2019-12-12 07:18:14 -0800 All reviewed patches have been landed. Closing bug. 385484 2019-12-12 00:39:10 -0800 2019-12-12 07:18:13 -0800 patch linelayouttraversal-flow-search.patch text/plain 4861 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiYTE2YjQ0MGFkNC4uZDAwN2U2NDk4NGEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxOS0xMi0xMiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjUyOTc5KTogQXZvaWQgdW5uZWNlc3Nhcnkgd29yayB3 aGVuIHNlYXJjaGluZyBmb3IgdGhlIGZsb3cgd2hlbiBjb25zdHJ1Y3RpbmcgbGluZSBsYXlvdXQg aXRlcmF0b3JBdm9pZCB1bm5lY2Vzc2FyeSB3b3JrIHdoZW4gc2VhcmNoaW5nIGZvciB0aGUgZmxv dyB3aGVuIGNvbnN0cnVjdGluZyBsaW5lIGxheW91dCBpdGVyYXRvcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1MTU1CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS81Nzg0NjkzNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXZSB1bmVjZXNzYXJpbHkgc2VhcmNoZWQgdGhlIGFuY2VzdG9yIGNoYWluIGZs b3cgdGhlIFJlbmRlckZsb3cuIFdlIGNhbiBhdm9pZCB0aGlzCisgICAgICAgIGZvciBub3cgc2lu Y2Ugd2Uga25vdyBvbmx5IGNhbmRpZGF0ZSBpdCB0aGUgZGlyZWN0IHBhcmVudC4KKworICAgICAg ICAqIHJlbmRlcmluZy9saW5lL0xpbmVMYXlvdXRUcmF2ZXJzYWwuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6TGluZUxheW91dFRyYXZlcnNhbDo6bGluZUxheW91dFN5c3RlbUZsb3dGb3JSZW5kZXJl cik6CisgICAgICAgIChXZWJDb3JlOjpMaW5lTGF5b3V0VHJhdmVyc2FsOjpmaXJzdFRleHRCb3hG b3IpOgorICAgICAgICAoV2ViQ29yZTo6TGluZUxheW91dFRyYXZlcnNhbDo6Zmlyc3RUZXh0Qm94 SW5UZXh0T3JkZXJGb3IpOgorICAgICAgICAoV2ViQ29yZTo6TGluZUxheW91dFRyYXZlcnNhbDo6 ZWxlbWVudEJveEZvcik6CisgICAgICAgIChXZWJDb3JlOjpMaW5lTGF5b3V0VHJhdmVyc2FsOjpm bG93Rm9yVGV4dCk6IERlbGV0ZWQuCisKIDIwMTktMTItMTAgIENhdGhpZSBDaGVuICA8Y2F0aGll Y2hlbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIEZpeGVkIFBhdHRlcm4uaCBjb21waWxlIGVycm9y CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvbGluZS9MaW5lTGF5b3V0VHJh dmVyc2FsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9saW5lL0xpbmVMYXlvdXRUcmF2 ZXJzYWwuY3BwCmluZGV4IDBkYzA2MzU3N2I1Li41MWVmMjFmYTNhNSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL2xpbmUvTGluZUxheW91dFRyYXZlcnNhbC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL2xpbmUvTGluZUxheW91dFRyYXZlcnNhbC5jcHAKQEAg LTcwLDMzICs3MCwzNCBAQCBib29sIFRleHRCb3hJdGVyYXRvcjo6YXRFbmQoKSBjb25zdAogICAg IH0pOwogfQogCi1zdGF0aWMgY29uc3QgUmVuZGVyQmxvY2tGbG93JiBmbG93Rm9yVGV4dChjb25z dCBSZW5kZXJUZXh0JiB0ZXh0KQorc3RhdGljIGNvbnN0IFJlbmRlckJsb2NrRmxvdyogbGluZUxh eW91dFN5c3RlbUZsb3dGb3JSZW5kZXJlcihjb25zdCBSZW5kZXJPYmplY3QmIHJlbmRlcmVyKQog ewotICAgIHJldHVybiBkb3duY2FzdDxSZW5kZXJCbG9ja0Zsb3c+KCp0ZXh0LmNvbnRhaW5pbmdC bG9ja0Zvck9iamVjdEluRmxvdygpKTsKKyAgICAvLyBJbiBjdXJyZW50bHkgc3VwcG9ydGVkIGNh c2VzIHRoZSByZW5kZXJlciBpcyBhbHdheXMgZGlyZWN0IGNoaWxkIG9mIHRoZSBmbG93LgorICAg IGlmICghaXM8UmVuZGVyQmxvY2tGbG93PigqcmVuZGVyZXIucGFyZW50KCkpKQorICAgICAgICBy ZXR1cm4gbnVsbHB0cjsKKyAgICByZXR1cm4gZG93bmNhc3Q8UmVuZGVyQmxvY2tGbG93PihyZW5k ZXJlci5wYXJlbnQoKSk7CiB9CiAKIFRleHRCb3hJdGVyYXRvciBmaXJzdFRleHRCb3hGb3IoY29u c3QgUmVuZGVyVGV4dCYgdGV4dCkKIHsKLSAgICBhdXRvJiBmbG93ID0gZmxvd0ZvclRleHQodGV4 dCk7Ci0KLSAgICBpZiAoYXV0byogc2ltcGxlTGluZUxheW91dCA9IGZsb3cuc2ltcGxlTGluZUxh eW91dCgpKSB7Ci0gICAgICAgIGF1dG8gcmFuZ2UgPSBzaW1wbGVMaW5lTGF5b3V0LT5ydW5SZXNv bHZlcigpLnJhbmdlRm9yUmVuZGVyZXIodGV4dCk7Ci0gICAgICAgIHJldHVybiB7IFNpbXBsZVBh dGggeyByYW5nZS5iZWdpbigpLCByYW5nZS5lbmQoKSB9IH07Ci0gICAgfQorICAgIGlmIChhdXRv KiBmbG93ID0gbGluZUxheW91dFN5c3RlbUZsb3dGb3JSZW5kZXJlcih0ZXh0KSkgeworICAgICAg ICBpZiAoYXV0byogc2ltcGxlTGluZUxheW91dCA9IGZsb3ctPnNpbXBsZUxpbmVMYXlvdXQoKSkg eworICAgICAgICAgICAgYXV0byByYW5nZSA9IHNpbXBsZUxpbmVMYXlvdXQtPnJ1blJlc29sdmVy KCkucmFuZ2VGb3JSZW5kZXJlcih0ZXh0KTsKKyAgICAgICAgICAgIHJldHVybiB7IFNpbXBsZVBh dGggeyByYW5nZS5iZWdpbigpLCByYW5nZS5lbmQoKSB9IH07CisgICAgICAgIH0KIAogI2lmIEVO QUJMRShMQVlPVVRfRk9STUFUVElOR19DT05URVhUKQotICAgIGlmIChhdXRvKiBsYXlvdXRGb3Jt YXR0aW5nQ29udGV4dExpbmVMYXlvdXQgPSBmbG93LmxheW91dEZvcm1hdHRpbmdDb250ZXh0TGlu ZUxheW91dCgpKQotICAgICAgICByZXR1cm4gbGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRMaW5lTGF5 b3V0LT50ZXh0Qm94ZXNGb3IodGV4dCk7CisgICAgICAgIGlmIChhdXRvKiBsYXlvdXRGb3JtYXR0 aW5nQ29udGV4dExpbmVMYXlvdXQgPSBmbG93LT5sYXlvdXRGb3JtYXR0aW5nQ29udGV4dExpbmVM YXlvdXQoKSkKKyAgICAgICAgICAgIHJldHVybiBsYXlvdXRGb3JtYXR0aW5nQ29udGV4dExpbmVM YXlvdXQtPnRleHRCb3hlc0Zvcih0ZXh0KTsKICNlbmRpZgorICAgIH0KIAogICAgIHJldHVybiB7 IENvbXBsZXhQYXRoIHsgdGV4dC5maXJzdFRleHRCb3goKSB9IH07CiB9CiAKIFRleHRCb3hJdGVy YXRvciBmaXJzdFRleHRCb3hJblRleHRPcmRlckZvcihjb25zdCBSZW5kZXJUZXh0JiB0ZXh0KQog ewotICAgIGF1dG8mIGZsb3cgPSBmbG93Rm9yVGV4dCh0ZXh0KTsKLQotICAgIGlmIChmbG93LmNv bXBsZXhMaW5lTGF5b3V0KCkgJiYgdGV4dC5jb250YWluc1JldmVyc2VkVGV4dCgpICYmIHRleHQu Zmlyc3RUZXh0Qm94KCkpIHsKKyAgICBpZiAodGV4dC5maXJzdFRleHRCb3goKSAmJiB0ZXh0LmNv bnRhaW5zUmV2ZXJzZWRUZXh0KCkpIHsKICAgICAgICAgVmVjdG9yPGNvbnN0IElubGluZVRleHRC b3gqPiBzb3J0ZWRUZXh0Qm94ZXM7CiAgICAgICAgIGZvciAoYXV0byogdGV4dEJveCA9IHRleHQu Zmlyc3RUZXh0Qm94KCk7IHRleHRCb3g7IHRleHRCb3ggPSB0ZXh0Qm94LT5uZXh0VGV4dEJveCgp KQogICAgICAgICAgICAgc29ydGVkVGV4dEJveGVzLmFwcGVuZCh0ZXh0Qm94KTsKQEAgLTEyNywy MSArMTI4LDE3IEBAIGJvb2wgRWxlbWVudEJveEl0ZXJhdG9yOjphdEVuZCgpIGNvbnN0CiAKIEVs ZW1lbnRCb3hJdGVyYXRvciBlbGVtZW50Qm94Rm9yKGNvbnN0IFJlbmRlckxpbmVCcmVhayYgcmVu ZGVyRWxlbWVudCkKIHsKLSAgICBhdXRvKiBjb250YWluaW5nQmxvY2sgPSByZW5kZXJFbGVtZW50 LmNvbnRhaW5pbmdCbG9jaygpOwotICAgIGlmICghaXM8UmVuZGVyQmxvY2tGbG93Pihjb250YWlu aW5nQmxvY2spKQotICAgICAgICByZXR1cm4geyB9OwotCi0gICAgYXV0byYgZmxvdyA9IGRvd25j YXN0PFJlbmRlckJsb2NrRmxvdz4oKmNvbnRhaW5pbmdCbG9jayk7Ci0KLSAgICBpZiAoYXV0byog c2ltcGxlTGluZUxheW91dCA9IGZsb3cuc2ltcGxlTGluZUxheW91dCgpKSB7Ci0gICAgICAgIGF1 dG8gcmFuZ2UgPSBzaW1wbGVMaW5lTGF5b3V0LT5ydW5SZXNvbHZlcigpLnJhbmdlRm9yUmVuZGVy ZXIocmVuZGVyRWxlbWVudCk7Ci0gICAgICAgIHJldHVybiB7IFNpbXBsZVBhdGgocmFuZ2UuYmVn aW4oKSwgcmFuZ2UuZW5kKCkpIH07Ci0gICAgfQorICAgIGlmIChhdXRvKiBmbG93ID0gbGluZUxh eW91dFN5c3RlbUZsb3dGb3JSZW5kZXJlcihyZW5kZXJFbGVtZW50KSkgeworICAgICAgICBpZiAo YXV0byogc2ltcGxlTGluZUxheW91dCA9IGZsb3ctPnNpbXBsZUxpbmVMYXlvdXQoKSkgeworICAg ICAgICAgICAgYXV0byByYW5nZSA9IHNpbXBsZUxpbmVMYXlvdXQtPnJ1blJlc29sdmVyKCkucmFu Z2VGb3JSZW5kZXJlcihyZW5kZXJFbGVtZW50KTsKKyAgICAgICAgICAgIHJldHVybiB7IFNpbXBs ZVBhdGgocmFuZ2UuYmVnaW4oKSwgcmFuZ2UuZW5kKCkpIH07CisgICAgICAgIH0KIAogI2lmIEVO QUJMRShMQVlPVVRfRk9STUFUVElOR19DT05URVhUKQotICAgIGlmIChhdXRvKiBsYXlvdXRGb3Jt YXR0aW5nQ29udGV4dExpbmVMYXlvdXQgPSBmbG93LmxheW91dEZvcm1hdHRpbmdDb250ZXh0TGlu ZUxheW91dCgpKQotICAgICAgICByZXR1cm4gbGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRMaW5lTGF5 b3V0LT5lbGVtZW50Qm94Rm9yKHJlbmRlckVsZW1lbnQpOworICAgICAgICBpZiAoYXV0byogbGF5 b3V0Rm9ybWF0dGluZ0NvbnRleHRMaW5lTGF5b3V0ID0gZmxvdy0+bGF5b3V0Rm9ybWF0dGluZ0Nv bnRleHRMaW5lTGF5b3V0KCkpCisgICAgICAgICAgICByZXR1cm4gbGF5b3V0Rm9ybWF0dGluZ0Nv bnRleHRMaW5lTGF5b3V0LT5lbGVtZW50Qm94Rm9yKHJlbmRlckVsZW1lbnQpOwogI2VuZGlmCisg ICAgfQogCiAgICAgcmV0dXJuIHsgQ29tcGxleFBhdGgocmVuZGVyRWxlbWVudC5pbmxpbmVCb3hX cmFwcGVyKCkpIH07CiB9Cg==