20515 2008-08-25 13:26:37 -0700 Crash upon parsing CSS: unicode-range: searchfield-cancel-buttonpt=-webkit-dashboard-region= 2008-09-18 15:18:52 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED HasReduction, InRadar P1 Normal --- 1 robert.swiecki+wkbugs bdakin oldest_to_newest 89310 0 robert.swiecki+wkbugs 2008-08-25 13:26:37 -0700 Webkit: 35904 Crash on the following code: <html> <style> body { unicode-range: searchfield-cancel-buttonpt=-webkit-dashboard-region= } </style> </html> Seems similar (according to the stacktrace) to https://bugs.webkit.org/show_bug.cgi?id=20513 (994.de8): Access violation - code c0000005 (!!! second chance !!!) eax=00000000 ebx=7fd225e0 ecx=00000000 edx=0012f65c esi=7fd52338 edi=00000000 eip=00b4f1c2 esp=0012f610 ebp=0012f8f4 iopl=0 nv up ei ng nz ac po cy cs=001b ss=0023 ds=0023 es=0023 fs=003b gs=0000 efl=00000293 WebKit!WebCore::CSSStyleSelector::resolveVariablesForDeclaration+0xc3: 00b4f1c2 8b07 mov eax,dword ptr [edi] ds:0023:00000000=???????? 0:000> kb ChildEBP RetAddr Args to Child 0012f8f4 00aa2fa1 7fd22600 7fd225e0 0012f918 WebKit!WebCore::CSSStyleSelector::resolveVariablesForDeclaration+0xc3 [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\css\cssstyleselector.cpp @ 547] 0012f944 00796977 7fd22600 ffffffff 7fed8780 WebKit!WebCore::CSSStyleSelector::addMatchedDeclaration+0x315141 0012f968 00797785 0012f9a8 0012f9a4 7fd4e448 WebKit!WebCore::CSSStyleSelector::matchRules+0x127 [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\css\cssstyleselector.cpp @ 618] 0012f998 007902f4 7fd3f9b0 00000001 00000001 WebKit!WebCore::CSSStyleSelector::styleForElement+0x165 [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\css\cssstyleselector.cpp @ 1137] 0012f9ac 00791f9c 7fd4e448 7fd3f9b0 0012fa28 WebKit!WebCore::Element::styleForRenderer+0x14 [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\dom\element.cpp @ 672] 0012f9cc 00790bbb 7fe93320 7fd3f9b0 0076f0f0 WebKit!WebCore::Node::createRendererIfNeeded+0x5c [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\dom\node.cpp @ 1015] 0012f9d8 0076f0f0 7ff0b800 0000000a 7ff9005c WebKit!WebCore::Element::attach+0xb [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\dom\element.cpp @ 718] 0012fa04 00769873 00000000 0012fa28 00000000 WebKit!WebCore::ContainerNode::appendChild+0xf0 [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\dom\containernode.cpp @ 574] 0012fa40 009387fd 7febf6a8 7fe91250 00938ec8 WebKit!WebCore::Document::implicitClose+0x283 [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\dom\document.cpp @ 1540] 0012fa4c 00938ec8 7fe91250 7ff0b82c 007ea32b WebKit!WebCore::FrameLoader::checkCompleted+0x9d [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\loader\frameloader.cpp @ 1295] 0012fa58 007ea32b 00000000 7fd3a428 00007f1e WebKit!WebCore::FrameLoader::finishedParsing+0x28 [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\loader\frameloader.cpp @ 1243] 0012fa70 007e4f27 00c49174 0000001e 00007f1e WebKit!WebCore::Document::finishedParsing+0x4b [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\dom\document.cpp @ 3779] 0012fa94 007dc65e 7fd3a428 7fef6434 7fef6400 WebKit!WebCore::HTMLParser::finished+0xc7 [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\html\htmlparser.cpp @ 1538] 0012fab4 007f4a21 7fd3cc00 7febf6a8 7fe91250 WebKit!WebCore::HTMLTokenizer::end+0x12e [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\html\htmltokenizer.cpp @ 1851] 0012fb08 00938e67 7fecca00 7febf6a8 00938b2b WebKit!WebCore::HTMLTokenizer::finish+0x51 [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\html\htmltokenizer.cpp @ 1889] 0012fb14 00938b2b 7ff01a00 7fecca00 0486ca50 WebKit!WebCore::FrameLoader::endIfNotLoadingMainResource+0x47 [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\loader\frameloader.cpp @ 1076] 0012fb24 009f2243 7fd2c450 045abcf0 009f4e67 WebKit!WebCore::FrameLoader::finishedLoading+0x2b [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\loader\frameloader.cpp @ 2914] 0012fb30 009f4e67 00944e11 7fd2c450 045abcf0 WebKit!WebCore::MainResourceLoader::didFinishLoading+0x23 [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\loader\mainresourceloader.cpp @ 321] 0012fb34 00944e11 7fd2c450 045abcf0 6a535f00 WebKit!WebCore::ResourceLoader::didFinishLoading+0x7 [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\loader\resourceloader.cpp @ 399] *** ERROR: Symbol file could not be found. Defaulted to export symbols for C:\Program Files\Safari\CFNetwork.dll - 0012fb40 6a535f00 045abcf0 7fd2c450 0486ca50 WebKit!WebCore::didFinishLoading+0x21 [c:\cygwin\home\buildbot\slave\win32-release-archive\build\opensource\webcore\platform\network\cf\resourcehandlecfnet.cpp @ 119] 89312 1 hyatt 2008-08-25 13:42:28 -0700 CSSParserValue::createCSSValue needs to handle unknown identifiers. It drops them on the floor right now and returns 0. Then the value list ends up with a null item. We should fix this method to actually create a CSSPrimitiveValue that can really be used. (Will probably need a new unit type like CSS_PARSER_IDENTIFIER for unknown identifiers.) 89314 2 mrowe 2008-08-25 13:49:46 -0700 <rdar://problem/6174100> 91670 3 23537 bdakin 2008-09-18 14:13:38 -0700 Created attachment 23537 Patch to handle invalid IDs 91671 4 23537 hyatt 2008-09-18 14:22:42 -0700 Comment on attachment 23537 Patch to handle invalid IDs All you're doing is making a value that has absolutely no contents. You need to actually store the string and implement the round-tripping like the other CSS_PARSER_*** types do. We're going to be turning CSS variables off, which means this bug isn't that high priority. 91676 5 23539 bdakin 2008-09-18 14:57:47 -0700 Created attachment 23539 Patch 2 I see. Using the other CSS_PARSER… types as a model, I think this does that. 91678 6 23539 hyatt 2008-09-18 15:06:46 -0700 Comment on attachment 23539 Patch 2 + case CSS_PARSER_IDENTIFIER: + text = quoteStringIfNeeded(m_value.string); Add a "break;" in case we add more cases in the future. This line is wrong: + value.unit = m_type; It should set the type to CSS_IDENT. Please put the layout test under fast/css/variables, since when we turn CSS variables off, we don't want to have to look for tests in other subdirectories. Fix those two things and r=me 91680 7 bdakin 2008-09-18 15:18:37 -0700 Fixed both and moved the tests. Thanks, Dave! 91681 8 bdakin 2008-09-18 15:18:52 -0700 Oh, and r36624. 23537 2008-09-18 14:13:38 -0700 2008-09-18 14:57:47 -0700 Patch to handle invalid IDs invalidID.txt text/plain 5407 bdakin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNjYyMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjggQEAKKzIwMDgtMDktMTggIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBm b3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTE1IENyYXNoIHVw b24gCisgICAgICAgIHBhcnNpbmcgQ1NTOiB1bmljb2RlLXJhbmdlOiBzZWFyY2hmaWVsZC1jYW5j ZWwtYnV0dG9ucHQ9LXdlYmtpdC0KKyAgICAgICAgZGFzaGJvYXJkLXJlZ2lvbj0KKyAgICAgICAg YW5kIGNvcnJlc3BvbmRpbmc6IDxyZGFyOi8vcHJvYmxlbS82MTc0MTAwPgorCisgICAgICAgIFRo aXMgcGF0Y2ggbWFrZXMgQ1NTUGFyc2VyVmFsdWU6OmNyZWF0ZUNTU1ZhbHVlIGhhbmRsZSB1bmtu b3duIAorICAgICAgICBpZGVudGlmaWVycy4gCisKKyAgICAgICAgKiBjc3MvQ1NTUGFyc2VyVmFs dWVzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlclZhbHVlOjpjcmVhdGVDU1NWYWx1 ZSk6IElmIHdlIGhhdmUgYW4gaWRlbnRpZmllciAKKyAgICAgICAgd2l0aCBubyBpZCAoYW4gdW5r bm93biBpZGVudGlmaWVyKSBjcmVhdGUgYSBDU1NQcmltaXRpdmVWYWx1ZSBvZiAKKyAgICAgICAg dHlwZSBDU1NfUEFSU0VSX0lERU5USUZJRVIKKyAgICAgICAgKiBjc3MvQ1NTUHJpbWl0aXZlVmFs dWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUHJpbWl0aXZlVmFsdWU6OkNTU1ByaW1pdGl2 ZVZhbHVlKTogTmV3IGNvbnN0cnVjdG9yIAorICAgICAgICB0aGF0IHRha2VzIGp1c3QgYSB0eXBl LgorICAgICAgICAqIGNzcy9DU1NQcmltaXRpdmVWYWx1ZS5oOgorICAgICAgICAoV2ViQ29yZTo6 Q1NTUHJpbWl0aXZlVmFsdWU6Oik6IEFkZHMgQ1NTX1BBUlNFUl9JREVOVElGSUVSIHRvIHRoZSAK KyAgICAgICAgbGlzdCBvZiBVbml0VHlwZXMuCisgICAgICAgIChXZWJDb3JlOjpDU1NQcmltaXRp dmVWYWx1ZTo6Y3JlYXRlKTogTmV3IGNyZWF0ZSB0aGF0IHRha2VzIGp1c3QgYSAKKyAgICAgICAg dHlwZS4KKwogMjAwOC0wOS0xOCAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAg ICAgICAgTW92ZSB0aGUgY29uY2VwdCBvZiBzdXBwcmVzc2lvbiBpbnZhbGlkYXRpb24gb24gV2lk Z2V0cyB0byBTY3JvbGxiYXIKSW5kZXg6IFdlYkNvcmUvY3NzL0NTU1BhcnNlclZhbHVlcy5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTUGFyc2VyVmFsdWVzLmNwcAkocmV2aXNpb24g MzY2MTQpCisrKyBXZWJDb3JlL2Nzcy9DU1NQYXJzZXJWYWx1ZXMuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC02MSw2ICs2MSw4IEBAIFBhc3NSZWZQdHI8Q1NTVmFsdWU+IENTU1BhcnNlclZhbHVlOjpj cmUKICAgICBSZWZQdHI8Q1NTVmFsdWU+IHBhcnNlZFZhbHVlOwogICAgIGlmIChpZCkKICAgICAg ICAgcGFyc2VkVmFsdWUgPSBDU1NQcmltaXRpdmVWYWx1ZTo6Y3JlYXRlSWRlbnRpZmllcihpZCk7 CisgICAgZWxzZSBpZiAodW5pdCA9PSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX0lERU5UKQorICAg ICAgICBwYXJzZWRWYWx1ZSA9IENTU1ByaW1pdGl2ZVZhbHVlOjpjcmVhdGUoQ1NTUHJpbWl0aXZl VmFsdWU6OkNTU19QQVJTRVJfSURFTlRJRklFUik7CiAgICAgZWxzZSBpZiAodW5pdCA9PSBDU1NQ cmltaXRpdmVWYWx1ZTo6Q1NTX05VTUJFUiAmJiBpc0ludCkKICAgICAgICAgcGFyc2VkVmFsdWUg PSBDU1NQcmltaXRpdmVWYWx1ZTo6Y3JlYXRlKGZWYWx1ZSwgQ1NTUHJpbWl0aXZlVmFsdWU6OkNT U19QQVJTRVJfSU5URUdFUik7CiAgICAgZWxzZSBpZiAodW5pdCA9PSBDU1NQYXJzZXJWYWx1ZTo6 T3BlcmF0b3IpIHsKSW5kZXg6IFdlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHAJKHJldmlzaW9uIDM2 NjE0KQorKysgV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xMzYsNiArMTM2LDExIEBAIENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NQcmltaXRpdmVWYWx1 ZShkb3UKICAgICBtX3ZhbHVlLm51bSA9IG51bTsKIH0KIAorQ1NTUHJpbWl0aXZlVmFsdWU6OkNT U1ByaW1pdGl2ZVZhbHVlKFVuaXRUeXBlcyB0eXBlKQorICAgIDogbV90eXBlKHR5cGUpCit7Cit9 CisKIENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NQcmltaXRpdmVWYWx1ZShjb25zdCBTdHJpbmcmIHN0 ciwgVW5pdFR5cGVzIHR5cGUpCiAgICAgOiBtX3R5cGUodHlwZSkKIHsKSW5kZXg6IFdlYkNvcmUv Y3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTUHJp bWl0aXZlVmFsdWUuaAkocmV2aXNpb24gMzY2MTQpCisrKyBXZWJDb3JlL2Nzcy9DU1NQcmltaXRp dmVWYWx1ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC03NSw3ICs3NSwxMCBAQCBwdWJsaWM6CiAgICAg ICAgIENTU19QQVJTRVJfVkFSSUFCTEVfRlVOQ1RJT05fU1lOVEFYID0gMTA1LAogICAgICAgICBD U1NfUEFSU0VSX1ZBUklBQkxFX0VRVUFMU19TWU5UQVggPSAxMDYsCiAgICAgICAgIENTU19QQVJT RVJfVkFSSUFCTEVfRE9MTEFSX1NZTlRBWCA9IDEwNywKLSAgICAgICAgQ1NTX1BBUlNFUl9IRVhD T0xPUiA9IDEwOAorICAgICAgICBDU1NfUEFSU0VSX0hFWENPTE9SID0gMTA4LAorICAgICAgICAK KyAgICAgICAgLy8gVGhpcyBpcyB1c2VkIGludGVybmFsbHkgZm9yIHVua25vd24gaWRlbnRpZmll cnMgCisgICAgICAgIENTU19QQVJTRVJfSURFTlRJRklFUiA9IDEwOQogICAgIH07CiAKICAgICBz dGF0aWMgUGFzc1JlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4gY3JlYXRlSWRlbnRpZmllcihpbnQg aWRlbnQpCkBAIC05MCw2ICs5MywxMCBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICByZXR1cm4g YWRvcHRSZWYobmV3IENTU1ByaW1pdGl2ZVZhbHVlKHZhbHVlKSk7CiAgICAgfQorICAgIHN0YXRp YyBQYXNzUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiBjcmVhdGUoVW5pdFR5cGVzIHR5cGUpCisg ICAgeworICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IENTU1ByaW1pdGl2ZVZhbHVlKHR5cGUp KTsKKyAgICB9CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+IGNyZWF0 ZShkb3VibGUgdmFsdWUsIFVuaXRUeXBlcyB0eXBlKQogICAgIHsKICAgICAgICAgcmV0dXJuIGFk b3B0UmVmKG5ldyBDU1NQcmltaXRpdmVWYWx1ZSh2YWx1ZSwgdHlwZSkpOwpAQCAtMTc2LDYgKzE4 Myw3IEBAIHByb3RlY3RlZDoKICAgICBDU1NQcmltaXRpdmVWYWx1ZShpbnQgaWRlbnQpOwogICAg IENTU1ByaW1pdGl2ZVZhbHVlKGRvdWJsZSwgVW5pdFR5cGVzKTsKICAgICBDU1NQcmltaXRpdmVW YWx1ZShjb25zdCBTdHJpbmcmLCBVbml0VHlwZXMpOworICAgIENTU1ByaW1pdGl2ZVZhbHVlKFVu aXRUeXBlcyk7CiAKIHByaXZhdGU6CiAgICAgQ1NTUHJpbWl0aXZlVmFsdWUoKTsKSW5kZXg6IExh eW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHJldmlzaW9uIDM2NjIxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMDktMTggIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRl c3QgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDUxNSBDcmFz aCB1cG9uIAorICAgICAgICBwYXJzaW5nIENTUzogdW5pY29kZS1yYW5nZTogc2VhcmNoZmllbGQt Y2FuY2VsLWJ1dHRvbnB0PS13ZWJraXQtCisgICAgICAgIGRhc2hib2FyZC1yZWdpb249CisgICAg ICAgIGFuZCBjb3JyZXNwb25kaW5nOiA8cmRhcjovL3Byb2JsZW0vNjE3NDEwMD4KKworICAgICAg ICAqIGZhc3QvY3NzL2ludmFsaWQtaWRlbnRpZmllci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg ICAgICAqIGZhc3QvY3NzL2ludmFsaWQtaWRlbnRpZmllci5odG1sOiBBZGRlZC4KKwogMjAwOC0w OS0xOCAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIFJ1YmJlci1zdGFt cGVkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9pbnZhbGlkLWlk ZW50aWZpZXItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY3Nz L2ludmFsaWQtaWRlbnRpZmllci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9mYXN0L2Nzcy9pbnZhbGlkLWlkZW50aWZpZXItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQpAQCAtMCwwICsxIEBACitUaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IGNyYXNoLgpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9jc3MvaW52YWxpZC1pZGVudGlmaWVyLmh0bWwKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jc3MvaW52YWxpZC1pZGVudGlmaWVyLmh0bWwJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9pbnZhbGlkLWlkZW50aWZpZXIuaHRt bAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNCBAQAorPGh0bWw+Cis8c2NyaXB0PgorICAgIGlm ICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91dFRlc3RDb250cm9s bGVyLmR1bXBBc1RleHQoKTsKKzwvc2NyaXB0PgorPHN0eWxlPgorYm9keSB7CisgICAgICAgIHVu aWNvZGUtcmFuZ2U6IHNlYXJjaGZpZWxkLWNhbmNlbC1idXR0b25wdD0td2Via2l0LWRhc2hib2Fy ZC1yZWdpb249Cit9Cis8L3N0eWxlPgorPGJvZHk+CisgICAgPHNwYW4+VGhpcyB0ZXN0IHBhc3Nl cyBpZiBpdCBkb2VzIG5vdCBjcmFzaC48L3NwYW4+Cis8L2JvZHk+Cis8L2h0bWw+Cg== 23539 2008-09-18 14:57:47 -0700 2008-09-18 15:06:46 -0700 Patch 2 try2.txt text/plain 5134 bdakin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNjYyMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjUgQEAKKzIwMDgtMDktMTggIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBm b3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTE1IENyYXNoIHVw b24gCisgICAgICAgIHBhcnNpbmcgQ1NTOiB1bmljb2RlLXJhbmdlOiBzZWFyY2hmaWVsZC1jYW5j ZWwtYnV0dG9ucHQ9LXdlYmtpdC0KKyAgICAgICAgZGFzaGJvYXJkLXJlZ2lvbj0KKyAgICAgICAg YW5kIGNvcnJlc3BvbmRpbmc6IDxyZGFyOi8vcHJvYmxlbS82MTc0MTAwPgorCisgICAgICAgIFRo aXMgcGF0Y2ggbWFrZXMgQ1NTUGFyc2VyVmFsdWU6OmNyZWF0ZUNTU1ZhbHVlIGhhbmRsZSB1bmtu b3duIAorICAgICAgICBpZGVudGlmaWVycy4KKworICAgICAgICAqIGNzcy9DU1NQYXJzZXJWYWx1 ZXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyVmFsdWU6OmNyZWF0ZUNTU1ZhbHVl KTogSWYgd2UgaGF2ZSBhbiBpZGVudGlmaWVyIAorICAgICAgICB3aXRoIG5vIGlkIChhbiB1bmtu b3duIGlkZW50aWZpZXIpIGNyZWF0ZSBhIENTU1ByaW1pdGl2ZVZhbHVlIG9mIAorICAgICAgICB0 eXBlIENTU19QQVJTRVJfSURFTlRJRklFUgorICAgICAgICAqIGNzcy9DU1NQcmltaXRpdmVWYWx1 ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQcmltaXRpdmVWYWx1ZTo6Y3NzVGV4dCk6Cisg ICAgICAgIChXZWJDb3JlOjpDU1NQcmltaXRpdmVWYWx1ZTo6cGFyc2VyVmFsdWUpOgorICAgICAg ICAqIGNzcy9DU1NQcmltaXRpdmVWYWx1ZS5oOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUHJpbWl0 aXZlVmFsdWU6Oik6CisKIDIwMDgtMDktMTggIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K IAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBEYXZpZCAiSSdkIHByZWZlciBub3QiIEh5YXR0 LgpJbmRleDogV2ViQ29yZS9jc3MvQ1NTUGFyc2VyVmFsdWVzLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL2Nzcy9DU1NQYXJzZXJWYWx1ZXMuY3BwCShyZXZpc2lvbiAzNjYxNCkKKysrIFdlYkNv cmUvY3NzL0NTU1BhcnNlclZhbHVlcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYxLDYgKzYxLDgg QEAgUGFzc1JlZlB0cjxDU1NWYWx1ZT4gQ1NTUGFyc2VyVmFsdWU6OmNyZQogICAgIFJlZlB0cjxD U1NWYWx1ZT4gcGFyc2VkVmFsdWU7CiAgICAgaWYgKGlkKQogICAgICAgICBwYXJzZWRWYWx1ZSA9 IENTU1ByaW1pdGl2ZVZhbHVlOjpjcmVhdGVJZGVudGlmaWVyKGlkKTsKKyAgICBlbHNlIGlmICh1 bml0ID09IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfSURFTlQpCisgICAgICAgIHBhcnNlZFZhbHVl ID0gQ1NTUHJpbWl0aXZlVmFsdWU6OmNyZWF0ZShzdHJpbmcsIENTU1ByaW1pdGl2ZVZhbHVlOjpD U1NfUEFSU0VSX0lERU5USUZJRVIpOwogICAgIGVsc2UgaWYgKHVuaXQgPT0gQ1NTUHJpbWl0aXZl VmFsdWU6OkNTU19OVU1CRVIgJiYgaXNJbnQpCiAgICAgICAgIHBhcnNlZFZhbHVlID0gQ1NTUHJp bWl0aXZlVmFsdWU6OmNyZWF0ZShmVmFsdWUsIENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfUEFSU0VS X0lOVEVHRVIpOwogICAgIGVsc2UgaWYgKHVuaXQgPT0gQ1NTUGFyc2VyVmFsdWU6Ok9wZXJhdG9y KSB7CkluZGV4OiBXZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwCShyZXZpc2lvbiAzNjYxNCkKKysr IFdlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzY5 LDYgKzc2OSw4IEBAIFN0cmluZyBDU1NQcmltaXRpdmVWYWx1ZTo6Y3NzVGV4dCgpIGNvbnMKICAg ICAgICAgICAgIGNoYXIgYyA9IHN0YXRpY19jYXN0PGNoYXI+KG1fdmFsdWUuaWRlbnQpOwogICAg ICAgICAgICAgdGV4dCA9IFN0cmluZygmYywgMVUpOwogICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgIGNhc2UgQ1NTX1BBUlNFUl9JREVOVElGSUVSOgorICAgICAgICAgICAgdGV4dCA9IHF1b3Rl U3RyaW5nSWZOZWVkZWQobV92YWx1ZS5zdHJpbmcpOwogICAgIH0KICAgICByZXR1cm4gdGV4dDsK IH0KQEAgLTgyOCw2ICs4MzAsMTEgQEAgQ1NTUGFyc2VyVmFsdWUgQ1NTUHJpbWl0aXZlVmFsdWU6 OnBhcnNlcgogICAgICAgICAgICAgdmFsdWUudW5pdCA9IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1Nf TlVNQkVSOwogICAgICAgICAgICAgdmFsdWUuaXNJbnQgPSB0cnVlOwogICAgICAgICAgICAgYnJl YWs7CisgICAgICAgIGNhc2UgQ1NTX1BBUlNFUl9JREVOVElGSUVSOgorICAgICAgICAgICAgdmFs dWUuc3RyaW5nLmNoYXJhY3RlcnMgPSBjb25zdF9jYXN0PFVDaGFyKj4obV92YWx1ZS5zdHJpbmct PmNoYXJhY3RlcnMoKSk7CisgICAgICAgICAgICB2YWx1ZS5zdHJpbmcubGVuZ3RoID0gbV92YWx1 ZS5zdHJpbmctPmxlbmd0aCgpOworICAgICAgICAgICAgdmFsdWUudW5pdCA9IG1fdHlwZTsKKyAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIENTU19VTktOT1dOOgogICAgICAgICBjYXNl IENTU19BVFRSOgogICAgICAgICBjYXNlIENTU19DT1VOVEVSOgpJbmRleDogV2ViQ29yZS9jc3Mv Q1NTUHJpbWl0aXZlVmFsdWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Nzcy9DU1NQcmltaXRp dmVWYWx1ZS5oCShyZXZpc2lvbiAzNjYxNCkKKysrIFdlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZh bHVlLmgJKHdvcmtpbmcgY29weSkKQEAgLTc1LDcgKzc1LDEwIEBAIHB1YmxpYzoKICAgICAgICAg Q1NTX1BBUlNFUl9WQVJJQUJMRV9GVU5DVElPTl9TWU5UQVggPSAxMDUsCiAgICAgICAgIENTU19Q QVJTRVJfVkFSSUFCTEVfRVFVQUxTX1NZTlRBWCA9IDEwNiwKICAgICAgICAgQ1NTX1BBUlNFUl9W QVJJQUJMRV9ET0xMQVJfU1lOVEFYID0gMTA3LAotICAgICAgICBDU1NfUEFSU0VSX0hFWENPTE9S ID0gMTA4CisgICAgICAgIENTU19QQVJTRVJfSEVYQ09MT1IgPSAxMDgsCisgICAgICAgIAorICAg ICAgICAvLyBUaGlzIGlzIHVzZWQgaW50ZXJuYWxseSBmb3IgdW5rbm93biBpZGVudGlmaWVycyAK KyAgICAgICAgQ1NTX1BBUlNFUl9JREVOVElGSUVSID0gMTA5CiAgICAgfTsKIAogICAgIHN0YXRp YyBQYXNzUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiBjcmVhdGVJZGVudGlmaWVyKGludCBpZGVu dCkKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDM2NjIxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMDktMTggIEJldGggRGFraW4gIDxi ZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRlc3QgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDUxNSBDcmFzaCB1cG9uIAorICAgICAgICBwYXJzaW5nIENTUzogdW5pY29kZS1yYW5nZTog c2VhcmNoZmllbGQtY2FuY2VsLWJ1dHRvbnB0PS13ZWJraXQtCisgICAgICAgIGRhc2hib2FyZC1y ZWdpb249CisgICAgICAgIGFuZCBjb3JyZXNwb25kaW5nOiA8cmRhcjovL3Byb2JsZW0vNjE3NDEw MD4KKworICAgICAgICAqIGZhc3QvY3NzL2ludmFsaWQtaWRlbnRpZmllci1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzL2ludmFsaWQtaWRlbnRpZmllci5odG1sOiBBZGRl ZC4KKwogMjAwOC0wOS0xOCAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAg IFJ1YmJlci1zdGFtcGVkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nz cy9pbnZhbGlkLWlkZW50aWZpZXItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2Zhc3QvY3NzL2ludmFsaWQtaWRlbnRpZmllci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9pbnZhbGlkLWlkZW50aWZpZXItZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxIEBACitUaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXMg bm90IGNyYXNoLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jc3MvaW52YWxpZC1pZGVudGlmaWVy Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jc3MvaW52YWxpZC1pZGVudGlm aWVyLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9pbnZhbGlkLWlk ZW50aWZpZXIuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNCBAQAorPGh0bWw+Cis8c2Ny aXB0PgorICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91 dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKzwvc2NyaXB0PgorPHN0eWxlPgorYm9keSB7 CisgICAgICAgIHVuaWNvZGUtcmFuZ2U6IHNlYXJjaGZpZWxkLWNhbmNlbC1idXR0b25wdD0td2Vi a2l0LWRhc2hib2FyZC1yZWdpb249Cit9Cis8L3N0eWxlPgorPGJvZHk+CisgICAgPHNwYW4+VGhp cyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2VzIG5vdCBjcmFzaC48L3NwYW4+Cis8L2JvZHk+Cis8L2h0 bWw+Cg==