205147 2019-12-11 17:21:48 -0800 DFG and FTL expects String.prototype to not qualify for StringObjectUse. 2019-12-12 10:09:21 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1597881 0 mark.lam 2019-12-11 17:21:48 -0800 Currently, String.prototype's JSType is StringObjectType. However, in the compiler, there are a few places that expect that the String.prototype value to not qualify as StringObjectUse. These places are: 1. SpeculatedType.cpp's speculationFromClassInfo() will speculate SpecObjectOther for the StringPrototype object. 2. DFGFixupPhase.cpp's addCheckStructureForOriginalStringObjectUse() only does a CheckStructure against globalObject->stringObjectStructure(). It does not check against String.prototype's structure. To resolve this discrepancy, we can either do: a. change String.prototype's JSType to something else. b. fix the places in the compiler to accept String.prototype as StringObjectUse. (a) is trivial and cheap to do. (b) is doable but will result in less optimal compiled code. Since passing String.prototype as a StringObject is expected to be a rare thing in JS code, it's not worth incurring the cost for (b). We'll apply (a). <rdar://problem/57748888> 1597887 1 385465 mark.lam 2019-12-11 17:35:16 -0800 Created attachment 385465 proposed patch. 1597891 2 385465 saam 2019-12-11 17:37:59 -0800 Comment on attachment 385465 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=385465&action=review > Source/JavaScriptCore/ChangeLog:3 > + FTL expects String.prototype to not qualify for StringObjectUse. it's not just the FTL. It's DFG+FTL > Source/JavaScriptCore/runtime/JSType.h:120 > + // Start StringObjectType types. this seems unnecessary > Source/JavaScriptCore/runtime/JSType.h:123 > + // End StringObjectType types. ditto No need to call something out we don't rely on IMO 1597895 3 385465 saam 2019-12-11 17:39:28 -0800 Comment on attachment 385465 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=385465&action=review >> Source/JavaScriptCore/runtime/JSType.h:123 >> + // End StringObjectType types. > > ditto > > No need to call something out we don't rely on IMO ignore me 1597896 4 385466 mark.lam 2019-12-11 17:44:20 -0800 Created attachment 385466 patch for landing. Thanks for the review. 1598045 5 mark.lam 2019-12-12 10:09:21 -0800 The Win EWS bot failures are just due to flakiness. A re-run of the EWS bot produced different failures, and the failure cannot be due to this change. Landed in r253432: <http://trac.webkit.org/r253432>. 385465 2019-12-11 17:35:16 -0800 2019-12-11 17:44:20 -0800 proposed patch. bug-205147.patch text/plain 5793 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTM0MDYpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTEyLTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBGVEwgZXhwZWN0cyBTdHJpbmcucHJvdG90eXBlIHRvIG5vdCBxdWFsaWZ5 IGZvciBTdHJpbmdPYmplY3RVc2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDUxNDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU3NzQ4ODg4Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNz L2Z0bC1leHBlY3RzLXN0cmluZy1wcm90b3R5cGUtdG8tbm90LWJlLVN0cmluZ09iamVjdFVzZS5q czogQWRkZWQuCisKIDIwMTktMTItMTEgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIHRlc3QgZm9yIG9zciBleGl0aW5nIHdpdGggaW50ZXJwcmV0 ZXIgb24gdGhlIHN0YWNrCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9mdGwtZXhwZWN0cy1zdHJpbmct cHJvdG90eXBlLXRvLW5vdC1iZS1TdHJpbmdPYmplY3RVc2UuanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNU ZXN0cy9zdHJlc3MvZnRsLWV4cGVjdHMtc3RyaW5nLXByb3RvdHlwZS10by1ub3QtYmUtU3RyaW5n T2JqZWN0VXNlLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL2Z0bC1leHBlY3Rz LXN0cmluZy1wcm90b3R5cGUtdG8tbm90LWJlLVN0cmluZ09iamVjdFVzZS5qcwkod29ya2luZyBj b3B5KQpAQCAtMCwwICsxLDYgQEAKK2ZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDsgaSsrKSB7Cisg ICAgbmV3IFN0cmluZygpLnNwbGl0KCk7Cit9Citmb3IgKGxldCBpID0gMDsgaSA8IDEwMDAwMDsg aSsrKSB7CisgICAgU3RyaW5nLnByb3RvdHlwZS5zcGxpdCgpOworfQpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTM0MDYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzkgQEAKKzIwMTktMTItMTEgIE1h cmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAgIEZUTCBleHBlY3RzIFN0cmlu Zy5wcm90b3R5cGUgdG8gbm90IHF1YWxpZnkgZm9yIFN0cmluZ09iamVjdFVzZS4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTE0NworICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNTc3NDg4ODg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5LCBTdHJpbmcucHJvdG90eXBlJ3MgSlNUeXBlIGlz IFN0cmluZ09iamVjdFR5cGUuCisKKyAgICAgICAgSG93ZXZlciwgaW4gdGhlIGNvbXBpbGVyLCB0 aGVyZSBhcmUgYSBmZXcgcGxhY2VzIHRoYXQgZXhwZWN0IHRoYXQgdGhlCisgICAgICAgIFN0cmlu Zy5wcm90b3R5cGUgdmFsdWUgdG8gbm90IHF1YWxpZnkgYXMgU3RyaW5nT2JqZWN0VXNlLiAgVGhl c2UgcGxhY2VzIGFyZToKKyAgICAgICAgMS4gU3BlY3VsYXRlZFR5cGUuY3BwJ3Mgc3BlY3VsYXRp b25Gcm9tQ2xhc3NJbmZvKCkgd2lsbCBzcGVjdWxhdGUgU3BlY09iamVjdE90aGVyCisgICAgICAg ICAgIGZvciB0aGUgU3RyaW5nUHJvdG90eXBlIG9iamVjdC4KKyAgICAgICAgMi4gREZHRml4dXBQ aGFzZS5jcHAncyBhZGRDaGVja1N0cnVjdHVyZUZvck9yaWdpbmFsU3RyaW5nT2JqZWN0VXNlKCkg b25seSBlbWl0cyBhCisgICAgICAgICAgIENoZWNrU3RydWN0dXJlIGFnYWluc3QgZ2xvYmFsT2Jq ZWN0LT5zdHJpbmdPYmplY3RTdHJ1Y3R1cmUoKS4gIEl0IGRvZXMgbm90CisgICAgICAgICAgIGNo ZWNrIGFnYWluc3QgU3RyaW5nLnByb3RvdHlwZSdzIHN0cnVjdHVyZS4KKworICAgICAgICBUbyBy ZXNvbHZlIHRoaXMgZGlzY3JlcGFuY3ksIHdlIGNhbiBlaXRoZXIgZG86CisgICAgICAgIGEuIGNo YW5nZSBTdHJpbmcucHJvdG90eXBlJ3MgSlNUeXBlIHRvIHNvbWV0aGluZyBlbHNlLgorICAgICAg ICBiLiBmaXggdGhlIHBsYWNlcyBpbiB0aGUgY29tcGlsZXIgdG8gYWNjZXB0IFN0cmluZy5wcm90 b3R5cGUgYXMgU3RyaW5nT2JqZWN0VXNlLgorCisgICAgICAgIChhKSBpcyB0cml2aWFsIGFuZCBj aGVhcCB0byBkby4gIChiKSBpcyBkb2FibGUgYnV0IHdpbGwgcmVzdWx0IGluIGxlc3Mgb3B0aW1h bAorICAgICAgICBjb21waWxlZCBjb2RlLiAgU2luY2UgcGFzc2luZyBTdHJpbmcucHJvdG90eXBl IGFzIGEgU3RyaW5nT2JqZWN0IGlzIGV4cGVjdGVkIHRvCisgICAgICAgIGJlIGEgcmFyZSB0aGlu ZyBpbiBKUyBjb2RlLCBpdCdzIG5vdCB3b3J0aCBpbmN1cnJpbmcgdGhlIGNvc3QgZm9yIChiKS4g IEluIHRoaXMKKyAgICAgICAgcGF0Y2gsIHdlIGFwcGx5IChhKSB0byBmaXggdGhlIGRpc2NyZXBh bmN5LgorCisgICAgICAgIEFsc28gYWRkZWQgYSBzcGVjaWFsaXphdGlvbiBjYXNlIHRvIEZPUl9F QUNIX0pTX0RZTkFNSUNfQ0FTVF9KU19UWVBFX09WRVJMT0FECisgICAgICAgIGZvciBqc0R5bmFt aWNDYXN0PFN0cmluZ09iamVjdD4gZm9yIGNvbXBsZXRlbmVzcy4KKworICAgICAgICAqIHJ1bnRp bWUvSlNDYXN0Lmg6CisgICAgICAgICogcnVudGltZS9KU1R5cGUuY3BwOgorICAgICAgICAoV1RG OjpwcmludEludGVybmFsKToKKyAgICAgICAgKiBydW50aW1lL0pTVHlwZS5oOgorICAgICAgICAq IHJ1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmg6CisKIDIwMTktMTItMTEgIFl1c3VrZSBTdXp1a2kg IDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBQdXQgYWxsIEFQSSByZWxhdGVk IEpTIGNlbGxzIGludG8gSXNvU3Vic3BhY2UKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTQ2FzdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0pTQ2FzdC5oCShyZXZpc2lvbiAyNTMzNjApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU0Nhc3QuaAkod29ya2luZyBjb3B5KQpAQCAtNzQsNiArNzQsNyBAQCBpbmxpbmUg VG8ganNDYXN0KEpTVmFsdWUgZnJvbSkKICAgICBtYWNybyhKU0xleGljYWxFbnZpcm9ubWVudCwg SlNUeXBlOjpMZXhpY2FsRW52aXJvbm1lbnRUeXBlLCBKU1R5cGU6Ok1vZHVsZUVudmlyb25tZW50 VHlwZSkgXAogICAgIG1hY3JvKEpTU3ltYm9sVGFibGVPYmplY3QsIEpTVHlwZTo6R2xvYmFsT2Jq ZWN0VHlwZSwgSlNUeXBlOjpNb2R1bGVFbnZpcm9ubWVudFR5cGUpIFwKICAgICBtYWNybyhKU1Nj b3BlLCBKU1R5cGU6Okdsb2JhbE9iamVjdFR5cGUsIEpTVHlwZTo6V2l0aFNjb3BlVHlwZSkgXAor ICAgIG1hY3JvKFN0cmluZ09iamVjdCwgSlNUeXBlOjpTdHJpbmdPYmplY3RUeXBlLCBKU1R5cGU6 OkRlcml2ZWRTdHJpbmdPYmplY3RUeXBlKSBcCiAKIAogLy8gRm9yd2FyZCBkZWNsYXJlIHRoZSBj bGFzc2VzIGJlY2F1c2UgdGhleSBtYXkgbm90IGFscmVhZHkgZXhpc3QuCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1R5cGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTVHlwZS5jcHAJKHJldmlzaW9uIDI1MzM2MCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTVHlwZS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTEwNyw2ICsxMDcsNyBAQCB2b2lkIHByaW50SW50ZXJuYWwoUHJpbnRTdHJlYW0mIG91dCwgSlND CiAgICAgQ0FTRShKU1dlYWtTZXRUeXBlKQogICAgIENBU0UoV2ViQXNzZW1ibHlNb2R1bGVUeXBl KQogICAgIENBU0UoU3RyaW5nT2JqZWN0VHlwZSkKKyAgICBDQVNFKERlcml2ZWRTdHJpbmdPYmpl Y3RUeXBlKQogICAgIENBU0UoTWF4SlNUeXBlKQogICAgIH0KIH0KSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0pTVHlwZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTVHlwZS5oCShyZXZpc2lvbiAyNTMzNjApCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9KU1R5cGUuaAkod29ya2luZyBjb3B5KQpAQCAtMTE3LDkgKzEx NywxMiBAQCBlbnVtIEpTVHlwZSA6IHVpbnQ4X3QgewogICAgIEpTV2Vha01hcFR5cGUsCiAgICAg SlNXZWFrU2V0VHlwZSwKICAgICBXZWJBc3NlbWJseU1vZHVsZVR5cGUsCisgICAgLy8gU3RhcnQg U3RyaW5nT2JqZWN0VHlwZSB0eXBlcy4KICAgICBTdHJpbmdPYmplY3RUeXBlLAorICAgIERlcml2 ZWRTdHJpbmdPYmplY3RUeXBlLAorICAgIC8vIEVuZCBTdHJpbmdPYmplY3RUeXBlIHR5cGVzLgog Ci0gICAgTGFzdEpTQ09iamVjdFR5cGUgPSBTdHJpbmdPYmplY3RUeXBlLCAvLyBUaGlzIGlzIHRo ZSBsYXN0ICJKU0MiIE9iamVjdCB0eXBlLiBBZnRlciB0aGlzLCB3ZSBoYXZlIGVtYmVkZGVyJ3Mg KGUuZy4sIFdlYkNvcmUpIGV4dGVuZGVkIG9iamVjdCB0eXBlcy4KKyAgICBMYXN0SlNDT2JqZWN0 VHlwZSA9IERlcml2ZWRTdHJpbmdPYmplY3RUeXBlLCAvLyBUaGlzIGlzIHRoZSBsYXN0ICJKU0Mi IE9iamVjdCB0eXBlLiBBZnRlciB0aGlzLCB3ZSBoYXZlIGVtYmVkZGVyJ3MgKGUuZy4sIFdlYkNv cmUpIGV4dGVuZGVkIG9iamVjdCB0eXBlcy4KICAgICBNYXhKU1R5cGUgPSAwYjExMTExMTExLAog fTsKIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBl LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJv dG90eXBlLmgJKHJldmlzaW9uIDI1MzM2MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1N0cmluZ1Byb3RvdHlwZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00MSw3ICs0MSw3IEBAIHB1 YmxpYzoKIAogICAgIHN0YXRpYyBTdHJ1Y3R1cmUqIGNyZWF0ZVN0cnVjdHVyZShWTSYgdm0sIEpT R2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIEpTVmFsdWUgcHJvdG90eXBlKQogICAgIHsKLSAg ICAgICAgcmV0dXJuIFN0cnVjdHVyZTo6Y3JlYXRlKHZtLCBnbG9iYWxPYmplY3QsIHByb3RvdHlw ZSwgVHlwZUluZm8oU3RyaW5nT2JqZWN0VHlwZSwgU3RydWN0dXJlRmxhZ3MpLCBpbmZvKCkpOwor ICAgICAgICByZXR1cm4gU3RydWN0dXJlOjpjcmVhdGUodm0sIGdsb2JhbE9iamVjdCwgcHJvdG90 eXBlLCBUeXBlSW5mbyhEZXJpdmVkU3RyaW5nT2JqZWN0VHlwZSwgU3RydWN0dXJlRmxhZ3MpLCBp bmZvKCkpOwogICAgIH0KIAogICAgIERFQ0xBUkVfSU5GTzsK 385466 2019-12-11 17:44:20 -0800 2019-12-11 17:44:20 -0800 patch for landing. bug-205147.patch text/plain 5803 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTM0MTEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTEyLTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBERkcgYW5kIEZUTCBleHBlY3RzIFN0cmluZy5wcm90b3R5cGUgdG8gbm90 IHF1YWxpZnkgZm9yIFN0cmluZ09iamVjdFVzZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTE0NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTc3 NDg4ODg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2FhbSBCYXJhdGkuCisKKyAgICAgICAgKiBz dHJlc3MvZnRsLWV4cGVjdHMtc3RyaW5nLXByb3RvdHlwZS10by1ub3QtYmUtU3RyaW5nT2JqZWN0 VXNlLmpzOiBBZGRlZC4KKwogMjAxOS0xMi0xMSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVy QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgdGVzdCBmb3Igb3NyIGV4aXRpbmcgd2l0aCBpbnRl cnByZXRlciBvbiB0aGUgc3RhY2sKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL2Z0bC1leHBlY3RzLXN0 cmluZy1wcm90b3R5cGUtdG8tbm90LWJlLVN0cmluZ09iamVjdFVzZS5qcwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBKU1Rlc3RzL3N0cmVzcy9mdGwtZXhwZWN0cy1zdHJpbmctcHJvdG90eXBlLXRvLW5vdC1iZS1T dHJpbmdPYmplY3RVc2UuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvZnRsLWV4 cGVjdHMtc3RyaW5nLXByb3RvdHlwZS10by1ub3QtYmUtU3RyaW5nT2JqZWN0VXNlLmpzCSh3b3Jr aW5nIGNvcHkpCkBAIC0wLDAgKzEsNiBAQAorZm9yICh2YXIgaSA9IDA7IGkgPCAxMDAwOyBpKysp IHsKKyAgICBuZXcgU3RyaW5nKCkuc3BsaXQoKTsKK30KK2ZvciAobGV0IGkgPSAwOyBpIDwgMTAw MDAwOyBpKyspIHsKKyAgICBTdHJpbmcucHJvdG90eXBlLnNwbGl0KCk7Cit9CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1MzQxMSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwzOSBAQAorMjAxOS0xMi0x MSAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAgREZHIGFuZCBGVEwg ZXhwZWN0cyBTdHJpbmcucHJvdG90eXBlIHRvIG5vdCBxdWFsaWZ5IGZvciBTdHJpbmdPYmplY3RV c2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDUx NDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU3NzQ4ODg4PgorCisgICAgICAgIFJldmlld2Vk IGJ5IFNhYW0gQmFyYXRpLgorCisgICAgICAgIEN1cnJlbnRseSwgU3RyaW5nLnByb3RvdHlwZSdz IEpTVHlwZSBpcyBTdHJpbmdPYmplY3RUeXBlLgorCisgICAgICAgIEhvd2V2ZXIsIGluIHRoZSBj b21waWxlciwgdGhlcmUgYXJlIGEgZmV3IHBsYWNlcyB0aGF0IGV4cGVjdCB0aGF0IHRoZQorICAg ICAgICBTdHJpbmcucHJvdG90eXBlIHZhbHVlIHRvIG5vdCBxdWFsaWZ5IGFzIFN0cmluZ09iamVj dFVzZS4gIFRoZXNlIHBsYWNlcyBhcmU6CisgICAgICAgIDEuIFNwZWN1bGF0ZWRUeXBlLmNwcCdz IHNwZWN1bGF0aW9uRnJvbUNsYXNzSW5mbygpIHdpbGwgc3BlY3VsYXRlIFNwZWNPYmplY3RPdGhl cgorICAgICAgICAgICBmb3IgdGhlIFN0cmluZ1Byb3RvdHlwZSBvYmplY3QuCisgICAgICAgIDIu IERGR0ZpeHVwUGhhc2UuY3BwJ3MgYWRkQ2hlY2tTdHJ1Y3R1cmVGb3JPcmlnaW5hbFN0cmluZ09i amVjdFVzZSgpIG9ubHkgZW1pdHMgYQorICAgICAgICAgICBDaGVja1N0cnVjdHVyZSBhZ2FpbnN0 IGdsb2JhbE9iamVjdC0+c3RyaW5nT2JqZWN0U3RydWN0dXJlKCkuICBJdCBkb2VzIG5vdAorICAg ICAgICAgICBjaGVjayBhZ2FpbnN0IFN0cmluZy5wcm90b3R5cGUncyBzdHJ1Y3R1cmUuCisKKyAg ICAgICAgVG8gcmVzb2x2ZSB0aGlzIGRpc2NyZXBhbmN5LCB3ZSBjYW4gZWl0aGVyIGRvOgorICAg ICAgICBhLiBjaGFuZ2UgU3RyaW5nLnByb3RvdHlwZSdzIEpTVHlwZSB0byBzb21ldGhpbmcgZWxz ZS4KKyAgICAgICAgYi4gZml4IHRoZSBwbGFjZXMgaW4gdGhlIGNvbXBpbGVyIHRvIGFjY2VwdCBT dHJpbmcucHJvdG90eXBlIGFzIFN0cmluZ09iamVjdFVzZS4KKworICAgICAgICAoYSkgaXMgdHJp dmlhbCBhbmQgY2hlYXAgdG8gZG8uICAoYikgaXMgZG9hYmxlIGJ1dCB3aWxsIHJlc3VsdCBpbiBs ZXNzIG9wdGltYWwKKyAgICAgICAgY29tcGlsZWQgY29kZS4gIFNpbmNlIHBhc3NpbmcgU3RyaW5n LnByb3RvdHlwZSBhcyBhIFN0cmluZ09iamVjdCBpcyBleHBlY3RlZCB0bworICAgICAgICBiZSBh IHJhcmUgdGhpbmcgaW4gSlMgY29kZSwgaXQncyBub3Qgd29ydGggaW5jdXJyaW5nIHRoZSBjb3N0 IGZvciAoYikuICBJbiB0aGlzCisgICAgICAgIHBhdGNoLCB3ZSBhcHBseSAoYSkgdG8gZml4IHRo ZSBkaXNjcmVwYW5jeS4KKworICAgICAgICBBbHNvIGFkZGVkIGEgc3BlY2lhbGl6YXRpb24gY2Fz ZSB0byBGT1JfRUFDSF9KU19EWU5BTUlDX0NBU1RfSlNfVFlQRV9PVkVSTE9BRAorICAgICAgICBm b3IganNEeW5hbWljQ2FzdDxTdHJpbmdPYmplY3Q+IGZvciBjb21wbGV0ZW5lc3MuCisKKyAgICAg ICAgKiBydW50aW1lL0pTQ2FzdC5oOgorICAgICAgICAqIHJ1bnRpbWUvSlNUeXBlLmNwcDoKKyAg ICAgICAgKFdURjo6cHJpbnRJbnRlcm5hbCk6CisgICAgICAgICogcnVudGltZS9KU1R5cGUuaDoK KyAgICAgICAgKiBydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5oOgorCiAyMDE5LTEyLTExICBZdXN1 a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gUHV0IGFsbCBB UEkgcmVsYXRlZCBKUyBjZWxscyBpbnRvIElzb1N1YnNwYWNlCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9KU0Nhc3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU0Nhc3QuaAkocmV2aXNpb24gMjUzNDExKQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSlNDYXN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTc0LDYgKzc0LDcg QEAgaW5saW5lIFRvIGpzQ2FzdChKU1ZhbHVlIGZyb20pCiAgICAgbWFjcm8oSlNMZXhpY2FsRW52 aXJvbm1lbnQsIEpTVHlwZTo6TGV4aWNhbEVudmlyb25tZW50VHlwZSwgSlNUeXBlOjpNb2R1bGVF bnZpcm9ubWVudFR5cGUpIFwKICAgICBtYWNybyhKU1N5bWJvbFRhYmxlT2JqZWN0LCBKU1R5cGU6 Okdsb2JhbE9iamVjdFR5cGUsIEpTVHlwZTo6TW9kdWxlRW52aXJvbm1lbnRUeXBlKSBcCiAgICAg bWFjcm8oSlNTY29wZSwgSlNUeXBlOjpHbG9iYWxPYmplY3RUeXBlLCBKU1R5cGU6OldpdGhTY29w ZVR5cGUpIFwKKyAgICBtYWNybyhTdHJpbmdPYmplY3QsIEpTVHlwZTo6U3RyaW5nT2JqZWN0VHlw ZSwgSlNUeXBlOjpEZXJpdmVkU3RyaW5nT2JqZWN0VHlwZSkgXAogCiAKIC8vIEZvcndhcmQgZGVj bGFyZSB0aGUgY2xhc3NlcyBiZWNhdXNlIHRoZXkgbWF5IG5vdCBhbHJlYWR5IGV4aXN0LgpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNUeXBlLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1R5cGUuY3BwCShyZXZpc2lvbiAyNTM0 MTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1R5cGUuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xMDcsNiArMTA3LDcgQEAgdm9pZCBwcmludEludGVybmFsKFByaW50U3RyZWFt JiBvdXQsIEpTQwogICAgIENBU0UoSlNXZWFrU2V0VHlwZSkKICAgICBDQVNFKFdlYkFzc2VtYmx5 TW9kdWxlVHlwZSkKICAgICBDQVNFKFN0cmluZ09iamVjdFR5cGUpCisgICAgQ0FTRShEZXJpdmVk U3RyaW5nT2JqZWN0VHlwZSkKICAgICBDQVNFKE1heEpTVHlwZSkKICAgICB9CiB9CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1R5cGUuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1R5cGUuaAkocmV2aXNpb24gMjUzNDExKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNUeXBlLmgJKHdvcmtpbmcgY29weSkKQEAg LTExNyw5ICsxMTcsMTIgQEAgZW51bSBKU1R5cGUgOiB1aW50OF90IHsKICAgICBKU1dlYWtNYXBU eXBlLAogICAgIEpTV2Vha1NldFR5cGUsCiAgICAgV2ViQXNzZW1ibHlNb2R1bGVUeXBlLAorICAg IC8vIFN0YXJ0IFN0cmluZ09iamVjdFR5cGUgdHlwZXMuCiAgICAgU3RyaW5nT2JqZWN0VHlwZSwK KyAgICBEZXJpdmVkU3RyaW5nT2JqZWN0VHlwZSwKKyAgICAvLyBFbmQgU3RyaW5nT2JqZWN0VHlw ZSB0eXBlcy4KIAotICAgIExhc3RKU0NPYmplY3RUeXBlID0gU3RyaW5nT2JqZWN0VHlwZSwgLy8g VGhpcyBpcyB0aGUgbGFzdCAiSlNDIiBPYmplY3QgdHlwZS4gQWZ0ZXIgdGhpcywgd2UgaGF2ZSBl bWJlZGRlcidzIChlLmcuLCBXZWJDb3JlKSBleHRlbmRlZCBvYmplY3QgdHlwZXMuCisgICAgTGFz dEpTQ09iamVjdFR5cGUgPSBEZXJpdmVkU3RyaW5nT2JqZWN0VHlwZSwgLy8gVGhpcyBpcyB0aGUg bGFzdCAiSlNDIiBPYmplY3QgdHlwZS4gQWZ0ZXIgdGhpcywgd2UgaGF2ZSBlbWJlZGRlcidzIChl LmcuLCBXZWJDb3JlKSBleHRlbmRlZCBvYmplY3QgdHlwZXMuCiAgICAgTWF4SlNUeXBlID0gMGIx MTExMTExMSwKIH07CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmlu Z1Byb3RvdHlwZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1N0cmluZ1Byb3RvdHlwZS5oCShyZXZpc2lvbiAyNTM0MTEpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuaAkod29ya2luZyBjb3B5KQpAQCAtNDEsNyAr NDEsNyBAQCBwdWJsaWM6CiAKICAgICBzdGF0aWMgU3RydWN0dXJlKiBjcmVhdGVTdHJ1Y3R1cmUo Vk0mIHZtLCBKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBKU1ZhbHVlIHByb3RvdHlwZSkK ICAgICB7Ci0gICAgICAgIHJldHVybiBTdHJ1Y3R1cmU6OmNyZWF0ZSh2bSwgZ2xvYmFsT2JqZWN0 LCBwcm90b3R5cGUsIFR5cGVJbmZvKFN0cmluZ09iamVjdFR5cGUsIFN0cnVjdHVyZUZsYWdzKSwg aW5mbygpKTsKKyAgICAgICAgcmV0dXJuIFN0cnVjdHVyZTo6Y3JlYXRlKHZtLCBnbG9iYWxPYmpl Y3QsIHByb3RvdHlwZSwgVHlwZUluZm8oRGVyaXZlZFN0cmluZ09iamVjdFR5cGUsIFN0cnVjdHVy ZUZsYWdzKSwgaW5mbygpKTsKICAgICB9CiAKICAgICBERUNMQVJFX0lORk87Cg==