205140 2019-12-11 15:37:53 -0800 REGRESSION (r172814): Don't export inline SQLiteDatabase::disableThreadingChecks() method 2019-12-12 15:10:48 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=136108 InRadar P2 Normal --- 1 ddkilzer ddkilzer achristensen bfulgham commit-queue sihui_liu webkit-bug-importer oldest_to_newest 1597820 0 ddkilzer 2019-12-11 15:37:53 -0800 This is wrong in Source/WebCore/platform/sql/SQLiteDatabase.h #ifndef NDEBUG WEBCORE_EXPORT void disableThreadingChecks(); #else WEBCORE_EXPORT void disableThreadingChecks() {} #endif The inline method should not have the WEBCORE_EXPORT macro. Regressed in r172814 for Bug 136108. Found when compiling WebKit with Release configuration and compiler optimizations disabled. 1597824 1 385452 ddkilzer 2019-12-11 15:41:23 -0800 Created attachment 385452 Patch v1 1598156 2 385452 commit-queue 2019-12-12 15:09:56 -0800 Comment on attachment 385452 Patch v1 Clearing flags on attachment: 385452 Committed r253445: <https://trac.webkit.org/changeset/253445> 1598157 3 commit-queue 2019-12-12 15:09:57 -0800 All reviewed patches have been landed. Closing bug. 1598158 4 webkit-bug-importer 2019-12-12 15:10:48 -0800 <rdar://problem/57893755> 385452 2019-12-11 15:41:23 -0800 2019-12-12 15:09:56 -0800 Patch v1 bug-205140-20191211154123.patch text/plain 1426 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTk0ZmQ0ZWMxNDg4MjAx YTM0ZjM1Nzk2MWUwOTg5OWZmNzIyYmNmNS4uOGRjMmVmZWIzZmM0YjQ4OTFkYTE5ZGUxYTY2NWEy NTU3NWJjYzhmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTEyLTExICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjE3 MjgxNCk6IERvbid0IGV4cG9ydCBpbmxpbmUgU1FMaXRlRGF0YWJhc2U6OmRpc2FibGVUaHJlYWRp bmdDaGVja3MoKSBtZXRob2QKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIwNTE0MD4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRm b3JtL3NxbC9TUUxpdGVEYXRhYmFzZS5oOgorICAgICAgICAoV2ViQ29yZTo6U1FMaXRlRGF0YWJh c2U6OmRpc2FibGVUaHJlYWRpbmdDaGVja3MpOgorICAgICAgICBSZW1vdmUgV0VCQ09SRV9FWFBP UlQgbWFjcm8gZnJvbSBpbmxpbmUgbWV0aG9kLiBUaGlzIG9ubHkgc2VlbXMKKyAgICAgICAgdG8g b2NjdXIgb24gUmVsZWFzZSBidWlsZHMgd2l0aCBjb21waWxlciBvcHRpbWl6YXRpb25zIGRpc2Fi bGVkLgorCiAyMDE5LTEyLTExICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29t PgogCiAgICAgICAgIEFkZCBlbmNvZGVycyBmb3IgTWVkaWFQbGF5ZXJFbnVtIGVudW1zCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcWwvU1FMaXRlRGF0YWJhc2UuaCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVEYXRhYmFzZS5oCmluZGV4IDUyMjRmMWU3 NzdjNTZiZWZiM2Q2NmY4ZTA1ODhhZDAwOGEyMDQyNGUuLjRiNzQzZTAxNGNiZTJmZjQ2ZDRhZWEx MTYyZWI2MzdmYzg5ZmNlNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3Nx bC9TUUxpdGVEYXRhYmFzZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxp dGVEYXRhYmFzZS5oCkBAIC0xMzUsNyArMTM1LDcgQEAgcHVibGljOgogI2lmbmRlZiBOREVCVUcK ICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIGRpc2FibGVUaHJlYWRpbmdDaGVja3MoKTsKICNlbHNl Ci0gICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBkaXNhYmxlVGhyZWFkaW5nQ2hlY2tzKCkge30KKyAg ICB2b2lkIGRpc2FibGVUaHJlYWRpbmdDaGVja3MoKSB7IH0KICNlbmRpZgogCiAgICAgV0VCQ09S RV9FWFBPUlQgc3RhdGljIHZvaWQgc2V0SXNEYXRhYmFzZU9wZW5pbmdGb3JiaWRkZW4oYm9vbCk7 Cg==