205137 2019-12-11 14:30:14 -0800 Remove unused Frame parameter from moveByGranularityRespectingWordBoundary() and take const VisiblePosition& 2019-12-11 15:46:38 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates webkit-bug-importer wenson_hsieh oldest_to_newest 1597797 0 dbates 2019-12-11 14:30:14 -0800 moveByGranularityRespectingWordBoundary() is passed a Frame&, which it does not use, and a non-const VisiblePosition to move from, which it does not mutate. Remove the unused Frame param and take the visible position as a const lvalue reference. 1597800 1 385440 dbates 2019-12-11 14:32:29 -0800 Created attachment 385440 Patch 1597830 2 385440 dbates 2019-12-11 15:45:30 -0800 Comment on attachment 385440 Patch Clearing flags on attachment: 385440 Committed r253400: <https://trac.webkit.org/changeset/253400> 1597831 3 dbates 2019-12-11 15:45:31 -0800 All reviewed patches have been landed. Closing bug. 1597833 4 webkit-bug-importer 2019-12-11 15:46:38 -0800 <rdar://problem/57857274> 385440 2019-12-11 14:32:29 -0800 2019-12-11 15:45:30 -0800 Patch bug-205137-20191211143229.patch text/plain 3105 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDUwYWQxYjFmODc5ZDhlMjcy MDJiYzEyOTMwNDdiMzY2NTZjODM5YzMuLjU4YWQ4YWVkMWY5ZjA3ZmQ2ZTkxNzJhNjBlNmY4ZWEz YWM2NDRiNjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMTItMTEgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSB1bnVzZWQgRnJhbWUg cGFyYW1ldGVyIGZyb20gbW92ZUJ5R3JhbnVsYXJpdHlSZXNwZWN0aW5nV29yZEJvdW5kYXJ5KCkg YW5kIHRha2UgY29uc3QgVmlzaWJsZVBvc2l0aW9uJgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1MTM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgbW92ZUJ5R3JhbnVsYXJpdHlSZXNwZWN0aW5nV29yZEJv dW5kYXJ5KCkgbmV2ZXIgbWFrZXMgdXNlIG9mIHRoZSBwYXNzZWQgRnJhbWUgYW5kIGRvZXMgbm90 IG11dGF0ZSB0aGUKKyAgICAgICAgcGFzc2VkIFZpc2libGVQb3NpdGlvbi4gU28sIGRvIG5vdCBh Y2NlcHQgdGhlIGZvcm1lciBhbmQgdGFrZSB0aGUgbGF0dGVyIGFzIGEgY29uc3QgbHZhbHVlIHJl ZmVyZW5jZS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5t bToKKyAgICAgICAgKFdlYktpdDo6bW92ZUJ5R3JhbnVsYXJpdHlSZXNwZWN0aW5nV29yZEJvdW5k YXJ5KToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6cmVxdWVzdERvY3VtZW50RWRpdGluZ0Nv bnRleHQpOgorCiAyMDE5LTEyLTExICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4K IAogICAgICAgICBVSVdLRG9jdW1lbnRDb250ZXh0IHJldHVybnMgMCBjaGFyYWN0ZXIgcmVjdHMg d2hlbiBjYXJldCBpcyBhdCBiZWdpbm5pbmcgb3IgZW5kIG9mIHRleHQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tIGIvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KaW5kZXggZjJmNmY0 OWQxNWNkZDkzMjk2ZTRkN2QwYzRhZjc0ZWEzYTE4ODc0Mi4uZjk3ZmJjNjVlNjRkY2Y4YjkzMTQ3 NjQ4YjU5MzNmOWE4ODE1OTNjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KQEAgLTM4NzcsNyArMzg3Nyw3IEBAIHZvaWQgV2Vi UGFnZTo6dXBkYXRlU2VsZWN0aW9uV2l0aERlbHRhKGludDY0X3QgbG9jYXRpb25EZWx0YSwgaW50 NjRfdCBsZW5ndGhEZWx0CiAgICAgY29tcGxldGlvbkhhbmRsZXIoKTsKIH0KIAotc3RhdGljIFZp c2libGVQb3NpdGlvbiBtb3ZlQnlHcmFudWxhcml0eVJlc3BlY3RpbmdXb3JkQm91bmRhcnkoRnJh bWUmIGZyYW1lLCBWaXNpYmxlUG9zaXRpb24mIHBvc2l0aW9uLCBUZXh0R3JhbnVsYXJpdHkgZ3Jh bnVsYXJpdHksIHVpbnQ2NF90IGdyYW51bGFyaXR5Q291bnQsIFNlbGVjdGlvbkRpcmVjdGlvbiBk aXJlY3Rpb24pCitzdGF0aWMgVmlzaWJsZVBvc2l0aW9uIG1vdmVCeUdyYW51bGFyaXR5UmVzcGVj dGluZ1dvcmRCb3VuZGFyeShjb25zdCBWaXNpYmxlUG9zaXRpb24mIHBvc2l0aW9uLCBUZXh0R3Jh bnVsYXJpdHkgZ3JhbnVsYXJpdHksIHVpbnQ2NF90IGdyYW51bGFyaXR5Q291bnQsIFNlbGVjdGlv bkRpcmVjdGlvbiBkaXJlY3Rpb24pCiB7CiAgICAgYm9vbCBiYWNrd2FyZHMgPSBkaXJlY3Rpb24g PT0gRGlyZWN0aW9uQmFja3dhcmQ7CiAgICAgYXV0byBmYXJ0aGVzdFBvc2l0aW9uSW5EaXJlY3Rp b24gPSBiYWNrd2FyZHMgPyBzdGFydE9mRWRpdGFibGVDb250ZW50KHBvc2l0aW9uKSA6IGVuZE9m RWRpdGFibGVDb250ZW50KHBvc2l0aW9uKTsKQEAgLTQwMDIsOCArNDAwMiw4IEBAIHZvaWQgV2Vi UGFnZTo6cmVxdWVzdERvY3VtZW50RWRpdGluZ0NvbnRleHQoRG9jdW1lbnRFZGl0aW5nQ29udGV4 dFJlcXVlc3QgcmVxdWVzCiAgICAgVmlzaWJsZVBvc2l0aW9uIGNvbnRleHRCZWZvcmVTdGFydDsK ICAgICBWaXNpYmxlUG9zaXRpb24gY29udGV4dEFmdGVyRW5kOwogICAgIGlmIChyZXF1ZXN0Lmdy YW51bGFyaXR5Q291bnQpIHsKLSAgICAgICAgY29udGV4dEJlZm9yZVN0YXJ0ID0gbW92ZUJ5R3Jh bnVsYXJpdHlSZXNwZWN0aW5nV29yZEJvdW5kYXJ5KGZyYW1lLmdldCgpLCByYW5nZU9mSW50ZXJl c3RTdGFydCwgcmVxdWVzdC5zdXJyb3VuZGluZ0dyYW51bGFyaXR5LCByZXF1ZXN0LmdyYW51bGFy aXR5Q291bnQsIERpcmVjdGlvbkJhY2t3YXJkKTsKLSAgICAgICAgY29udGV4dEFmdGVyRW5kID0g bW92ZUJ5R3JhbnVsYXJpdHlSZXNwZWN0aW5nV29yZEJvdW5kYXJ5KGZyYW1lLmdldCgpLCByYW5n ZU9mSW50ZXJlc3RFbmQsIHJlcXVlc3Quc3Vycm91bmRpbmdHcmFudWxhcml0eSwgcmVxdWVzdC5n cmFudWxhcml0eUNvdW50LCBEaXJlY3Rpb25Gb3J3YXJkKTsKKyAgICAgICAgY29udGV4dEJlZm9y ZVN0YXJ0ID0gbW92ZUJ5R3JhbnVsYXJpdHlSZXNwZWN0aW5nV29yZEJvdW5kYXJ5KHJhbmdlT2ZJ bnRlcmVzdFN0YXJ0LCByZXF1ZXN0LnN1cnJvdW5kaW5nR3JhbnVsYXJpdHksIHJlcXVlc3QuZ3Jh bnVsYXJpdHlDb3VudCwgRGlyZWN0aW9uQmFja3dhcmQpOworICAgICAgICBjb250ZXh0QWZ0ZXJF bmQgPSBtb3ZlQnlHcmFudWxhcml0eVJlc3BlY3RpbmdXb3JkQm91bmRhcnkocmFuZ2VPZkludGVy ZXN0RW5kLCByZXF1ZXN0LnN1cnJvdW5kaW5nR3JhbnVsYXJpdHksIHJlcXVlc3QuZ3JhbnVsYXJp dHlDb3VudCwgRGlyZWN0aW9uRm9yd2FyZCk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgY29udGV4 dEJlZm9yZVN0YXJ0ID0gcmFuZ2VPZkludGVyZXN0U3RhcnQ7CiAgICAgICAgIGNvbnRleHRBZnRl ckVuZCA9IHJhbmdlT2ZJbnRlcmVzdEVuZDsK