205124 2019-12-11 10:32:08 -0800 Add test for osr exiting with interpreter on the stack 2019-12-11 12:15:34 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue mark.lam webkit-bug-importer oldest_to_newest 1597677 0 keith_miller 2019-12-11 10:32:08 -0800 Add test for osr exiting with interpreter on the stack 1597680 1 385406 keith_miller 2019-12-11 10:32:59 -0800 Created attachment 385406 Patch 1597682 2 385406 mark.lam 2019-12-11 10:45:10 -0800 Comment on attachment 385406 Patch rs=me. Make sure EWS bots are happy. 1597697 3 385406 mark.lam 2019-12-11 11:08:17 -0800 Comment on attachment 385406 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385406&action=review > JSTests/stress/osr-exit-with-interpreter-on-stack.js:1 > +//@ requiredOptions('--thresholdForJITAfterWarmUp=10', '--useConcurrentJIT=0') /requiredOptions/requireOptions/ nit: use '--useConcurrentJIT=false' instead. I've been told in the past that though the bool option is able to take an int, using it in official code is a no-no. So, let's just avoid that. 1597701 4 mark.lam 2019-12-11 11:23:29 -0800 <rdar://problem/55917224> 1597705 5 385416 keith_miller 2019-12-11 11:31:21 -0800 Created attachment 385416 Patch for landing 1597707 6 385406 keith_miller 2019-12-11 11:32:24 -0800 Comment on attachment 385406 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385406&action=review >> JSTests/stress/osr-exit-with-interpreter-on-stack.js:1 >> +//@ requiredOptions('--thresholdForJITAfterWarmUp=10', '--useConcurrentJIT=0') > > /requiredOptions/requireOptions/ > > nit: use '--useConcurrentJIT=false' instead. I've been told in the past that though the bool option is able to take an int, using it in official code is a no-no. So, let's just avoid that. Whoops, fixed. Ehh, we use 0/1 more than true/false currently so I'm gonna stick with 0. 1597725 7 385416 commit-queue 2019-12-11 12:15:33 -0800 Comment on attachment 385416 Patch for landing Clearing flags on attachment: 385416 Committed r253384: <https://trac.webkit.org/changeset/253384> 1597726 8 commit-queue 2019-12-11 12:15:34 -0800 All reviewed patches have been landed. Closing bug. 385406 2019-12-11 10:32:59 -0800 2019-12-11 11:31:20 -0800 Patch bug-205124-20191211103241.patch text/plain 1551 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMzc5CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDRmZDU4MGViZWVjNGVkNmU1MTgxM2VjZWU4M2Zk NzY3ZTI4YzEwMTIuLmNlYmFlZjAwZTQ0OTdhYzQ5MGZjZDFiZGJhZjU4MGZhZjBjMmM5ZGMgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTktMTItMTEgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBs ZS5jb20+CisKKyAgICAgICAgQWRkIHRlc3QgZm9yIG9zciBleGl0aW5nIHdpdGggaW50ZXJwcmV0 ZXIgb24gdGhlIHN0YWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDUxMjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBJIGZvcmdvdCB0byBhZGQgdGhpcyB0ZXN0IGJlZm9yZS4KKworICAgICAgICAqIHN0 cmVzcy9vc3ItZXhpdC13aXRoLWludGVycHJldGVyLW9uLXN0YWNrLmpzOiBBZGRlZC4KKyAgICAg ICAgKGZvbyk6CisKIDIwMTktMTItMTAgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNv bT4KIAogICAgICAgICBbSlNDXSBBZGhvY2x5IGNyZWF0ZWQgQ2FsbExpbmtJbmZvIGluIEdldHRl clNldHRlckFjY2VzcyBzaG91bGQgYmUgb3duZWQgYnkgR0NBd2FyZUpJVFN0dWJSb3V0aW5lCmRp ZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9vc3ItZXhpdC13aXRoLWludGVycHJldGVyLW9uLXN0 YWNrLmpzIGIvSlNUZXN0cy9zdHJlc3Mvb3NyLWV4aXQtd2l0aC1pbnRlcnByZXRlci1vbi1zdGFj ay5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi4wZGU3OGIxNTZmNDk3NDFkMDNhZWE4MjQxOTg1OTRkNDY5YWNjNTU4 Ci0tLSAvZGV2L251bGwKKysrIGIvSlNUZXN0cy9zdHJlc3Mvb3NyLWV4aXQtd2l0aC1pbnRlcnBy ZXRlci1vbi1zdGFjay5qcwpAQCAtMCwwICsxLDE4IEBACisvL0AgcmVxdWlyZWRPcHRpb25zKCct LXRocmVzaG9sZEZvckpJVEFmdGVyV2FybVVwPTEwJywgJy0tdXNlQ29uY3VycmVudEpJVD0wJykK KworZnVuY3Rpb24gZm9vKGFycmF5KSB7CisgICAgbGV0IGxlbmd0aCA9IGFycmF5Lmxlbmd0aDsK KyAgICBpZiAobGVuZ3RoID09IDEpIHsKKyAgICAgICAgcmV0dXJuIGFycmF5OworICAgIH0gZWxz ZSB7CisgICAgICAgIGZvciAobGV0IGkgPSAxOyBpIDwgbGVuZ3RoOyArK2kpIHsKKyAgICAgICAg ICAgIGxldCB2YWx1ZSA9IGZvbyhhcnJheS5zbGljZSgwLCBpKSk7CisgICAgICAgICAgICBmb28o YXJyYXkuc2xpY2UoaSkpOworICAgICAgICAgICAgdmFsdWUubGVuZ3RoOworICAgICAgICAgICAg Zm9vKGFycmF5LnNsaWNlKGkpKTsKKyAgICAgICAgfQorICAgICAgICByZXR1cm4gZnVuY3Rpb24o KSB7fTsKKyAgICB9Cit9Cit2YXIgYXJyYXkgPSBbJ2EnLCAnYicsICdjJywgJ2QnLCAnZSddOwor Zm9vKGFycmF5KTsK 385416 2019-12-11 11:31:21 -0800 2019-12-11 12:15:33 -0800 Patch for landing bug-205124-20191211113111.patch text/plain 1544 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMzc5CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDRmZDU4MGViZWVjNGVkNmU1MTgxM2VjZWU4M2Zk NzY3ZTI4YzEwMTIuLmFhZWY4ODQxZDIwNWZhYmRhMWJmZGQ4NzY5YTZlMTRiZjY2NTIwMzcgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTktMTItMTEgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBs ZS5jb20+CisKKyAgICAgICAgQWRkIHRlc3QgZm9yIG9zciBleGl0aW5nIHdpdGggaW50ZXJwcmV0 ZXIgb24gdGhlIHN0YWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDUxMjQKKworICAgICAgICBSZXZpZXdlZCBieSBNYXJrIExhbS4KKworICAgICAg ICBJIGZvcmdvdCB0byBhZGQgdGhpcyB0ZXN0IGJlZm9yZS4KKworICAgICAgICAqIHN0cmVzcy9v c3ItZXhpdC13aXRoLWludGVycHJldGVyLW9uLXN0YWNrLmpzOiBBZGRlZC4KKyAgICAgICAgKGZv byk6CisKIDIwMTktMTItMTAgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAog ICAgICAgICBbSlNDXSBBZGhvY2x5IGNyZWF0ZWQgQ2FsbExpbmtJbmZvIGluIEdldHRlclNldHRl ckFjY2VzcyBzaG91bGQgYmUgb3duZWQgYnkgR0NBd2FyZUpJVFN0dWJSb3V0aW5lCmRpZmYgLS1n aXQgYS9KU1Rlc3RzL3N0cmVzcy9vc3ItZXhpdC13aXRoLWludGVycHJldGVyLW9uLXN0YWNrLmpz IGIvSlNUZXN0cy9zdHJlc3Mvb3NyLWV4aXQtd2l0aC1pbnRlcnByZXRlci1vbi1zdGFjay5qcwpu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi42MTdhZTNjMzcwYmFmMTFlZWI1OTFkZTEzZTVlNTBkNDVhZTNlZGFmCi0tLSAv ZGV2L251bGwKKysrIGIvSlNUZXN0cy9zdHJlc3Mvb3NyLWV4aXQtd2l0aC1pbnRlcnByZXRlci1v bi1zdGFjay5qcwpAQCAtMCwwICsxLDE4IEBACisvL0AgcmVxdWlyZU9wdGlvbnMoJy0tdGhyZXNo b2xkRm9ySklUQWZ0ZXJXYXJtVXA9MTAnLCAnLS11c2VDb25jdXJyZW50SklUPTAnKQorCitmdW5j dGlvbiBmb28oYXJyYXkpIHsKKyAgICBsZXQgbGVuZ3RoID0gYXJyYXkubGVuZ3RoOworICAgIGlm IChsZW5ndGggPT0gMSkgeworICAgICAgICByZXR1cm4gYXJyYXk7CisgICAgfSBlbHNlIHsKKyAg ICAgICAgZm9yIChsZXQgaSA9IDE7IGkgPCBsZW5ndGg7ICsraSkgeworICAgICAgICAgICAgbGV0 IHZhbHVlID0gZm9vKGFycmF5LnNsaWNlKDAsIGkpKTsKKyAgICAgICAgICAgIGZvbyhhcnJheS5z bGljZShpKSk7CisgICAgICAgICAgICB2YWx1ZS5sZW5ndGg7CisgICAgICAgICAgICBmb28oYXJy YXkuc2xpY2UoaSkpOworICAgICAgICB9CisgICAgICAgIHJldHVybiBmdW5jdGlvbigpIHt9Owor ICAgIH0KK30KK3ZhciBhcnJheSA9IFsnYScsICdiJywgJ2MnLCAnZCcsICdlJ107Citmb28oYXJy YXkpOwo=