205115 2019-12-11 08:08:27 -0800 [LFC][IFC] Fix fast/text/hyphenate-limit-lines.html 2019-12-11 08:45:57 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1597621 0 zalan 2019-12-11 08:08:27 -0800 handle the hyphenated line count properly 1597622 1 webkit-bug-importer 2019-12-11 08:08:50 -0800 <rdar://problem/57837829> 1597625 2 385393 zalan 2019-12-11 08:16:19 -0800 Created attachment 385393 Patch 1597627 3 385393 koivisto 2019-12-11 08:23:03 -0800 Comment on attachment 385393 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385393&action=review > Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:246 > + m_successiveHyphenatedLineCount = breakingContext.partialTrailingContent && breakingContext.partialTrailingContent->needsHyphen ? m_successiveHyphenatedLineCount + 1 : 0; Might read better as if() 1597628 4 koivisto 2019-12-11 08:24:05 -0800 if() ++m_successiveHyphenatedLineCount; else m_successiveHyphenatedLineCount = 0; 1597631 5 zalan 2019-12-11 08:36:09 -0800 Committed r253373: <https://trac.webkit.org/changeset/253373> 1597636 6 zalan 2019-12-11 08:45:57 -0800 (In reply to Antti Koivisto from comment #3) > Comment on attachment 385393 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385393&action=review > > > Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:246 > > + m_successiveHyphenatedLineCount = breakingContext.partialTrailingContent && breakingContext.partialTrailingContent->needsHyphen ? m_successiveHyphenatedLineCount + 1 : 0; > > Might read better as if() good point! 385393 2019-12-11 08:16:19 -0800 2019-12-11 08:19:22 -0800 Patch bug-205115-20191211081618.patch text/plain 2275 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzVmODRlMjdkYWFjN2Q2 ZDQ3YmI3NzI3ZDdlMGM4ZGE1ODc4NjcyNy4uNzZlYTg4NjdhNjk1MWE4NWI3NjhmYTdkYTIzMTA4 N2Q3MDY0NmVkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTEyLTExICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBGaXggZmFz dC90ZXh0L2h5cGhlbmF0ZS1saW1pdC1saW5lcy5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDUxMTUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzU3ODM3ODI5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIERvIG5vdCBhZGp1c3QgdGhlIG1fc3VjY2Vzc2l2ZUh5cGhlbmF0ZWRMaW5lQ291bnQgdW5s ZXNzIGl0J3MgdGhlIGVuZCBvZiB0aGUgbGluZSAoZWl0aGVyIHNwbGl0IG9yIHB1c2gpLgorCisg ICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvTGluZUxheW91dENvbnRleHQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lTGF5b3V0Q29udGV4dDo6cHJvY2Vzc1VuY29t bWl0dGVkQ29udGVudCk6CisKIDIwMTktMTItMTEgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxl LmNvbT4KIAogICAgICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0gUGFpbnQgc2VlbWluZ2x5IGJsYW5r IHJ1bnMgKDAgd2lkdGgsIHJlc3VsdCBvZiBuZWdhdGl2ZSBsZXR0ZXItc3BhY2luZykKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0xpbmVMYXlvdXRD b250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0xpbmVM YXlvdXRDb250ZXh0LmNwcAppbmRleCBiYThkNWFjMzRjYzI3MjQ0NTk0ODJhZTU5MmY4OTBmNGYy YmVhZjFjLi4wMWYxZWMxZTFmYjU2ZTMwYTNjNDJkZWY0NGViMjFiYmFiMGVkZTkwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9MaW5lTGF5b3V0Q29u dGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvTGlu ZUxheW91dENvbnRleHQuY3BwCkBAIC0yNDAsOSArMjQwLDEyIEBAIExpbmVMYXlvdXRDb250ZXh0 OjpJc0VuZE9mTGluZSBMaW5lTGF5b3V0Q29udGV4dDo6cHJvY2Vzc1VuY29tbWl0dGVkQ29udGVu dChMaW5lCiAgICAgICAgIG1fdW5jb21taXR0ZWRDb250ZW50LnJlc2V0KCk7CiAgICAgZWxzZQog ICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICAvLyBBZGp1c3QgaHlwaGVuYXRlZCBs aW5lIGNvdW50Ci0gICAgbV9zdWNjZXNzaXZlSHlwaGVuYXRlZExpbmVDb3VudCA9IGJyZWFraW5n Q29udGV4dC5wYXJ0aWFsVHJhaWxpbmdDb250ZW50ICYmIGJyZWFraW5nQ29udGV4dC5wYXJ0aWFs VHJhaWxpbmdDb250ZW50LT5uZWVkc0h5cGhlbiA/IG1fc3VjY2Vzc2l2ZUh5cGhlbmF0ZWRMaW5l Q291bnQgKyAxIDogMDsKLSAgICByZXR1cm4gYnJlYWtpbmdDb250ZXh0LmNvbnRlbnRXcmFwcGlu Z1J1bGUgPT0gTGluZUJyZWFrZXI6OkJyZWFraW5nQ29udGV4dDo6Q29udGVudFdyYXBwaW5nUnVs ZTo6S2VlcCA/IElzRW5kT2ZMaW5lOjpObyA6SXNFbmRPZkxpbmU6OlllczsKKyAgICBhdXRvIGlz RW5kT2ZMaW5lID0gYnJlYWtpbmdDb250ZXh0LmNvbnRlbnRXcmFwcGluZ1J1bGUgPT0gTGluZUJy ZWFrZXI6OkJyZWFraW5nQ29udGV4dDo6Q29udGVudFdyYXBwaW5nUnVsZTo6S2VlcCA/IElzRW5k T2ZMaW5lOjpObyA6IElzRW5kT2ZMaW5lOjpZZXM7CisgICAgaWYgKGlzRW5kT2ZMaW5lID09IElz RW5kT2ZMaW5lOjpZZXMpIHsKKyAgICAgICAgLy8gQWRqdXN0IGh5cGhlbmF0ZWQgbGluZSBjb3Vu dC4KKyAgICAgICAgbV9zdWNjZXNzaXZlSHlwaGVuYXRlZExpbmVDb3VudCA9IGJyZWFraW5nQ29u dGV4dC5wYXJ0aWFsVHJhaWxpbmdDb250ZW50ICYmIGJyZWFraW5nQ29udGV4dC5wYXJ0aWFsVHJh aWxpbmdDb250ZW50LT5uZWVkc0h5cGhlbiA/IG1fc3VjY2Vzc2l2ZUh5cGhlbmF0ZWRMaW5lQ291 bnQgKyAxIDogMDsKKyAgICB9CisgICAgcmV0dXJuIGlzRW5kT2ZMaW5lOwogfQogCiB9Cg==