205114 2019-12-11 07:42:19 -0800 [LFC][Integration] Paint seemingly blank runs (0 width, result of negative letter-spacing) 2019-12-12 13:32:07 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1597616 0 zalan 2019-12-11 07:42:19 -0800 negative letter-spacing can produce 0 width runs. 1597617 1 webkit-bug-importer 2019-12-11 07:42:50 -0800 <rdar://problem/57837165> 1597618 2 385391 zalan 2019-12-11 07:46:49 -0800 Created attachment 385391 Patch 1597619 3 385391 koivisto 2019-12-11 08:03:56 -0800 Comment on attachment 385391 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385391&action=review > Source/WebCore/layout/displaytree/DisplayInlineContent.cpp:40 > + if (runRect.intersects(rect) || (runRect.isEmpty() && rect.contains(runRect))) { Empty case can still have width or height. Is it correct to require the entire width or height be contained in rect? Maybe you could add FloatRect::intersectsEvenIfEmpty? There is already uniteEvenIfEmpty. 1598118 4 385540 zalan 2019-12-12 13:22:06 -0800 Created attachment 385540 Patch 1598120 5 zalan 2019-12-12 13:32:07 -0800 Committed r253442: <https://trac.webkit.org/changeset/253442> 385391 2019-12-11 07:46:49 -0800 2019-12-12 13:22:05 -0800 Patch bug-205114-20191211074647.patch text/plain 3865 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODJmNjJkNjUyYTE3MzQ5 MTgyZTMwZmQwMGJkMjJmZjY1OTFjZmUyZC4uMzVmODRlMjdkYWFjN2Q2ZDQ3YmI3NzI3ZDdlMGM4 ZGE1ODc4NjcyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTEyLTExICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSW50ZWdyYXRpb25d IFBhaW50IHNlZW1pbmdseSBibGFuayBydW5zICgwIHdpZHRoLCByZXN1bHQgb2YgbmVnYXRpdmUg bGV0dGVyLXNwYWNpbmcpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDUxMTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU3ODM3MTY1PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5lZ2F0aXZlIGxldHRl ci1zcGFjaW5nIGNhbiBwcm9kdWNlIDAgd2lkdGggcnVucy4gRG9uJ3Qgc2tpcCB0aGVtIHdoZW4g cGFpbnRpbmcuCisKKyAgICAgICAgKiBsYXlvdXQvZGlzcGxheXRyZWUvRGlzcGxheUlubGluZUNv bnRlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheTo6IGNvbnN0KToKKyAgICAgICAg KiBsYXlvdXQvZGlzcGxheXRyZWUvRGlzcGxheUlubGluZUNvbnRlbnQuaDoKKyAgICAgICAgKiBs YXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkxheW91dEludGVncmF0aW9uOjpMaW5lTGF5b3V0OjpwYWludCk6CisKIDIw MTktMTItMTAgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZD XVtJRkNdIE1vdmUgc2luZ2xlIHdoaXRlc3BhY2UgbWVhc3VyaW5nIHRvIFRleHRVdGlsCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZGlzcGxheXRyZWUvRGlzcGxheUlubGluZUNv bnRlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Rpc3BsYXl0cmVlL0Rpc3BsYXlJbmxp bmVDb250ZW50LmNwcAppbmRleCBmMGFiYTBkOWQ0ZjFhZTY2ZDZmMGRlNTEzNDNkMjlkYTE3MGI4 Njk0Li44NzE2Y2VkMzczODZjMmYwZmJhOWVhZDg0MWEwMDYxYjViNmNhMDQzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZGlzcGxheXRyZWUvRGlzcGxheUlubGluZUNvbnRlbnQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9kaXNwbGF5dHJlZS9EaXNwbGF5SW5saW5l Q29udGVudC5jcHAKQEAgLTMxLDEzICszMSwxMyBAQAogbmFtZXNwYWNlIFdlYkNvcmUgewogbmFt ZXNwYWNlIERpc3BsYXkgewogCi1XVEY6Okl0ZXJhdG9yUmFuZ2U8Y29uc3QgUnVuKj4gSW5saW5l Q29udGVudDo6cnVuc0ZvclJlY3QoY29uc3QgTGF5b3V0UmVjdCYgcmVjdCkgY29uc3QKK1dURjo6 SXRlcmF0b3JSYW5nZTxjb25zdCBSdW4qPiBJbmxpbmVDb250ZW50OjpydW5zRm9yUmVjdChjb25z dCBGbG9hdFJlY3QmIHJlY3QpIGNvbnN0CiB7CiAgICAgLy8gRklYTUU6IERvIHNvbWV0aGluZyBl ZmZpY2llbnQuCiAgICAgY29uc3QgUnVuKiBmaXJzdCA9IG51bGxwdHI7CiAgICAgZm9yIChhdXRv JiBydW4gOiBydW5zKSB7CiAgICAgICAgIGF1dG8gcnVuUmVjdCA9IEZsb2F0UmVjdCB7IHJ1bi5s b2dpY2FsUmVjdCgpIH07Ci0gICAgICAgIGlmIChydW5SZWN0LmludGVyc2VjdHMocmVjdCkpIHsK KyAgICAgICAgaWYgKHJ1blJlY3QuaW50ZXJzZWN0cyhyZWN0KSB8fCAocnVuUmVjdC5pc0VtcHR5 KCkgJiYgcmVjdC5jb250YWlucyhydW5SZWN0KSkpIHsKICAgICAgICAgICAgIGZpcnN0ID0gJnJ1 bjsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CkBAIC00OCw3ICs0OCw3IEBAIFdURjo6 SXRlcmF0b3JSYW5nZTxjb25zdCBSdW4qPiBJbmxpbmVDb250ZW50OjpydW5zRm9yUmVjdChjb25z dCBMYXlvdXRSZWN0JiByZWN0CiAgICAgY29uc3QgUnVuKiBsYXN0ID0gbnVsbHB0cjsKICAgICBm b3IgKGF1dG8mIHJ1biA6IFdURjo6bWFrZVJldmVyc2VkUmFuZ2UocnVucykpIHsKICAgICAgICAg YXV0byBydW5SZWN0ID0gRmxvYXRSZWN0IHsgcnVuLmxvZ2ljYWxSZWN0KCkgfTsKLSAgICAgICAg aWYgKHJ1blJlY3QuaW50ZXJzZWN0cyhyZWN0KSkgeworICAgICAgICBpZiAocnVuUmVjdC5pbnRl cnNlY3RzKHJlY3QpIHx8IChydW5SZWN0LmlzRW1wdHkoKSAmJiByZWN0LmNvbnRhaW5zKHJ1blJl Y3QpKSkgewogICAgICAgICAgICAgbGFzdCA9ICZydW47CiAgICAgICAgICAgICBicmVhazsKICAg ICAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Rpc3BsYXl0cmVlL0Rp c3BsYXlJbmxpbmVDb250ZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZGlzcGxheXRyZWUv RGlzcGxheUlubGluZUNvbnRlbnQuaAppbmRleCA1ZWM4ZGYwNTQ3YzJiODk0MzkwYjYyNTJmOWU1 OGVjMzIzYTAzOWJjLi42ODQ0NTI5MzBlYTQ0ZmY2NThjM2JlNGNhNDkzMDNkNjkwYWMxMzJmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZGlzcGxheXRyZWUvRGlzcGxheUlubGlu ZUNvbnRlbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZGlzcGxheXRyZWUvRGlzcGxh eUlubGluZUNvbnRlbnQuaApAQCAtNDMsNyArNDMsNyBAQCBzdHJ1Y3QgSW5saW5lQ29udGVudCA6 IHB1YmxpYyBSZWZDb3VudGVkPElubGluZUNvbnRlbnQ+IHsKICAgICBMaW5lQm94ZXMgbGluZUJv eGVzOwogCiAgICAgY29uc3QgTGluZUJveCYgbGluZUJveEZvclJ1bihjb25zdCBSdW4mIHJ1bikg Y29uc3QgeyByZXR1cm4gbGluZUJveGVzW3J1bi5saW5lSW5kZXgoKV07IH0KLSAgICBXVEY6Okl0 ZXJhdG9yUmFuZ2U8Y29uc3QgUnVuKj4gcnVuc0ZvclJlY3QoY29uc3QgTGF5b3V0UmVjdCYpIGNv bnN0OworICAgIFdURjo6SXRlcmF0b3JSYW5nZTxjb25zdCBSdW4qPiBydW5zRm9yUmVjdChjb25z dCBGbG9hdFJlY3QmKSBjb25zdDsKIH07CiAKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwIGIvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91 dC5jcHAKaW5kZXggNTZiYzI1YjJiYjhlMmVjOGY4M2M1ZGIzMGYzN2ViNGU3MmIyN2U3Ni4uMjdh YzgwODI1MWMyMzMwYmIwNjgyNmI5MjNhOWRhNDIwM2FiYTZjNCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0 aW9uTGluZUxheW91dC5jcHAKQEAgLTIzMyw3ICsyMzMsNyBAQCB2b2lkIExpbmVMYXlvdXQ6OnBh aW50KFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjb25zdCBMYXlvdXRQb2ludCYgcGFpbnRPZmZzZXQp CiAgICAgYXV0byBwYWludFJlY3QgPSBwYWludEluZm8ucmVjdDsKICAgICBwYWludFJlY3QubW92 ZUJ5KC1wYWludE9mZnNldCk7CiAKLSAgICBmb3IgKGF1dG8mIHJ1biA6IGlubGluZUNvbnRlbnQu cnVuc0ZvclJlY3QocGFpbnRSZWN0KSkgeworICAgIGZvciAoYXV0byYgcnVuIDogaW5saW5lQ29u dGVudC5ydW5zRm9yUmVjdChGbG9hdFJlY3QgeyBwYWludFJlY3QgfSkpIHsKICAgICAgICAgaWYg KCFydW4udGV4dENvbnRleHQoKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwogCg== 385540 2019-12-12 13:22:06 -0800 2019-12-12 13:23:41 -0800 Patch bug-205114-20191212132205.patch text/plain 2300 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDE2ZWFjZGUxNzU0NWIx NDBlYTU3OWI5NTM5NDA0ZTk3M2QzOTRkMC4uMDEwMWQ2MThkYzQ1MjY2MGNlYzAxYzYxNGVmODE4 ODI5ZDhiM2EwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTEyLTEyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSW50ZWdyYXRpb25d IFBhaW50IHNlZW1pbmdseSBibGFuayBydW5zICgwIHdpZHRoLCByZXN1bHQgb2YgbmVnYXRpdmUg bGV0dGVyLXNwYWNpbmcpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDUxMTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU3ODM3MTY1PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExldCdzIG5vdCBpbnRl cnNlY3QgdGhlIHJ1bidzIHJlY3Qgd2l0aCB0aGUgZGFtYWdlZCBhcmVhIHdoZW4gd2UgZG9uJ3Qg eWV0IGhhdmUgYW55IHBhaW50CisgICAgICAgIG92ZXJmbG93IGluZm9ybWF0aW9uIChUaGlzIHNo b3VsZCByYXRoZXIgdXNlIHRoZSBsaW5lIGJveCBzZXQgdG8gaWRlbnRpZnkgdGhlIGxpbmUgcmFu Z2UgdG8gcGFpbnQuKQorCisgICAgICAgICogbGF5b3V0L2Rpc3BsYXl0cmVlL0Rpc3BsYXlJbmxp bmVDb250ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRpc3BsYXk6OiBjb25zdCk6CisKIDIw MTktMTItMTIgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZD XVtJRkNdIEZpeCBmYXN0L3RleHQvd2hpdGVzcGFjZS8wMjMuaHRtbApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2Rpc3BsYXl0cmVlL0Rpc3BsYXlJbmxpbmVDb250ZW50LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2xheW91dC9kaXNwbGF5dHJlZS9EaXNwbGF5SW5saW5lQ29udGVudC5j cHAKaW5kZXggZjBhYmEwZDlkNGYxYWU2NmQ2ZjBkZTUxMzQzZDI5ZGExNzBiODY5NC4uOWMxMWU0 MjZiN2M5M2EyY2MzZDgwZDZlNWNkNTI5ZDBlYTk1YzdlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvbGF5b3V0L2Rpc3BsYXl0cmVlL0Rpc3BsYXlJbmxpbmVDb250ZW50LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvZGlzcGxheXRyZWUvRGlzcGxheUlubGluZUNvbnRlbnQuY3Bw CkBAIC0zMSwzMCArMzEsMTIgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIG5hbWVzcGFjZSBEaXNw bGF5IHsKIAotV1RGOjpJdGVyYXRvclJhbmdlPGNvbnN0IFJ1bio+IElubGluZUNvbnRlbnQ6OnJ1 bnNGb3JSZWN0KGNvbnN0IExheW91dFJlY3QmIHJlY3QpIGNvbnN0CitXVEY6Okl0ZXJhdG9yUmFu Z2U8Y29uc3QgUnVuKj4gSW5saW5lQ29udGVudDo6cnVuc0ZvclJlY3QoY29uc3QgTGF5b3V0UmVj dCYpIGNvbnN0CiB7Ci0gICAgLy8gRklYTUU6IERvIHNvbWV0aGluZyBlZmZpY2llbnQuCi0gICAg Y29uc3QgUnVuKiBmaXJzdCA9IG51bGxwdHI7Ci0gICAgZm9yIChhdXRvJiBydW4gOiBydW5zKSB7 Ci0gICAgICAgIGF1dG8gcnVuUmVjdCA9IEZsb2F0UmVjdCB7IHJ1bi5sb2dpY2FsUmVjdCgpIH07 Ci0gICAgICAgIGlmIChydW5SZWN0LmludGVyc2VjdHMocmVjdCkpIHsKLSAgICAgICAgICAgIGZp cnN0ID0gJnJ1bjsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9Ci0gICAgfQotICAgIGlm ICghZmlyc3QpCisgICAgLy8gRklYTUU6IERvIHNvbWV0aGluZyBlZmZpY2llbnQgZS5nLiB1c2lu ZyBsaW5lIGJveGVzLgorICAgIGlmIChydW5zLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIHsg bnVsbHB0ciwgbnVsbHB0ciB9OwotCi0gICAgY29uc3QgUnVuKiBsYXN0ID0gbnVsbHB0cjsKLSAg ICBmb3IgKGF1dG8mIHJ1biA6IFdURjo6bWFrZVJldmVyc2VkUmFuZ2UocnVucykpIHsKLSAgICAg ICAgYXV0byBydW5SZWN0ID0gRmxvYXRSZWN0IHsgcnVuLmxvZ2ljYWxSZWN0KCkgfTsKLSAgICAg ICAgaWYgKHJ1blJlY3QuaW50ZXJzZWN0cyhyZWN0KSkgewotICAgICAgICAgICAgbGFzdCA9ICZy dW47Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgfQotICAgIH0KLQotICAgIHJldHVybiB7 IGZpcnN0LCBsYXN0ICsgMSB9OworICAgIHJldHVybiB7ICZydW5zLmZpcnN0KCksICZydW5zLmxh c3QoKSArIDEgfTsKIH0KIAogfQo=