205105 2019-12-10 23:41:56 -0800 Web Inspector: REGRESSION(r253173): Console: evaluating a command should automatically scroll to it's result 2019-12-11 16:40:26 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 204630 1 hi hi bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1597534 0 hi 2019-12-10 23:41:56 -0800 # STEPS TO REPRODUCE: 1. inspect any page 2. expand the split console on any tab that isn't the Console Tab 3. evaluate commands until there is a scrollbar 4. scroll to the top of the log 5. evaluate a command => log doesn't scroll to the bottom 1597535 1 385360 hi 2019-12-10 23:44:57 -0800 Created attachment 385360 Patch 1597828 2 385360 bburg 2019-12-11 15:44:27 -0800 Comment on attachment 385360 Patch r=me, way simpler! This was bugging me. thanks Devin! 1597854 3 385360 commit-queue 2019-12-11 16:39:16 -0800 Comment on attachment 385360 Patch Clearing flags on attachment: 385360 Committed r253404: <https://trac.webkit.org/changeset/253404> 1597855 4 commit-queue 2019-12-11 16:39:17 -0800 All reviewed patches have been landed. Closing bug. 1597856 5 webkit-bug-importer 2019-12-11 16:40:26 -0800 <rdar://problem/57859615> 385360 2019-12-10 23:44:57 -0800 2019-12-11 16:39:16 -0800 Patch bug-205105-20191210234456.patch text/plain 6326 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDYzZDJlZTk1YWVkMWE5N2Q0MjIxMDUxOWQ3MmRi Y2VmMjQ0YjVlNzMuLmEzNmZmZjFkODBlN2Y2ZDU2MjkzYzRiN2E4Mzk3NjUxZjdlMWY2OGYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE5LTEyLTEwICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyNTMxNzMpOiBDb25zb2xlOiBldmFsdWF0aW5nIGEgY29tbWFuZCBzaG91bGQg YXV0b21hdGljYWxseSBzY3JvbGwgdG8gaXQncyByZXN1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTEwNQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Mb2dDb250 ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLkxvZ0NvbnRlbnRWaWV3KToKKyAgICAgICAgKFdJLkxv Z0NvbnRlbnRWaWV3LnByb3RvdHlwZS5nZXQgc2Nyb2xsYWJsZUVsZW1lbnRzKToKKyAgICAgICAg KFdJLkxvZ0NvbnRlbnRWaWV3LnByb3RvdHlwZS5fdXBkYXRlTWVzc2FnZXNTZWxlY3Rpb24pOgor ICAgICAgICAoV0kuTG9nQ29udGVudFZpZXcucHJvdG90eXBlLl9oaWdobGlnaHRTZWFyY2hNYXRj aEF0SW5kZXgpOgorICAgICAgICAoV0kuTG9nQ29udGVudFZpZXcucHJvdG90eXBlLmxheW91dCk6 IERlbGV0ZWQuCisgICAgICAgIChXSS5Mb2dDb250ZW50Vmlldy5wcm90b3R5cGUuX2Vuc3VyZU1l c3NhZ2VJc1Zpc2libGUpOiBEZWxldGVkLgorICAgICAgICAoV0kuTG9nQ29udGVudFZpZXcucHJv dG90eXBlLl9wb3NpdGlvbkZvck1lc3NhZ2UpOiBEZWxldGVkLgorICAgICAgICBOb3cgdGhhdCB0 aGlzIHVzZXMgYGRpc3BsYXk6IGZsZXg7YCwgdGhlIGFjdHVhbCBzY3JvbGxhYmxlIGVsZW1lbnQg aXMgdGhlIGBtZXNzYWdlc0VsZW1lbnRgLAorICAgICAgICBzbyB1c2UgdGhhdCBpbnN0ZWFkIHdo ZW4gbWFudWFsbHkgc2V0dGluZyB0aGUgYHNjcm9sbFRvcGAuIFVzZSBgc2Nyb2xsSW50b1ZpZXdJ Zk5lZWRlZGAgd2hlbgorICAgICAgICByZXZlYWxpbmcgc2VhcmNoIHJlc3VsdHMgaW5zdGVhZCBv ZiBhbnkgY3VzdG9tIHNjcm9sbCBvZmZzZXQgY2FsY3VsYXRpb25zLgorCisgICAgICAgICogVXNl ckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmlldy5jc3M6CisgICAgICAgICguY29udGVudC12 aWV3LmxvZyA+IC5oaWRkZW4tbWVzc2FnZXMtYmFubmVyKToKKyAgICAgICAgRHJpdmUtYnk6IGVu c3VyZSB0aGF0IHRoZSBoaWRkZW4gbWVzc2FnZXMgYmFubmVyIGRvZXNuJ3Qgc2hyaW5rLgorCiAy MDE5LTEyLTEwICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBS RUdSRVNTSU9OKHIyNTI1MjMpOiBXZWIgSW5zcGVjdG9yOiBTdHlsZXM6IHNlbWljb2xvbiBpcyB3 cm9uZ2x5IHBvc2l0aW9uZWQgaW4gbXVsdGlsaW5lIHZhbHVlcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuY3NzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcu Y3NzCmluZGV4IDI2MWI4OTEzM2ZhZjViNzU4YmU1NDJmNTQ5NTQ2YTFmMzMyZDg5Y2IuLjc1ODE4 NGZkMGUyOTdmOGI3ZWJmNjA5NTExNWIwMTBlZjJjMmI2MjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmNzcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmll dy5jc3MKQEAgLTMwLDIwICszMCwxOCBAQAogCiAuY29udGVudC12aWV3LmxvZyA+IC5oaWRkZW4t bWVzc2FnZXMtYmFubmVyIHsKICAgICBkaXNwbGF5OiBmbGV4OworICAgIGZsZXgtc2hyaW5rOiAw OwogICAgIGp1c3RpZnktY29udGVudDogY2VudGVyOwogICAgIGFsaWduLWl0ZW1zOiBjZW50ZXI7 CiAgICAgcG9zaXRpb246IHJlbGF0aXZlOwogICAgIGhlaWdodDogdmFyKC0tbmF2aWdhdGlvbi1i YXItaGVpZ2h0KTsKICAgICBwYWRkaW5nOiAwIDRweDsKICAgICBjb2xvcjogdmFyKC0teWVsbG93 LWhpZ2hsaWdodC10ZXh0LWNvbG9yKTsKLSAgICBiYWNrZ3JvdW5kLWNvbG9yOiB2YXIoLS15ZWxs b3ctaGlnaGxpZ2h0LWJhY2tncm91bmQtY29sb3IpOwotICAgIGJvcmRlci1ib3R0b206IDFweCBz b2xpZCB2YXIoLS1ib3JkZXItY29sb3IpOwotfQotCi0uY29udGVudC12aWV3LmxvZyA+IC5oaWRk ZW4tbWVzc2FnZXMtYmFubmVyIHsKICAgICB3aGl0ZS1zcGFjZTogbm93cmFwOwogICAgIHRleHQt b3ZlcmZsb3c6IGVsbGlwc2lzOwogICAgIG92ZXJmbG93OiBoaWRkZW47CisgICAgYmFja2dyb3Vu ZC1jb2xvcjogdmFyKC0teWVsbG93LWhpZ2hsaWdodC1iYWNrZ3JvdW5kLWNvbG9yKTsKKyAgICBi b3JkZXItYm90dG9tOiAxcHggc29saWQgdmFyKC0tYm9yZGVyLWNvbG9yKTsKIH0KIAogLmNvbnRl bnQtdmlldy5sb2cgPiAuaGlkZGVuLW1lc3NhZ2VzLWJhbm5lciA+IGJ1dHRvbiB7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50 Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0Nv bnRlbnRWaWV3LmpzCmluZGV4IGQ4YmQ0MzIwYjE3OWYzYWI4YTlhZGU0NTQzODUyMTVlMjQxYjY3 NjUuLmNlNTQ1NWM2MjQ1NjhhZTRlZGMyY2Q4YzljYmI1MzMzZTYwYjAzM2EgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3 LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0Nv bnRlbnRWaWV3LmpzCkBAIC01Nyw3ICs1Nyw3IEBAIFdJLkxvZ0NvbnRlbnRWaWV3ID0gY2xhc3Mg TG9nQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmlldwogICAgICAgICB0aGlzLl9rZXli b2FyZFNob3J0Y3V0Q29tbWFuZEEgPSBuZXcgV0kuS2V5Ym9hcmRTaG9ydGN1dChXSS5LZXlib2Fy ZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRyb2wsICJBIik7CiAgICAgICAgIHRoaXMu X2tleWJvYXJkU2hvcnRjdXRFc2MgPSBuZXcgV0kuS2V5Ym9hcmRTaG9ydGN1dChudWxsLCBXSS5L ZXlib2FyZFNob3J0Y3V0LktleS5Fc2NhcGUpOwogCi0gICAgICAgIHRoaXMuX2xvZ1ZpZXdDb250 cm9sbGVyID0gbmV3IFdJLkphdmFTY3JpcHRMb2dWaWV3Q29udHJvbGxlcih0aGlzLm1lc3NhZ2Vz RWxlbWVudCwgdGhpcy5lbGVtZW50LCB0aGlzLnByb21wdCwgdGhpcywgImNvbnNvbGUtcHJvbXB0 LWhpc3RvcnkiKTsKKyAgICAgICAgdGhpcy5fbG9nVmlld0NvbnRyb2xsZXIgPSBuZXcgV0kuSmF2 YVNjcmlwdExvZ1ZpZXdDb250cm9sbGVyKHRoaXMubWVzc2FnZXNFbGVtZW50LCB0aGlzLm1lc3Nh Z2VzRWxlbWVudCwgdGhpcy5wcm9tcHQsIHRoaXMsICJjb25zb2xlLXByb21wdC1oaXN0b3J5Iik7 CiAgICAgICAgIHRoaXMuX2xhc3RNZXNzYWdlVmlldyA9IG51bGw7CiAKICAgICAgICAgY29uc3Qg Zml4ZWQgPSB0cnVlOwpAQCAtMTcyLDcgKzE3Miw3IEBAIFdJLkxvZ0NvbnRlbnRWaWV3ID0gY2xh c3MgTG9nQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmlldwogCiAgICAgZ2V0IHNjcm9s bGFibGVFbGVtZW50cygpCiAgICAgewotICAgICAgICByZXR1cm4gW3RoaXMuZWxlbWVudF07Cisg ICAgICAgIHJldHVybiBbdGhpcy5tZXNzYWdlc0VsZW1lbnRdOwogICAgIH0KIAogICAgIGdldCBz aG91bGRLZWVwRWxlbWVudHNTY3JvbGxlZFRvQm90dG9tKCkKQEAgLTM1NCwxMyArMzU0LDYgQEAg V0kuTG9nQ29udGVudFZpZXcgPSBjbGFzcyBMb2dDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRl bnRWaWV3CiAgICAgICAgICAgICB0aGlzLnByb21wdC5mb2N1cygpOwogICAgIH0KIAotICAgIC8v IFByb3RlY3RlZAotCi0gICAgbGF5b3V0KCkKLSAgICB7Ci0gICAgICAgIHRoaXMuX3Njcm9sbEVs ZW1lbnRIZWlnaHQgPSB0aGlzLm1lc3NhZ2VzRWxlbWVudC5nZXRCb3VuZGluZ0NsaWVudFJlY3Qo KS5oZWlnaHQ7Ci0gICAgfQotCiAgICAgLy8gUHJpdmF0ZQogCiAgICAgX2Zvcm1hdE1lc3NhZ2Vz QXNEYXRhKG9ubHlTZWxlY3RlZCkKQEAgLTcxNywzNyArNzEwLDExIEBAIFdJLkxvZ0NvbnRlbnRW aWV3ID0gY2xhc3MgTG9nQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmlldwogICAgICAg ICBpZiAoIXJhbmdlU2VsZWN0aW9uKQogICAgICAgICAgICAgdGhpcy5fcmVmZXJlbmNlTWVzc2Fn ZUZvclJhbmdlU2VsZWN0aW9uID0gbWVzc2FnZTsKIAotICAgICAgICBpZiAoc2hvdWxkU2Nyb2xs SW50b1ZpZXcgJiYgIWFscmVhZHlTZWxlY3RlZE1lc3NhZ2UpCi0gICAgICAgICAgICB0aGlzLl9l bnN1cmVNZXNzYWdlSXNWaXNpYmxlKHRoaXMuX3NlbGVjdGVkTWVzc2FnZXMubGFzdFZhbHVlKTsK LSAgICB9Ci0KLSAgICBfZW5zdXJlTWVzc2FnZUlzVmlzaWJsZShtZXNzYWdlKQotICAgIHsKLSAg ICAgICAgaWYgKCFtZXNzYWdlKQotICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAgIHZhciB5 ID0gdGhpcy5fcG9zaXRpb25Gb3JNZXNzYWdlKG1lc3NhZ2UpLnk7Ci0gICAgICAgIGlmICh5IDwg MCkgewotICAgICAgICAgICAgdGhpcy5lbGVtZW50LnNjcm9sbFRvcCArPSB5OwotICAgICAgICAg ICAgcmV0dXJuOworICAgICAgICBpZiAoc2hvdWxkU2Nyb2xsSW50b1ZpZXcgJiYgIWFscmVhZHlT ZWxlY3RlZE1lc3NhZ2UpIHsKKyAgICAgICAgICAgIGxldCBsYXN0TWVzc2FnZSA9IHRoaXMuX3Nl bGVjdGVkTWVzc2FnZXMubGFzdFZhbHVlOworICAgICAgICAgICAgaWYgKGxhc3RNZXNzYWdlKQor ICAgICAgICAgICAgICAgIGxhc3RNZXNzYWdlLnNjcm9sbEludG9WaWV3SWZOZWVkZWQoKTsKICAg ICAgICAgfQotCi0gICAgICAgIHZhciBuZXh0TWVzc2FnZSA9IHRoaXMuX25leHRNZXNzYWdlKG1l c3NhZ2UpOwotICAgICAgICBpZiAobmV4dE1lc3NhZ2UpIHsKLSAgICAgICAgICAgIHkgPSB0aGlz Ll9wb3NpdGlvbkZvck1lc3NhZ2UobmV4dE1lc3NhZ2UpLnk7Ci0gICAgICAgICAgICBpZiAoeSA+ IHRoaXMuX3Njcm9sbEVsZW1lbnRIZWlnaHQpCi0gICAgICAgICAgICAgICAgdGhpcy5lbGVtZW50 LnNjcm9sbFRvcCArPSB5IC0gdGhpcy5fc2Nyb2xsRWxlbWVudEhlaWdodDsKLSAgICAgICAgfSBl bHNlIHsKLSAgICAgICAgICAgIHkgKz0gbWVzc2FnZS5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKS5o ZWlnaHQ7Ci0gICAgICAgICAgICBpZiAoeSA+IHRoaXMuX3Njcm9sbEVsZW1lbnRIZWlnaHQpCi0g ICAgICAgICAgICAgICAgdGhpcy5lbGVtZW50LnNjcm9sbFRvcCArPSB5IC0gdGhpcy5fc2Nyb2xs RWxlbWVudEhlaWdodDsKLSAgICAgICAgfQotICAgIH0KLQotICAgIF9wb3NpdGlvbkZvck1lc3Nh Z2UobWVzc2FnZSkKLSAgICB7Ci0gICAgICAgIHZhciBwYWdlUG9pbnQgPSB3aW5kb3cud2Via2l0 Q29udmVydFBvaW50RnJvbU5vZGVUb1BhZ2UobWVzc2FnZSwgbmV3IFdlYktpdFBvaW50KDAsIDAp KTsKLSAgICAgICAgcmV0dXJuIHdpbmRvdy53ZWJraXRDb252ZXJ0UG9pbnRGcm9tUGFnZVRvTm9k ZSh0aGlzLmVsZW1lbnQsIHBhZ2VQb2ludCk7CiAgICAgfQogCiAgICAgX2lzTWVzc2FnZVZpc2li bGUobWVzc2FnZSkKQEAgLTEyMDQsNyArMTE3MSw3IEBAIFdJLkxvZ0NvbnRlbnRWaWV3ID0gY2xh c3MgTG9nQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmlldwogICAgICAgICB0aGlzLl9z ZWxlY3RlZFNlYXJjaE1hdGNoID0gdGhpcy5fc2VhcmNoTWF0Y2hlc1tpbmRleF07CiAgICAgICAg IHRoaXMuX3NlbGVjdGVkU2VhcmNoTWF0Y2guaGlnaGxpZ2h0LmNsYXNzTGlzdC5hZGQoV0kuTG9n Q29udGVudFZpZXcuU2VsZWN0ZWRTdHlsZUNsYXNzTmFtZSk7CiAKLSAgICAgICAgdGhpcy5fZW5z dXJlTWVzc2FnZUlzVmlzaWJsZSh0aGlzLl9zZWxlY3RlZFNlYXJjaE1hdGNoLm1lc3NhZ2UpOwor ICAgICAgICB0aGlzLl9zZWxlY3RlZFNlYXJjaE1hdGNoLm1lc3NhZ2Uuc2Nyb2xsSW50b1ZpZXdJ Zk5lZWRlZChmYWxzZSk7CiAgICAgfQogCiAgICAgX3Byb3Zpc2lvbmFsTG9hZFN0YXJ0ZWQoKQo=