205100 2019-12-10 21:45:01 -0800 [WebAuthn] Implement dummy _WKWebAuthenticationPanel SPIs for CTAP PIN support 2019-12-11 16:18:06 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 181943 1 jiewen_tan jiewen_tan bfulgham commit-queue jiewen_tan webkit-bug-importer oldest_to_newest 1597500 0 jiewen_tan 2019-12-10 21:45:01 -0800 Implement dummy _WKWebAuthenticationPanel SPIs for CTAP PIN support. 1597501 1 webkit-bug-importer 2019-12-10 21:46:11 -0800 <rdar://problem/57822953> 1597511 2 385348 jiewen_tan 2019-12-10 22:01:36 -0800 Created attachment 385348 Patch 1597516 3 385348 bfulgham 2019-12-10 22:25:31 -0800 Comment on attachment 385348 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385348&action=review I think this looks good. Did you run it by Garrett? R=me > Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:71 > +- (void)panel:(_WKWebAuthenticationPanel *)panel requestPINWithRetries:(NSUInteger)retries completionHandler:(void (^)(NSData *))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); Do you need a stub implementation to build cleanly? 1597552 4 385348 jiewen_tan 2019-12-11 02:23:56 -0800 Comment on attachment 385348 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385348&action=review Thanks Brent for r+ the patch. >> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:71 >> +- (void)panel:(_WKWebAuthenticationPanel *)panel requestPINWithRetries:(NSUInteger)retries completionHandler:(void (^)(NSData *))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); > > Do you need a stub implementation to build cleanly? No, I don't think so given this is a protocol. 1597553 5 jiewen_tan 2019-12-11 02:24:20 -0800 (In reply to Brent Fulgham from comment #3) > Comment on attachment 385348 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385348&action=review > > I think this looks good. Did you run it by Garrett? R=me Yes, I do. > > > Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:71 > > +- (void)panel:(_WKWebAuthenticationPanel *)panel requestPINWithRetries:(NSUInteger)retries completionHandler:(void (^)(NSData *))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); > > Do you need a stub implementation to build cleanly? 1597558 6 385348 commit-queue 2019-12-11 03:07:53 -0800 Comment on attachment 385348 Patch Clearing flags on attachment: 385348 Committed r253366: <https://trac.webkit.org/changeset/253366> 1597559 7 commit-queue 2019-12-11 03:07:54 -0800 All reviewed patches have been landed. Closing bug. 1597706 8 jiewen_tan 2019-12-11 11:31:40 -0800 Committed r253382: <https://trac.webkit.org/changeset/253382> 1597842 9 jiewen_tan 2019-12-11 16:18:06 -0800 Yet another nit: Committed r253401: <https://trac.webkit.org/changeset/253401> 385348 2019-12-10 22:01:36 -0800 2019-12-11 03:07:53 -0800 Patch bug-205100-20191210220135.patch text/plain 4773 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ0OWRiNjk3MTg5NTM2ODFh YzczMTkxZDA2MDgzYzE4NzY5MmE5ZGEuLmFkMDUwNjc5ZmYwNzcyZmQ3YTU1ODRmOGVhYjhlNmZk YmQ1ZjQ5MzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNTIgQEAKKzIwMTktMTItMTAgIEppZXdlbiBU YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aG5dIEltcGxlbWVu dCBkdW1teSBfV0tXZWJBdXRoZW50aWNhdGlvblBhbmVsIFNQSXMgZm9yIENUQVAgUElOIHN1cHBv cnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTEw MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTc4MjI5NTM+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBpbXBsZW1lbnRzIGR1bW15 IF9XS1dlYkF1dGhlbnRpY2F0aW9uUGFuZWwgU1BJcyBmb3IgQ1RBUCBQSU4gc3VwcG9ydC4KKyAg ICAgICAgQ1RBUCBQSU4gaXMgYSB3YXkgZm9yIGF1dGhlbnRpY2F0b3JzIHRvIGJlIGFibGUgdG8g ZG8gdXNlciB2ZXJpZmljYXRpb24gYnkgYXNraW5nCisgICAgICAgIGNsaWVudHMvdXNlcnMgZm9y IGEgcHJlLXNldCBQSU4uIEhlcmUgaXMgdGhlIHNwZWM6CisgICAgICAgIGh0dHBzOi8vZmlkb2Fs bGlhbmNlLm9yZy9zcGVjcy9maWRvLXYyLjAtcHMtMjAxOTAxMzAvZmlkby1jbGllbnQtdG8tYXV0 aGVudGljYXRvci1wcm90b2NvbC12Mi4wLXBzLTIwMTkwMTMwLmh0bWwjYXV0aGVudGljYXRvckNs aWVudFBJTgorICAgICAgICBJbiBvcmRlciB0byBzdXBwb3J0IHRoaXMsIFdlYktpdCBuZWVkcyB0 byBpbnRlcmFjdHMgd2l0aCBVSUNsaWVudHMgdG8gYXNrIHVzZXJzCisgICAgICAgIHRvIGVudGVy IHRoZSBQSU5zLiBUaGVyZWZvcmUsIGEgbmV3IHNldCBvZiBTUEkgaXMgbmVlZGVkLgorCisgICAg ICAgIEhlcmUgaXMgdGhlIHByb3Bvc2VkIFNQSSBmb3IgV2ViS2l0IHRvIGFzayBTYWZhcmkgZm9y IHRoZSBQSU46CisgICAgICAgIEBwcm90b2NvbCBfV0tXZWJBdXRoZW50aWNhdGlvblBhbmVsRGVs ZWdhdGUgPE5TT2JqZWN0PgorICAgICAgICBAb3B0aW9uYWwKKyAgICAgICAgLi4uCisgICAgICAg IC0gKHZvaWQpcGFuZWw6KF9XS1dlYkF1dGhlbnRpY2F0aW9uUGFuZWwgKilwYW5lbCByZXF1ZXN0 UElOV2l0aFJldHJpZXM6KE5TVUludGVnZXIpcmV0cmllcyBjb21wbGV0aW9uSGFuZGxlcjoodm9p ZCAoXikoTlNEYXRhICopKWNvbXBsZXRpb25IYW5kbGVyIFdLX0FQSV9BVkFJTEFCTEUobWFjb3Mo V0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CisgICAgICAgIC4uLgorICAgICAgICBAZW5k CisKKyAgICAgICAgUmV0cmllcyBpcyB0aGUgbnVtYmVyIG9mIHJldGlyZXMgYmVmb3JlIHRoZSBh dXRoZW50aWNhdG9yIGdldHRpbmcgYmxvY2tlZCwgd2hpY2gKKyAgICAgICAgaXMgYSBzdGF0ZSB0 aGF0IG9ubHkgZmFjdG9yeSByZXNldCBjYW4gc2F2ZSB0aGUgYXV0aGVudGljYXRvci4gVUlDbGll bnRzIGNhbiBoYXZlCisgICAgICAgIGEgdGhyZXNob2xkIGFuZCBXQVJOIHVzZXJzIGxvdWRseSB3 aGVuIHRoZSB0aHJlc2hvbGQgaXMgcmVhY2hlZC4KKyAgICAgICAgQSBieXRlIGFycmF5IHRoYXQg aXMgbGVzcyB0aGFuIG9yIGVxdWFsIHRvIDYzIGJ5dGVzIGlzIGV4cGVjdGVkIHRvIHJldHVybiB0 byB0aGUKKyAgICAgICAgcGFzc2VkIGNvbXBsZXRpb24gaGFuZGxlci4gT3RoZXJ3aXNlLCB0aGUg Y29tcGxldGlvbiBoYW5kbGVyIHdpbGwgYmFpbCBvdXQuCisKKyAgICAgICAgRm9yIGVycm9yIGhh bmRsaW5nOgorICAgICAgICB0eXBlZGVmIE5TX0VOVU0oTlNJbnRlZ2VyLCBfV0tXZWJBdXRoZW50 aWNhdGlvblBhbmVsVXBkYXRlKSB7CisgICAgICAgICAgICAuLi4KKyAgICAgICAgICAgIF9XS1dl YkF1dGhlbnRpY2F0aW9uUGFuZWxVcGRhdGVQSU5CbG9ja2VkLAorICAgICAgICAgICAgX1dLV2Vi QXV0aGVudGljYXRpb25QYW5lbFVwZGF0ZVBJTkF1dGhCbG9ja2VkLAorICAgICAgICAgICAgX1dL V2ViQXV0aGVudGljYXRpb25QYW5lbFVwZGF0ZVBJTkludmFsaWQsCisgICAgICAgIH0gV0tfQVBJ X0FWQUlMQUJMRShtYWNvcyhXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEpKTsKKworICAgICAg ICBUaGUgYWJvdmUgdGhyZWUgZXJyb3Igd2lsbCBiZSBwYXNzZWQgdG8gVUlDbGllbnRzIHZpYSB1 cGRhdGVXZWJBdXRoZW50aWNhdGlvblBhbmVsIFNQSS4KKyAgICAgICAgX1dLV2ViQXV0aGVudGlj YXRpb25QYW5lbFVwZGF0ZVBJTkJsb2NrZWQgbWVhbnMgdGhlIGF1dGhlbnRpY2F0b3IgaXMgZGVh ZC4gQSBmYWN0b3J5CisgICAgICAgIHJlc2V0IGlzIG5lZWRlZC4KKyAgICAgICAgX1dLV2ViQXV0 aGVudGljYXRpb25QYW5lbFVwZGF0ZVBJTkF1dGhCbG9ja2VkIG1lYW5zIDMgY29uc2VjdXRpdmUg bWlzbWF0Y2hlcy4gVGhlCisgICAgICAgIGF1dGhlbnRpY2F0b3Igd2lsbCBuZWVkIHRvIGJlIHJl Y29ubmVjdGVkLgorICAgICAgICBfV0tXZWJBdXRoZW50aWNhdGlvblBhbmVsVXBkYXRlUElOSW52 YWxpZCBtZWFucyBhIHdyb25nIFBJTiBpcyBwcm92aWRlZC4gVGhpcyB3aWxsCisgICAgICAgIG9m dGVuIGJlIGZvbGxvd2VkIHdpdGggYW5vdGhlciByZXF1ZXN0UElOV2l0aFJldHJpZXMgZGVsZWdh dGUgY2FsbC4KKyAgICAgICAgSGVyZSBpcyB0aGUgc3BlYyBmb3IgdGhlIGVycm9yOgorICAgICAg ICBodHRwczovL2ZpZG9hbGxpYW5jZS5vcmcvc3BlY3MvZmlkby12Mi4wLXBzLTIwMTkwMTMwL2Zp ZG8tY2xpZW50LXRvLWF1dGhlbnRpY2F0b3ItcHJvdG9jb2wtdjIuMC1wcy0yMDE5MDEzMC5odG1s I3VzaW5nLXBpblRva2VuLWluLWF1dGhlbnRpY2F0b3JNYWtlQ3JlZGVudGlhbC4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLV2ViQXV0aGVudGljYXRpb25QYW5lbC5oOgorCiAy MDE5LTEyLTA5ICB5b3Vlbm4gZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBO ZXR3b3JrUmVzb3VyY2VMb2FkZXIgc2hvdWxkIGNvbnN1bWUgaXRzIHNhbmRib3ggZXh0ZW5zaW9u cyB3aGVuIHN0YXJ0aW5nIGEgZmV0Y2ggdGhyb3VnaCBzZXJ2aWNlIHdvcmtlcgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1dlYkF1dGhlbnRpY2F0aW9u UGFuZWwuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tXZWJBdXRoZW50 aWNhdGlvblBhbmVsLmgKaW5kZXggM2M4NzRhYmZkZGEzMGJiY2Q3YjVkZTA4OTNmNGM0ZmNkNzcw OTNjZS4uMDA2Y2Q3MWUzNzA2NDRmODlhYjgxZDc3NTNiYmNkMDQzYjg4YTJiNSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1dlYkF1dGhlbnRpY2F0aW9u UGFuZWwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLV2ViQXV0 aGVudGljYXRpb25QYW5lbC5oCkBAIC00Miw2ICs0Miw5IEBAIHR5cGVkZWYgTlNfRU5VTShOU0lu dGVnZXIsIF9XS1dlYkF1dGhlbnRpY2F0aW9uUGFuZWxSZXN1bHQpIHsKIHR5cGVkZWYgTlNfRU5V TShOU0ludGVnZXIsIF9XS1dlYkF1dGhlbnRpY2F0aW9uUGFuZWxVcGRhdGUpIHsKICAgICBfV0tX ZWJBdXRoZW50aWNhdGlvblBhbmVsVXBkYXRlTXVsdGlwbGVORkNUYWdzUHJlc2VudCwKICAgICBf V0tXZWJBdXRoZW50aWNhdGlvblBhbmVsVXBkYXRlTm9DcmVkZW50aWFsc0ZvdW5kLAorICAgIF9X S1dlYkF1dGhlbnRpY2F0aW9uUGFuZWxVcGRhdGVQSU5CbG9ja2VkLAorICAgIF9XS1dlYkF1dGhl bnRpY2F0aW9uUGFuZWxVcGRhdGVQSU5BdXRoQmxvY2tlZCwKKyAgICBfV0tXZWJBdXRoZW50aWNh dGlvblBhbmVsVXBkYXRlUElOSW52YWxpZCwKIH0gV0tfQVBJX0FWQUlMQUJMRShtYWNvcyhXS19N QUNfVEJBKSwgaW9zKFdLX0lPU19UQkEpKTsKIAogdHlwZWRlZiBOU19FTlVNKE5TSW50ZWdlciwg X1dLV2ViQXV0aGVudGljYXRpb25SZXN1bHQpIHsKQEAgLTY1LDYgKzY4LDcgQEAgdHlwZWRlZiBO U19FTlVNKE5TSW50ZWdlciwgX1dLV2ViQXV0aGVudGljYXRpb25UeXBlKSB7CiAKIC0gKHZvaWQp cGFuZWw6KF9XS1dlYkF1dGhlbnRpY2F0aW9uUGFuZWwgKilwYW5lbCB1cGRhdGVXZWJBdXRoZW50 aWNhdGlvblBhbmVsOihfV0tXZWJBdXRoZW50aWNhdGlvblBhbmVsVXBkYXRlKXVwZGF0ZSBXS19B UElfQVZBSUxBQkxFKG1hY29zKFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOwogLSAodm9p ZClwYW5lbDooX1dLV2ViQXV0aGVudGljYXRpb25QYW5lbCAqKXBhbmVsIGRpc21pc3NXZWJBdXRo ZW50aWNhdGlvblBhbmVsV2l0aFJlc3VsdDooX1dLV2ViQXV0aGVudGljYXRpb25SZXN1bHQpcmVz dWx0IFdLX0FQSV9BVkFJTEFCTEUobWFjb3MoV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7 CistICh2b2lkKXBhbmVsOihfV0tXZWJBdXRoZW50aWNhdGlvblBhbmVsICopcGFuZWwgcmVxdWVz dFBJTldpdGhSZXRyaWVzOihOU1VJbnRlZ2VyKXJldHJpZXMgY29tcGxldGlvbkhhbmRsZXI6KHZv aWQgKF4pKE5TRGF0YSAqKSljb21wbGV0aW9uSGFuZGxlciBXS19BUElfQVZBSUxBQkxFKG1hY29z KFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOwogCiBAZW5kCiAK