205023 2019-12-09 11:51:24 -0800 GetByIdVariant::dumpInContext() should not ref UniqueStringImpls. 2019-12-09 12:51:36 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1596909 0 mark.lam 2019-12-09 11:51:24 -0800 ... because GetByIdVariant::dumpInContext() may be called from the compiler thread. <rdar://problem/57747265> 1596911 1 385175 mark.lam 2019-12-09 11:58:21 -0800 Created attachment 385175 proposed patch. 1596924 2 385175 commit-queue 2019-12-09 12:51:34 -0800 Comment on attachment 385175 proposed patch. Clearing flags on attachment: 385175 Committed r253298: <https://trac.webkit.org/changeset/253298> 1596925 3 commit-queue 2019-12-09 12:51:36 -0800 All reviewed patches have been landed. Closing bug. 385175 2019-12-09 11:58:21 -0800 2019-12-09 12:51:34 -0800 proposed patch. bug-205023.patch text/plain 1872 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUzMjk2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE5LTEyLTA5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBH ZXRCeUlkVmFyaWFudDo6ZHVtcEluQ29udGV4dCgpIHNob3VsZCBub3QgcmVmIFVuaXF1ZVN0cmlu Z0ltcGxzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjA1MDIzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81Nzc0NzI2NT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGJlY2F1c2UgR2V0QnlJ ZFZhcmlhbnQ6OmR1bXBJbkNvbnRleHQoKSBtYXkgYmUgY2FsbGVkIGZyb20gdGhlIGNvbXBpbGVy CisgICAgICAgIHRocmVhZC4gIEdldEJ5SWRWYXJpYW50OjpkdW1wSW5Db250ZXh0KCkgaW5hZHZl cnRlbnRseSBpbnZva2luZyB0aGUgU3RyaW5nIGNvcHkKKyAgICAgICAgY29uc3RydWN0b3Igb24g YW4gSWRlbnRpZmllciwgd2hpY2ggaW4gdHVybiwgcmVmcyB0aGUgdW5kZXJseWluZyBVbmlxdWVT dHJpbmdJbXBsLgorICAgICAgICBUaGlzIHJlc3VsdHMgaW4gYSByYWNlIGFnYWluc3QgdGhlIG11 dGF0b3IgdG8gYWRqdXN0IHRoZSByZWZDb3VudC4KKworICAgICAgICBUaGUgZml4IGlzIHRvIGhh dmUgR2V0QnlJZFZhcmlhbnQ6OmR1bXBJbkNvbnRleHQoKSBwcmludCB0aGUgdW5kZXJseWluZwor ICAgICAgICBTdHJpbmdJbXBsIGluc3RlYWQgb2YgdGhlIElkZW50aWZpZXIgaXRzZWxmLgorCisg ICAgICAgICogYnl0ZWNvZGUvR2V0QnlJZFZhcmlhbnQuY3BwOgorICAgICAgICAoSlNDOjpHZXRC eUlkVmFyaWFudDo6ZHVtcEluQ29udGV4dCBjb25zdCk6CisKIDIwMTktMTItMDggIFlvdXN1a2Ug S2ltb3RvICA8eW91c3VrZS5raW1vdG9Ac29ueS5jb20+CiAKICAgICAgICAgW1dpbkNhaXJvXSBS ZWZpbmUgaW5pdGlhbGl6YXRpb24gYW5kIGVycm9yIGhhbmRsaW5nIGluIFJlbW90ZUluc3BlY3Rv clNvY2tldApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0dldEJ5SWRWYXJp YW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvR2V0 QnlJZFZhcmlhbnQuY3BwCShyZXZpc2lvbiAyNTMyOTQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYnl0ZWNvZGUvR2V0QnlJZFZhcmlhbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODIsNyAr MTgyLDcgQEAgdm9pZCBHZXRCeUlkVmFyaWFudDo6ZHVtcChQcmludFN0cmVhbSYgbwogdm9pZCBH ZXRCeUlkVmFyaWFudDo6ZHVtcEluQ29udGV4dChQcmludFN0cmVhbSYgb3V0LCBEdW1wQ29udGV4 dCogY29udGV4dCkgY29uc3QKIHsKICAgICBvdXQucHJpbnQoIjwiKTsKLSAgICBvdXQucHJpbnQo ImlkPSciLCBtX2lkZW50aWZpZXIgPyAqbV9pZGVudGlmaWVyIDogSWRlbnRpZmllcigpLCAiJywg Iik7CisgICAgb3V0LnByaW50KCJpZD0nIiwgbV9pZGVudGlmaWVyID8gbV9pZGVudGlmaWVyLT5p bXBsKCkgOiBTdHJpbmdJbXBsOjplbXB0eSgpLCAiJywgIik7CiAgICAgaWYgKCFpc1NldCgpKSB7 CiAgICAgICAgIG91dC5wcmludCgiZW1wdHk+Iik7CiAgICAgICAgIHJldHVybjsK