205022 2019-12-09 11:12:44 -0800 REGRESSION(r253140): WebAssembly validation should check for unmatched else before calling addElse/addElseToUnreachable 2019-12-09 15:23:59 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1596902 0 tzagallo 2019-12-09 11:12:44 -0800 ... 1596904 1 tzagallo 2019-12-09 11:14:39 -0800 <rdar://problem/57748159> 1596905 2 385172 tzagallo 2019-12-09 11:15:28 -0800 Created attachment 385172 Patch 1596973 3 385172 commit-queue 2019-12-09 15:23:58 -0800 Comment on attachment 385172 Patch Clearing flags on attachment: 385172 Committed r253303: <https://trac.webkit.org/changeset/253303> 1596974 4 commit-queue 2019-12-09 15:23:59 -0800 All reviewed patches have been landed. Closing bug. 385172 2019-12-09 11:15:28 -0800 2019-12-09 15:23:58 -0800 Patch bug-205022-20191209111526.patch text/plain 4125 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMjk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi Yjc3ODg2YjliMGViZGQyYTg5NTQ2Yzc0NmI5NDg2MDRhMWM0MzlhLi45ZjY4NTEzZjhiN2MwNTEx YTNkNGJmZDdhYzNlNjIxMDM4YzI1ZGUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0xMi0wOSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNTMxNDApOiBXZWJBc3NlbWJseSB2YWxpZGF0aW9u IHNob3VsZCBjaGVjayBmb3IgdW5tYXRjaGVkIGVsc2UgYmVmb3JlIGNhbGxpbmcgYWRkRWxzZS9h ZGRFbHNlVG9VbnJlYWNoYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjA1MDIyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81Nzc0ODE1OT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIG1vdmlu ZyB0aGUgdmFsaWRhdGlvbiBjb2RlIGludG8gdGhlIHBhcnNlciBpbiByMjUzMTQwLCBJIG1pc3Nl ZCB0aGUgdmFsaWRhdGlvbiBjaGVjayBvZiB3aGV0aGVyCisgICAgICAgIGFuIGlmIGJsb2NrIHdh cyBhdCB0aGUgdG9wIG9mIHRoZSBjb250cm9sIHN0YWNrIGJlZm9yZSBjYWxsaW5nIGFkZEVsc2Uv YWRkRWxzZVRvVW5yZWFjaGFibGUuCisKKyAgICAgICAgKiB3YXNtL1dhc21GdW5jdGlvblBhcnNl ci5oOgorICAgICAgICAoSlNDOjpXYXNtOjpGdW5jdGlvblBhcnNlcjxDb250ZXh0Pjo6cGFyc2VF eHByZXNzaW9uKToKKyAgICAgICAgKEpTQzo6V2FzbTo6RnVuY3Rpb25QYXJzZXI8Q29udGV4dD46 OnBhcnNlVW5yZWFjaGFibGVFeHByZXNzaW9uKToKKwogMjAxOS0xMi0wOCAgWW91c3VrZSBLaW1v dG8gIDx5b3VzdWtlLmtpbW90b0Bzb255LmNvbT4KIAogICAgICAgICBbV2luQ2Fpcm9dIFJlZmlu ZSBpbml0aWFsaXphdGlvbiBhbmQgZXJyb3IgaGFuZGxpbmcgaW4gUmVtb3RlSW5zcGVjdG9yU29j a2V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtRnVuY3Rpb25Q YXJzZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21GdW5jdGlvblBhcnNlci5o CmluZGV4IGZlY2E4ODAyYmYyNzQzMzk2MmJkOGMwZjFlZDg2ODU4N2UwOGY1MjkuLjFmN2UwNmFm M2EyOWEyOTEyZDQ0OWJjYWJmMTA4ODZiMjNlZWVlY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS93YXNtL1dhc21GdW5jdGlvblBhcnNlci5oCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS93YXNtL1dhc21GdW5jdGlvblBhcnNlci5oCkBAIC03MjksOCArNzI5LDggQEAgRk9S X0VBQ0hfV0FTTV9NRU1PUllfU1RPUkVfT1AoQ1JFQVRFX0NBU0UpCiAKICAgICAgICAgQ29udHJv bEVudHJ5JiBjb250cm9sRW50cnkgPSBtX2NvbnRyb2xTdGFjay5sYXN0KCk7CiAKKyAgICAgICAg V0FTTV9WQUxJREFUT1JfRkFJTF9JRighQ29udHJvbFR5cGU6OmlzSWYoY29udHJvbEVudHJ5LmNv bnRyb2xEYXRhKSwgImVsc2UgYmxvY2sgaXNuJ3QgYXNzb2NpYXRlZCB0byBhbiBpZiIpOwogICAg ICAgICBXQVNNX0ZBSUxfSUZfSEVMUEVSX0ZBSUxTKHVuaWZ5KGNvbnRyb2xFbnRyeS5jb250cm9s RGF0YSkpOwotCiAgICAgICAgIFdBU01fVFJZX0FERF9UT19DT05URVhUKGFkZEVsc2UoY29udHJv bEVudHJ5LmNvbnRyb2xEYXRhLCBtX2V4cHJlc3Npb25TdGFjaykpOwogICAgICAgICBtX2V4cHJl c3Npb25TdGFjayA9IFdURk1vdmUoY29udHJvbEVudHJ5LmVsc2VCbG9ja1N0YWNrKTsKICAgICAg ICAgcmV0dXJuIHsgfTsKQEAgLTg4NCw2ICs4ODQsNyBAQCBhdXRvIEZ1bmN0aW9uUGFyc2VyPENv bnRleHQ+OjpwYXJzZVVucmVhY2hhYmxlRXhwcmVzc2lvbigpIC0+IFBhcnRpYWxSZXN1bHQKIAog ICAgICAgICBDb250cm9sRW50cnkmIGRhdGEgPSBtX2NvbnRyb2xTdGFjay5sYXN0KCk7CiAgICAg ICAgIG1fdW5yZWFjaGFibGVCbG9ja3MgPSAwOworICAgICAgICBXQVNNX1ZBTElEQVRPUl9GQUlM X0lGKCFDb250cm9sVHlwZTo6aXNJZihkYXRhLmNvbnRyb2xEYXRhKSwgImVsc2UgYmxvY2sgaXNu J3QgYXNzb2NpYXRlZCB0byBhbiBpZiIpOwogICAgICAgICBXQVNNX1RSWV9BRERfVE9fQ09OVEVY VChhZGRFbHNlVG9VbnJlYWNoYWJsZShkYXRhLmNvbnRyb2xEYXRhKSk7CiAgICAgICAgIG1fZXhw cmVzc2lvblN0YWNrID0gV1RGTW92ZShkYXRhLmVsc2VCbG9ja1N0YWNrKTsKICAgICAgICAgcmV0 dXJuIHsgfTsKZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VM b2cKaW5kZXggNjEyMDM3ODVlOWYyYTc2ZjdiMWNkZWQ1NzkyZDI4OGIxZmVjMzVmNi4uMmM5MjE5 NWMyNDAzYjMwMjZlMjg2M2I4ZWRiMjcwNjFmNzU3MGIwNiAxMDA2NDQKLS0tIGEvSlNUZXN0cy9D aGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOS0x Mi0wOSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdS RVNTSU9OKHIyNTMxNDApOiBXZWJBc3NlbWJseSB2YWxpZGF0aW9uIHNob3VsZCBjaGVjayBmb3Ig dW5tYXRjaGVkIGVsc2UgYmVmb3JlIGNhbGxpbmcgYWRkRWxzZS9hZGRFbHNlVG9VbnJlYWNoYWJs ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1MDIy CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81Nzc0ODE1OT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdhc20vcmVncmVzcy91bm1hdGNoZWQtZWxz ZS5qczogQWRkZWQuCisgICAgICAgIChjYXRjaCk6CisKIDIwMTktMTItMDggIFRhZGV1IFphZ2Fs bG8gIDx0emFnYWxsb0BhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYkFzc2VtYmx5XSBGaXggTExJ bnRHZW5lcmF0b3IncyBjaGVja0NvbnNpc3RlbmN5IGNvbnRyYWN0CmRpZmYgLS1naXQgYS9KU1Rl c3RzL3dhc20vcmVncmVzcy91bm1hdGNoZWQtZWxzZS5qcyBiL0pTVGVzdHMvd2FzbS9yZWdyZXNz L3VubWF0Y2hlZC1lbHNlLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjZiNDRlMmQzMTBlYzBhMjBlM2MwYWQ5ZDAy MWE3Nzc0YzU0YTU5MDAKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3dhc20vcmVncmVzcy91 bm1hdGNoZWQtZWxzZS5qcwpAQCAtMCwwICsxLDcgQEAKK3RyeSB7CisgICAgbmV3IFdlYkFzc2Vt Ymx5Lk1vZHVsZShuZXcgVWludDhBcnJheShbMCwgOTcsIDExNSwgMTA5LCAxLCAwLCAwLCAwLCAx LCA3LCAxLCA5NiwgMywgMTI3LCAxMjcsIDEyNywgMCwgMiwgMTIsIDEsIDIsIDEwNiwgMTE1LCAz LCAxMDksIDEwMSwgMTA5LCAyLCAxLCAxLCAxLCAzLCAyLCAxLCAwLCA2LCAxLCAwLCA3LCAxMywg MSwgOSwgMTAwLCAxMTEsIDk1LCAxMDksIDEwMSwgMTA5LCA5OSwgMTEyLCAxMjEsIDAsIDAsIDEw LCA1NywgMSwgNTUsIDEsIDEsIDEyNywgNjUsIDAsIDMzLCAzLCAzLCA2NCwgMiwgNjQsIDMyLCAy LCAzMiwgMywgNzAsIDEzLCAwLCA1LCAxLCA2NSwgNCwgMTA4LCAzMiwgMywgNjUsIDQsIDEwOCwg MTA2LCAzMiwgMCwgMzIsIDMsIDY1LCA0LCAxMDgsIDEwNiwgNDAsIDAsIDAsIDU0LCAwLCAwLCAz MiwgMywgNjUsIDEsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAgXSkpOworICAgIHRocm93IG5ldyBF cnJvcignTW9kdWxlIHNob3VsZCBoYXZlIGZhaWxlZCB2YWxpZGF0aW9uJyk7Cit9IGNhdGNoIChl cnIpIHsKKyAgICBpZiAoZXJyLm1lc3NhZ2UgIT0gIldlYkFzc2VtYmx5Lk1vZHVsZSBkb2Vzbid0 IHZhbGlkYXRlOiBlbHNlIGJsb2NrIGlzbid0IGFzc29jaWF0ZWQgdG8gYW4gaWYsIGluIGZ1bmN0 aW9uIGF0IGluZGV4IDAgKGV2YWx1YXRpbmcgJ25ldyBXZWJBc3NlbWJseS5Nb2R1bGUnKSIpCisg ICAgICAgIHRocm93IGVycjsKK30K