204987 2019-12-07 09:32:29 -0800 Remove invalid assertion in FTL's allocateJSArray(). 2019-12-07 12:16:18 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1596582 0 mark.lam 2019-12-07 09:32:29 -0800 The assertion (in the compiler thread) does not take into account that the mutator may be in the process of transiting to HavingABadTime. As a result, the assertion may fail intermittently. The assertion is just bad and should be removed. <rdar://problem/57280725> 1596583 1 385101 mark.lam 2019-12-07 09:36:52 -0800 Created attachment 385101 proposed patch. 1596603 2 385101 commit-queue 2019-12-07 12:16:17 -0800 Comment on attachment 385101 proposed patch. Clearing flags on attachment: 385101 Committed r253260: <https://trac.webkit.org/changeset/253260> 1596604 3 commit-queue 2019-12-07 12:16:18 -0800 All reviewed patches have been landed. Closing bug. 385101 2019-12-07 09:36:52 -0800 2019-12-07 12:16:17 -0800 proposed patch. bug-204987.patch text/plain 2037 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUzMjU0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE5LTEyLTA3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW1vdmUgaW52YWxpZCBhc3NlcnRpb24gaW4gRlRMJ3MgYWxsb2NhdGVKU0FycmF5KCkuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ5ODcKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzU3MjgwNzI1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSBhc3NlcnRpb24gKGluIHRoZSBjb21waWxlciB0aHJl YWQpIGRvZXMgbm90IHRha2UgaW50byBhY2NvdW50IHRoYXQgdGhlIG11dGF0b3IKKyAgICAgICAg bWF5IGJlIGluIHRoZSBwcm9jZXNzIG9mIHRyYW5zaXRpbmcgdG8gSGF2aW5nQUJhZFRpbWUuICBB cyBhIHJlc3VsdCwgdGhlIGFzc2VydGlvbgorICAgICAgICBtYXkgZmFpbCBpbnRlcm1pdHRlbnRs eS4gIFRoaXMgcGF0Y2ggZml4ZXMgdGhpcyBpc3N1ZSBieSByZW1vdmluZyB0aGlzIGJhZAorICAg ICAgICBhc3NlcnRpb24uCisKKyAgICAgICAgKiBmdGwvRlRMTG93ZXJERkdUb0IzLmNwcDoKKyAg ICAgICAgKEpTQzo6RlRMOjpERkc6Okxvd2VyREZHVG9CMzo6YWxsb2NhdGVKU0FycmF5KToKKwog MjAxOS0xMi0wNyAgSm9vbmdodW4gUGFyayAgPGpoNzE4LnBhcmtAc2Ftc3VuZy5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZC4gUmVtb3ZlIHRoZSBidWlsZCB3YXJuaW5nIGJlbG93IHNpbmNlIHIy NTAwMDkuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9CMy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1Rv QjMuY3BwCShyZXZpc2lvbiAyNTMyNDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZU TExvd2VyREZHVG9CMy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0MzQ5LDE1ICsxNDM0OSw2IEBA IHByaXZhdGU6CiAgICAgQXJyYXlWYWx1ZXMgYWxsb2NhdGVKU0FycmF5KExWYWx1ZSBwdWJsaWNM ZW5ndGgsIExWYWx1ZSB2ZWN0b3JMZW5ndGgsIExWYWx1ZSBzdHJ1Y3R1cmUsIExWYWx1ZSBpbmRl eGluZ1R5cGUsIGJvb2wgc2hvdWxkSW5pdGlhbGl6ZUVsZW1lbnRzID0gdHJ1ZSwgYm9vbCBzaG91 bGRMYXJnZUFycmF5U2l6ZUNyZWF0ZUFycmF5U3RvcmFnZSA9IHRydWUpCiAgICAgewogICAgICAg ICBKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0ID0gbV9ncmFwaC5nbG9iYWxPYmplY3RGb3Io bV9ub2RlLT5vcmlnaW4uc2VtYW50aWMpOwotICAgICAgICBpZiAoaW5kZXhpbmdUeXBlLT5oYXNJ bnQzMigpKSB7Ci0gICAgICAgICAgICBJbmRleGluZ1R5cGUgdHlwZSA9IHN0YXRpY19jYXN0PElu ZGV4aW5nVHlwZT4oaW5kZXhpbmdUeXBlLT5hc0ludDMyKCkpOwotICAgICAgICAgICAgQVNTRVJU X1VOVVNFRCh0eXBlLAotICAgICAgICAgICAgICAgIGhhc1VuZGVjaWRlZCh0eXBlKQotICAgICAg ICAgICAgICAgIHx8IGhhc0ludDMyKHR5cGUpCi0gICAgICAgICAgICAgICAgfHwgaGFzRG91Ymxl KHR5cGUpCi0gICAgICAgICAgICAgICAgfHwgaGFzQ29udGlndW91cyh0eXBlKSk7Ci0gICAgICAg IH0KLQogICAgICAgICBMQmFzaWNCbG9jayBmYXN0Q2FzZSA9IG1fb3V0Lm5ld0Jsb2NrKCk7CiAg ICAgICAgIExCYXNpY0Jsb2NrIGxhcmdlQ2FzZSA9IG1fb3V0Lm5ld0Jsb2NrKCk7CiAgICAgICAg IExCYXNpY0Jsb2NrIGZhaWxDYXNlID0gbV9vdXQubmV3QmxvY2soKTsK