204965 2019-12-06 14:54:14 -0800 Web Inspector: REGRESSION(r252652): Local Overrides: creating a local override for a resource loaded before Web Inspector was opened shows NaN for the Status Code 2019-12-06 16:05:35 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1596379 0 hi 2019-12-06 14:54:14 -0800 # STEPS TO REPRODUCE: 1. inspect any page 2. create a local override for any resource loaded before Web Inspector was opened 3. right click the local override and select "Edit Local Override…" => NaN shown in Status Code text box 1596387 1 385049 hi 2019-12-06 15:07:13 -0800 Created attachment 385049 Patch 1596393 2 385049 joepeck 2019-12-06 15:14:45 -0800 Comment on attachment 385049 Patch rs=me 1596416 3 385049 commit-queue 2019-12-06 16:04:52 -0800 Comment on attachment 385049 Patch Clearing flags on attachment: 385049 Committed r253229: <https://trac.webkit.org/changeset/253229> 1596417 4 commit-queue 2019-12-06 16:04:53 -0800 All reviewed patches have been landed. Closing bug. 1596418 5 webkit-bug-importer 2019-12-06 16:05:35 -0800 <rdar://problem/57716883> 385049 2019-12-06 15:07:13 -0800 2019-12-06 16:04:52 -0800 Patch 204965.diff text/plain 2511 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGU4ODkwNmZkMTY3Li44NDgxYTc5Mzc2ZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMTItMDYgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJF R1JFU1NJT04ocjI1MjY1Mik6IExvY2FsIE92ZXJyaWRlczogY3JlYXRpbmcgYSBsb2NhbCBvdmVy cmlkZSBmb3IgYSByZXNvdXJjZSBsb2FkZWQgYmVmb3JlIFdlYiBJbnNwZWN0b3Igd2FzIG9wZW5l ZCBzaG93cyBOYU4gZm9yIHRoZSBTdGF0dXMgQ29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0OTY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0xvY2FsUmVzb3Vy Y2VPdmVycmlkZVBvcG92ZXIuanM6CisgICAgICAgIChXSS5Mb2NhbFJlc291cmNlT3ZlcnJpZGVQ b3BvdmVyLnByb3RvdHlwZS5zaG93KToKKyAgICAgICAgTWFrZSBzdXJlIHRvIHVwZGF0ZSB0aGUg b2JqZWN0IHRoYXQgaG9sZHMgdGhlIHJlc291cmNlJ3Mgb3JpZ2luYWwgZGF0YSBpbiBhZGRpdGlv biB0byB0aGUKKyAgICAgICAgb2JqZWN0IHRoYXQgaG9sZHMgdGhlIGN1cnJlbnQgZWRpdGVkIHZh bHVlcy4KKyAgICAgICAgRHJpdmUtYnk6IHVwZGF0ZSB0aGUgcG9wb3ZlciBvbmNlIGFsbCBvZiB0 aGUgYENvZGVNaXJyb3JgcyBoYXZlIHVwZGF0ZWQgdG8gaGlkZSBzY3JvbGxiYXJzLgorCiAyMDE5 LTEyLTA1ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBSRUdSRVNTSU9OKHIyNDI2MDQpOiBDb25zb2xlOiB1bnJlYWQgaW5kaWNhdG9y IG92ZXJsYXBzIHNlbGVjdGlvbiBiYWNrZ3JvdW5kIG9mIHByZXZpb3VzIHNjb3BlIGJhciBpdGVt CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9M b2NhbFJlc291cmNlT3ZlcnJpZGVQb3BvdmVyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvTG9jYWxSZXNvdXJjZU92ZXJyaWRlUG9wb3Zlci5qcwppbmRleCA3 OWMzZTY1MWQ5My4uYTQ3MWI2ZDQyZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvY2FsUmVzb3VyY2VPdmVycmlkZVBvcG92ZXIuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9jYWxSZXNvdXJj ZU92ZXJyaWRlUG9wb3Zlci5qcwpAQCAtMTMxLDEyICsxMzEsMTkgQEAgV0kuTG9jYWxSZXNvdXJj ZU92ZXJyaWRlUG9wb3ZlciA9IGNsYXNzIExvY2FsUmVzb3VyY2VPdmVycmlkZVBvcG92ZXIgZXh0 ZW5kcyBXSS4KIAogICAgICAgICBpZiAoIWRhdGEudXJsKQogICAgICAgICAgICAgZGF0YS51cmwg PSB0aGlzLl9kZWZhdWx0VVJMKCk7CisKICAgICAgICAgaWYgKCFkYXRhLm1pbWVUeXBlKQogICAg ICAgICAgICAgZGF0YS5taW1lVHlwZSA9ICJ0ZXh0L2phdmFzY3JpcHQiOwotICAgICAgICBpZiAo IWRhdGEuc3RhdHVzQ29kZSB8fCBkYXRhLnN0YXR1c0NvZGUgPT09ICJOYU4iKQorCisgICAgICAg IGlmICghZGF0YS5zdGF0dXNDb2RlIHx8IGRhdGEuc3RhdHVzQ29kZSA9PT0gIk5hTiIpIHsKICAg ICAgICAgICAgIGRhdGEuc3RhdHVzQ29kZSA9ICIyMDAiOwotICAgICAgICBpZiAoIWRhdGEuc3Rh dHVzVGV4dCkKKyAgICAgICAgICAgIHJlc291cmNlRGF0YS5zdGF0dXNDb2RlID0gdW5kZWZpbmVk OworICAgICAgICB9CisKKyAgICAgICAgaWYgKCFkYXRhLnN0YXR1c1RleHQpIHsKICAgICAgICAg ICAgIGRhdGEuc3RhdHVzVGV4dCA9IFdJLkhUVFBVdGlsaXRpZXMuc3RhdHVzVGV4dEZvclN0YXR1 c0NvZGUocGFyc2VJbnQoZGF0YS5zdGF0dXNDb2RlKSk7CisgICAgICAgICAgICByZXNvdXJjZURh dGEuc3RhdHVzVGV4dCA9IHVuZGVmaW5lZDsKKyAgICAgICAgfQogCiAgICAgICAgIGxldCByZXNw b25zZUhlYWRlcnMgPSBsb2NhbFJlc291cmNlID8gbG9jYWxSZXNvdXJjZS5yZXNwb25zZUhlYWRl cnMgOiB7fTsKIApAQCAtMzgyLDYgKzM4OSw4IEBAIFdJLkxvY2FsUmVzb3VyY2VPdmVycmlkZVBv cG92ZXIgPSBjbGFzcyBMb2NhbFJlc291cmNlT3ZlcnJpZGVQb3BvdmVyIGV4dGVuZHMgV0kuCiAK ICAgICAgICAgICAgIHRoaXMuX3VybENvZGVNaXJyb3IuZm9jdXMoKTsKICAgICAgICAgICAgIHRo aXMuX3VybENvZGVNaXJyb3Iuc2V0Q3Vyc29yKHRoaXMuX3VybENvZGVNaXJyb3IubGluZUNvdW50 KCksIDApOworCisgICAgICAgICAgICB0aGlzLnVwZGF0ZSgpOwogICAgICAgICB9KTsKICAgICB9 CiAK