204951 2019-12-06 10:23:54 -0800 compositing/video/video-border-radius-clipping.html is a flaky Image Failure 2019-12-13 16:19:06 -0800 1 1 1 Unclassified WebKit Compositing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=205226 InRadar P2 Normal --- 1 jlewis3 simon.fraser dino eric.carlson ews-watchlist glenn jer.noble koivisto philipj sergio simon.fraser tsavell webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1596286 0 jlewis3 2019-12-06 10:23:54 -0800 compositing/video/video-border-radius-clipping.html is a flaky Image Failure on Catalina Release WK2 This seems to have first started after https://trac.webkit.org/changeset/252245/webkit where Angle support was introduced. https://build.webkit.org/results/Apple-Catalina-Release-WK2-Tests/r253206%20(1314)/results.html https://results.webkit.org/?suite=layout-tests&test=compositing%2Fvideo%2Fvideo-border-radius-clipping.html https://build.webkit.org/results/Apple-Catalina-Release-WK2-Tests/r253206%20(1314)/compositing/video/video-border-radius-clipping-diffs.html 1596287 1 webkit-bug-importer 2019-12-06 10:24:53 -0800 <rdar://problem/57703078> 1596615 2 ap 2019-12-07 13:33:26 -0800 This is quite interesting. The first failure on results.webkit.org is indeed with r252246, but that seems very unlikely to be related, and the failure is too rare to blame to a specific revision. But the test also fails on other queues, both or results.webkit.org and internally. It fails in many different ways. The failure that Matt pointed out is painting a red rectangle. Other failures include antialiasing differences and getting a red line. 1597021 3 385210 simon.fraser 2019-12-09 16:55:53 -0800 Created attachment 385210 Patch 1597025 4 simon.fraser 2019-12-09 16:58:49 -0800 https://trac.webkit.org/changeset/253310/webkit 1598436 5 tsavell 2019-12-13 12:05:57 -0800 This appears to have caused compositing/video/video-border-radius-clipping.html to become a constant failure on High Sierra and Catalina wk1 history: https://results.webkit.org/?suite=layout-tests&test=compositing%2Fvideo%2Fvideo-border-radius-clipping.html Diff: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/r253485%20(17701)/compositing/video/video-border-radius-clipping-diffs.html Looks like a single pixel difference. 1598548 6 tsavell 2019-12-13 16:18:17 -0800 Tracking this in https://bugs.webkit.org/show_bug.cgi?id=205226 385210 2019-12-09 16:55:53 -0800 2019-12-09 16:58:43 -0800 Patch bug-204951-20191209165552.patch text/plain 5581 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMjk2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTFhNTA0MTE5NzIwNjMwODllYmQ0 NjQ4YWFiYzM4ZjM5MmM3MDc0My4uN2JjN2JhMjc1Zjc4NDNlNDA1N2Q2MzgyODVlNmI4MDA1YTc1 YmQ2MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTEyLTA5ICBTaW1vbiBGcmFzZXIgIDxz aW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIGNvbXBvc2l0aW5nL3ZpZGVvL3ZpZGVv LWJvcmRlci1yYWRpdXMtY2xpcHBpbmcuaHRtbCBpcyBhIGZsYWt5IEltYWdlIEZhaWx1cmUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDk1MQorICAg ICAgICByZGFyOi8vcHJvYmxlbS81NzcwMzA3OAorCisgICAgICAgIFVucmV2aWV3ZWQgdGVzdCBn YXJkZW5pbmcuIE1ha2UgdGhlIHRlc3Qgc2VlayBzbyB3ZSBoYXZlIGEgaGlnaGVyIGNoYW5jZQor ICAgICAgICBvZiBnZXR0aW5nIGEgdmlkZW8gZnJhbWUuIEl0J3MgYXBwYXJlbnRseSBpbXBvc3Np YmxlIHRvIGtub3cgd2hlbiB3ZSBoYXZlCisgICAgICAgIGEgZnJhbWUgZm9yIHJlZiB0ZXN0aW5n LgorCisgICAgICAgICogY29tcG9zaXRpbmcvdmlkZW8vdmlkZW8tYm9yZGVyLXJhZGl1cy1jbGlw cGluZy1leHBlY3RlZC5odG1sOgorICAgICAgICAqIGNvbXBvc2l0aW5nL3ZpZGVvL3ZpZGVvLWJv cmRlci1yYWRpdXMtY2xpcHBpbmcuaHRtbDoKKwogMjAxOS0xMi0wOSAgVHJ1aXR0IFNhdmVsbCAg PHRzYXZlbGxAYXBwbGUuY29tPgogCiAgICAgICAgIChyMjUyODg5KSB3ZWJydGMvcGVlcmNvbm5l Y3Rpb24tcGFnZS1jYWNoZS5odG1sIGlzIGNyYXNoaW5nIG9uIGlPUyBEZWJ1ZwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvdmlkZW8vdmlkZW8tYm9yZGVyLXJhZGl1cy1jbGlw cGluZy1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvdmlkZW8vdmlkZW8t Ym9yZGVyLXJhZGl1cy1jbGlwcGluZy1leHBlY3RlZC5odG1sCmluZGV4IDZhZTNlYWMzZmFkMDlm N2ZhZDc1ODA5ZjQ3Y2Y0OGFiNWVkOTdmMzguLjkxOGJjOTA3ZmMxNjc4ZTIwM2JmOWNkMjI5NzFk NTI3ZGI3NTkyNzkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3ZpZGVvL3Zp ZGVvLWJvcmRlci1yYWRpdXMtY2xpcHBpbmctZXhwZWN0ZWQuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9jb21wb3NpdGluZy92aWRlby92aWRlby1ib3JkZXItcmFkaXVzLWNsaXBwaW5nLWV4cGVjdGVk Lmh0bWwKQEAgLTE4LDMyICsxOCwzMSBAQAogICAgIDwvc3R5bGU+CiAgICAgPHNjcmlwdCBzcmM9 Ii4uLy4uL21lZGlhL21lZGlhLWZpbGUuanMiPjwvc2NyaXB0PgogICAgIDxzY3JpcHQ+Ci0gICAg ICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKLSAgICAgICAgICAgIHRlc3RSdW5uZXIud2FpdFVu dGlsRG9uZSgpOworICAgICAgICB2YXIgcmVxdWlyZVBpeGVsRHVtcCA9IHRydWU7CisgICAgICAg IHZhciB2aWRlbzsKIAotICAgICAgICBmdW5jdGlvbiBzZXR1cFRlc3QoKQorICAgICAgICBmdW5j dGlvbiB0ZXN0Q29tcGxldGUoKQogICAgICAgICB7Ci0gICAgICAgICAgICB2YXIgdG90YWxDb3Vu dCA9IGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCd2aWRlbycpLmxlbmd0aDsKLSAgICAg ICAgICAgIHZhciBjb3VudCA9IHRvdGFsQ291bnQ7Ci0gICAgICAgICAgICBkb2N1bWVudC5hZGRF dmVudExpc3RlbmVyKCJjYW5wbGF5dGhyb3VnaCIsIGZ1bmN0aW9uICgpIHsKLSAgICAgICAgICAg ICAgICBpZiAoIS0tY291bnQgJiYgd2luZG93LnRlc3RSdW5uZXIpIHsKLSAgICAgICAgICAgICAg ICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIHRl c3RSdW5uZXIubm90aWZ5RG9uZSgpOwotICAgICAgICAgICAgICAgICAgICB9LCB0b3RhbENvdW50 ICogMTUwKTsKLSAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICB9LCB0cnVlKTsKKyAgICAg ICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgICAgICAgICB0ZXN0UnVubmVy Lm5vdGlmeURvbmUoKTsKKyAgICAgICAgfQogCi0gICAgICAgICAgICBkb2N1bWVudC5hZGRFdmVu dExpc3RlbmVyKCJlcnJvciIsIGZ1bmN0aW9uIChldmVudCkgewotICAgICAgICAgICAgICAgIGNv bnNvbGUubG9nKCJWaWRlbyAiICsgZXZlbnQudGFyZ2V0LmdldEF0dHJpYnV0ZSgibmFtZSIpICsg IiBmYWlsZWQgdG8gbG9hZCwgZXJyb3IgIiArIGV2ZW50LnRhcmdldC5lcnJvci5jb2RlKTsKLSAg ICAgICAgICAgICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCi0gICAgICAgICAgICAgICAgICAg IHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOwotICAgICAgICAgICAgfSwgdHJ1ZSk7CisgICAgICAg IGZ1bmN0aW9uIGNhbnBsYXl0aHJvdWdoKCkKKyAgICAgICAgeworICAgICAgICAgICAgdmlkZW8u Y3VycmVudFRpbWUgPSAxOworICAgICAgICB9CiAKLSAgICAgICAgICAgIHNldFNyY0J5VGFnTmFt ZSgidmlkZW8iLCBmaW5kTWVkaWFGaWxlKCJ2aWRlbyIsICIuLi8uLi9tZWRpYS9jb250ZW50L2Nv dW50aW5nIikpOworICAgICAgICBmdW5jdGlvbiBkb1Rlc3QoKQorICAgICAgICB7CisgICAgICAg ICAgICBmaW5kTWVkaWFFbGVtZW50KCk7CisgICAgICAgICAgICB3YWl0Rm9yRXZlbnQoJ2NhbnBs YXl0aHJvdWdoJywgY2FucGxheXRocm91Z2gpOworICAgICAgICAgICAgd2FpdEZvckV2ZW50KCdz ZWVrZWQnLCB0ZXN0Q29tcGxldGUpOworICAgICAgICAgICAgdmlkZW8uc3JjID0gZmluZE1lZGlh RmlsZSgndmlkZW8nLCAnLi4vLi4vbWVkaWEvY29udGVudC9jb3VudGluZycpOwogICAgICAgICB9 CiAgICAgICAgIAotICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIHNldHVw VGVzdCwgZmFsc2UpOworICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIGRv VGVzdCwgZmFsc2UpOwogICAgIDwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPSIuLi8uLi9tZWRp YS92aWRlby10ZXN0LmpzIj48L3NjcmlwdD4KIDwvaGVhZD4KIDxib2R5PgogICAgIDx2aWRlbz48 L3ZpZGVvPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvdmlkZW8vdmlkZW8t Ym9yZGVyLXJhZGl1cy1jbGlwcGluZy5odG1sIGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvdmlk ZW8vdmlkZW8tYm9yZGVyLXJhZGl1cy1jbGlwcGluZy5odG1sCmluZGV4IDE2OTJmMWVjNWE1NTY0 ODk1N2Q0YjQ4MWQwYTllYzhjNjEzZTg4YTIuLjQ3ODkyZmViMmY5Y2U3OTgzNTBkZmJlYjNiODQ4 ZDRjMDIxMDM0OGQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3ZpZGVvL3Zp ZGVvLWJvcmRlci1yYWRpdXMtY2xpcHBpbmcuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9jb21wb3Np dGluZy92aWRlby92aWRlby1ib3JkZXItcmFkaXVzLWNsaXBwaW5nLmh0bWwKQEAgLTksNyArOSw3 IEBACiAgICAgICAgICAgICBtYXJnaW46IDUwcHg7CiAgICAgICAgICAgICB3aWR0aDogNTAwLjI1 cHg7CiAgICAgICAgIH0KLSAgICAgICAgCisKICAgICAgICAgLm9ic2N1cmVyIHsKICAgICAgICAg ICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKICAgICAgICAgICAgIHdpZHRoOiAxNHB4OwpAQCAtMTks MzIgKzE5LDMxIEBACiAgICAgPC9zdHlsZT4KICAgICA8c2NyaXB0IHNyYz0iLi4vLi4vbWVkaWEv bWVkaWEtZmlsZS5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdD4KLSAgICAgICAgaWYgKHdpbmRv dy50ZXN0UnVubmVyKQotICAgICAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7Cisg ICAgICAgIHZhciByZXF1aXJlUGl4ZWxEdW1wID0gdHJ1ZTsKKyAgICAgICAgdmFyIHZpZGVvOwog Ci0gICAgICAgIGZ1bmN0aW9uIHNldHVwVGVzdCgpCisgICAgICAgIGZ1bmN0aW9uIHRlc3RDb21w bGV0ZSgpCiAgICAgICAgIHsKLSAgICAgICAgICAgIHZhciB0b3RhbENvdW50ID0gZG9jdW1lbnQu Z2V0RWxlbWVudHNCeVRhZ05hbWUoJ3ZpZGVvJykubGVuZ3RoOwotICAgICAgICAgICAgdmFyIGNv dW50ID0gdG90YWxDb3VudDsKLSAgICAgICAgICAgIGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIo ImNhbnBsYXl0aHJvdWdoIiwgZnVuY3Rpb24gKCkgewotICAgICAgICAgICAgICAgIGlmICghLS1j b3VudCAmJiB3aW5kb3cudGVzdFJ1bm5lcikgewotICAgICAgICAgICAgICAgICAgICBzZXRUaW1l b3V0KGZ1bmN0aW9uKCkgewotICAgICAgICAgICAgICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3Rp ZnlEb25lKCk7Ci0gICAgICAgICAgICAgICAgICAgIH0sIHRvdGFsQ291bnQgKiAxNTApOwotICAg ICAgICAgICAgICAgIH0KLSAgICAgICAgICAgIH0sIHRydWUpOworICAgICAgICAgICAgaWYgKHdp bmRvdy50ZXN0UnVubmVyKQorICAgICAgICAgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgp OworICAgICAgICB9CiAKLSAgICAgICAgICAgIGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoImVy cm9yIiwgZnVuY3Rpb24gKGV2ZW50KSB7Ci0gICAgICAgICAgICAgICAgY29uc29sZS5sb2coIlZp ZGVvICIgKyBldmVudC50YXJnZXQuZ2V0QXR0cmlidXRlKCJuYW1lIikgKyAiIGZhaWxlZCB0byBs b2FkLCBlcnJvciAiICsgZXZlbnQudGFyZ2V0LmVycm9yLmNvZGUpOwotICAgICAgICAgICAgICAg IGlmICh3aW5kb3cudGVzdFJ1bm5lcikKLSAgICAgICAgICAgICAgICAgICAgdGVzdFJ1bm5lci5u b3RpZnlEb25lKCk7Ci0gICAgICAgICAgICB9LCB0cnVlKTsKKyAgICAgICAgZnVuY3Rpb24gY2Fu cGxheXRocm91Z2goKQorICAgICAgICB7CisgICAgICAgICAgICB2aWRlby5jdXJyZW50VGltZSA9 IDE7CisgICAgICAgIH0KIAotICAgICAgICAgICAgc2V0U3JjQnlUYWdOYW1lKCJ2aWRlbyIsIGZp bmRNZWRpYUZpbGUoInZpZGVvIiwgIi4uLy4uL21lZGlhL2NvbnRlbnQvY291bnRpbmciKSk7Cisg ICAgICAgIGZ1bmN0aW9uIGRvVGVzdCgpCisgICAgICAgIHsKKyAgICAgICAgICAgIGZpbmRNZWRp YUVsZW1lbnQoKTsKKyAgICAgICAgICAgIHdhaXRGb3JFdmVudCgnY2FucGxheXRocm91Z2gnLCBj YW5wbGF5dGhyb3VnaCk7CisgICAgICAgICAgICB3YWl0Rm9yRXZlbnQoJ3NlZWtlZCcsIHRlc3RD b21wbGV0ZSk7CisgICAgICAgICAgICB2aWRlby5zcmMgPSBmaW5kTWVkaWFGaWxlKCd2aWRlbycs ICcuLi8uLi9tZWRpYS9jb250ZW50L2NvdW50aW5nJyk7CiAgICAgICAgIH0KICAgICAgICAgCi0g ICAgICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywgc2V0dXBUZXN0LCBmYWxzZSk7 CisgICAgICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywgZG9UZXN0LCBmYWxzZSk7 CiAgICAgPC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9Ii4uLy4uL21lZGlhL3ZpZGVvLXRlc3Qu anMiPjwvc2NyaXB0PgogPC9oZWFkPgogPGJvZHk+CiAgICAgPHZpZGVvPjwvdmlkZW8+Cg==