204950 2019-12-06 09:03:15 -0800 Reduce timeout for page to handle beforeunload events when trying to close a page 2020-02-03 08:58:42 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 206366 207121 1 cdumez cdumez achristensen beidson commit-queue ggaren rniwa webkit-bug-importer youennf oldest_to_newest 1596267 0 cdumez 2019-12-06 09:03:15 -0800 Reduce timeout for page to handle beforeunload events when trying to close a page. It may currently take up to 3 seconds to actually close a tab after the user clicks on the "X" to close it. This is because we wait for the page to fire and handle the beforeunload events and only give up after 3 seconds. I propose we reduce this timeout to something more reasonable from a user standpoint (e.g. 500ms, no more than 1 second). 1596268 1 webkit-bug-importer 2019-12-06 09:03:34 -0800 <rdar://problem/57700419> 1596271 2 385021 cdumez 2019-12-06 09:08:15 -0800 Created attachment 385021 Patch 1596384 3 385021 commit-queue 2019-12-06 15:02:18 -0800 Comment on attachment 385021 Patch Clearing flags on attachment: 385021 Committed r253224: <https://trac.webkit.org/changeset/253224> 1596385 4 commit-queue 2019-12-06 15:02:19 -0800 All reviewed patches have been landed. Closing bug. 385021 2019-12-06 09:08:15 -0800 2019-12-06 15:02:18 -0800 Patch bug-204950-20191206090814.patch text/plain 5210 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI4MmVkMWI0MDY3MjgwYjIz YWY2ZmU5MTVjNmY1NTc0YjM3ZmQ0YTMuLjc5Mjc4ZDA0NjFiYzMxNjUxMGUxMzk5ZGZiODg2MWQ2 YWI5ZmY0M2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTktMTItMDYgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWR1Y2UgdGltZW91dCBmb3IgcGFn ZSB0byBoYW5kbGUgYmVmb3JldW5sb2FkIGV2ZW50cyB3aGVuIHRyeWluZyB0byBjbG9zZSBhIHBh Z2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDk1 MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTc3MDA0MTk+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVkdWNlIHRpbWVvdXQgZm9yIHBhZ2UgdG8g aGFuZGxlIGJlZm9yZXVubG9hZCBldmVudHMgd2hlbiB0cnlpbmcgdG8gY2xvc2UgYSBwYWdlLiBJ dCB3b3VsZCBwcmV2aW91c2x5CisgICAgICAgIHRha2UgdXAgdG8gMyBzZWNvbmRzIHRvIGFjdHVh bGx5IGNsb3NlIGEgdGFiIGFmdGVyIHRoZSB1c2VyIHdvdWxkIGNsaWNrIG9uIHRoZSAiWCIgdG8g Y2xvc2UgaXQuIFRoaXMKKyAgICAgICAgaXMgYmVjYXVzZSB3ZSB3b3VsZCB3YWl0IGZvciB0aGUg cGFnZSB0byBmaXJlIGFuZCBoYW5kbGUgdGhlIGJlZm9yZXVubG9hZCBldmVudHMgYW5kIG9ubHkg Z2l2ZSB1cCBhZnRlcgorICAgICAgICAzIHNlY29uZHMuIFRoaXMgcGF0Y2ggcmVkdWNlcyB0aGlz IHRpbWVvdXQgdG8gc29tZXRoaW5nIG1vcmUgcmVhc29uYWJsZSBmcm9tIGEgdXNlciBzdGFuZHBv aW50ICg1MDBtcykuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAg ICAgICAgKFdlYktpdDo6bV90cnlDbG9zZVRpbWVvdXRUaW1lcik6CisgICAgICAgIChXZWJLaXQ6 OldlYlBhZ2VQcm94eTo6dHJ5Q2xvc2UpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6 OnRyeUNsb3NlVGltZWRPdXQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmNsb3Nl UGFnZSk6CisgICAgICAgIChXZWJLaXQ6Om1fcmVzZXRSZWNlbnRDcmFzaENvdW50VGltZXIpOiBE ZWxldGVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaDoKKwogMjAxOS0xMi0w NSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFN0b3AgdXNpbmcg cmVzZXJ2ZUNhcGFjaXR5KCkgLyByZXNlcnZlSW5pdGlhbENhcGFjaXR5KCkgaW4gSVBDIGRlY29k ZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCBlMjkwMTQ5 M2I3MDQzZTVhZDAzOTYyYzExODJlOTQ2YjM4MDgyMmJjLi5kODQxZDNkMzg1ZjU4ZTdhNWRkMWQ5 OTgxNDk4NGQ3NTQ1YjVjNjczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94 eS5jcHAKQEAgLTI3MSw2ICsyNzEsNyBAQCBzdGF0aWMgY29uc3QgdW5zaWduZWQgd2hlZWxFdmVu dFF1ZXVlU2l6ZVRocmVzaG9sZCA9IDEwOwogc3RhdGljIGNvbnN0IFNlY29uZHMgcmVzZXRSZWNl bnRDcmFzaENvdW50RGVsYXkgPSAzMF9zOwogc3RhdGljIHVuc2lnbmVkIG1heGltdW1XZWJQcm9j ZXNzUmVsYXVuY2hBdHRlbXB0cyA9IDE7CiBzdGF0aWMgY29uc3QgU2Vjb25kcyBhdWRpYmxlQWN0 aXZpdHlDbGVhckRlbGF5ID0gMTBfczsKK3N0YXRpYyBjb25zdCBTZWNvbmRzIHRyeUNsb3NlVGlt ZW91dERlbGF5ID0gNTAwX21zOwogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIHVzaW5nIG5hbWVzcGFj ZSBXZWJDb3JlOwpAQCAtNDQ5LDYgKzQ1MCw3IEBAIFdlYlBhZ2VQcm94eTo6V2ViUGFnZVByb3h5 KFBhZ2VDbGllbnQmIHBhZ2VDbGllbnQsIFdlYlByb2Nlc3NQcm94eSYgcHJvY2VzcywgUmVmCiAg ICAgLCBtX2luc3BlY3RvckRlYnVnZ2FibGUobWFrZVVuaXF1ZTxXZWJQYWdlRGVidWdnYWJsZT4o KnRoaXMpKQogI2VuZGlmCiAgICAgLCBtX3Jlc2V0UmVjZW50Q3Jhc2hDb3VudFRpbWVyKFJ1bkxv b3A6Om1haW4oKSwgdGhpcywgJldlYlBhZ2VQcm94eTo6cmVzZXRSZWNlbnRDcmFzaENvdW50KQor ICAgICwgbV90cnlDbG9zZVRpbWVvdXRUaW1lcihSdW5Mb29wOjptYWluKCksIHRoaXMsICZXZWJQ YWdlUHJveHk6OnRyeUNsb3NlVGltZWRPdXQpCiB7CiAgICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dF RChMb2FkaW5nLCAiY29uc3RydWN0b3I6Iik7CiAKQEAgLTEwNzQsMjUgKzEwNzYsMzEgQEAgYm9v bCBXZWJQYWdlUHJveHk6OnRyeUNsb3NlKCkKICAgICBpZiAoIWhhc1J1bm5pbmdQcm9jZXNzKCkp CiAgICAgICAgIHJldHVybiB0cnVlOwogCi0gICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dFRChMb2Fk aW5nLCAidHJ5Q2xvc2U6Iik7CisgICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dFRChQcm9jZXNzLCAi dHJ5Q2xvc2U6Iik7CiAKICAgICAvLyBDbG9zZSB3aXRob3V0IGRlbGF5IGlmIHRoZSBwcm9jZXNz IGFsbG93cyBpdC4gT3VyIGdvYWwgaXMgdG8gdGVybWluYXRlCiAgICAgLy8gdGhlIHByb2Nlc3Ms IHNvIHdlIGNoZWNrIGEgcGVyLXByb2Nlc3Mgc3RhdHVzIGJpdC4KICAgICBpZiAobV9wcm9jZXNz LT5pc1N1ZGRlblRlcm1pbmF0aW9uRW5hYmxlZCgpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAot ICAgIG1fcHJvY2Vzcy0+cmVzcG9uc2l2ZW5lc3NUaW1lcigpLnN0YXJ0KCk7CisgICAgbV90cnlD bG9zZVRpbWVvdXRUaW1lci5zdGFydE9uZVNob3QodHJ5Q2xvc2VUaW1lb3V0RGVsYXkpOwogICAg IHNlbmRXaXRoQXN5bmNSZXBseShNZXNzYWdlczo6V2ViUGFnZTo6VHJ5Q2xvc2UoKSwgW3RoaXMs IHdlYWtUaGlzID0gbWFrZVdlYWtQdHIoKnRoaXMpXShib29sIHNob3VsZENsb3NlKSB7CiAgICAg ICAgIGlmICghd2Vha1RoaXMpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgbV9wcm9j ZXNzLT5yZXNwb25zaXZlbmVzc1RpbWVyKCkuc3RvcCgpOworICAgICAgICBtX3RyeUNsb3NlVGlt ZW91dFRpbWVyLnN0b3AoKTsKICAgICAgICAgaWYgKHNob3VsZENsb3NlKQogICAgICAgICAgICAg Y2xvc2VQYWdlKCk7CiAgICAgfSk7CiAgICAgcmV0dXJuIGZhbHNlOwogfQogCit2b2lkIFdlYlBh Z2VQcm94eTo6dHJ5Q2xvc2VUaW1lZE91dCgpCit7CisgICAgUkVMRUFTRV9MT0dfRVJST1JfSUZf QUxMT1dFRChQcm9jZXNzLCAidHJ5Q2xvc2VUaW1lZE91dDogVGltZWQgb3V0IHdhaXRpbmcgZm9y IHRoZSBwcm9jZXNzIHRvIHJlc3BvbmQgdG8gdGhlIFdlYlBhZ2U6OlRyeUNsb3NlIElQQywgY2xv c2luZyB0aGUgcGFnZSBub3ciKTsKKyAgICBjbG9zZVBhZ2UoKTsKK30KKwogdm9pZCBXZWJQYWdl UHJveHk6Om1heWJlSW5pdGlhbGl6ZVNhbmRib3hFeHRlbnNpb25IYW5kbGUoV2ViUHJvY2Vzc1By b3h5JiBwcm9jZXNzLCBjb25zdCBVUkwmIHVybCwgY29uc3QgVVJMJiByZXNvdXJjZURpcmVjdG9y eVVSTCwgU2FuZGJveEV4dGVuc2lvbjo6SGFuZGxlJiBzYW5kYm94RXh0ZW5zaW9uSGFuZGxlLCBi b29sIGNoZWNrQXNzdW1lZFJlYWRBY2Nlc3NUb1Jlc291cmNlVVJMKQogewogICAgIGlmICghdXJs LmlzTG9jYWxGaWxlKCkpCkBAIC01MzIxLDYgKzUzMjksMTAgQEAgdm9pZCBXZWJQYWdlUHJveHk6 OmRpZEV4aXRGdWxsc2NyZWVuKCkKIAogdm9pZCBXZWJQYWdlUHJveHk6OmNsb3NlUGFnZSgpCiB7 CisgICAgaWYgKGlzQ2xvc2VkKCkpCisgICAgICAgIHJldHVybjsKKworICAgIFJFTEVBU0VfTE9H X0lGX0FMTE9XRUQoUHJvY2VzcywgImNsb3NlUGFnZToiKTsKICAgICBwYWdlQ2xpZW50KCkuY2xl YXJBbGxFZGl0Q29tbWFuZHMoKTsKICAgICBtX3VpQ2xpZW50LT5jbG9zZSh0aGlzKTsKIH0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKaW5kZXggMGZiNTMxZjgxYzY4NmQzZTA1 MzllZTI4MGVkODY3OWE0N2UwY2I1Zi4uZWQ4M2JiZjIxNWU1YWY1YjRiZjcxNDJkODAxYjU1MjJk MDVhYjEyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5 LmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKQEAgLTIxNzcs NiArMjE3Nyw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBjbGVhckF1ZGlibGVBY3Rpdml0eSgpOwog I2VuZGlmCiAKKyAgICB2b2lkIHRyeUNsb3NlVGltZWRPdXQoKTsKICAgICB2b2lkIG1ha2VTdG9y YWdlU3BhY2VSZXF1ZXN0KFdlYkNvcmU6OkZyYW1lSWRlbnRpZmllciwgY29uc3QgU3RyaW5nJiBv cmlnaW5JZGVudGlmaWVyLCBjb25zdCBTdHJpbmcmIGRhdGFiYXNlTmFtZSwgY29uc3QgU3RyaW5n JiBkaXNwbGF5TmFtZSwgdWludDY0X3QgY3VycmVudFF1b3RhLCB1aW50NjRfdCBjdXJyZW50T3Jp Z2luVXNhZ2UsIHVpbnQ2NF90IGN1cnJlbnREYXRhYmFzZVVzYWdlLCB1aW50NjRfdCBleHBlY3Rl ZFVzYWdlLCBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKHVpbnQ2NF90KT4mJik7CiAKICAgICBjb25z dCBJZGVudGlmaWVyIG1faWRlbnRpZmllcjsKQEAgLTI1OTQsNiArMjU5NSw4IEBAIHByaXZhdGU6 CiAgICAgYm9vbCBtX25lZWRzRm9udEF0dHJpYnV0ZXMgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9t YXlIYXZlVW5pdmVyc2FsRmlsZVJlYWRTYW5kYm94RXh0ZW5zaW9uIHsgZmFsc2UgfTsKIAorICAg IFJ1bkxvb3A6OlRpbWVyPFdlYlBhZ2VQcm94eT4gbV90cnlDbG9zZVRpbWVvdXRUaW1lcjsKKwog ICAgIHN0ZDo6dW5pcXVlX3B0cjxQcm92aXNpb25hbFBhZ2VQcm94eT4gbV9wcm92aXNpb25hbFBh Z2U7CiAgICAgc3RkOjp1bmlxdWVfcHRyPFN1c3BlbmRlZFBhZ2VQcm94eT4gbV9zdXNwZW5kZWRQ YWdlS2VwdFRvUHJldmVudEZsYXNoaW5nOwogICAgIFdlYWtQdHI8U3VzcGVuZGVkUGFnZVByb3h5 PiBtX2xhc3RTdXNwZW5kZWRQYWdlOwo=