20495 2008-08-24 00:10:35 -0700 paintBorder in RenderObject paint two times the corners 2011-04-19 11:46:23 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Minor --- 58761 1 mario.bensi simon.fraser bdakin hyatt simon.fraser oldest_to_newest 89184 0 mario.bensi 2008-08-24 00:10:35 -0700 here a log of drawBorder coordinate in paintBorder : x1 : 215 y1 : 474 x2 : 768 y2 : 478 x1 : 215 y1 : 533 x2 : 768 y2 : 537 x1 : 215 y1 : 474 x2 : 219 y2 : 537 x1 : 764 y1 : 474 x2 : 768 y2 : 537 the result is that : ------------------------ | | | | ------------------------ | | | | | | | | | | | | | | | | | | | | ------------------------ | | | | ------------------------ I think we should have that : ------------------------ | | ------------------------ | | | | | | | | | | | | | | | | | | | | ------------------------ | | ------------------------ 89185 1 22957 mario.bensi 2008-08-24 00:21:15 -0700 Created attachment 22957 test to draw a border 89186 2 22958 mario.bensi 2008-08-24 00:23:50 -0700 Created attachment 22958 fix paintBorder remove the border width when the paintBorder draw the left and rigth side. 89265 3 22977 mario.bensi 2008-08-25 04:15:23 -0700 Created attachment 22977 fix paintBorder and add test before borderPaint 89267 4 22979 mario.bensi 2008-08-25 05:21:55 -0700 Created attachment 22979 fix paintBorder, add test and fix coding style 89575 5 eric 2008-08-27 17:40:13 -0700 Hyatt, beth? any thoughts? This looks sane to me. 89584 6 22979 hyatt 2008-08-27 18:26:32 -0700 Comment on attachment 22979 fix paintBorder, add test and fix coding style I think this needs test cases. You are in effect choosing one border style to "win" at the corner. We need to test this to see how we match up. This is very important for tests like Acid 2. 89585 7 hyatt 2008-08-27 18:26:58 -0700 We need to compare with IE and Firefox. 89864 8 23099 mario.bensi 2008-09-01 06:20:58 -0700 Created attachment 23099 fix paintBorder in RenderObject and remove the bug on acid2 I use the old code when the rect is not available and this fix the problem on acid2 and on the text border you have not the border paint two time. 89903 9 23099 eric 2008-09-02 03:14:50 -0700 Comment on attachment 23099 fix paintBorder in RenderObject and remove the bug on acid2 I can't evaluate the correctness of this patch, but I can say that the copy-paste code used here is a bad idea. The if should be used to store the necessary variables, and then a single drawBorder call should be used. It appears that you're changing where it's drawing from/to. It seems the code right above this adjusts y and y2 in an if, why can't this change also do the same? (use an if to adjust y and y2? or copy y and y2 into some other nicely named variables and ajust them there). Copy/paste of code which is confusing to begin with is a bad idea. Ideally this method would be cleaned up to use FloatPoint and possibly to take fewer parameters :) 388661 10 simon.fraser 2011-04-19 11:46:23 -0700 http://trac.webkit.org/changeset/84273 22957 2008-08-24 00:21:15 -0700 2008-08-24 00:24:44 -0700 test to draw a border anim.html text/html 383 mario.bensi PGh0bWw+Cjxib2R5Pgo8ZGl2IG9ubW91c2VvdmVyPSJ0aGlzLnN0eWxlLm9wYWNpdHkgPSAwOyIg b25tb3VzZW91dD0idGhpcy5zdHlsZS5vcGFjaXR5PTEiIHN0eWxlPSItd2Via2l0LXRyYW5zaXRp b246IG9wYWNpdHkgMXMgbGluZWFyOyBiYWNrZ3JvdW5kLWNvbG9yOiAjZGRkZGRkOyBib3JkZXI6 NXB4IHNvbGlkIGJsYWNrOyI+VGhpcyBkaXYgd2lsbCBmYWRlIG91dCB3aGVuIGhvdmVyZWQgb3Zl ci4gIEluIGJyb3dzZXJzIHRoYXQgZG8gbm90IHN1cHBvcnQgdGhpcyBhbmltYXRpb24sIHRoZXJl IHdpbGwgYmUgZ3JhY2VmdWwgZGVncmFkYXRpb24sIGFzIHRoZSBkaXYgd2lsbCBzaW1wbHkgZmFk ZSBvdXQgaW1tZWRpYXRlbHkuPC9kaXY+CjwvYm9keT4KPC9odG1sPgo= 22958 2008-08-24 00:23:50 -0700 2008-08-25 04:15:53 -0700 fix paintBorder paintBorder.patch text/plain 2330 mario.bensi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTkwMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDgtMDgtMjQgIE1hcmlvIEJlbnNpICA8bWJlbnNpQHBsZXlvLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgZml4IHBh aW50Qm9yZGVyIGluIFJlbmRlck9iamVjdCB3aGljaCBwYWludCB0d28gdGltZXMgdGhlIGNvcm5l cnMKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyT2JqZWN0OjpwYWludEJvcmRlcik6IHJlbW92ZSB0aGUgYm9yZGVyIHdpZHRo IHdoZW4gdGhlCisJcGFpbnRCb3JkZXIgZHJhdyB0aGUgbGVmdCBhbmQgcmlndGggc2lkZS4KKwog MjAwOC0wOC0yMyAgQ2FtZXJvbiBad2FyaWNoICA8Y3d6d2FyaWNoQHV3YXRlcmxvby5jYT4KIAog ICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBNYXJrIFJvd2UuCkluZGV4OiBXZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlck9iamVjdC5jcHAJKHJldmlzaW9uIDM1OTAwKQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTUxOSw4ICsxNTE5LDggQEAgdm9pZCBS ZW5kZXJPYmplY3Q6OnBhaW50Qm9yZGVyKEdyYXBoaWNzQwogICAgICAgICAgICAgeTIgLT0gYm90 dG9tTGVmdC5oZWlnaHQoKTsKICAgICAgICAgfQogCi0gICAgICAgIGRyYXdCb3JkZXIoZ3JhcGhp Y3NDb250ZXh0LCB0eCwgeSwgdHggKyBzdHlsZS0+Ym9yZGVyTGVmdFdpZHRoKCksIHkyLCBCU0xl ZnQsIGxjLCBzdHlsZS0+Y29sb3IoKSwgbHMsCi0gICAgICAgICAgICAgICAgICAgaWdub3JlX3Rv cCA/IDAgOiBzdHlsZS0+Ym9yZGVyVG9wV2lkdGgoKSwgaWdub3JlX2JvdHRvbSA/IDAgOiBzdHls ZS0+Ym9yZGVyQm90dG9tV2lkdGgoKSk7CisgICAgICAgIGRyYXdCb3JkZXIoZ3JhcGhpY3NDb250 ZXh0LCB0eCwgeSArIHN0eWxlLT5ib3JkZXJUb3BXaWR0aCgpLCB0eCArIHN0eWxlLT5ib3JkZXJM ZWZ0V2lkdGgoKSwgeTItc3R5bGUtPmJvcmRlclRvcFdpZHRoKCksIAorCSAgICAgICAgICAgQlNM ZWZ0LCBsYywgc3R5bGUtPmNvbG9yKCksIGxzLCBpZ25vcmVfdG9wID8gMCA6IHN0eWxlLT5ib3Jk ZXJUb3BXaWR0aCgpLCBpZ25vcmVfYm90dG9tID8gMCA6IHN0eWxlLT5ib3JkZXJCb3R0b21XaWR0 aCgpKTsKIAogICAgICAgICBpZiAocmVuZGVyUmFkaWkgJiYgKCF1cHBlckxlZnRCb3JkZXJTdHls ZXNNYXRjaCB8fCAhbG93ZXJMZWZ0Qm9yZGVyU3R5bGVzTWF0Y2gpKSB7CiAgICAgICAgICAgICBp bnQgdG9wWCA9IHR4OwpAQCAtMTU4OCw4ICsxNTg4LDggQEAgdm9pZCBSZW5kZXJPYmplY3Q6OnBh aW50Qm9yZGVyKEdyYXBoaWNzQwogICAgICAgICAgICAgeTIgLT0gYm90dG9tUmlnaHQuaGVpZ2h0 KCk7CiAgICAgICAgIH0KIAotICAgICAgICBkcmF3Qm9yZGVyKGdyYXBoaWNzQ29udGV4dCwgdHgg KyB3IC0gc3R5bGUtPmJvcmRlclJpZ2h0V2lkdGgoKSwgeSwgdHggKyB3LCB5MiwgQlNSaWdodCwg cmMsIHN0eWxlLT5jb2xvcigpLCBycywKLSAgICAgICAgICAgICAgICAgICBpZ25vcmVfdG9wID8g MCA6IHN0eWxlLT5ib3JkZXJUb3BXaWR0aCgpLCBpZ25vcmVfYm90dG9tID8gMCA6IHN0eWxlLT5i b3JkZXJCb3R0b21XaWR0aCgpKTsKKyAgICAgICAgZHJhd0JvcmRlcihncmFwaGljc0NvbnRleHQs IHR4ICsgdyAtIHN0eWxlLT5ib3JkZXJSaWdodFdpZHRoKCksIHkgKyBzdHlsZS0+Ym9yZGVyVG9w V2lkdGgoKSwgdHggKyB3LCB5Mi1zdHlsZS0+Ym9yZGVyVG9wV2lkdGgoKSwgCisJICAgICAgICAg ICBCU1JpZ2h0LCByYywgc3R5bGUtPmNvbG9yKCksIHJzLCBpZ25vcmVfdG9wID8gMCA6IHN0eWxl LT5ib3JkZXJUb3BXaWR0aCgpLCBpZ25vcmVfYm90dG9tID8gMCA6IHN0eWxlLT5ib3JkZXJCb3R0 b21XaWR0aCgpKTsKIAogICAgICAgICBpZiAocmVuZGVyUmFkaWkgJiYgKCF1cHBlclJpZ2h0Qm9y ZGVyU3R5bGVzTWF0Y2ggfHwgIWxvd2VyUmlnaHRCb3JkZXJTdHlsZXNNYXRjaCkpIHsKICAgICAg ICAgICAgIHRoaWNrbmVzcyA9IHN0eWxlLT5ib3JkZXJSaWdodFdpZHRoKCkgKiAyOwo= 22977 2008-08-25 04:15:23 -0700 2008-08-25 05:22:11 -0700 fix paintBorder and add test before borderPaint paintBorder.patch text/plain 2592 mario.bensi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTkxNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDgtMDgtMjUgIE1hcmlvIEJlbnNpICA8bWJlbnNpQHBsZXlvLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgZml4IHBh aW50Qm9yZGVyIGluIFJlbmRlck9iamVjdCB3aGljaCBwYWludCB0d28gdGltZXMgdGhlIGNvcm5l cnMKKworICAgICAgICBXQVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENIQU5HRUQKKwor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyT2JqZWN0OjpwYWludEJvcmRlcik6IHJlbW92ZSB0aGUgYm9yZGVyIHdpZHRoIHdoZW4g dGhlIHBhaW50Qm9yZGVyIGRyYXcgdGhlIGxlZnQgYW5kIHJpZ3RoIHNpZGUuCisKIDIwMDgtMDgt MjUgIEhvbGdlciBIYW5zIFBldGVyIEZyZXl0aGVyICA8emVja2VAc2VsZmlzaC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgU2ltb24uCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJP YmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5j cHAJKHJldmlzaW9uIDM1OTE2KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTUxOCw5ICsxNTE4LDkgQEAgdm9pZCBSZW5kZXJPYmplY3Q6 OnBhaW50Qm9yZGVyKEdyYXBoaWNzQwogICAgICAgICAgICAgeSArPSB0b3BMZWZ0LmhlaWdodCgp OwogICAgICAgICAgICAgeTIgLT0gYm90dG9tTGVmdC5oZWlnaHQoKTsKICAgICAgICAgfQotCi0g ICAgICAgIGRyYXdCb3JkZXIoZ3JhcGhpY3NDb250ZXh0LCB0eCwgeSwgdHggKyBzdHlsZS0+Ym9y ZGVyTGVmdFdpZHRoKCksIHkyLCBCU0xlZnQsIGxjLCBzdHlsZS0+Y29sb3IoKSwgbHMsCi0gICAg ICAgICAgICAgICAgICAgaWdub3JlX3RvcCA/IDAgOiBzdHlsZS0+Ym9yZGVyVG9wV2lkdGgoKSwg aWdub3JlX2JvdHRvbSA/IDAgOiBzdHlsZS0+Ym9yZGVyQm90dG9tV2lkdGgoKSk7CisJaWYgKCh5 ICsgc3R5bGUtPmJvcmRlclRvcFdpZHRoKCkpIDw9ICh5MiAtIHN0eWxlLT5ib3JkZXJUb3BXaWR0 aCgpKSkKKyAgICAgICAgICAgIGRyYXdCb3JkZXIoZ3JhcGhpY3NDb250ZXh0LCB0eCwgeSArIHN0 eWxlLT5ib3JkZXJUb3BXaWR0aCgpLCB0eCArIHN0eWxlLT5ib3JkZXJMZWZ0V2lkdGgoKSwgeTIg LSBzdHlsZS0+Ym9yZGVyVG9wV2lkdGgoKSwgCisgICAgICAgICAgICAgICAgICAgICAgIEJTTGVm dCwgbGMsIHN0eWxlLT5jb2xvcigpLCBscywgaWdub3JlX3RvcCA/IDAgOiBzdHlsZS0+Ym9yZGVy VG9wV2lkdGgoKSwgaWdub3JlX2JvdHRvbSA/IDAgOiBzdHlsZS0+Ym9yZGVyQm90dG9tV2lkdGgo KSk7CiAKICAgICAgICAgaWYgKHJlbmRlclJhZGlpICYmICghdXBwZXJMZWZ0Qm9yZGVyU3R5bGVz TWF0Y2ggfHwgIWxvd2VyTGVmdEJvcmRlclN0eWxlc01hdGNoKSkgewogICAgICAgICAgICAgaW50 IHRvcFggPSB0eDsKQEAgLTE1ODgsOCArMTU4OCw5IEBAIHZvaWQgUmVuZGVyT2JqZWN0OjpwYWlu dEJvcmRlcihHcmFwaGljc0MKICAgICAgICAgICAgIHkyIC09IGJvdHRvbVJpZ2h0LmhlaWdodCgp OwogICAgICAgICB9CiAKLSAgICAgICAgZHJhd0JvcmRlcihncmFwaGljc0NvbnRleHQsIHR4ICsg dyAtIHN0eWxlLT5ib3JkZXJSaWdodFdpZHRoKCksIHksIHR4ICsgdywgeTIsIEJTUmlnaHQsIHJj LCBzdHlsZS0+Y29sb3IoKSwgcnMsCi0gICAgICAgICAgICAgICAgICAgaWdub3JlX3RvcCA/IDAg OiBzdHlsZS0+Ym9yZGVyVG9wV2lkdGgoKSwgaWdub3JlX2JvdHRvbSA/IDAgOiBzdHlsZS0+Ym9y ZGVyQm90dG9tV2lkdGgoKSk7CisgICAgICAgIGlmICgoeSArIHN0eWxlLT5ib3JkZXJUb3BXaWR0 aCgpKSA8PSAoeTIgLSBzdHlsZS0+Ym9yZGVyVG9wV2lkdGgoKSkpCisgICAgICAgICAgICBkcmF3 Qm9yZGVyKGdyYXBoaWNzQ29udGV4dCwgdHggKyB3IC0gc3R5bGUtPmJvcmRlclJpZ2h0V2lkdGgo KSwgeSArIHN0eWxlLT5ib3JkZXJUb3BXaWR0aCgpLCB0eCArIHcsIHkyLXN0eWxlLT5ib3JkZXJU b3BXaWR0aCgpLCAKKyAgICAgICAgICAgICAgICAgICAgICAgQlNSaWdodCwgcmMsIHN0eWxlLT5j b2xvcigpLCBycywgaWdub3JlX3RvcCA/IDAgOiBzdHlsZS0+Ym9yZGVyVG9wV2lkdGgoKSwgaWdu b3JlX2JvdHRvbSA/IDAgOiBzdHlsZS0+Ym9yZGVyQm90dG9tV2lkdGgoKSk7CiAKICAgICAgICAg aWYgKHJlbmRlclJhZGlpICYmICghdXBwZXJSaWdodEJvcmRlclN0eWxlc01hdGNoIHx8ICFsb3dl clJpZ2h0Qm9yZGVyU3R5bGVzTWF0Y2gpKSB7CiAgICAgICAgICAgICB0aGlja25lc3MgPSBzdHls ZS0+Ym9yZGVyUmlnaHRXaWR0aCgpICogMjsK 22979 2008-08-25 05:21:55 -0700 2010-06-10 15:57:03 -0700 fix paintBorder, add test and fix coding style paintBorder.patch text/plain 2594 mario.bensi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTkxNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDgtMDgtMjUgIE1hcmlvIEJlbnNpICA8bWJlbnNpQHBsZXlvLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgZml4IHBh aW50Qm9yZGVyIGluIFJlbmRlck9iamVjdCB3aGljaCBwYWludCB0d28gdGltZXMgdGhlIGNvcm5l cnMKKworICAgICAgICBXQVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENIQU5HRUQKKwor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyT2JqZWN0OjpwYWludEJvcmRlcik6IHJlbW92ZSB0aGUgYm9yZGVyIHdpZHRoIHdoZW4g dGhlIHBhaW50Qm9yZGVyIGRyYXcgdGhlIGxlZnQgYW5kIHJpZ3RoIHNpZGUuCisKIDIwMDgtMDgt MjUgIEhvbGdlciBIYW5zIFBldGVyIEZyZXl0aGVyICA8emVja2VAc2VsZmlzaC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgU2ltb24uCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJP YmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5j cHAJKHJldmlzaW9uIDM1OTE2KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTUxOCw5ICsxNTE4LDkgQEAgdm9pZCBSZW5kZXJPYmplY3Q6 OnBhaW50Qm9yZGVyKEdyYXBoaWNzQwogICAgICAgICAgICAgeSArPSB0b3BMZWZ0LmhlaWdodCgp OwogICAgICAgICAgICAgeTIgLT0gYm90dG9tTGVmdC5oZWlnaHQoKTsKICAgICAgICAgfQotCi0g ICAgICAgIGRyYXdCb3JkZXIoZ3JhcGhpY3NDb250ZXh0LCB0eCwgeSwgdHggKyBzdHlsZS0+Ym9y ZGVyTGVmdFdpZHRoKCksIHkyLCBCU0xlZnQsIGxjLCBzdHlsZS0+Y29sb3IoKSwgbHMsCi0gICAg ICAgICAgICAgICAgICAgaWdub3JlX3RvcCA/IDAgOiBzdHlsZS0+Ym9yZGVyVG9wV2lkdGgoKSwg aWdub3JlX2JvdHRvbSA/IDAgOiBzdHlsZS0+Ym9yZGVyQm90dG9tV2lkdGgoKSk7CisJaWYgKCh5 ICsgc3R5bGUtPmJvcmRlclRvcFdpZHRoKCkpIDw9ICh5MiAtIHN0eWxlLT5ib3JkZXJUb3BXaWR0 aCgpKSkKKyAgICAgICAgICAgIGRyYXdCb3JkZXIoZ3JhcGhpY3NDb250ZXh0LCB0eCwgeSArIHN0 eWxlLT5ib3JkZXJUb3BXaWR0aCgpLCB0eCArIHN0eWxlLT5ib3JkZXJMZWZ0V2lkdGgoKSwgeTIg LSBzdHlsZS0+Ym9yZGVyVG9wV2lkdGgoKSwgCisgICAgICAgICAgICAgICAgICAgICAgIEJTTGVm dCwgbGMsIHN0eWxlLT5jb2xvcigpLCBscywgaWdub3JlX3RvcCA/IDAgOiBzdHlsZS0+Ym9yZGVy VG9wV2lkdGgoKSwgaWdub3JlX2JvdHRvbSA/IDAgOiBzdHlsZS0+Ym9yZGVyQm90dG9tV2lkdGgo KSk7CiAKICAgICAgICAgaWYgKHJlbmRlclJhZGlpICYmICghdXBwZXJMZWZ0Qm9yZGVyU3R5bGVz TWF0Y2ggfHwgIWxvd2VyTGVmdEJvcmRlclN0eWxlc01hdGNoKSkgewogICAgICAgICAgICAgaW50 IHRvcFggPSB0eDsKQEAgLTE1ODgsOCArMTU4OCw5IEBAIHZvaWQgUmVuZGVyT2JqZWN0OjpwYWlu dEJvcmRlcihHcmFwaGljc0MKICAgICAgICAgICAgIHkyIC09IGJvdHRvbVJpZ2h0LmhlaWdodCgp OwogICAgICAgICB9CiAKLSAgICAgICAgZHJhd0JvcmRlcihncmFwaGljc0NvbnRleHQsIHR4ICsg dyAtIHN0eWxlLT5ib3JkZXJSaWdodFdpZHRoKCksIHksIHR4ICsgdywgeTIsIEJTUmlnaHQsIHJj LCBzdHlsZS0+Y29sb3IoKSwgcnMsCi0gICAgICAgICAgICAgICAgICAgaWdub3JlX3RvcCA/IDAg OiBzdHlsZS0+Ym9yZGVyVG9wV2lkdGgoKSwgaWdub3JlX2JvdHRvbSA/IDAgOiBzdHlsZS0+Ym9y ZGVyQm90dG9tV2lkdGgoKSk7CisgICAgICAgIGlmICgoeSArIHN0eWxlLT5ib3JkZXJUb3BXaWR0 aCgpKSA8PSAoeTIgLSBzdHlsZS0+Ym9yZGVyVG9wV2lkdGgoKSkpCisgICAgICAgICAgICBkcmF3 Qm9yZGVyKGdyYXBoaWNzQ29udGV4dCwgdHggKyB3IC0gc3R5bGUtPmJvcmRlclJpZ2h0V2lkdGgo KSwgeSArIHN0eWxlLT5ib3JkZXJUb3BXaWR0aCgpLCB0eCArIHcsIHkyIC0gc3R5bGUtPmJvcmRl clRvcFdpZHRoKCksIAorICAgICAgICAgICAgICAgICAgICAgICBCU1JpZ2h0LCByYywgc3R5bGUt PmNvbG9yKCksIHJzLCBpZ25vcmVfdG9wID8gMCA6IHN0eWxlLT5ib3JkZXJUb3BXaWR0aCgpLCBp Z25vcmVfYm90dG9tID8gMCA6IHN0eWxlLT5ib3JkZXJCb3R0b21XaWR0aCgpKTsKIAogICAgICAg ICBpZiAocmVuZGVyUmFkaWkgJiYgKCF1cHBlclJpZ2h0Qm9yZGVyU3R5bGVzTWF0Y2ggfHwgIWxv d2VyUmlnaHRCb3JkZXJTdHlsZXNNYXRjaCkpIHsKICAgICAgICAgICAgIHRoaWNrbmVzcyA9IHN0 eWxlLT5ib3JkZXJSaWdodFdpZHRoKCkgKiAyOwo= 23099 2008-09-01 06:20:58 -0700 2008-09-02 03:14:50 -0700 fix paintBorder in RenderObject and remove the bug on acid2 paintBorder.patch text/plain 3039 mario.bensi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNjAxMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTEgQEAKKzIwMDgtMDktMDEgIE1hcmlvIEJlbnNpICA8bWJlbnNpQHBsZXlvLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgZml4IHBh aW50Qm9yZGVyIGluIFJlbmRlck9iamVjdCB3aGljaCBwYWludCB0d28gdGltZXMgdGhlIGNvcm5l cnMKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyT2JqZWN0OjpwYWludEJvcmRlcikgOiByZW1vdmUgdGhlIGJvcmRlciB3aWR0 aCB3aGVuIHRoZSBwYWludEJvcmRlciBkcmF3IHRoZSBsZWZ0IGFuZCByaWd0aCBzaWRlLiAKKwog MjAwOC0wOS0wMSAgRGlyayBTY2h1bHplICA8dmJzODVAZ214LmRlPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCShy ZXZpc2lvbiAzNjAxMikKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTE1MTksOSArMTUxOSwxMiBAQCB2b2lkIFJlbmRlck9iamVjdDo6cGFp bnRCb3JkZXIoR3JhcGhpY3NDCiAgICAgICAgICAgICB5ICs9IHRvcExlZnQuaGVpZ2h0KCk7CiAg ICAgICAgICAgICB5MiAtPSBib3R0b21MZWZ0LmhlaWdodCgpOwogICAgICAgICB9Ci0KLSAgICAg ICAgZHJhd0JvcmRlcihncmFwaGljc0NvbnRleHQsIHR4LCB5LCB0eCArIHN0eWxlLT5ib3JkZXJM ZWZ0V2lkdGgoKSwgeTIsIEJTTGVmdCwgbGMsIHN0eWxlLT5jb2xvcigpLCBscywKLSAgICAgICAg ICAgICAgICAgICBpZ25vcmVfdG9wID8gMCA6IHN0eWxlLT5ib3JkZXJUb3BXaWR0aCgpLCBpZ25v cmVfYm90dG9tID8gMCA6IHN0eWxlLT5ib3JkZXJCb3R0b21XaWR0aCgpKTsKKyAgICAgICAgaWYg KCh5ICsgc3R5bGUtPmJvcmRlclRvcFdpZHRoKCkpIDw9ICh5MiAtIHN0eWxlLT5ib3JkZXJUb3BX aWR0aCgpKSkKKyAgICAgICAgICAgIGRyYXdCb3JkZXIoZ3JhcGhpY3NDb250ZXh0LCB0eCwgeSAr IHN0eWxlLT5ib3JkZXJUb3BXaWR0aCgpLCB0eCArIHN0eWxlLT5ib3JkZXJMZWZ0V2lkdGgoKSwg eTIgLSBzdHlsZS0+Ym9yZGVyVG9wV2lkdGgoKSwgCisgICAgICAgICAgICAgICAgICAgICAgIEJT TGVmdCwgbGMsIHN0eWxlLT5jb2xvcigpLCBscywgaWdub3JlX3RvcCA/IDAgOiBzdHlsZS0+Ym9y ZGVyVG9wV2lkdGgoKSwgaWdub3JlX2JvdHRvbSA/IDAgOiBzdHlsZS0+Ym9yZGVyQm90dG9tV2lk dGgoKSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIGRyYXdCb3JkZXIoZ3JhcGhpY3NDb250 ZXh0LCB0eCwgeSwgdHggKyBzdHlsZS0+Ym9yZGVyTGVmdFdpZHRoKCksIHkyLAorICAgICAgICAg ICAgICAgICAgICAgICBCU0xlZnQsIGxjLCBzdHlsZS0+Y29sb3IoKSwgbHMsIGlnbm9yZV90b3Ag PyAwIDogc3R5bGUtPmJvcmRlclRvcFdpZHRoKCksIGlnbm9yZV9ib3R0b20gPyAwIDogc3R5bGUt PmJvcmRlckJvdHRvbVdpZHRoKCkpOwogCiAgICAgICAgIGlmIChyZW5kZXJSYWRpaSAmJiAoIXVw cGVyTGVmdEJvcmRlclN0eWxlc01hdGNoIHx8ICFsb3dlckxlZnRCb3JkZXJTdHlsZXNNYXRjaCkp IHsKICAgICAgICAgICAgIGludCB0b3BYID0gdHg7CkBAIC0xNTg5LDggKzE1OTIsMTIgQEAgdm9p ZCBSZW5kZXJPYmplY3Q6OnBhaW50Qm9yZGVyKEdyYXBoaWNzQwogICAgICAgICAgICAgeTIgLT0g Ym90dG9tUmlnaHQuaGVpZ2h0KCk7CiAgICAgICAgIH0KIAotICAgICAgICBkcmF3Qm9yZGVyKGdy YXBoaWNzQ29udGV4dCwgdHggKyB3IC0gc3R5bGUtPmJvcmRlclJpZ2h0V2lkdGgoKSwgeSwgdHgg KyB3LCB5MiwgQlNSaWdodCwgcmMsIHN0eWxlLT5jb2xvcigpLCBycywKLSAgICAgICAgICAgICAg ICAgICBpZ25vcmVfdG9wID8gMCA6IHN0eWxlLT5ib3JkZXJUb3BXaWR0aCgpLCBpZ25vcmVfYm90 dG9tID8gMCA6IHN0eWxlLT5ib3JkZXJCb3R0b21XaWR0aCgpKTsKKyAgICAgICAgaWYgKCh5ICsg c3R5bGUtPmJvcmRlclRvcFdpZHRoKCkpIDw9ICh5MiAtIHN0eWxlLT5ib3JkZXJUb3BXaWR0aCgp KSkKKyAgICAgICAgICAgIGRyYXdCb3JkZXIoZ3JhcGhpY3NDb250ZXh0LCB0eCArIHcgLSBzdHls ZS0+Ym9yZGVyUmlnaHRXaWR0aCgpLCB5ICsgc3R5bGUtPmJvcmRlclRvcFdpZHRoKCksIHR4ICsg dywgeTIgLSBzdHlsZS0+Ym9yZGVyVG9wV2lkdGgoKSwgCisgICAgICAgICAgICAgICAgICAgICAg IEJTUmlnaHQsIHJjLCBzdHlsZS0+Y29sb3IoKSwgcnMsIGlnbm9yZV90b3AgPyAwIDogc3R5bGUt PmJvcmRlclRvcFdpZHRoKCksIGlnbm9yZV9ib3R0b20gPyAwIDogc3R5bGUtPmJvcmRlckJvdHRv bVdpZHRoKCkpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBkcmF3Qm9yZGVyKGdyYXBoaWNz Q29udGV4dCwgdHggKyB3IC0gc3R5bGUtPmJvcmRlclJpZ2h0V2lkdGgoKSwgeSwgdHggKyB3LCB5 MiwKKyAgICAgICAgICAgICAgICAgICAgICAgQlNSaWdodCwgcmMsIHN0eWxlLT5jb2xvcigpLCBy cywgaWdub3JlX3RvcCA/IDAgOiBzdHlsZS0+Ym9yZGVyVG9wV2lkdGgoKSwgaWdub3JlX2JvdHRv bSA/IDAgOiBzdHlsZS0+Ym9yZGVyQm90dG9tV2lkdGgoKSk7CiAKICAgICAgICAgaWYgKHJlbmRl clJhZGlpICYmICghdXBwZXJSaWdodEJvcmRlclN0eWxlc01hdGNoIHx8ICFsb3dlclJpZ2h0Qm9y ZGVyU3R5bGVzTWF0Y2gpKSB7CiAgICAgICAgICAgICB0aGlja25lc3MgPSBzdHlsZS0+Ym9yZGVy UmlnaHRXaWR0aCgpICogMjsK