204941 2019-12-06 03:17:54 -0800 [LFC][Integration] Support isLineBreak() in iterator 2019-12-06 06:35:19 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham commit-queue esprehn+autocc ews-watchlist glenn kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1596200 0 koivisto 2019-12-06 03:17:54 -0800 Wire it up. 1596201 1 384999 koivisto 2019-12-06 03:31:18 -0800 Created attachment 384999 patch 1596215 2 384999 zalan 2019-12-06 05:10:53 -0800 Comment on attachment 384999 patch View in context: https://bugs.webkit.org/attachment.cgi?id=384999&action=review > Source/WebCore/layout/displaytree/DisplayRun.h:101 > + bool isLineBreak() const { return layoutBox().isLineBreakBox() || (textContext() && textContext()->content() == "\n"); } && style().preserveNewline() We might need to start tracking type information in DisplayRuns. 1596219 3 385007 koivisto 2019-12-06 05:50:23 -0800 Created attachment 385007 patch 1596224 4 385007 commit-queue 2019-12-06 06:34:30 -0800 Comment on attachment 385007 patch Clearing flags on attachment: 385007 Committed r253204: <https://trac.webkit.org/changeset/253204> 1596225 5 commit-queue 2019-12-06 06:34:31 -0800 All reviewed patches have been landed. Closing bug. 1596226 6 webkit-bug-importer 2019-12-06 06:35:19 -0800 <rdar://problem/57697294> 384999 2019-12-06 03:31:18 -0800 2019-12-06 05:50:23 -0800 patch lfc-traversal-linebreak.patch text/plain 2606 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiMWZjYzY1OWUyZC4uY2I5OTVkODRkODEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0xMi0wNiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgW0xGQ11bSW50ZWdyYXRpb25dIFN1cHBvcnQgaXNMaW5lQnJlYWsoKSBpbiBp dGVyYXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjA0OTQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBsYXlvdXQvZGlzcGxheXRyZWUvRGlzcGxheVJ1bi5oOgorICAgICAgICAoV2ViQ29yZTo6RGlz cGxheTo6UnVuOjppc0xpbmVCcmVhayBjb25zdCk6CisgICAgICAgICogcmVuZGVyaW5nL2xpbmUv TGluZUxheW91dFRyYXZlcnNhbERpc3BsYXlSdW5QYXRoLmg6CisgICAgICAgIChXZWJDb3JlOjpM aW5lTGF5b3V0VHJhdmVyc2FsOjpEaXNwbGF5UnVuUGF0aDo6aXNMaW5lQnJlYWsgY29uc3QpOgor ICAgICAgICAoV2ViQ29yZTo6TGluZUxheW91dFRyYXZlcnNhbDo6RGlzcGxheVJ1blBhdGg6OnRy YXZlcnNlTmV4dFRleHRCb3hJblZpc3VhbE9yZGVyKToKKworICAgICAgICBBbHNvIHJlbW92ZSB1 bm5lZWRlZCBza2lwcGluZyBvZiBydW5zIHdpdGhvdXQgdGV4dCBjb250ZXh0LiBBbGwgcnVucyBn ZW5lcmF0ZWQgZnJvbSB0ZXh0IG5vZGVzIG5vdyBoYXZlIHRoZW0uCisKIDIwMTktMTItMDUgIFph bGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJRkNdIEZpeCBj c3MxL2Jhc2ljL2NvbnRhaW5tZW50Lmh0bWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9kaXNwbGF5dHJlZS9EaXNwbGF5UnVuLmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZGlz cGxheXRyZWUvRGlzcGxheVJ1bi5oCmluZGV4IDM3NzRiNmRiYTQ5Li40NTA4NDI0ZWYzMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Rpc3BsYXl0cmVlL0Rpc3BsYXlSdW4uaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZGlzcGxheXRyZWUvRGlzcGxheVJ1bi5oCkBAIC05 OCw2ICs5OCw4IEBAIHN0cnVjdCBSdW4gewogICAgIHZvaWQgc2V0SW1hZ2UoQ2FjaGVkSW1hZ2Um IGltYWdlKSB7IG1fY2FjaGVkSW1hZ2UgPSAmaW1hZ2U7IH0KICAgICBDYWNoZWRJbWFnZSogaW1h Z2UoKSBjb25zdCB7IHJldHVybiBtX2NhY2hlZEltYWdlOyB9CiAKKyAgICBib29sIGlzTGluZUJy ZWFrKCkgY29uc3QgeyByZXR1cm4gbGF5b3V0Qm94KCkuaXNMaW5lQnJlYWtCb3goKSB8fCAodGV4 dENvbnRleHQoKSAmJiB0ZXh0Q29udGV4dCgpLT5jb250ZW50KCkgPT0gIlxuIik7IH0KKwogICAg IGNvbnN0IExheW91dDo6Qm94JiBsYXlvdXRCb3goKSBjb25zdCB7IHJldHVybiAqbV9sYXlvdXRC b3g7IH0KICAgICBjb25zdCBSZW5kZXJTdHlsZSYgc3R5bGUoKSBjb25zdCB7IHJldHVybiBtX2xh eW91dEJveC0+c3R5bGUoKTsgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvbGluZS9MaW5lTGF5b3V0VHJhdmVyc2FsRGlzcGxheVJ1blBhdGguaCBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9saW5lL0xpbmVMYXlvdXRUcmF2ZXJzYWxEaXNwbGF5UnVuUGF0aC5oCmlu ZGV4IDljODE3ODcwYjgzLi5kMjAyNDFjN2FjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL2xpbmUvTGluZUxheW91dFRyYXZlcnNhbERpc3BsYXlSdW5QYXRoLmgKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL2xpbmUvTGluZUxheW91dFRyYXZlcnNhbERpc3BsYXlS dW5QYXRoLmgKQEAgLTYxLDcgKzYxLDcgQEAgcHVibGljOgogCiAgICAgYm9vbCBpc0xlZnRUb1Jp Z2h0RGlyZWN0aW9uKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQogICAgIGJvb2wgZGlyT3ZlcnJp ZGUoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQotICAgIGJvb2wgaXNMaW5lQnJlYWsoKSBjb25z dCB7IHJldHVybiBmYWxzZTsgfSAvLyBGSVhNRTogSW1wbGVtZW50LgorICAgIGJvb2wgaXNMaW5l QnJlYWsoKSBjb25zdCB7IHJldHVybiBydW4oKS5pc0xpbmVCcmVhaygpOyB9CiAKICAgICBib29s IGhhc0h5cGhlbigpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9IC8vIEZJWE1FOiBJbXBsZW1lbnQu CiAgICAgU3RyaW5nVmlldyB0ZXh0KCkgY29uc3QgeyByZXR1cm4gcnVuKCkudGV4dENvbnRleHQo KS0+Y29udGVudCgpOyB9CkBAIC04NSw4ICs4NSw2IEBAIHB1YmxpYzoKICAgICB7CiAgICAgICAg IEFTU0VSVCghYXRFbmQoKSk7CiAgICAgICAgICsrbV9ydW5JbmRleDsKLSAgICAgICAgd2hpbGUg KCFhdEVuZCgpICYmICFydW4oKS50ZXh0Q29udGV4dCgpKQotICAgICAgICAgICAgKyttX3J1bklu ZGV4OwogICAgIH0KICAgICB2b2lkIHRyYXZlcnNlTmV4dFRleHRCb3hJblRleHRPcmRlcigpIHsg IHRyYXZlcnNlTmV4dFRleHRCb3hJblZpc3VhbE9yZGVyKCk7IH0KIAo= 385007 2019-12-06 05:50:23 -0800 2019-12-06 06:34:30 -0800 patch lfc-traversal-linebreak-2.patch text/plain 2633 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiMWZjYzY1OWUyZC4uYjFmYzhmNmM3NWQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0xMi0wNiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgW0xGQ11bSW50ZWdyYXRpb25dIFN1cHBvcnQgaXNMaW5lQnJlYWsoKSBpbiBp dGVyYXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjA0OTQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgWmFsYW4gQnVqdGFzLgorCisgICAgICAgICog bGF5b3V0L2Rpc3BsYXl0cmVlL0Rpc3BsYXlSdW4uaDoKKyAgICAgICAgKFdlYkNvcmU6OkRpc3Bs YXk6OlJ1bjo6aXNMaW5lQnJlYWsgY29uc3QpOgorICAgICAgICAqIHJlbmRlcmluZy9saW5lL0xp bmVMYXlvdXRUcmF2ZXJzYWxEaXNwbGF5UnVuUGF0aC5oOgorICAgICAgICAoV2ViQ29yZTo6TGlu ZUxheW91dFRyYXZlcnNhbDo6RGlzcGxheVJ1blBhdGg6OmlzTGluZUJyZWFrIGNvbnN0KToKKyAg ICAgICAgKFdlYkNvcmU6OkxpbmVMYXlvdXRUcmF2ZXJzYWw6OkRpc3BsYXlSdW5QYXRoOjp0cmF2 ZXJzZU5leHRUZXh0Qm94SW5WaXN1YWxPcmRlcik6CisKKyAgICAgICAgQWxzbyByZW1vdmUgdW5u ZWVkZWQgc2tpcHBpbmcgb2YgcnVucyB3aXRob3V0IHRleHQgY29udGV4dC4gQWxsIHJ1bnMgZ2Vu ZXJhdGVkIGZyb20gdGV4dCBub2RlcyBub3cgaGF2ZSB0aGVtLgorCiAyMDE5LTEyLTA1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBGaXggY3Nz MS9iYXNpYy9jb250YWlubWVudC5odG1sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlv dXQvZGlzcGxheXRyZWUvRGlzcGxheVJ1bi5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Rpc3Bs YXl0cmVlL0Rpc3BsYXlSdW4uaAppbmRleCAzNzc0YjZkYmE0OS4uNDQ4ODExODhjMTggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9kaXNwbGF5dHJlZS9EaXNwbGF5UnVuLmgKKysr IGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Rpc3BsYXl0cmVlL0Rpc3BsYXlSdW4uaApAQCAtOTgs NiArOTgsOCBAQCBzdHJ1Y3QgUnVuIHsKICAgICB2b2lkIHNldEltYWdlKENhY2hlZEltYWdlJiBp bWFnZSkgeyBtX2NhY2hlZEltYWdlID0gJmltYWdlOyB9CiAgICAgQ2FjaGVkSW1hZ2UqIGltYWdl KCkgY29uc3QgeyByZXR1cm4gbV9jYWNoZWRJbWFnZTsgfQogCisgICAgYm9vbCBpc0xpbmVCcmVh aygpIGNvbnN0IHsgcmV0dXJuIGxheW91dEJveCgpLmlzTGluZUJyZWFrQm94KCkgfHwgKHRleHRD b250ZXh0KCkgJiYgdGV4dENvbnRleHQoKS0+Y29udGVudCgpID09ICJcbiIgJiYgc3R5bGUoKS5w cmVzZXJ2ZU5ld2xpbmUoKSk7IH0KKwogICAgIGNvbnN0IExheW91dDo6Qm94JiBsYXlvdXRCb3go KSBjb25zdCB7IHJldHVybiAqbV9sYXlvdXRCb3g7IH0KICAgICBjb25zdCBSZW5kZXJTdHlsZSYg c3R5bGUoKSBjb25zdCB7IHJldHVybiBtX2xheW91dEJveC0+c3R5bGUoKTsgfQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvbGluZS9MaW5lTGF5b3V0VHJhdmVyc2FsRGlz cGxheVJ1blBhdGguaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9saW5lL0xpbmVMYXlvdXRU cmF2ZXJzYWxEaXNwbGF5UnVuUGF0aC5oCmluZGV4IDljODE3ODcwYjgzLi5kMjAyNDFjN2FjYSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL2xpbmUvTGluZUxheW91dFRyYXZl cnNhbERpc3BsYXlSdW5QYXRoLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL2xpbmUv TGluZUxheW91dFRyYXZlcnNhbERpc3BsYXlSdW5QYXRoLmgKQEAgLTYxLDcgKzYxLDcgQEAgcHVi bGljOgogCiAgICAgYm9vbCBpc0xlZnRUb1JpZ2h0RGlyZWN0aW9uKCkgY29uc3QgeyByZXR1cm4g dHJ1ZTsgfQogICAgIGJvb2wgZGlyT3ZlcnJpZGUoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQot ICAgIGJvb2wgaXNMaW5lQnJlYWsoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfSAvLyBGSVhNRTog SW1wbGVtZW50LgorICAgIGJvb2wgaXNMaW5lQnJlYWsoKSBjb25zdCB7IHJldHVybiBydW4oKS5p c0xpbmVCcmVhaygpOyB9CiAKICAgICBib29sIGhhc0h5cGhlbigpIGNvbnN0IHsgcmV0dXJuIGZh bHNlOyB9IC8vIEZJWE1FOiBJbXBsZW1lbnQuCiAgICAgU3RyaW5nVmlldyB0ZXh0KCkgY29uc3Qg eyByZXR1cm4gcnVuKCkudGV4dENvbnRleHQoKS0+Y29udGVudCgpOyB9CkBAIC04NSw4ICs4NSw2 IEBAIHB1YmxpYzoKICAgICB7CiAgICAgICAgIEFTU0VSVCghYXRFbmQoKSk7CiAgICAgICAgICsr bV9ydW5JbmRleDsKLSAgICAgICAgd2hpbGUgKCFhdEVuZCgpICYmICFydW4oKS50ZXh0Q29udGV4 dCgpKQotICAgICAgICAgICAgKyttX3J1bkluZGV4OwogICAgIH0KICAgICB2b2lkIHRyYXZlcnNl TmV4dFRleHRCb3hJblRleHRPcmRlcigpIHsgIHRyYXZlcnNlTmV4dFRleHRCb3hJblZpc3VhbE9y ZGVyKCk7IH0KIAo=