204927 2019-12-05 16:07:32 -0800 Fix WebGL conformance test build_177_to_178.html with USE_ANGLE 2020-03-11 17:12:12 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 198948 1 jdarpinian jdarpinian achristensen commit-queue dino ews-watchlist graouts justin_fan kbr kondapallykalyan webkit-bug-importer oldest_to_newest 1596083 0 jdarpinian 2019-12-05 16:07:32 -0800 Fix WebGL conformance test build_177_to_178.html with USE_ANGLE 1596084 1 384972 jdarpinian 2019-12-05 16:10:24 -0800 Created attachment 384972 Fix WebGL conformance test build_177_to_178.html with USE_ANGLE 1596086 2 384973 jdarpinian 2019-12-05 16:15:10 -0800 Created attachment 384973 Don't disable extension for compileShaderDirect 1596440 3 kbr 2019-12-06 16:56:44 -0800 LGTM but I'm not a reviewer. Dean, Alex, possible to get your review of this? 1599541 4 384973 dino 2019-12-17 13:27:55 -0800 Comment on attachment 384973 Don't disable extension for compileShaderDirect View in context: https://bugs.webkit.org/attachment.cgi?id=384973&action=review > Source/WebCore/platform/graphics/angle/GraphicsContext3DANGLE.cpp:-822 > - compileShader(shader); Hopefully this method will go away soon (with an ANGLE backend) 1599578 5 384973 commit-queue 2019-12-17 15:17:53 -0800 Comment on attachment 384973 Don't disable extension for compileShaderDirect Clearing flags on attachment: 384973 Committed r253652: <https://trac.webkit.org/changeset/253652> 1599579 6 commit-queue 2019-12-17 15:17:55 -0800 All reviewed patches have been landed. Closing bug. 1599580 7 webkit-bug-importer 2019-12-17 15:18:30 -0800 <rdar://problem/58023728> 384972 2019-12-05 16:10:24 -0800 2019-12-05 16:15:09 -0800 Fix WebGL conformance test build_177_to_178.html with USE_ANGLE bug-204927-20191205161024.patch text/plain 1897 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzY3MGQ0ZTUwODAzZmY2 NDFkNjc3Yjc2NWMzNWE1YWFkNWFlMDIxNy4uZWYxMmI5MTFjZWVmYmI2MmY5ZTVmYTExOWY0YjRl Y2M2OWJlMDNmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTEyLTA1ICBKYW1l cyBEYXJwaW5pYW4gIDxqZGFycGluaWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggV2Vi R0wgY29uZm9ybWFuY2UgdGVzdCBidWlsZF8xNzdfdG9fMTc4Lmh0bWwgd2l0aCBVU0VfQU5HTEUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDkyNwor CisgICAgICAgIERpc2FibGUgQU5HTEVfdGV4dHVyZV9yZWN0YW5nbGUgd2hlbiBjb21waWxpbmcg dXNlciBzaGFkZXJzLgorICAgICAgICBUaGlzIG1pcnJvcnMgYSBjaGFuZ2UgSSBtYWRlIHRvIENo cm9taXVtIGhlcmU6CisgICAgICAgIGh0dHBzOi8vY2hyb21pdW0tcmV2aWV3Lmdvb2dsZXNvdXJj ZS5jb20vYy9jaHJvbWl1bS9zcmMvKy8xODQyMjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9HcmFwaGlj c0NvbnRleHQzREFOR0xFLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNE Ojpjb21waWxlU2hhZGVyKToKKwogMjAxOS0xMi0wNSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgogCiAgICAgICAgIFtJUENdIEZhaWwgQmFja0ZvcndhcmRJdGVtSWRlbnRpZmllciBk ZWNvZGluZyBpZiB0aGUgZGVjb2RlZCBpbnRlZ2VyIGlzIG5vdCBhIHZhbGlkIElECmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9HcmFwaGljc0NvbnRl eHQzREFOR0xFLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2FuZ2xlL0dy YXBoaWNzQ29udGV4dDNEQU5HTEUuY3BwCmluZGV4IDZiNWJlMTA0YmQwM2NhZDYzN2VjMjAyZTc5 MzkxZGZjMTM2ZDQ5MGEuLmQwYzljYjA3NTFmZDA1NWE2ZTY1MmQ1MWRhODU2MGQyNTI5MGI1ZTUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2FuZ2xlL0dyYXBo aWNzQ29udGV4dDNEQU5HTEUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2FuZ2xlL0dyYXBoaWNzQ29udGV4dDNEQU5HTEUuY3BwCkBAIC04MTQsNyArODE0LDEyIEBA IHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OmNvbXBpbGVTaGFkZXIoUGxhdGZvcm0zRE9iamVjdCBz aGFkZXIpCiB7CiAgICAgQVNTRVJUKHNoYWRlcik7CiAgICAgbWFrZUNvbnRleHRDdXJyZW50KCk7 CisgICAgLy8gV2UgbmVlZCB0aGlzIGV4dGVuc2lvbiB0byBzdXBwb3J0IElPU3VyZmFjZSBiYWNr YnVmZmVycywgYnV0IHdlCisgICAgLy8gZG9uJ3Qgd2FudCBpdCBleHBvc2VkIHRvIFdlYkdMIHVz ZXIgc2hhZGVycy4gVGVtcG9yYXJpbHkgZGlzYWJsZQorICAgIC8vIGl0IGR1cmluZyBzaGFkZXIg Y29tcGlsYXRpb24uCisgICAgZ2w6OkRpc2FibGVFeHRlbnNpb25BTkdMRSgiR0xfQU5HTEVfdGV4 dHVyZV9yZWN0YW5nbGUiKTsKICAgICBnbDo6Q29tcGlsZVNoYWRlcihzaGFkZXIpOworICAgIGds OjpSZXF1ZXN0RXh0ZW5zaW9uQU5HTEUoIkdMX0FOR0xFX3RleHR1cmVfcmVjdGFuZ2xlIik7CiB9 CiAKIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OmNvbXBpbGVTaGFkZXJEaXJlY3QoUGxhdGZvcm0z RE9iamVjdCBzaGFkZXIpCg== 384973 2019-12-05 16:15:10 -0800 2019-12-17 15:17:53 -0800 Don't disable extension for compileShaderDirect bug-204927-20191205161510.patch text/plain 2184 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzY3MGQ0ZTUwODAzZmY2 NDFkNjc3Yjc2NWMzNWE1YWFkNWFlMDIxNy4uZWYxMmI5MTFjZWVmYmI2MmY5ZTVmYTExOWY0YjRl Y2M2OWJlMDNmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTEyLTA1ICBKYW1l cyBEYXJwaW5pYW4gIDxqZGFycGluaWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggV2Vi R0wgY29uZm9ybWFuY2UgdGVzdCBidWlsZF8xNzdfdG9fMTc4Lmh0bWwgd2l0aCBVU0VfQU5HTEUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDkyNwor CisgICAgICAgIERpc2FibGUgQU5HTEVfdGV4dHVyZV9yZWN0YW5nbGUgd2hlbiBjb21waWxpbmcg dXNlciBzaGFkZXJzLgorICAgICAgICBUaGlzIG1pcnJvcnMgYSBjaGFuZ2UgSSBtYWRlIHRvIENo cm9taXVtIGhlcmU6CisgICAgICAgIGh0dHBzOi8vY2hyb21pdW0tcmV2aWV3Lmdvb2dsZXNvdXJj ZS5jb20vYy9jaHJvbWl1bS9zcmMvKy8xODQyMjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9HcmFwaGlj c0NvbnRleHQzREFOR0xFLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNE Ojpjb21waWxlU2hhZGVyKToKKwogMjAxOS0xMi0wNSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgogCiAgICAgICAgIFtJUENdIEZhaWwgQmFja0ZvcndhcmRJdGVtSWRlbnRpZmllciBk ZWNvZGluZyBpZiB0aGUgZGVjb2RlZCBpbnRlZ2VyIGlzIG5vdCBhIHZhbGlkIElECmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9HcmFwaGljc0NvbnRl eHQzREFOR0xFLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2FuZ2xlL0dy YXBoaWNzQ29udGV4dDNEQU5HTEUuY3BwCmluZGV4IDZiNWJlMTA0YmQwM2NhZDYzN2VjMjAyZTc5 MzkxZGZjMTM2ZDQ5MGEuLjk5ZmM5MmJhMGJiNjI0ZGYzMmE5NTM0MmM3MjQyOTQ3MTliYjU2MDMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2FuZ2xlL0dyYXBo aWNzQ29udGV4dDNEQU5HTEUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2FuZ2xlL0dyYXBoaWNzQ29udGV4dDNEQU5HTEUuY3BwCkBAIC04MTQsMTIgKzgxNCwxOSBA QCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjpjb21waWxlU2hhZGVyKFBsYXRmb3JtM0RPYmplY3Qg c2hhZGVyKQogewogICAgIEFTU0VSVChzaGFkZXIpOwogICAgIG1ha2VDb250ZXh0Q3VycmVudCgp OworICAgIC8vIFdlIG5lZWQgdGhpcyBleHRlbnNpb24gdG8gc3VwcG9ydCBJT1N1cmZhY2UgYmFj a2J1ZmZlcnMsIGJ1dCB3ZQorICAgIC8vIGRvbid0IHdhbnQgaXQgZXhwb3NlZCB0byBXZWJHTCB1 c2VyIHNoYWRlcnMuIFRlbXBvcmFyaWx5IGRpc2FibGUKKyAgICAvLyBpdCBkdXJpbmcgc2hhZGVy IGNvbXBpbGF0aW9uLgorICAgIGdsOjpEaXNhYmxlRXh0ZW5zaW9uQU5HTEUoIkdMX0FOR0xFX3Rl eHR1cmVfcmVjdGFuZ2xlIik7CiAgICAgZ2w6OkNvbXBpbGVTaGFkZXIoc2hhZGVyKTsKKyAgICBn bDo6UmVxdWVzdEV4dGVuc2lvbkFOR0xFKCJHTF9BTkdMRV90ZXh0dXJlX3JlY3RhbmdsZSIpOwog fQogCiB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjpjb21waWxlU2hhZGVyRGlyZWN0KFBsYXRmb3Jt M0RPYmplY3Qgc2hhZGVyKQogewotICAgIGNvbXBpbGVTaGFkZXIoc2hhZGVyKTsKKyAgICBBU1NF UlQoc2hhZGVyKTsKKyAgICBtYWtlQ29udGV4dEN1cnJlbnQoKTsKKyAgICBnbDo6Q29tcGlsZVNo YWRlcihzaGFkZXIpOwogfQogCiB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjpjb3B5VGV4SW1hZ2Uy RChHQzNEZW51bSB0YXJnZXQsIEdDM0RpbnQgbGV2ZWwsIEdDM0RlbnVtIGludGVybmFsZm9ybWF0 LCBHQzNEaW50IHgsIEdDM0RpbnQgeSwgR0MzRHNpemVpIHdpZHRoLCBHQzNEc2l6ZWkgaGVpZ2h0 LCBHQzNEaW50IGJvcmRlcikK