204925 2019-12-05 15:30:51 -0800 Custom analysis task page should allow schedule any triggerable accepted tests. 2019-12-06 18:22:14 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dewei_zhu dewei_zhu dewei_zhu rniwa oldest_to_newest 1596055 0 dewei_zhu 2019-12-05 15:30:51 -0800 Custom analysis task page should allow schedule any triggerable accepted tests. 1596056 1 384968 dewei_zhu 2019-12-05 15:35:35 -0800 Created attachment 384968 Patch 1596181 2 384968 rniwa 2019-12-06 01:19:18 -0800 Comment on attachment 384968 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384968&action=review > Websites/perf.webkit.org/public/v3/components/custom-analysis-task-configurator.js:227 > + const tests = [...acceptedTests].sort((testA, testB) => testA.fullName() > testB.fullName()) ; Nit: a whitespace between ) and ;. This isn't how sorting works in JavaScript. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort 1596350 3 385039 dewei_zhu 2019-12-06 13:53:50 -0800 Created attachment 385039 Patch 1596362 4 385039 dewei_zhu 2019-12-06 14:22:34 -0800 Comment on attachment 385039 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385039&action=review > Websites/perf.webkit.org/public/v3/components/custom-analysis-task-configurator.js:231 > + }) ; Forgot to fix the extra space. Will fix it in the final landing patch. 1596472 5 dewei_zhu 2019-12-06 18:21:48 -0800 Landed in r253220. 1596473 6 dewei_zhu 2019-12-06 18:22:14 -0800 rdar://problem/57436598 384968 2019-12-05 15:35:35 -0800 2019-12-06 13:53:49 -0800 Patch bug-204925-20191205153535.patch text/plain 2031 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMTc0CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCAzZGNjYzgxMGQxNWRmNGQzNjQ0MGUyNzlmZjI2NGY2ZGEzYzliZDU5Li5iN2Q2ZDNlNGNh YTBmZGQxNmEzNjhiZjk2YzM0ZDBlMWYwNDVjZDJlIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxOS0xMi0wNSAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICBDdXN0b20gYW5hbHlzaXMgdGFzayBwYWdlIHNob3VsZCBh bGxvdyBzY2hlZHVsZSBhbnkgdHJpZ2dlcmFibGUgYWNjZXB0ZWQgdGVzdHMuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ5MjUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYSBidWcgdGhhdCBzdWJ0 ZXN0IHdpbGwgbm90IHNob3cgb24gY3VzdG9tIGFuYWx5c2lzIHRhc2sgcGFnZSBpZiBib3RoIGl0 c2VsZiBhbmQgcGFyZW50IHRlc3QgYXJlCisgICAgICAgIGFjY2VwdGVkIGJ5IHRyaWdnZXJhYmxl LgorICAgICAgICBPcmRlciB0ZXN0IGxpc3QgaW4gYWxwaGFiZXRpY2FsIG9yZGVyLgorCisgICAg ICAgICogcHVibGljL3YzL2NvbXBvbmVudHMvY3VzdG9tLWFuYWx5c2lzLXRhc2stY29uZmlndXJh dG9yLmpzOgorICAgICAgICAoQ3VzdG9tQW5hbHlzaXNUYXNrQ29uZmlndXJhdG9yLnByb3RvdHlw ZS5fcmVuZGVyVHJpZ2dlcmFibGVUZXN0cyk6CisKIDIwMTktMTAtMjggIERld2VpIFpodSAgPGRl d2VpX3podUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGEgYnVnIHRoYXQgY2Fubm90IHVuaGlk ZSBhIHBsYXRmb3JtLgpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1Ymxp Yy92My9jb21wb25lbnRzL2N1c3RvbS1hbmFseXNpcy10YXNrLWNvbmZpZ3VyYXRvci5qcyBiL1dl YnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvY29tcG9uZW50cy9jdXN0b20tYW5hbHlz aXMtdGFzay1jb25maWd1cmF0b3IuanMKaW5kZXggZTJjNTM0MmQ3NTNiODdhOGExY2ZhZDUyZjVj MDRmNDZhZDg5ZjI2NC4uODgwODc4ZjMzNmU5ZDQ4NDY5NDZjYzAxMWIyMTBlZDZjZmFiYTM1OSAx MDA2NDQKLS0tIGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9jb21wb25lbnRz L2N1c3RvbS1hbmFseXNpcy10YXNrLWNvbmZpZ3VyYXRvci5qcworKysgYi9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvcHVibGljL3YzL2NvbXBvbmVudHMvY3VzdG9tLWFuYWx5c2lzLXRhc2stY29u ZmlndXJhdG9yLmpzCkBAIC0yMjQsOCArMjI0LDcgQEAgY2xhc3MgQ3VzdG9tQW5hbHlzaXNUYXNr Q29uZmlndXJhdG9yIGV4dGVuZHMgQ29tcG9uZW50QmFzZSB7CiAgICAgICAgICAgICBmb3IgKGNv bnN0IHRlc3Qgb2YgdHJpZ2dlcmFibGUuYWNjZXB0ZWRUZXN0cygpKQogICAgICAgICAgICAgICAg IGFjY2VwdGVkVGVzdHMuYWRkKHRlc3QpOwogICAgICAgICB9Ci0KLSAgICAgICAgbGV0IHRlc3Rz ID0gVGVzdC5hbGwoKS5maWx0ZXIoKHRlc3QpID0+IGFjY2VwdGVkVGVzdHMuaGFzKHRlc3QpICYm ICghdGVzdC5wYXJlbnRUZXN0KCkgfHwgIWFjY2VwdGVkVGVzdHMuaGFzKHRlc3QucGFyZW50VGVz dCgpKSkpOworICAgICAgICBjb25zdCB0ZXN0cyA9IFsuLi5hY2NlcHRlZFRlc3RzXS5zb3J0KCh0 ZXN0QSwgdGVzdEIpID0+IHRlc3RBLmZ1bGxOYW1lKCkgPiB0ZXN0Qi5mdWxsTmFtZSgpKSA7CiAg ICAgICAgIHJldHVybiB0aGlzLl9yZW5kZXJSYWRpb0J1dHRvbkxpc3QodGhpcy5jb250ZW50KCd0 ZXN0LWxpc3QnKSwgJ3Rlc3QnLCB0ZXN0cywgdGhpcy5zZWxlY3RUZXN0cy5iaW5kKHRoaXMpLCAo dGVzdCkgPT4gdGVzdC5mdWxsTmFtZSgpKTsKICAgICB9CiAK 385039 2019-12-06 13:53:50 -0800 2019-12-06 14:07:21 -0800 Patch bug-204925-20191206135350.patch text/plain 2157 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMTc0CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCAzZGNjYzgxMGQxNWRmNGQzNjQ0MGUyNzlmZjI2NGY2ZGEzYzliZDU5Li5iN2Q2ZDNlNGNh YTBmZGQxNmEzNjhiZjk2YzM0ZDBlMWYwNDVjZDJlIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxOS0xMi0wNSAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICBDdXN0b20gYW5hbHlzaXMgdGFzayBwYWdlIHNob3VsZCBh bGxvdyBzY2hlZHVsZSBhbnkgdHJpZ2dlcmFibGUgYWNjZXB0ZWQgdGVzdHMuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ5MjUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYSBidWcgdGhhdCBzdWJ0 ZXN0IHdpbGwgbm90IHNob3cgb24gY3VzdG9tIGFuYWx5c2lzIHRhc2sgcGFnZSBpZiBib3RoIGl0 c2VsZiBhbmQgcGFyZW50IHRlc3QgYXJlCisgICAgICAgIGFjY2VwdGVkIGJ5IHRyaWdnZXJhYmxl LgorICAgICAgICBPcmRlciB0ZXN0IGxpc3QgaW4gYWxwaGFiZXRpY2FsIG9yZGVyLgorCisgICAg ICAgICogcHVibGljL3YzL2NvbXBvbmVudHMvY3VzdG9tLWFuYWx5c2lzLXRhc2stY29uZmlndXJh dG9yLmpzOgorICAgICAgICAoQ3VzdG9tQW5hbHlzaXNUYXNrQ29uZmlndXJhdG9yLnByb3RvdHlw ZS5fcmVuZGVyVHJpZ2dlcmFibGVUZXN0cyk6CisKIDIwMTktMTAtMjggIERld2VpIFpodSAgPGRl d2VpX3podUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGEgYnVnIHRoYXQgY2Fubm90IHVuaGlk ZSBhIHBsYXRmb3JtLgpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1Ymxp Yy92My9jb21wb25lbnRzL2N1c3RvbS1hbmFseXNpcy10YXNrLWNvbmZpZ3VyYXRvci5qcyBiL1dl YnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvY29tcG9uZW50cy9jdXN0b20tYW5hbHlz aXMtdGFzay1jb25maWd1cmF0b3IuanMKaW5kZXggZTJjNTM0MmQ3NTNiODdhOGExY2ZhZDUyZjVj MDRmNDZhZDg5ZjI2NC4uZDY2MGRiZDNhOTNiYzZiZmMzY2ZjMDMyYmEzMzVlMTMxMDBlZGY0MiAx MDA2NDQKLS0tIGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9jb21wb25lbnRz L2N1c3RvbS1hbmFseXNpcy10YXNrLWNvbmZpZ3VyYXRvci5qcworKysgYi9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvcHVibGljL3YzL2NvbXBvbmVudHMvY3VzdG9tLWFuYWx5c2lzLXRhc2stY29u ZmlndXJhdG9yLmpzCkBAIC0yMjQsOCArMjI0LDExIEBAIGNsYXNzIEN1c3RvbUFuYWx5c2lzVGFz a0NvbmZpZ3VyYXRvciBleHRlbmRzIENvbXBvbmVudEJhc2UgewogICAgICAgICAgICAgZm9yIChj b25zdCB0ZXN0IG9mIHRyaWdnZXJhYmxlLmFjY2VwdGVkVGVzdHMoKSkKICAgICAgICAgICAgICAg ICBhY2NlcHRlZFRlc3RzLmFkZCh0ZXN0KTsKICAgICAgICAgfQotCi0gICAgICAgIGxldCB0ZXN0 cyA9IFRlc3QuYWxsKCkuZmlsdGVyKCh0ZXN0KSA9PiBhY2NlcHRlZFRlc3RzLmhhcyh0ZXN0KSAm JiAoIXRlc3QucGFyZW50VGVzdCgpIHx8ICFhY2NlcHRlZFRlc3RzLmhhcyh0ZXN0LnBhcmVudFRl c3QoKSkpKTsKKyAgICAgICAgY29uc3QgdGVzdHMgPSBbLi4uYWNjZXB0ZWRUZXN0c10uc29ydCgo dGVzdEEsIHRlc3RCKSA9PiB7CisgICAgICAgICAgICBpZiAodGVzdEEuZnVsbE5hbWUoKSA9PSB0 ZXN0Qi5mdWxsTmFtZSgpKQorICAgICAgICAgICAgICAgIHJldHVybiAwOworICAgICAgICAgICAg cmV0dXJuIHRlc3RBLmZ1bGxOYW1lKCkgPCB0ZXN0Qi5mdWxsTmFtZSgpID8gLTEgOiAxOworICAg ICAgICB9KSA7CiAgICAgICAgIHJldHVybiB0aGlzLl9yZW5kZXJSYWRpb0J1dHRvbkxpc3QodGhp cy5jb250ZW50KCd0ZXN0LWxpc3QnKSwgJ3Rlc3QnLCB0ZXN0cywgdGhpcy5zZWxlY3RUZXN0cy5i aW5kKHRoaXMpLCAodGVzdCkgPT4gdGVzdC5mdWxsTmFtZSgpKTsKICAgICB9CiAK