204924 2019-12-05 15:14:19 -0800 Fix inspector/css test assertions after r253158 2019-12-05 15:30:25 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204902 InRadar P2 Normal --- 1 simon.fraser simon.fraser ews-watchlist hi joepeck keith_miller mark.lam msaboff saam simon.fraser tzagallo webkit-bug-importer oldest_to_newest 1596045 0 simon.fraser 2019-12-05 15:14:19 -0800 Fix inspector/css test assertions after r253158 1596046 1 384967 simon.fraser 2019-12-05 15:14:58 -0800 Created attachment 384967 Patch 1596047 2 ews-watchlist 2019-12-05 15:16:08 -0800 This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features. 1596048 3 384967 hi 2019-12-05 15:20:52 -0800 Comment on attachment 384967 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384967&action=review r=me, with one additional fix > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Oops. > Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js:754 > + Highlight: "highlight", In addition to this, I think the only thing that's necessary for the Web Inspector frontend to handle this is adding the following to `WI.CSSManager.displayNameForPseudoId`: ``` case CSSManager.PseudoSelectorNames.Highlight: return WI.unlocalizedString("::highlight"); ``` Without this, the Web Inspector frontend would log an error to the console. I'd rather fix both the backend `ASSERT` and any frontend requirements at the same time. It's not necessary to add it to the switch-case inside the `if (!InspectorBackend.Enum.CSS.PseudoId)` as that's only used for compatibility purposes when inspecting older webpages, meaning that path won't be taken when inspecting a page that has `PseudoId::Highlight` defined. 1596052 4 simon.fraser 2019-12-05 15:29:19 -0800 https://trac.webkit.org/changeset/253176/webkit 1596053 5 webkit-bug-importer 2019-12-05 15:30:25 -0800 <rdar://problem/57679991> 384967 2019-12-05 15:14:58 -0800 2019-12-05 15:20:52 -0800 Patch bug-204924-20191205151457.patch text/plain 4132 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh NzlkYWIwNGVhNzgyNDU4OTM2ZWYzZDY4NjMxYmQxMjE2ZGRkNmYyLi43NzYwZTZiNDY5NDBkMjEy ZGEwNTE4MjhlN2UwYWYzMTE1YWYzYmUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOS0xMi0wNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxl LmNvbT4KKworICAgICAgICBGaXggaW5zcGVjdG9yL2NzcyB0ZXN0IGFzc2VydGlvbnMgYWZ0ZXIg cjI1MzE1OCAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwNDkyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAK KyAgICAgICAgVGVhY2ggdGhlIGluc3BlY3RvciBwcm90b2NvbCBhYm91dCB0aGUgOjpoaWdobGln aHQgcHNldWRvZWxlbWVudC4KKworICAgICAgICAqIGluc3BlY3Rvci9wcm90b2NvbC9DU1MuanNv bjoKKwogMjAxOS0xMi0wNCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAg ICAgICAgIFtKU0NdIEFJIHNob3VsZCBjb252ZXJ0IElzQ2VsbFdpdGhUeXBlIHRvIGNvbnN0YW50 IHdoZW4gU3RydWN0dXJlIHNldCBpcyBmaW5pdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkMTEwYzI5YjZmODAx ZmZiZjY1YTE2NzUxODU3ZDg0N2JiZTQ0N2E3Li4xNzI3N2EwYjhlMmE5MDg4ODAwYWRhNDQ3NjNl ZjlmNzE0NDQyNmQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMTItMDUgIFNp bW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGluc3Bl Y3Rvci9jc3MgdGVzdCBhc3NlcnRpb25zIGFmdGVyIHIyNTMxNTggCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ5MjQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKwor ICAgICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ1NTQWdlbnQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6cHJvdG9jb2xWYWx1ZUZvclBzZXVkb0lkKToKKwogMjAxOS0xMi0wNSAgWmFs YW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lGQ10gVHJpbSB0 cmFpbGluZyBsZXR0ZXItc3BhY2luZyBhdCBpbmxpbmUgY29udGFpbmVyIGJvdW5kYXJ5CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL0NoYW5nZUxvZwppbmRleCA3OGRjZTZhNDc1YTEwOWU3OGI5MzAyODhkZDI3ZGQ5N2Mx Mjk0MWQ0Li41N2E4ZGNmMzc5MThiYTBlYjBlZTQ4NGRkMjg1NTdiNjgwN2E4NTZjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxOS0xMi0wNSAgU2ltb24gRnJh c2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggaW5zcGVjdG9yL2Nz cyB0ZXN0IGFzc2VydGlvbnMgYWZ0ZXIgcjI1MzE1OCAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDkyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Db250cm9sbGVycy9DU1NN YW5hZ2VyLmpzOgorCiAyMDE5LTEyLTA0ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGFsbG93IGluc3BlY3RvciB0byBwYXVz ZSBwcm92aXNpb25hbCBwYWdlIGxvYWQgYW5kIHJlc3RvcmUgaXRzIHN0YXRlCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL0NTUy5qc29uIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9wcm90b2NvbC9DU1MuanNvbgppbmRleCBmZDEy MTE2MTkyNzdmMzhkZDYwY2QwOWI0OTljN2U4NzU3ZjcyNGM5Li5mODQ3MDIxMWUyMDc4Zjg0Mzk1 ODNkMTg5MzAzZDhjM2FlZGU0MmYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aW5zcGVjdG9yL3Byb3RvY29sL0NTUy5qc29uCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnNwZWN0b3IvcHJvdG9jb2wvQ1NTLmpzb24KQEAgLTM4LDYgKzM4LDcgQEAKICAgICAgICAgICAg ICJlbnVtIjogWwogICAgICAgICAgICAgICAgICJmaXJzdC1saW5lIiwKICAgICAgICAgICAgICAg ICAiZmlyc3QtbGV0dGVyIiwKKyAgICAgICAgICAgICAgICAiaGlnaGxpZ2h0IiwKICAgICAgICAg ICAgICAgICAibWFya2VyIiwKICAgICAgICAgICAgICAgICAiYmVmb3JlIiwKICAgICAgICAgICAg ICAgICAiYWZ0ZXIiLApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2FnZW50 cy9JbnNwZWN0b3JDU1NBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRz L0luc3BlY3RvckNTU0FnZW50LmNwcAppbmRleCA0N2Q1OTMzMTlmZGUxNmFkZTQ3NDI5MzI2MTBj ZTlhNTA5MTdjMmQxLi40ZmRhMjI0NmQ3OGQyYjQ3NWNlNzc2MjRmOWJjNWJjODZlYmRiOWY1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckNTU0Fn ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckNT U0FnZW50LmNwcApAQCAtNDQyLDYgKzQ0Miw4IEBAIHN0YXRpYyBPcHRpb25hbDxJbnNwZWN0b3I6 OlByb3RvY29sOjpDU1M6OlBzZXVkb0lkPiBwcm90b2NvbFZhbHVlRm9yUHNldWRvSWQoUHNlCiAg ICAgICAgIHJldHVybiBJbnNwZWN0b3I6OlByb3RvY29sOjpDU1M6OlBzZXVkb0lkOjpBZnRlcjsK ICAgICBjYXNlIFBzZXVkb0lkOjpTZWxlY3Rpb246CiAgICAgICAgIHJldHVybiBJbnNwZWN0b3I6 OlByb3RvY29sOjpDU1M6OlBzZXVkb0lkOjpTZWxlY3Rpb247CisgICAgY2FzZSBQc2V1ZG9JZDo6 SGlnaGxpZ2h0OgorICAgICAgICByZXR1cm4gSW5zcGVjdG9yOjpQcm90b2NvbDo6Q1NTOjpQc2V1 ZG9JZDo6SGlnaGxpZ2h0OwogICAgIGNhc2UgUHNldWRvSWQ6OlNjcm9sbGJhcjoKICAgICAgICAg cmV0dXJuIEluc3BlY3Rvcjo6UHJvdG9jb2w6OkNTUzo6UHNldWRvSWQ6OlNjcm9sbGJhcjsKICAg ICBjYXNlIFBzZXVkb0lkOjpTY3JvbGxiYXJUaHVtYjoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NTU01hbmFnZXIuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9DU1NNYW5hZ2VyLmpz CmluZGV4IGMwNDk1MDgyZDY5NDVmZGJmMjZlYWNkMWZlM2I1OWRiZjI2MjI3ZWQuLjY1MGI3NzU2 MDc5NmUyMTBkNmE1NjMwMDRkOTliYjI0YTU3ZThlYjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NTU01hbmFnZXIuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ1NTTWFuYWdl ci5qcwpAQCAtNzUxLDYgKzc1MSw3IEBAIFdJLkNTU01hbmFnZXIuUHNldWRvU2VsZWN0b3JOYW1l cyA9IHsKICAgICBCZWZvcmU6ICJiZWZvcmUiLAogICAgIEZpcnN0TGV0dGVyOiAiZmlyc3QtbGV0 dGVyIiwKICAgICBGaXJzdExpbmU6ICJmaXJzdC1saW5lIiwKKyAgICBIaWdobGlnaHQ6ICJoaWdo bGlnaHQiLAogICAgIE1hcmtlcjogIm1hcmtlciIsCiAgICAgUmVzaXplcjogInJlc2l6ZXIiLAog ICAgIFNjcm9sbGJhcjogInNjcm9sbGJhciIsCg==