204902 2019-12-05 11:12:27 -0800 Add CSS parser support for the highlight pseudoelement 2019-12-06 15:24:01 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204924 InRadar P2 Normal --- 204903 1 simon.fraser simon.fraser allan.jensen darin esprehn+autocc ews-watchlist glenn gyuyoung.kim koivisto kondapallykalyan macpherson megan_gardner menard pdr simon.fraser webkit-bug-importer oldest_to_newest 1595893 0 simon.fraser 2019-12-05 11:12:27 -0800 Add CSS parser support for the highlight pseudoelement 1595897 1 384924 simon.fraser 2019-12-05 11:13:39 -0800 Created attachment 384924 Patch 1595902 2 simon.fraser 2019-12-05 11:29:54 -0800 https://trac.webkit.org/changeset/253158/webkit 1595903 3 webkit-bug-importer 2019-12-05 11:30:27 -0800 <rdar://problem/57670974> 1596308 4 384924 darin 2019-12-06 12:04:54 -0800 Comment on attachment 384924 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384924&action=review > Source/WebCore/rendering/style/RenderStyleConstants.h:85 > -enum class PseudoId : uint8_t { > +enum class PseudoId : uint16_t { What’s the rationale for this change? 1596341 5 simon.fraser 2019-12-06 13:45:01 -0800 (In reply to Darin Adler from comment #4) > Comment on attachment 384924 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384924&action=review > > > Source/WebCore/rendering/style/RenderStyleConstants.h:85 > > -enum class PseudoId : uint8_t { > > +enum class PseudoId : uint16_t { > > What’s the rationale for this change? Compiler was telling me that uint8_t wasn't big enough at the: PublicPseudoIdMask = ((1 << FirstInternalPseudoId) - 1) & ~((1 << FirstPublicPseudoId) - 1) line, but maybe I need to fix that bitmasking instead. 1596347 6 384924 darin 2019-12-06 13:51:44 -0800 Comment on attachment 384924 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384924&action=review >>> Source/WebCore/rendering/style/RenderStyleConstants.h:85 >>> +enum class PseudoId : uint16_t { >> >> What’s the rationale for this change? > > Compiler was telling me that uint8_t wasn't big enough at the: > PublicPseudoIdMask = ((1 << FirstInternalPseudoId) - 1) & ~((1 << FirstPublicPseudoId) - 1) > line, but maybe I need to fix that bitmasking instead. Looks to me like the issue is that PublicPseudoIdMask should not be a PseudoId value. It’s mask for use when these PseudoId values are used as bit numbers, not one of the PseudoId values. So we should move it out of the enum class. 1596402 7 simon.fraser 2019-12-06 15:24:01 -0800 Yeah I'll do that. 384924 2019-12-05 11:13:39 -0800 2019-12-05 11:17:01 -0800 Patch bug-204902-20191205111339.patch text/plain 5360 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWMxYTdkZDA1ZmJlNjJk M2E4ZDI3MGEzZGYxZTdkZGEzMTEyODFkMS4uMWRkNTVhYThiN2EyMzQwM2Q5YTQ5NTliNmIzMGJi MTUyMjNhYzJjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTEyLTA1ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBDU1MgcGFy c2VyIHN1cHBvcnQgZm9yIHRoZSBoaWdobGlnaHQgcHNldWRvZWxlbWVudAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0OTAyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGJhc2ljIENTUyBwYXJzaW5n IHN1cHBvcnQgZm9yIDo6aGlnaGxpZ2h0KCksIHBlcgorICAgICAgICBodHRwczovL2dpdGh1Yi5j b20vTWljcm9zb2Z0RWRnZS9NU0VkZ2VFeHBsYWluZXJzL2Jsb2IvbWFzdGVyL2hpZ2hsaWdodC9l eHBsYWluZXIubWQKKworICAgICAgICAqIGNzcy9DU1NTZWxlY3Rvci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDU1NTZWxlY3Rvcjo6cHNldWRvSWQpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTU2Vs ZWN0b3I6OnBhcnNlUHNldWRvRWxlbWVudFR5cGUpOgorICAgICAgICAqIGNzcy9DU1NTZWxlY3Rv ci5oOgorICAgICAgICAqIGNzcy9TZWxlY3RvclBzZXVkb0VsZW1lbnRUeXBlTWFwLmluOgorICAg ICAgICAqIGNzcy9wYXJzZXIvQ1NTU2VsZWN0b3JQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Q1NTU2VsZWN0b3JQYXJzZXI6OmNvbnN1bWVQc2V1ZG8pOgorICAgICAgICAqIHJlbmRlcmlu Zy9zdHlsZS9SZW5kZXJTdHlsZUNvbnN0YW50cy5oOgorCiAyMDE5LTEyLTA0ICBMb3VpZSBMaXZv bi1CZW1lbCAgPGxsaXZvbmJlbWVsQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgZXhjbHVzaW9u IHJ1bGUgZm9yIHRleHQgbWFuaXB1bGF0aW9uIFNQSSB0byBleGNsdWRlIGJhc2VkIG9uIGVsZW1l bnQgY2xhc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3IuY3BwCmluZGV4IDMwYWY5MWUyNzIwMmYw MDJiOGEzMDY5Y2E4YzU2ZDkxNDEzMmY0ZDAuLmNhOTg5ZGQ4ZDYzMTA1YmNhNDMwZjcwY2EyZmI5 NzM2OGY1NDdiMTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmNwcApAQCAtMjc1LDYgKzI3 NSw4IEBAIFBzZXVkb0lkIENTU1NlbGVjdG9yOjpwc2V1ZG9JZChQc2V1ZG9FbGVtZW50VHlwZSB0 eXBlKQogICAgICAgICByZXR1cm4gUHNldWRvSWQ6OkZpcnN0TGV0dGVyOwogICAgIGNhc2UgUHNl dWRvRWxlbWVudFNlbGVjdGlvbjoKICAgICAgICAgcmV0dXJuIFBzZXVkb0lkOjpTZWxlY3Rpb247 CisgICAgY2FzZSBQc2V1ZG9FbGVtZW50SGlnaGxpZ2h0OgorICAgICAgICByZXR1cm4gUHNldWRv SWQ6OkhpZ2hsaWdodDsKICAgICBjYXNlIFBzZXVkb0VsZW1lbnRNYXJrZXI6CiAgICAgICAgIHJl dHVybiBQc2V1ZG9JZDo6TWFya2VyOwogICAgIGNhc2UgUHNldWRvRWxlbWVudEJlZm9yZToKQEAg LTMxNCwxMSArMzE2LDE2IEBAIENTU1NlbGVjdG9yOjpQc2V1ZG9FbGVtZW50VHlwZSBDU1NTZWxl Y3Rvcjo6cGFyc2VQc2V1ZG9FbGVtZW50VHlwZShTdHJpbmdWaWV3IG5hCiB7CiAgICAgaWYgKG5h bWUuaXNOdWxsKCkpCiAgICAgICAgIHJldHVybiBQc2V1ZG9FbGVtZW50VW5rbm93bjsKKwogICAg IGF1dG8gdHlwZSA9IHBhcnNlUHNldWRvRWxlbWVudFN0cmluZyhuYW1lKTsKICAgICBpZiAodHlw ZSA9PSBQc2V1ZG9FbGVtZW50VW5rbm93bikgewogICAgICAgICBpZiAobmFtZS5zdGFydHNXaXRo KCItd2Via2l0LSIpKQogICAgICAgICAgICAgdHlwZSA9IFBzZXVkb0VsZW1lbnRXZWJLaXRDdXN0 b207CiAgICAgfQorCisgICAgaWYgKHR5cGUgPT0gUHNldWRvRWxlbWVudEhpZ2hsaWdodCAmJiAh UnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVyZXMoKS5oaWdobGlnaHRBUElFbmFi bGVkKCkpCisgICAgICAgIHJldHVybiBQc2V1ZG9FbGVtZW50VW5rbm93bjsKKwogICAgIGlmICh0 eXBlID09IFBzZXVkb0VsZW1lbnRQYXJ0ICYmICFSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFy ZWRGZWF0dXJlcygpLmNzc1NoYWRvd1BhcnRzRW5hYmxlZCgpKQogICAgICAgICByZXR1cm4gUHNl dWRvRWxlbWVudFVua25vd247CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NT ZWxlY3Rvci5oIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmgKaW5kZXggZWEyYzEw MjgxZDIzOWQ3N2U1N2UzYzIwMjYxN2E4YTlhYmEyZDAwZS4uZjRjMzM1ZjQyMTQxNjExZGVlNzVm YmZjNWVkN2U1MTBhZWVlMjY5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1Nl bGVjdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmgKQEAgLTE4MSw2 ICsxODEsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAjZW5kaWYKICAgICAgICAgICAgIFBzZXVk b0VsZW1lbnRGaXJzdExldHRlciwKICAgICAgICAgICAgIFBzZXVkb0VsZW1lbnRGaXJzdExpbmUs CisgICAgICAgICAgICBQc2V1ZG9FbGVtZW50SGlnaGxpZ2h0LAogICAgICAgICAgICAgUHNldWRv RWxlbWVudE1hcmtlciwKICAgICAgICAgICAgIFBzZXVkb0VsZW1lbnRQYXJ0LAogICAgICAgICAg ICAgUHNldWRvRWxlbWVudFJlc2l6ZXIsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv U2VsZWN0b3JQc2V1ZG9FbGVtZW50VHlwZU1hcC5pbiBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxl Y3RvclBzZXVkb0VsZW1lbnRUeXBlTWFwLmluCmluZGV4IGMwN2RiODM1YzdlZWJjOGJhNjljNTQw NWY0YzkwMTMzZDk4YjZhOTUuLmE3YmNjMTBkZmMxZjZjMjU2YmIyNzBlMDY1ZDI2ZmVhMTU4OTMy MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvclBzZXVkb0VsZW1lbnRU eXBlTWFwLmluCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvclBzZXVkb0VsZW1lbnRU eXBlTWFwLmluCkBAIC01LDYgKzUsNyBAQCBjdWUKICNlbmRpZgogZmlyc3QtbGV0dGVyCiBmaXJz dC1saW5lCitoaWdobGlnaHQKIG1hcmtlcgogcGFydAogcGxhY2Vob2xkZXIsIFBzZXVkb0VsZW1l bnRXZWJLaXRDdXN0b20KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NT U2VsZWN0b3JQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NTZWxlY3Rv clBhcnNlci5jcHAKaW5kZXggOTczNjNlNjhjYWE4ZGJkNzY3ZjQ4M2Q4OGIwNjFlNTIwZmI5NjM5 NC4uNTM4ZmYxMGE0ZWViYTBhNWZjMDQ5ZWJjOTU1MDQ0MmIxZTZhNjVhYiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NTZWxlY3RvclBhcnNlci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NTZWxlY3RvclBhcnNlci5jcHAKQEAgLTYxMSw3ICs2 MTEsNiBAQCBzdGQ6OnVuaXF1ZV9wdHI8Q1NTUGFyc2VyU2VsZWN0b3I+IENTU1NlbGVjdG9yUGFy c2VyOjpjb25zdW1lUHNldWRvKENTU1BhcnNlclRvawogICAgICAgICBkZWZhdWx0OgogICAgICAg ICAgICAgYnJlYWs7CiAgICAgICAgIH0KLQogICAgIH0KICAgICAKICAgICBpZiAoc2VsZWN0b3It Pm1hdGNoKCkgPT0gQ1NTU2VsZWN0b3I6OlBzZXVkb0VsZW1lbnQpIHsKQEAgLTYyNyw2ICs2MjYs MTcgQEAgc3RkOjp1bmlxdWVfcHRyPENTU1BhcnNlclNlbGVjdG9yPiBDU1NTZWxlY3RvclBhcnNl cjo6Y29uc3VtZVBzZXVkbyhDU1NQYXJzZXJUb2sKICAgICAgICAgICAgIHJldHVybiBzZWxlY3Rv cjsKICAgICAgICAgfQogI2VuZGlmCisgICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlBzZXVkb0Vs ZW1lbnRIaWdobGlnaHQ6IHsKKyAgICAgICAgICAgIERpc2FsbG93UHNldWRvRWxlbWVudHNTY29w ZSBzY29wZSh0aGlzKTsKKworICAgICAgICAgICAgYXV0byYgaWRlbnQgPSBibG9jay5jb25zdW1l SW5jbHVkaW5nV2hpdGVzcGFjZSgpOworICAgICAgICAgICAgaWYgKGlkZW50LnR5cGUoKSAhPSBJ ZGVudFRva2VuKQorICAgICAgICAgICAgICAgIHJldHVybiBudWxscHRyOworCisgICAgICAgICAg ICBhdXRvIGFyZ3VtZW50TGlzdCA9IG1ha2VVbmlxdWU8VmVjdG9yPEF0b21TdHJpbmc+PigpOwor ICAgICAgICAgICAgYXJndW1lbnRMaXN0LT5hcHBlbmQoaWRlbnQudmFsdWUoKS50b0F0b21TdHJp bmcoKSk7CisgICAgICAgICAgICByZXR1cm4gc2VsZWN0b3I7CisgICAgICAgIH0KICAgICAgICAg Y2FzZSBDU1NTZWxlY3Rvcjo6UHNldWRvRWxlbWVudFBhcnQ6IHsKICAgICAgICAgICAgIGF1dG8g YXJndW1lbnRMaXN0ID0gbWFrZVVuaXF1ZTxWZWN0b3I8QXRvbVN0cmluZz4+KCk7CiAgICAgICAg ICAgICBkbyB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVu ZGVyU3R5bGVDb25zdGFudHMuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5k ZXJTdHlsZUNvbnN0YW50cy5oCmluZGV4IGFhOTI0ZmVmNmEwZWZkNWI0NDBmMDBkNGVkNTMyYmI2 Nzc1MzhiNWMuLmY4ZDA2NzMwMDVmZjI5YzFkYzBjMjk4MWQyYjAyZTZkODJiMDBkMjYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZUNvbnN0YW50 cy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZUNvbnN0 YW50cy5oCkBAIC04MiwxMyArODIsMTQgQEAgZW51bSBjbGFzcyBTdHlsZURpZmZlcmVuY2VDb250 ZXh0U2Vuc2l0aXZlUHJvcGVydHkgewogfTsKIAogLy8gU3RhdGljIHBzZXVkbyBzdHlsZXMuIER5 bmFtaWMgb25lcyBhcmUgcHJvZHVjZWQgb24gdGhlIGZseS4KLWVudW0gY2xhc3MgUHNldWRvSWQg OiB1aW50OF90IHsKK2VudW0gY2xhc3MgUHNldWRvSWQgOiB1aW50MTZfdCB7CiAgICAgLy8gVGhl IG9yZGVyIG11c3QgYmUgTm9uZSwgcHVibGljIElEcywgYW5kIHRoZW4gaW50ZXJuYWwgSURzLgog ICAgIE5vbmUsCiAKICAgICAvLyBQdWJsaWM6CiAgICAgRmlyc3RMaW5lLAogICAgIEZpcnN0TGV0 dGVyLAorICAgIEhpZ2hsaWdodCwKICAgICBNYXJrZXIsCiAgICAgQmVmb3JlLAogICAgIEFmdGVy LAo=