204901 2019-12-05 10:52:05 -0800 Web Inspector: http/tests/inspector/target/pause-on-inline-debugger-statement.html is crashing in debug 2019-12-05 15:49:22 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 yurys yurys commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1595883 0 yurys 2019-12-05 10:52:05 -0800 Triggers same assertion on all platforms: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Finspector%2Ftarget%2Fpause-on-inline-debugger-statement.html stderr: ASSERTION FAILED: m_reasonForSuspendingActiveDOMObjects == ReasonForSuspension::PageWillBeSuspended ./dom/ScriptExecutionContext.cpp(257) : virtual void WebCore::ScriptExecutionContext::suspendActiveDOMObjects(WebCore::ReasonForSuspension) 1 0x132210619 WTFCrash 2 0x11828d88b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x11ac6f979 WebCore::ScriptExecutionContext::suspendActiveDOMObjects(WebCore::ReasonForSuspension) 4 0x11aa88ed4 WebCore::Document::suspendActiveDOMObjects(WebCore::ReasonForSuspension) 5 0x11aa869a9 WebCore::Document::suspendScheduledTasks(WebCore::ReasonForSuspension) 6 0x11b85d1aa WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer(WebCore::Page&, bool) 7 0x11b85d41c WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer(WebCore::Page&, bool) 8 0x11b723649 WebCore::Chrome::runJavaScriptAlert(WebCore::Frame&, WTF::String const&) 9 0x11b74228f WebCore::DOMWindow::alert(WTF::String const&) 10 0x118b0987d WebCore::jsDOMWindowInstanceFunctionAlert2Body(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSDOMWindow*, JSC::ThrowScope&) 11 0x118b096a7 WebCore::jsDOMWindowInstanceFunctionAlertOverloadDispatcher(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSDOMWindow*, JSC::ThrowScope&) 12 0x118a13d4f long long WebCore::IDLOperation<WebCore::JSDOMWindow>::call<&(WebCore::jsDOMWindowInstanceFunctionAlertOverloadDispatcher(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSDOMWindow*, JSC::ThrowScope&)), (WebCore::CastedThisErrorBehavior)0>(JSC::JSGlobalObject&, JSC::CallFrame&, char const*) 13 0x118a13a34 WebCore::jsDOMWindowInstanceFunctionAlert(JSC::JSGlobalObject*, JSC::CallFrame*) 14 0x388079c0116b 15 0x13271ffbc llint_entry 16 0x13271ffbc llint_entry 17 0x13271ffbc llint_entry 18 0x132703133 vmEntryToJavaScript 19 0x1334c9947 JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) 20 0x1334c8f59 JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::JSGlobalObject*, JSC::JSObject*) 21 0x133830a3c JSC::evaluate(JSC::JSGlobalObject*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) 22 0x133830ca1 JSC::evaluateWithScopeExtension(JSC::JSGlobalObject*, JSC::SourceCode const&, JSC::JSObject*, WTF::NakedPtr<JSC::Exception>&) 23 0x133445734 Inspector::JSInjectedScriptHost::evaluateWithScopeExtension(JSC::JSGlobalObject*, JSC::CallFrame*) 24 0x13344ebd3 Inspector::jsInjectedScriptHostPrototypeFunctionEvaluateWithScopeExtension(JSC::JSGlobalObject*, JSC::CallFrame*) 25 0x388079c0116b 26 0x13271ffbc llint_entry 27 0x13271ffbc llint_entry 28 0x132703133 vmEntryToJavaScript 29 0x1334c9947 JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) 30 0x1334c9fa4 JSC::Interpreter::executeCall(JSC::JSGlobalObject*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 31 0x1337d2e2c JSC::call(JSC::JSGlobalObject*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) LEAK: 2 WebPageProxy 1595955 1 384937 yurys 2019-12-05 13:10:20 -0800 Created attachment 384937 Patch 1596018 2 384937 hi 2019-12-05 14:38:11 -0800 Comment on attachment 384937 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384937&action=review > LayoutTests/ChangeLog:8 > + Restructured the test to avoid inadvertent alert() when navigating to a new Can you explain what "inadvertent alert()" means? It sounds like the issue was that logging during a page navigation triggered an `ASSERT` somewhere? Is this test just masking the problem, in that we need to change non-test logic somewhere, or is it purely that the test is doing something normally impossible? > LayoutTests/http/tests/inspector/target/pause-on-inline-debugger-statement.html:16 > + const url = "http://localhost:8000/inspector/target/resources/inline-debugger-statement.html"; > + WI.mainTarget.PageAgent.navigate(url); NIT: you could inline this 1596030 3 384937 yurys 2019-12-05 14:53:49 -0800 Comment on attachment 384937 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384937&action=review >> LayoutTests/ChangeLog:8 >> + Restructured the test to avoid inadvertent alert() when navigating to a new > > Can you explain what "inadvertent alert()" means? It sounds like the issue was that logging during a page navigation triggered an `ASSERT` somewhere? Is this test just masking the problem, in that we need to change non-test logic somewhere, or is it purely that the test is doing something normally impossible? The test revealed existing problem: when when execution is paused on debugger statement in inline script evaluating 'alert(1)' in console would trigger the assert. Since this is unrelated to PSON I suggest we address it separately, filed https://bugs.webkit.org/show_bug.cgi?id=204923. This test should not trigger assert while printing output in the first place. >> LayoutTests/http/tests/inspector/target/pause-on-inline-debugger-statement.html:16 >> + WI.mainTarget.PageAgent.navigate(url); > > NIT: you could inline this I'd rather leave it as named variable for documentation purposes. 1596036 4 384937 hi 2019-12-05 14:58:42 -0800 Comment on attachment 384937 Patch r=me, please wait for all-green EWS 1596064 5 384937 commit-queue 2019-12-05 15:48:48 -0800 Comment on attachment 384937 Patch Clearing flags on attachment: 384937 Committed r253179: <https://trac.webkit.org/changeset/253179> 1596065 6 commit-queue 2019-12-05 15:48:49 -0800 All reviewed patches have been landed. Closing bug. 1596066 7 webkit-bug-importer 2019-12-05 15:49:22 -0800 <rdar://problem/57680698> 384937 2019-12-05 13:10:20 -0800 2019-12-05 15:48:48 -0800 Patch bug-204901-20191205131019.patch text/plain 3876 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMTU1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMGZjNjAxNmI3MTk2NTgyYTM5MjJi MDI3YThkZmQwNWMyNmE3MzY5MS4uNWE4ZTJjMDFlYmZlM2E4ZTQ1NDI2ZWMzMjFiMGU5ZDFmNmJl MGJhNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTEyLTA1ICBZdXJ5IFNlbWlraGF0c2t5 ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGh0dHAvdGVz dHMvaW5zcGVjdG9yL3RhcmdldC9wYXVzZS1vbi1pbmxpbmUtZGVidWdnZXItc3RhdGVtZW50Lmh0 bWwgaXMgY3Jhc2hpbmcgaW4gZGVidWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwNDkwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFJlc3RydWN0dXJlZCB0aGUgdGVzdCB0byBhdm9pZCBpbmFkdmVydGVu dCBhbGVydCgpIHdoZW4gbmF2aWdhdGluZyB0byBhIG5ldworICAgICAgICBwcm9jZXNzLiBOZXcg bG9ncyBhcmUgcHJpbnRlZCBhZnRlciBpbnNwZWN0ZWQgcGFnZSBoYXMgbmF2aWdhdGVkLgorCisg ICAgICAgICogaHR0cC90ZXN0cy9pbnNwZWN0b3IvdGFyZ2V0L3BhdXNlLW9uLWlubGluZS1kZWJ1 Z2dlci1zdGF0ZW1lbnQtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvaW5zcGVj dG9yL3RhcmdldC9wYXVzZS1vbi1pbmxpbmUtZGVidWdnZXItc3RhdGVtZW50Lmh0bWw6CisKIDIw MTktMTItMDUgIHlvdWVubiBmYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIG1h cGxpa2Ugc2hvdWxkIGRlZmluZSBhIHNldCBtZXRob2QKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvaW5zcGVjdG9yL3RhcmdldC9wYXVzZS1vbi1pbmxpbmUtZGVidWdnZXItc3Rh dGVtZW50LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3Rh cmdldC9wYXVzZS1vbi1pbmxpbmUtZGVidWdnZXItc3RhdGVtZW50LWV4cGVjdGVkLnR4dAppbmRl eCBiMmY2NjhlNGY5OTY1NWNjNTUwNzgxMWNhYjRjNjQ3YmIwOTM5ZGFlLi41OGY2NTIxZGIyN2M4 Y2U5ZmI5OGZmMGVmMmE0ZGI4MWRkODkyMGM5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL2luc3BlY3Rvci90YXJnZXQvcGF1c2Utb24taW5saW5lLWRlYnVnZ2VyLXN0YXRlbWVu dC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvdGFy Z2V0L3BhdXNlLW9uLWlubGluZS1kZWJ1Z2dlci1zdGF0ZW1lbnQtZXhwZWN0ZWQudHh0CkBAIC0x LDIgKzEsNyBAQAotQUxFUlQ6IFBBU1M6IFNob3VsZCBwYXVzZSBvbiBkZWJ1Z2dlciBzdGF0ZW1l bnQuCiBUZXN0IHBhZ2UgdXNlZCB0byBjaGVjayB0aGF0IGV4ZWN1dGlvbiB3aWxsIGJyZWFrIG9u IGlubGluZSAnZGVidWdnZXInIHN0YXRlbWVudCBhZnRlciBjcm9zcy1vcmlnaW4gbmF2aWdhdGlv bi4KKworCis9PSBSdW5uaW5nIHRlc3Qgc3VpdGU6IFRhcmdldC5QU09OCistLSBSdW5uaW5nIHRl c3QgY2FzZTogSW5saW5lRGVidWdnZXJTdGF0ZW1lbnQKK1BBU1M6IFNob3VsZCBwYXVzZSBvbiBk ZWJ1Z2dlciBzdGF0ZW1lbnQuCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMv aW5zcGVjdG9yL3RhcmdldC9wYXVzZS1vbi1pbmxpbmUtZGVidWdnZXItc3RhdGVtZW50Lmh0bWwg Yi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci90YXJnZXQvcGF1c2Utb24taW5saW5l LWRlYnVnZ2VyLXN0YXRlbWVudC5odG1sCmluZGV4IGE2OTRkZDI3YzJiMGRiZjNmMDQwZDc4Y2Q4 YzFjOTM1MjVkYWZmOGMuLjlkMGQ4ZTlkYzdlMGNlZTFiZjIxZWU1YjE0NWRmMDEzYmY0ODMzZDYg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3RhcmdldC9wYXVz ZS1vbi1pbmxpbmUtZGVidWdnZXItc3RhdGVtZW50Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9pbnNwZWN0b3IvdGFyZ2V0L3BhdXNlLW9uLWlubGluZS1kZWJ1Z2dlci1zdGF0ZW1l bnQuaHRtbApAQCAtMTEsMjQgKzExLDE5IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgIHN1aXRlLmFk ZFRlc3RDYXNlKHsKICAgICAgICAgbmFtZTogIklubGluZURlYnVnZ2VyU3RhdGVtZW50IiwKICAg ICAgICAgZGVzY3JpcHRpb246ICJDaGVjayB0aGF0IG5ldyBwcm92aXNpb25hbCBwYWdlIGNhbiBi ZSBwYXVzZWQgYmVmb3JlIG5hdmlnYXRpb24uIiwKLSAgICAgICAgdGVzdChyZXNvbHZlLCByZWpl Y3QpIHsKLSAgICAgICAgICAgIFdJLmRlYnVnZ2VyTWFuYWdlci5hd2FpdEV2ZW50KFdJLkRlYnVn Z2VyTWFuYWdlci5FdmVudC5QYXVzZWQpCi0gICAgICAgICAgICAudGhlbigoKSA9PiB7Ci0gICAg ICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5wYXNzKGBTaG91bGQgcGF1c2Ugb24gZGVidWdnZXIg c3RhdGVtZW50LmApOworICAgICAgICBhc3luYyB0ZXN0KCkgeworICAgICAgICAgICAgY29uc3Qg dXJsID0gImh0dHA6Ly9sb2NhbGhvc3Q6ODAwMC9pbnNwZWN0b3IvdGFyZ2V0L3Jlc291cmNlcy9p bmxpbmUtZGVidWdnZXItc3RhdGVtZW50Lmh0bWwiOworICAgICAgICAgICAgV0kubWFpblRhcmdl dC5QYWdlQWdlbnQubmF2aWdhdGUodXJsKTsKIAotICAgICAgICAgICAgICAgIC8vIFdhaXQgZm9y IHBhZ2UgcmVsb2FkIGV2ZW50IHRvIGF2b2lkIHJhY2UgYmV0d2VlbiB0ZXN0IHJlc3VsdHMgZmx1 c2hpbmcgYW5kIHRoZSB0ZXN0IGNvbXBsZXRpb24uCi0gICAgICAgICAgICAgICAgbGV0IHBhZ2VM b2FkUHJvbWlzZSA9IEluc3BlY3RvclRlc3QuYXdhaXRFdmVudChGcm9udGVuZFRlc3RIYXJuZXNz LkV2ZW50LlRlc3RQYWdlRGlkTG9hZCk7Ci0gICAgICAgICAgICAgICAgLy9XSS5tYWluVGFyZ2V0 LkRlYnVnZ2VyQWdlbnQuCi0gICAgICAgICAgICAgICAgUHJvbWlzZS5yZXNvbHZlKCkudGhlbigo KSA9PiB7Ci0gICAgICAgICAgICAgICAgICAgIFdJLmRlYnVnZ2VyTWFuYWdlci5yZXN1bWUoKTsK LSAgICAgICAgICAgICAgICB9KTsKLSAgICAgICAgICAgICAgICByZXR1cm4gcGFnZUxvYWRQcm9t aXNlOwotICAgICAgICAgICAgfSkKLSAgICAgICAgICAgIC50aGVuKHJlc29sdmUpOworICAgICAg ICAgICAgYXdhaXQgV0kuZGVidWdnZXJNYW5hZ2VyLmF3YWl0RXZlbnQoV0kuRGVidWdnZXJNYW5h Z2VyLkV2ZW50LlBhdXNlZCk7CiAKKyAgICAgICAgICAgIC8vIFdhaXQgZm9yIHBhZ2UgcmVsb2Fk IGV2ZW50IHRvIGF2b2lkIHJhY2UgYmV0d2VlbiB0ZXN0IHJlc3VsdHMgZmx1c2hpbmcgYW5kIHRo ZSB0ZXN0IGNvbXBsZXRpb24uCisgICAgICAgICAgICBhd2FpdCBQcm9taXNlLmFsbChbCisgICAg ICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5hd2FpdEV2ZW50KEZyb250ZW5kVGVzdEhhcm5lc3Mu RXZlbnQuVGVzdFBhZ2VEaWRMb2FkKSwKKyAgICAgICAgICAgICAgICBXSS5kZWJ1Z2dlck1hbmFn ZXIucmVzdW1lKCkKKyAgICAgICAgICAgIF0pOwogCi0gICAgICAgICAgICBjb25zdCB1cmwgPSAi aHR0cDovL2xvY2FsaG9zdDo4MDAwL2luc3BlY3Rvci90YXJnZXQvcmVzb3VyY2VzL2lubGluZS1k ZWJ1Z2dlci1zdGF0ZW1lbnQuaHRtbCI7Ci0gICAgICAgICAgICBXSS5tYWluVGFyZ2V0LlBhZ2VB Z2VudC5uYXZpZ2F0ZSh1cmwpOworICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5wYXNzKGBTaG91 bGQgcGF1c2Ugb24gZGVidWdnZXIgc3RhdGVtZW50LmApOwogICAgICAgICB9CiAgICAgfSk7CiAK