204885 2019-12-05 05:28:21 -0800 [LFC][IFC] Many render tree dump tests show 1px too narrow runs 2019-12-05 09:12:20 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1595776 0 koivisto 2019-12-05 05:28:21 -0800 We are losing precisions when converting measured widths to LayoutUnits. 1595779 1 384899 koivisto 2019-12-05 05:36:27 -0800 Created attachment 384899 patch 1595788 2 384899 zalan 2019-12-05 06:43:29 -0800 Comment on attachment 384899 patch View in context: https://bugs.webkit.org/attachment.cgi?id=384899&action=review > Source/WebCore/layout/inlineformatting/text/TextUtil.cpp:74 > + return std::max(0_lu, LayoutUnit::fromFloatRound(width)); Please add a some words here so that it's clear why we do this random (and presumably temporary) rounding. So I guess the reason why SLL uses float everywhere is to match ComplexLineLayout results. This is very unfortunate and probably fails over time with accumulated rounding. I wish we could essentiallyEqual the layout tests the same way LayoutContext::verifyAndOutputMismatchingLayoutTree does. :( 1595832 3 384899 commit-queue 2019-12-05 09:11:26 -0800 Comment on attachment 384899 patch Clearing flags on attachment: 384899 Committed r253151: <https://trac.webkit.org/changeset/253151> 1595833 4 commit-queue 2019-12-05 09:11:28 -0800 All reviewed patches have been landed. Closing bug. 1595834 5 webkit-bug-importer 2019-12-05 09:12:20 -0800 <rdar://problem/57665768> 384899 2019-12-05 05:36:27 -0800 2019-12-05 09:11:26 -0800 patch lfc-width-round.patch text/plain 2133 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0OTM2YWI2MjFjZS4uMWE3ZTkxZjM1YjMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxOS0xMi0wNSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgW0xGQ11bSUZDXSBNYW55IHJlbmRlciB0cmVlIGR1bXAgdGVzdHMgc2hvdyAx cHggdG9vIG5hcnJvdyBydW5zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDQ4ODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXaWR0aCBtZWFzdXJlbWVudCBpcyBjdXJyZW50bHkgY2xhbXBpbmcgdGhlIG1l YXN1cmVkIChmbG9hdCkgdGV4dCB3aWR0aHMgdG8gbGF5b3V0IHVuaXRzLiBVc2Ugcm91bmRpbmcg aW5zdGVhZC4KKworICAgICAgICBUaGlzIGRvZXNuJ3Qgc29sdmUgdGhlIGZ1bmRhbWVudGFsIHBy b2JsZW0gb2YgbG9zcyBvZiBwcmVjaXNpb24gYnV0IGl0IGFsbG93cyBtYW55IG1vcmUgcmVuZGVy IHRyZWUgZHVtcAorICAgICAgICBiYXNlZCBsYXlvdXQgdGVzdHMgdG8gcGFzcy4KKworICAgICAg ICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL3RleHQvVGV4dFV0aWwuY3BwOgorICAgICAgICAo V2ViQ29yZTo6TGF5b3V0OjpUZXh0VXRpbDo6d2lkdGgpOgorICAgICAgICAoV2ViQ29yZTo6TGF5 b3V0OjpUZXh0VXRpbDo6Zml4ZWRQaXRjaFdpZHRoKToKKwogMjAxOS0xMi0wNCAgUnlvc3VrZSBO aXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgRG9jdW1lbnRFdmVudFF1 ZXVlIGFuZCBXb3JrZXJFdmVudFF1ZXVlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlv dXQvaW5saW5lZm9ybWF0dGluZy90ZXh0L1RleHRVdGlsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9pbmxpbmVmb3JtYXR0aW5nL3RleHQvVGV4dFV0aWwuY3BwCmluZGV4IDEwMjA3NzFiNjUy Li4yNTI5MDg3MWZhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZv cm1hdHRpbmcvdGV4dC9UZXh0VXRpbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lu bGluZWZvcm1hdHRpbmcvdGV4dC9UZXh0VXRpbC5jcHAKQEAgLTcxLDcgKzcxLDcgQEAgTGF5b3V0 VW5pdCBUZXh0VXRpbDo6d2lkdGgoY29uc3QgQm94JiBpbmxpbmVCb3gsIHVuc2lnbmVkIGZyb20s IHVuc2lnbmVkIHRvLCBMYXkKICAgICBpZiAobWVhc3VyZVdpdGhFbmRTcGFjZSkKICAgICAgICAg d2lkdGggLT0gKGZvbnQuc3BhY2VXaWR0aCgpICsgZm9udC53b3JkU3BhY2luZygpKTsKIAotICAg IHJldHVybiBzdGQ6Om1heCgwX2x1LCBMYXlvdXRVbml0IHsgd2lkdGggfSk7CisgICAgcmV0dXJu IHN0ZDo6bWF4KDBfbHUsIExheW91dFVuaXQ6OmZyb21GbG9hdFJvdW5kKHdpZHRoKSk7CiB9CiAK IExheW91dFVuaXQgVGV4dFV0aWw6OmZpeGVkUGl0Y2hXaWR0aChjb25zdCBTdHJpbmdWaWV3JiB0 ZXh0LCBjb25zdCBSZW5kZXJTdHlsZSYgc3R5bGUsIHVuc2lnbmVkIGZyb20sIHVuc2lnbmVkIHRv LCBMYXlvdXRVbml0IGNvbnRlbnRMb2dpY2FsTGVmdCkKQEAgLTkwLDcgKzkwLDcgQEAgTGF5b3V0 VW5pdCBUZXh0VXRpbDo6Zml4ZWRQaXRjaFdpZHRoKGNvbnN0IFN0cmluZ1ZpZXcmIHRleHQsIGNv bnN0IFJlbmRlclN0eWxlJgogICAgICAgICAgICAgd2lkdGggKz0gZm9udC53b3JkU3BhY2luZygp OwogICAgIH0KIAotICAgIHJldHVybiBzdGQ6Om1heCgwX2x1LCBMYXlvdXRVbml0IHsgd2lkdGgg fSk7CisgICAgcmV0dXJuIHN0ZDo6bWF4KDBfbHUsIExheW91dFVuaXQ6OmZyb21GbG9hdFJvdW5k KHdpZHRoKSk7CiB9CiAKIFRleHRVdGlsOjpTcGxpdERhdGEgVGV4dFV0aWw6OnNwbGl0KGNvbnN0 IEJveCYgaW5saW5lQm94LCB1bnNpZ25lZCBzdGFydFBvc2l0aW9uLCB1bnNpZ25lZCBsZW5ndGgs IExheW91dFVuaXQgdGV4dFdpZHRoLCBMYXlvdXRVbml0IGF2YWlsYWJsZVdpZHRoLCBMYXlvdXRV bml0IGNvbnRlbnRMb2dpY2FsTGVmdCkK