204873 2019-12-04 21:51:19 -0800 [MSVC] writeNumberToBufferUnsigned is unsafe for bool type 2019-12-09 17:57:15 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204870 InRadar P2 Normal --- 1 fujii fujii benjamin cdumez cmarcelo darin dbates don.olmstead ews-watchlist jfbastien ross.kirsling webkit-bug-importer oldest_to_newest 1595716 0 fujii 2019-12-04 21:51:19 -0800 [MSVC] writeNumberToBufferUnsigned is unsafe for bool type MSVC reports warning for using / operator for bool type. > warning C4804: '/': unsafe use of type 'bool' in operation GCC and Clang doesn't report warnings for bool / 10. https://godbolt.org/z/RjKz-m See also Bug 204870. 1595717 1 384880 fujii 2019-12-04 21:56:16 -0800 Created attachment 384880 Patch 1595797 2 384880 darin 2019-12-05 07:35:08 -0800 Comment on attachment 384880 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384880&action=review I think supporting bool and turning into "0"/"1" is an accident, not intentional design. We should consider deleting the feature by disabling the template expansion instead of improving the implementation. > Source/WTF/wtf/text/IntegerToStringConversion.h:130 > + *destination++ = number ? '1' : '0'; No need for ++ here, if we decide to keep this code. > Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:99 > + EXPECT_STREQ("0", makeString(false).utf8().data()); > + EXPECT_STREQ("1", makeString(true).utf8().data()); I don’t think we should serialize as "0" and "1". Instead I would suggest "false" and "true", which is what std::ostream does. 1596160 3 fujii 2019-12-05 19:42:28 -0800 Makes sense. I'm going to add static_assert at the moment. 1596161 4 384988 fujii 2019-12-05 19:43:35 -0800 Created attachment 384988 Patch 1596294 5 384988 darin 2019-12-06 11:17:25 -0800 Comment on attachment 384988 Patch Looks fine. I probably would have said something more like “bool not supported” rather than focusing on the implementation detail fo why this function template won’t work 1596750 6 fujii 2019-12-08 18:28:49 -0800 I'm going to revise the message. "'bool' isn't supported" 1596751 7 385129 fujii 2019-12-08 18:32:42 -0800 Created attachment 385129 Patch for landing 1597057 8 385129 fujii 2019-12-09 17:55:44 -0800 Comment on attachment 385129 Patch for landing Clearing flags on attachment: 385129 Committed r253315: <https://trac.webkit.org/changeset/253315> 1597059 9 fujii 2019-12-09 17:55:48 -0800 All reviewed patches have been landed. Closing bug. 1597060 10 webkit-bug-importer 2019-12-09 17:57:15 -0800 <rdar://problem/57777920> 384880 2019-12-04 21:56:16 -0800 2019-12-05 19:43:18 -0800 Patch bug-204873-20191205145615.patch text/plain 3234 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGRmYzU3YmE0NmU3NDFiYzZiNTExNDAx ZmZjZmIxZDA2MWY4ZTVhMWYuLmFjNThkYmYzYjg2ODVmNGE1NzVjM2JhZTY4ZTYzY2Q5OWQ5OTU5 YTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMTItMDQgIEZ1amlpIEhpcm9ub3JpICA8SGly b25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW01TVkNdIHdyaXRlTnVtYmVyVG9CdWZm ZXJVbnNpZ25lZCBpcyB1bnNhZmUgZm9yIGJvb2wgdHlwZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0ODczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTVNWQyByZXBvcnRzIHdhcm5pbmcgZm9yIHVzaW5n IC8gb3BlcmF0b3IgZm9yIGJvb2wgdHlwZS4KKyAgICAgICAgPiB3YXJuaW5nIEM0ODA0OiAnLyc6 IHVuc2FmZSB1c2Ugb2YgdHlwZSAnYm9vbCcgaW4gb3BlcmF0aW9uCisKKyAgICAgICAgQWRkIGEg c3BlY2lhbGl6YXRpb24gb2Ygd3JpdGVOdW1iZXJUb0J1ZmZlclVuc2lnbmVkIGZvciBib29sIHR5 cGUuCisKKyAgICAgICAgKiB3dGYvdGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmg6Cisg ICAgICAgIChXVEY6OndyaXRlTnVtYmVyVG9CdWZmZXJVbnNpZ25lZDxib29sLCBUPik6IEFkZGVk LgorICAgICAgICAoV1RGOjpsZW5ndGhPZk51bWJlckFzU3RyaW5nVW5zaWduZWQ8Ym9vbD4pOiBB ZGRlZC4KKwogMjAxOS0xMi0wMyAgU3VubnkgSGUgIDxzdW5ueV9oZUBhcHBsZS5jb20+CiAKICAg ICAgICAgRW5hYmxlIHNlY3VyaXR5IGFzc2VydGlvbnMgb24gYWxsIEFTQU4gYnVpbGRzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0ludGVnZXJUb1N0cmluZ0NvbnZlcnNpb24uaCBi L1NvdXJjZS9XVEYvd3RmL3RleHQvSW50ZWdlclRvU3RyaW5nQ29udmVyc2lvbi5oCmluZGV4IDlm YWE0ZjRjOGY2YmJiNmZiNTI0ZTA0MGVkYjU3YzAyYWViN2NmMDYuLjFlNWZiMmU1MzE3MzgzODQ1 YTMyZTI2NzQ0NmIxMDgxNjkwZDllN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQv SW50ZWdlclRvU3RyaW5nQ29udmVyc2lvbi5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvSW50 ZWdlclRvU3RyaW5nQ29udmVyc2lvbi5oCkBAIC0xMjQsNCArMTI0LDE2IEBAIGlubGluZSB1bnNp Z25lZCBsZW5ndGhPZk51bWJlckFzU3RyaW5nVW5zaWduZWQoVW5zaWduZWRJbnRlZ2VyVHlwZSBu dW1iZXIpCiAgICAgcmV0dXJuIGxlbmd0aE9mTnVtYmVyQXNTdHJpbmdJbXBsPFVuc2lnbmVkSW50 ZWdlclR5cGUsIFBvc2l0aXZlTnVtYmVyPihudW1iZXIpOwogfQogCit0ZW1wbGF0ZTx0eXBlbmFt ZSBDaGFyYWN0ZXJUeXBlPgoraW5saW5lIHZvaWQgd3JpdGVOdW1iZXJUb0J1ZmZlclVuc2lnbmVk KGJvb2wgbnVtYmVyLCBDaGFyYWN0ZXJUeXBlKiBkZXN0aW5hdGlvbikKK3sKKyAgICAqZGVzdGlu YXRpb24rKyA9IG51bWJlciA/ICcxJyA6ICcwJzsKK30KKwordGVtcGxhdGU8PgoraW5saW5lIHVu c2lnbmVkIGxlbmd0aE9mTnVtYmVyQXNTdHJpbmdVbnNpZ25lZDxib29sPihib29sKQoreworICAg IHJldHVybiAxOworfQorCiB9IC8vIG5hbWVzcGFjZSBXVEYKZGlmZiAtLWdpdCBhL1Rvb2xzL0No YW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiOWY3NzVkOTg3YTBjZGUxYTRjM2ViMDNj M2IyNjMyYzY4ZWJmN2Q2Li42ZmU5MWEzYjFiMWM0MzliMjAzZjg4OWJkMmRkNzg1YmUzZThkYTQy IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTktMTItMDQgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlA c29ueS5jb20+CisKKyAgICAgICAgW01TVkNdIHdyaXRlTnVtYmVyVG9CdWZmZXJVbnNpZ25lZCBp cyB1bnNhZmUgZm9yIGJvb2wgdHlwZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjA0ODczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9TdHJpbmdDb25jYXRlbmF0 ZS5jcHA6CisgICAgICAgIChXVEYuU3RyaW5nQ29uY2F0ZW5hdGVfQm9vbCk6IEFkZGVkIGEgdGVz dCBjYXNlIGZvciBib29sIHR5cGUgb2YgbWFrZVN0cmluZy4KKwogMjAxOS0xMi0wNCAgSm9uYXRo YW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgcmVzdWx0cy53ZWJraXQu b3JnOiBEZWNyZWFzZSB0dGwgZm9yIGFyY2hpdmVzCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dURi9TdHJpbmdDb25jYXRlbmF0ZS5jcHAgYi9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dURi9TdHJpbmdDb25jYXRlbmF0ZS5jcHAKaW5kZXggNGI1N2M1MTc0Y2U4YWQ1 NTUyODdhYzc4YmMwOGRlNTI0YzFjZGQ0ZS4uYTRhOTUzNmUxMzUwMzFjY2NkOWUxZDA5YmVlNDNl YzcyNDgzMzY2NiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3Ry aW5nQ29uY2F0ZW5hdGUuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1N0 cmluZ0NvbmNhdGVuYXRlLmNwcApAQCAtOTMsNiArOTMsMTIgQEAgVEVTVChXVEYsIFN0cmluZ0Nv bmNhdGVuYXRlX1Vuc2lnbmVkKQogICAgIEVYUEVDVF9TVFJFUSgiaGVsbG8gMzIzNTgzOTc0MiB3 b3JsZCIsIG1ha2VTdHJpbmcoImhlbGxvICIsIHN0YXRpY19jYXN0PHNpemVfdD4oMHhjMGRlZmVm ZSksICIgd29ybGQiKS51dGY4KCkuZGF0YSgpKTsKIH0KIAorVEVTVChXVEYsIFN0cmluZ0NvbmNh dGVuYXRlX0Jvb2wpCit7CisgICAgRVhQRUNUX1NUUkVRKCIwIiwgbWFrZVN0cmluZyhmYWxzZSku dXRmOCgpLmRhdGEoKSk7CisgICAgRVhQRUNUX1NUUkVRKCIxIiwgbWFrZVN0cmluZyh0cnVlKS51 dGY4KCkuZGF0YSgpKTsKK30KKwogVEVTVChXVEYsIFN0cmluZ0NvbmNhdGVuYXRlX0Zsb2F0KQog ewogICAgIEVYUEVDVF9TVFJFUSgiaGVsbG8gMTc4OTAgd29ybGQiLCBtYWtlU3RyaW5nKCJoZWxs byAiLCAxNzg5MC4wZiAsICIgd29ybGQiKS51dGY4KCkuZGF0YSgpKTsK 384988 2019-12-05 19:43:35 -0800 2019-12-08 18:32:25 -0800 Patch bug-204873-20191206124333.patch text/plain 1680 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGRmYzU3YmE0NmU3NDFiYzZiNTExNDAx ZmZjZmIxZDA2MWY4ZTVhMWYuLjc0NzMzZDMzZmQ0MTMxMTRhNDYyNWE0NzE5NmM1YjA4NzM0NzY3 MDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMTItMDQgIEZ1amlpIEhpcm9ub3JpICA8SGly b25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW01TVkNdIHdyaXRlTnVtYmVyVG9CdWZm ZXJVbnNpZ25lZCBpcyB1bnNhZmUgZm9yIGJvb2wgdHlwZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0ODczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTVNWQyByZXBvcnRzIHdhcm5pbmcgZm9yIHVzaW5n IC8gb3BlcmF0b3IgZm9yIGJvb2wgdHlwZS4KKyAgICAgICAgPiB3YXJuaW5nIEM0ODA0OiAnLyc6 IHVuc2FmZSB1c2Ugb2YgdHlwZSAnYm9vbCcgaW4gb3BlcmF0aW9uCisKKyAgICAgICAgKiB3dGYv dGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmg6IEFkZGVkIGEgc3RhdGljX2Fzc2VydCB0 byBlbnN1cmUgVW5zaWduZWRJbnRlZ2VyVHlwZSBpc24ndCBib29sLgorCiAyMDE5LTEyLTAzICBT dW5ueSBIZSAgPHN1bm55X2hlQGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgc2VjdXJpdHkg YXNzZXJ0aW9ucyBvbiBhbGwgQVNBTiBidWlsZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3Rm L3RleHQvSW50ZWdlclRvU3RyaW5nQ29udmVyc2lvbi5oIGIvU291cmNlL1dURi93dGYvdGV4dC9J bnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKaW5kZXggOWZhYTRmNGM4ZjZiYmI2ZmI1MjRlMDQw ZWRiNTdjMDJhZWI3Y2YwNi4uNDVkNWI1ZTkwYTc1OWY4ZDJhZjIyZGYzNzYxMWE4YjRiNGUxMzY0 NyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJz aW9uLmgKKysrIGIvU291cmNlL1dURi93dGYvdGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9u LmgKQEAgLTY0LDYgKzY0LDcgQEAgaW5saW5lIHR5cGVuYW1lIEludGVnZXJUb1N0cmluZ0NvbnZl cnNpb25UcmFpdDxUPjo6UmV0dXJuVHlwZSBudW1iZXJUb1N0cmluZ1Vuc2kKIHRlbXBsYXRlPHR5 cGVuYW1lIENoYXJhY3RlclR5cGUsIHR5cGVuYW1lIFVuc2lnbmVkSW50ZWdlclR5cGUsIFBvc2l0 aXZlT3JOZWdhdGl2ZU51bWJlciBOdW1iZXJUeXBlPgogc3RhdGljIHZvaWQgd3JpdGVOdW1iZXJU b0J1ZmZlckltcGwoVW5zaWduZWRJbnRlZ2VyVHlwZSBudW1iZXIsIENoYXJhY3RlclR5cGUqIGRl c3RpbmF0aW9uKQogeworICAgIHN0YXRpY19hc3NlcnQoIXN0ZDo6aXNfc2FtZV92PGJvb2wsIHN0 ZDo6cmVtb3ZlX2N2X3Q8VW5zaWduZWRJbnRlZ2VyVHlwZT4+LCAiYXJpdGhtZXRpYyBvcGVyYXRp b25zIGFyZSB1bnNhZmUgZm9yIHR5cGUgJ2Jvb2wnIik7CiAgICAgTENoYXIgYnVmW3NpemVvZihV bnNpZ25lZEludGVnZXJUeXBlKSAqIDMgKyAxXTsKICAgICBMQ2hhciogZW5kID0gc3RkOjplbmQo YnVmKTsKICAgICBMQ2hhciogcCA9IGVuZDsK 385129 2019-12-08 18:32:42 -0800 2019-12-08 18:32:42 -0800 Patch for landing bug-204873-20191209113241.patch text/plain 1780 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDJiOWNiOTdhMjhjYmUxZTMxOGFkMTU0 MThjYzk3ZmI5M2YzYWM0YWIuLjJmY2Q0ZTZmNTMyMTY1MjdhMDk1N2NkY2Y0YzUyYmNmODk4YTU0 YWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMTItMDggIEZ1amlpIEhpcm9ub3JpICA8SGly b25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW01TVkNdIHdyaXRlTnVtYmVyVG9CdWZm ZXJVbnNpZ25lZCBpcyB1bnNhZmUgZm9yIGJvb2wgdHlwZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0ODczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIuCisKKyAgICAgICAgTVNWQyByZXBvcnRzIHdhcm5pbmcgZm9yIHVzaW5nIC8g b3BlcmF0b3IgZm9yIGJvb2wgdHlwZS4KKyAgICAgICAgPiB3YXJuaW5nIEM0ODA0OiAnLyc6IHVu c2FmZSB1c2Ugb2YgdHlwZSAnYm9vbCcgaW4gb3BlcmF0aW9uCisKKyAgICAgICAgQW5kLCAnYm9v bCcgaXNuJ3QgZXhwZWN0ZWQgdG8gYmUgc2VyaWFsaXplZCBhcyAnMCcgb3IgJzEnLiAnYm9vbCcg aXNuJ3Qgc3VwcG9ydGVkLgorCisgICAgICAgICogd3RmL3RleHQvSW50ZWdlclRvU3RyaW5nQ29u dmVyc2lvbi5oOiBBZGRlZCBhIHN0YXRpY19hc3NlcnQgdG8gZW5zdXJlIFVuc2lnbmVkSW50ZWdl clR5cGUgaXNuJ3QgYm9vbC4KKwogMjAxOS0xMi0wNiAgWmFuIERvYmVyc2VrICA8emRvYmVyc2Vr QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBVc2UgYm1hbGxvYydzIG1lbW9yeSBm b290cHJpbnQgQVBJIGZvciBKU0MgaGVhcCBncm93dGggbWFuYWdlbWVudApkaWZmIC0tZ2l0IGEv U291cmNlL1dURi93dGYvdGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmggYi9Tb3VyY2Uv V1RGL3d0Zi90ZXh0L0ludGVnZXJUb1N0cmluZ0NvbnZlcnNpb24uaAppbmRleCA5ZmFhNGY0Yzhm NmJiYjZmYjUyNGUwNDBlZGI1N2MwMmFlYjdjZjA2Li5iY2ZmZDlkZjI3ZDAwOWUxZGM1ZDBmZWMy ZmIyNDNiZmFmZDEwYjA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0ludGVnZXJU b1N0cmluZ0NvbnZlcnNpb24uaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0ludGVnZXJUb1N0 cmluZ0NvbnZlcnNpb24uaApAQCAtNjQsNiArNjQsNyBAQCBpbmxpbmUgdHlwZW5hbWUgSW50ZWdl clRvU3RyaW5nQ29udmVyc2lvblRyYWl0PFQ+OjpSZXR1cm5UeXBlIG51bWJlclRvU3RyaW5nVW5z aQogdGVtcGxhdGU8dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZSwgdHlwZW5hbWUgVW5zaWduZWRJbnRl Z2VyVHlwZSwgUG9zaXRpdmVPck5lZ2F0aXZlTnVtYmVyIE51bWJlclR5cGU+CiBzdGF0aWMgdm9p ZCB3cml0ZU51bWJlclRvQnVmZmVySW1wbChVbnNpZ25lZEludGVnZXJUeXBlIG51bWJlciwgQ2hh cmFjdGVyVHlwZSogZGVzdGluYXRpb24pCiB7CisgICAgc3RhdGljX2Fzc2VydCghc3RkOjppc19z YW1lX3Y8Ym9vbCwgc3RkOjpyZW1vdmVfY3ZfdDxVbnNpZ25lZEludGVnZXJUeXBlPj4sICInYm9v bCcgbm90IHN1cHBvcnRlZCIpOwogICAgIExDaGFyIGJ1ZltzaXplb2YoVW5zaWduZWRJbnRlZ2Vy VHlwZSkgKiAzICsgMV07CiAgICAgTENoYXIqIGVuZCA9IHN0ZDo6ZW5kKGJ1Zik7CiAgICAgTENo YXIqIHAgPSBlbmQ7Cg==