204870 2019-12-04 19:47:34 -0800 [MSVC] WebResourceLoadStatisticsStore.h is reporting warning C4804: '/': unsafe use of type 'bool' in operation 2019-12-05 10:30:20 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204873 InRadar P2 Normal --- 1 fujii katherine_cheney commit-queue darin katherine_cheney webkit-bug-importer oldest_to_newest 1595677 0 fujii 2019-12-04 19:47:34 -0800 [MSVC] WebResourceLoadStatisticsStore.h is reporting warning C4804: '/': unsafe use of type 'bool' in operation Since r253118 (Bug 203432) https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Build%29/builds/13884 [18/43] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\__\__\WebKit\DerivedSources\NetworkProcessMessageReceiver.cpp.obj C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/IntegerToStringConversion.h(104): warning C4804: '/=': unsafe use of type 'bool' in operation C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/IntegerToStringConversion.h(124): note: see reference to function template instantiation 'unsigned int WTF::lengthOfNumberAsStringImpl<UnsignedIntegerType,WTF::PositiveNumber>(UnsignedIntegerType)' being compiled with [ UnsignedIntegerType=bool ] C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/StringConcatenateNumbers.h(58): note: see reference to function template instantiation 'unsigned int WTF::lengthOfNumberAsStringUnsigned<UnsignedInt>(UnsignedIntegerType)' being compiled with [ UnsignedInt=bool, UnsignedIntegerType=bool ] C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/StringConcatenateNumbers.h(58): note: while compiling class template member function 'unsigned int WTF::StringTypeAdapter<bool,void>::length(void) const' C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/StringConcatenate.h(319): note: see reference to function template instantiation 'unsigned int WTF::StringTypeAdapter<bool,void>::length(void) const' being compiled C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/StringConcatenate.h(348): note: see reference to class template instantiation 'WTF::StringTypeAdapter<bool,void>' being compiled C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/StringConcatenate.h(354): note: see reference to function template instantiation 'WTF::String WTF::tryMakeString<const char*,WTF::String,const char*,bool>(const char *,WTF::String,const char *,bool)' being compiled C:\WebKit-BuildWorker\wincairo-wkl-release\build\Source\WebKit\NetworkProcess\Classifier\WebResourceLoadStatisticsStore.h(87): note: see reference to function template instantiation 'WTF::String WTF::makeString<const char*,WTF::String,const char*,bool>(const char *,WTF::String,const char *,bool)' being compiled C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/IntegerToStringConversion.h(104): warning C4804: '/': unsafe use of type 'bool' in operation C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/IntegerToStringConversion.h(72): warning C4804: '%': unsafe use of type 'bool' in operation C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/IntegerToStringConversion.h(94): note: see reference to function template instantiation 'void WTF::writeNumberToBufferImpl<CharacterType,UnsignedIntegerType,WTF::PositiveNumber>(UnsignedIntegerType,CharacterType *)' being compiled with [ CharacterType=LChar, UnsignedIntegerType=bool ] C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/StringConcatenateNumbers.h(60): note: see reference to function template instantiation 'void WTF::writeNumberToBufferUnsigned<CharacterType,UnsignedInt>(UnsignedIntegerType,CharacterType *)' being compiled with [ CharacterType=LChar, UnsignedInt=bool, UnsignedIntegerType=bool ] C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/StringConcatenate.h(305): note: see reference to function template instantiation 'void WTF::StringTypeAdapter<bool,void>::writeTo<ResultType>(CharacterType *) const' being compiled with [ ResultType=LChar, CharacterType=LChar ] C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/StringConcatenate.h(305): note: see reference to function template instantiation 'void WTF::StringTypeAdapter<bool,void>::writeTo<ResultType>(CharacterType *) const' being compiled with [ ResultType=LChar, CharacterType=LChar ] C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/StringConcatenate.h(310): note: see reference to function template instantiation 'void WTF::stringTypeAdapterAccumulator<ResultType,WTF::StringTypeAdapter<bool,void>>(ResultType *,Adapter)' being compiled with [ ResultType=LChar, Adapter=WTF::StringTypeAdapter<bool,void> ] C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/StringConcatenate.h(310): note: see reference to function template instantiation 'void WTF::stringTypeAdapterAccumulator<ResultType,WTF::StringTypeAdapter<const char*,void>,WTF::StringTypeAdapter<bool,void>>(ResultType *,Adapter,WTF::StringTypeAdapter<bool,void>)' being compiled with [ ResultType=LChar, Adapter=WTF::StringTypeAdapter<const char*,void> ] C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/StringConcatenate.h(310): note: see reference to function template instantiation 'void WTF::stringTypeAdapterAccumulator<ResultType,WTF::StringTypeAdapter<WTF::String,void>,WTF::StringTypeAdapter<const char*,void>,WTF::StringTypeAdapter<bool,void>>(ResultType *,Adapter,WTF::StringTypeAdapter<const char*,void>,WTF::StringTypeAdapter<bool,void>)' being compiled with [ ResultType=LChar, Adapter=WTF::StringTypeAdapter<WTF::String,void> ] C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/StringConcatenate.h(317): note: see reference to function template instantiation 'void WTF::stringTypeAdapterAccumulator<LChar,StringTypeAdapter,WTF::StringTypeAdapter<WTF::String,void>,WTF::StringTypeAdapter<const char*,void>,WTF::StringTypeAdapter<bool,void>>(ResultType *,Adapter,WTF::StringTypeAdapter<WTF::String,void>,WTF::StringTypeAdapter<const char*,void>,WTF::StringTypeAdapter<bool,void>)' being compiled with [ StringTypeAdapter=WTF::StringTypeAdapter<const char*,void>, ResultType=LChar, Adapter=WTF::StringTypeAdapter<const char*,void> ] C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/StringConcatenate.h(348): note: see reference to function template instantiation 'WTF::String WTF::tryMakeStringFromAdapters<WTF::StringTypeAdapter<const char*,void>,WTF::StringTypeAdapter<WTF::String,void>,WTF::StringTypeAdapter<const char*,void>,WTF::StringTypeAdapter<bool,void>>(StringTypeAdapter,WTF::StringTypeAdapter<WTF::String,void>,WTF::StringTypeAdapter<const char*,void>,WTF::StringTypeAdapter<bool,void>)' being compiled with [ StringTypeAdapter=WTF::StringTypeAdapter<const char*,void> ] C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/IntegerToStringConversion.h(73): warning C4804: '/=': unsafe use of type 'bool' in operation C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\WTF\Headers\wtf/text/IntegerToStringConversion.h(73): warning C4804: '/': unsafe use of type 'bool' in operation 1595688 1 fujii 2019-12-04 20:14:25 -0800 This can be solved by 1. storageAccessGranted ? "0" : "1" 2. unsigned(storageAccessGranted) 3. Change makeString to explitly accept bool type #3 seems better for MSVC. 1595714 2 fujii 2019-12-04 21:19:26 -0800 GCC and Clang doesn't report warnings for bool / 10. https://godbolt.org/z/RjKz-m 1595718 3 fujii 2019-12-04 21:57:33 -0800 (In reply to Fujii Hironori from comment #1) > #3 seems better for MSVC. Filed: Bug 204873 – [MSVC] writeNumberToBufferUnsigned is unsafe for bool type 1595796 4 darin 2019-12-05 07:33:48 -0800 I suggest doing (1) for now. Or could do this more efficient version: storageAccessGranted ? '0' : '1' Then I suggest we consider either adding support for bool or disabling use of bool in makeString. But I don’t think a bool should necessarily serialize as "0"/"1". 1595816 5 384906 katherine_cheney 2019-12-05 08:47:32 -0800 Created attachment 384906 Patch 1595872 6 384906 commit-queue 2019-12-05 10:29:22 -0800 Comment on attachment 384906 Patch Clearing flags on attachment: 384906 Committed r253155: <https://trac.webkit.org/changeset/253155> 1595873 7 commit-queue 2019-12-05 10:29:24 -0800 All reviewed patches have been landed. Closing bug. 1595874 8 webkit-bug-importer 2019-12-05 10:30:20 -0800 <rdar://problem/57668408> 384906 2019-12-05 08:47:32 -0800 2019-12-05 10:29:22 -0800 Patch bug-204870-20191205084732.patch text/plain 1791 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJiNzVhZjZkMjE0MDU3NDM3 YzQ3YTdjNmNmMWEwYzgwMWRmYjY5NTguLmQzYTc3ZDk4ZmZiNWZlY2NmOGUyNGZlMzQwMTNjM2M4 OTgwZDJkMTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMTItMDUgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgW01TVkNdIFdlYlJl c291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5oIGlzIHJlcG9ydGluZyB3YXJuaW5nIEM0ODA0OiAn Lyc6IHVuc2FmZSB1c2Ugb2YgdHlwZSAnYm9vbCcgaW4gb3BlcmF0aW9uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ4NzAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGNvbnZlcnRzIHN0 b3JhZ2VBY2Nlc3NHcmFudGVkIHRvIGEgY2hhciBzaW5jZSBtYWtlU3RyaW5nKCkKKyAgICAgICAg ZG9lcyBub3QgZXhwbGljaXRseSBhY2NlcHQgYm9vbCB0eXBlcy4KKworICAgICAgICAqIE5ldHdv cmtQcm9jZXNzL0NsYXNzaWZpZXIvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLmg6Cisg ICAgICAgIChXZWJLaXQ6OlRoaXJkUGFydHlEYXRhRm9yU3BlY2lmaWNGaXJzdFBhcnR5Ojp0b1N0 cmluZyBjb25zdCk6CisKIDIwMTktMTItMDUgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtHTGliXSBEaXNwbGF5IEdTdHJlYW1lciB2ZXJzaW9uIGlu IGFib3V0OmdwdSBwYWdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNz L0NsYXNzaWZpZXIvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLmggYi9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0 b3JlLmgKaW5kZXggZDNmOWNmMGYzYTJkM2Q2YmYyNGJjOWZiMWI0NWJlNWMyOGE5M2VjMS4uYzU5 MWZjMmUzYzkwODZjMjA1OGFiNDc1YzZkMjM0YTYzNDRmOTE1NyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1dlYlJlc291cmNlTG9hZFN0YXRpc3Rp Y3NTdG9yZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9X ZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUuaApAQCAtODQsNyArODQsNyBAQCBzdHJ1Y3Qg VGhpcmRQYXJ0eURhdGFGb3JTcGVjaWZpY0ZpcnN0UGFydHkgewogCiAgICAgU3RyaW5nIHRvU3Ry aW5nKCkgY29uc3QKICAgICB7Ci0gICAgICAgIHJldHVybiBtYWtlU3RyaW5nKCJIYXMgYmVlbiBn cmFudGVkIHN0b3JhZ2UgYWNjZXNzIHVuZGVyICIsIGZpcnN0UGFydHlEb21haW4uc3RyaW5nKCks ICI6ICIsIHN0b3JhZ2VBY2Nlc3NHcmFudGVkKTsKKyAgICAgICAgcmV0dXJuIG1ha2VTdHJpbmco IkhhcyBiZWVuIGdyYW50ZWQgc3RvcmFnZSBhY2Nlc3MgdW5kZXIgIiwgZmlyc3RQYXJ0eURvbWFp bi5zdHJpbmcoKSwgIjogIiwgc3RvcmFnZUFjY2Vzc0dyYW50ZWQgPyAnMScgOiAnMCcpOwogICAg IH0KIAogICAgIGJvb2wgb3BlcmF0b3I9PShUaGlyZFBhcnR5RGF0YUZvclNwZWNpZmljRmlyc3RQ YXJ0eSBjb25zdCBvdGhlcikgY29uc3QK