204869 2019-12-04 18:38:27 -0800 run-javascriptcore-tests is failing to run testmasm of 64bit AppleWin on Buildbot 2019-12-04 21:04:27 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen ap bfulgham dbates don.olmstead ews-watchlist jbedard pvollan ross.kirsling webkit-bug-importer oldest_to_newest 1595671 0 fujii 2019-12-04 18:38:27 -0800 run-javascriptcore-tests is failing to run testmasm of 64bit AppleWin on Buildbot https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Tests%29/builds/4291 > perl ./Tools/Scripts/run-javascriptcore-tests --no-build --no-fail-fast --json-output=jsc_results.json --release --builder-name 'Apple Win 10 Release (Tests)' --build-number 4291 --buildbot-worker bot546 --buildbot-master build.webkit.org --report https://results.webkit.org > in dir /home/buildbot/worker/win10-release-tests/build (timeout 1200 secs) > watching logfiles {'json': 'jsc_results.json'} > argv: ['perl', './Tools/Scripts/run-javascriptcore-tests', '--no-build', '--no-fail-fast', '--json-output=jsc_results.json', '--release', '--builder-name', 'Apple Win 10 Release (Tests)', '--build-number', '4291', '--buildbot-worker', 'bot546', '--buildbot-master', 'build.webkit.org', '--report', 'https://results.webkit.org'] > using PTY: False > Use of uninitialized value in concatenation (.) or string at ./Tools/Scripts/run-javascriptcore-tests line 427. > Failed to run C:/cygwin/home/buildbot/worker/win10-release-tests/build/WebKitBuild/Release/bin64/testmasm at ./Tools/Scripts/run-javascriptcore-tests line 526. > program finished with exit code 2 > elapsedTime=11.391830 testmasm is built if DEVELOPER_MODE is enabled. AppleWin doesn't enable DEVELOPER_MODE. run-javascriptcore-tests was given --no-testmasm switch for 32bit builds on Buildbot. 1595673 1 384872 fujii 2019-12-04 18:51:43 -0800 Created attachment 384872 Patch 1595680 2 384872 pvollan 2019-12-04 20:05:02 -0800 Comment on attachment 384872 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384872&action=review > Tools/Scripts/webkitdirs.pm:2276 > - push @args, "-DDEVELOPER_MODE=ON" if isFTW() || isGtk() || isJSCOnly() || isWPE() || isWinCairo(); > + push @args, "-DDEVELOPER_MODE=ON" if isJSCOnly() || isWPE() || isWin64(); Did you forget to keep isGtk()? 1595710 3 384872 fujii 2019-12-04 20:58:21 -0800 Comment on attachment 384872 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384872&action=review >> Tools/Scripts/webkitdirs.pm:2276 >> + push @args, "-DDEVELOPER_MODE=ON" if isJSCOnly() || isWPE() || isWin64(); > > Did you forget to keep isGtk()? Yes! Thank you. 1595711 4 384879 fujii 2019-12-04 21:00:47 -0800 Created attachment 384879 Patch for landing 1595712 5 fujii 2019-12-04 21:04:01 -0800 Committed r253142: <https://trac.webkit.org/changeset/253142> 1595713 6 webkit-bug-importer 2019-12-04 21:04:27 -0800 <rdar://problem/57652630> 384872 2019-12-04 18:51:43 -0800 2019-12-04 21:00:31 -0800 Patch bug-204869-20191205115142.patch text/plain 1634 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMTM2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjlmNzc1ZDk4N2EwY2RlMWE0YzNlYjAzYzNiMjYzMmM2 OGViZjdkNi4uNjllNmFjYzlhZGZlNjM4MDZjMDFkNTZhZjM3Nzg0ZjQwYTQ3MDc4MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE5LTEyLTA0ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIHJ1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cyBpcyBmYWlsaW5nIHRvIHJ1biB0 ZXN0bWFzbSBvZiA2NGJpdCBBcHBsZVdpbiBvbiBCdWlsZGJvdAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0ODY5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5hYmxlIERFVkVMT1BFUl9NT0RFIGZvciBh bGwgNjRiaXQgV2luZG93cyBidWlsZHMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMu cG06CisgICAgICAgIChnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdCk6IFJlcGxh Y2VkICJpc0ZUVygpIHx8IGlzV2luQ2Fpcm8oKSIgd2l0aCBpc1dpbjY0KCkKKyAgICAgICAgaW4g dGhlIGNvbmRpdGlvbiBvZiBlbmFibGluZyBERVZFTE9QRVJfTU9ERS4KKwogMjAxOS0xMi0wNCAg Sm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgcmVzdWx0cy53 ZWJraXQub3JnOiBEZWNyZWFzZSB0dGwgZm9yIGFyY2hpdmVzCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXgg MDY1Mzk3MGIxODE4Y2FlOTY5NTc5YzRlN2ZhY2ZlMTNjYjYwNjdjMi4uNjZlYTZlMTVlMjBmNDE4 NTlkMzFhYTNjMDkwNmI1ZTJmYjU5NmE3NCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMjI3Myw3ICsy MjczLDcgQEAgc3ViIGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0CiAgICAgcHVz aCBAYXJncywgJy1EU0hPV19CSU5ESU5HU19HRU5FUkFUSU9OX1BST0dSRVNTPTEnIHVubGVzcyAo JHdpbGxVc2VOaW5qYSAmJiAtdCBTVERPVVQpOwogCiAgICAgIyBTb21lIHBvcnRzIGhhdmUgcHJv ZHVjdGlvbiBtb2RlLCBidXQgYnVpbGQtd2Via2l0IHNob3VsZCBhbHdheXMgdXNlIGRldmVsb3Bl ciBtb2RlLgotICAgIHB1c2ggQGFyZ3MsICItRERFVkVMT1BFUl9NT0RFPU9OIiBpZiBpc0ZUVygp IHx8IGlzR3RrKCkgfHwgaXNKU0NPbmx5KCkgfHwgaXNXUEUoKSB8fCBpc1dpbkNhaXJvKCk7Cisg ICAgcHVzaCBAYXJncywgIi1EREVWRUxPUEVSX01PREU9T04iIGlmIGlzSlNDT25seSgpIHx8IGlz V1BFKCkgfHwgaXNXaW42NCgpOwogCiAgICAgaWYgKGFyY2hpdGVjdHVyZSgpIGVxICJ4ODZfNjQi ICYmIHNob3VsZEJ1aWxkMzJCaXQoKSkgewogICAgICAgICAjIENNQUtFX0xJQlJBUllfQVJDSElU RUNUVVJFIGlzIG5lZWRlZCB0byBnZXQgdGhlIHJpZ2h0IC5wYwo= 384879 2019-12-04 21:00:47 -0800 2019-12-04 21:00:47 -0800 Patch for landing bug-204869-20191205140046.patch text/plain 1702 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMTM3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjlmNzc1ZDk4N2EwY2RlMWE0YzNlYjAzYzNiMjYzMmM2 OGViZjdkNi4uYTZiNmMxMDA3MjgzOTY5M2MyMWUwY2ZiOWE4YWI1NTM0ZDAwMTdhZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTEyLTA0ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIHJ1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cyBpcyBmYWlsaW5nIHRvIHJ1biB0 ZXN0bWFzbSBvZiA2NGJpdCBBcHBsZVdpbiBvbiBCdWlsZGJvdAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0ODY5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgUGVyIEFybmUgVm9sbGFuLgorCisgICAgICAgIHRlc3RtYXNtIGlzIGNvbXBpbGVkIG9ubHkg d2hlbiBERVZFTE9QRVJfTU9ERS4KKyAgICAgICAgRW5hYmxlIERFVkVMT1BFUl9NT0RFIGZvciBh bGwgNjRiaXQgV2luZG93cyBidWlsZHMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMu cG06CisgICAgICAgIChnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdCk6IFJlcGxh Y2VkICJpc0ZUVygpIHx8IGlzV2luQ2Fpcm8oKSIgd2l0aCBpc1dpbjY0KCkKKyAgICAgICAgaW4g dGhlIGNvbmRpdGlvbiBvZiBlbmFibGluZyBERVZFTE9QRVJfTU9ERS4KKwogMjAxOS0xMi0wNCAg Sm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgcmVzdWx0cy53 ZWJraXQub3JnOiBEZWNyZWFzZSB0dGwgZm9yIGFyY2hpdmVzCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXgg MDY1Mzk3MGIxODE4Y2FlOTY5NTc5YzRlN2ZhY2ZlMTNjYjYwNjdjMi4uNjQwODU5M2NkZjg5ZDhi NGEyYTZiOTNkOWEzNzExYTE4YjdlMDM2OSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMjI3Myw3ICsy MjczLDcgQEAgc3ViIGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0CiAgICAgcHVz aCBAYXJncywgJy1EU0hPV19CSU5ESU5HU19HRU5FUkFUSU9OX1BST0dSRVNTPTEnIHVubGVzcyAo JHdpbGxVc2VOaW5qYSAmJiAtdCBTVERPVVQpOwogCiAgICAgIyBTb21lIHBvcnRzIGhhdmUgcHJv ZHVjdGlvbiBtb2RlLCBidXQgYnVpbGQtd2Via2l0IHNob3VsZCBhbHdheXMgdXNlIGRldmVsb3Bl ciBtb2RlLgotICAgIHB1c2ggQGFyZ3MsICItRERFVkVMT1BFUl9NT0RFPU9OIiBpZiBpc0ZUVygp IHx8IGlzR3RrKCkgfHwgaXNKU0NPbmx5KCkgfHwgaXNXUEUoKSB8fCBpc1dpbkNhaXJvKCk7Cisg ICAgcHVzaCBAYXJncywgIi1EREVWRUxPUEVSX01PREU9T04iIGlmIGlzR3RrKCkgfHwgaXNKU0NP bmx5KCkgfHwgaXNXUEUoKSB8fCBpc1dpbjY0KCk7CiAKICAgICBpZiAoYXJjaGl0ZWN0dXJlKCkg ZXEgIng4Nl82NCIgJiYgc2hvdWxkQnVpbGQzMkJpdCgpKSB7CiAgICAgICAgICMgQ01BS0VfTElC UkFSWV9BUkNISVRFQ1RVUkUgaXMgbmVlZGVkIHRvIGdldCB0aGUgcmlnaHQgLnBjCg==