204866 2019-12-04 17:19:18 -0800 Fix a broken assertion in GetByStatus::computeForStubInfoWithoutExitSiteFeedback(). 2019-12-04 17:39:22 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1595650 0 mark.lam 2019-12-04 17:19:18 -0800 The assertion wrong assumes that access.offset() cannot be invalid unless the access.type() is a Miss. However, if the AccessCase is a Custom value or accessor, the offset is always invalid. We'll fix the assertion. 1595655 1 384868 mark.lam 2019-12-04 17:25:01 -0800 Created attachment 384868 proposed patch. 1595657 2 384868 saam 2019-12-04 17:28:29 -0800 Comment on attachment 384868 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=384868&action=review > Source/JavaScriptCore/bytecode/GetByStatus.cpp:295 > + ASSERT(access.isCustom() || ((AccessCase::Miss == access.type()) == (access.offset() == invalidOffset))); you could also do: ASSERT(((AccessCase::Miss == access.type() || access.isCustom()) == (access.offset() == invalidOffset))); 1595660 3 mark.lam 2019-12-04 17:38:06 -0800 (In reply to Saam Barati from comment #2) > you could also do: > ASSERT(((AccessCase::Miss == access.type() || access.isCustom()) == > (access.offset() == invalidOffset))); Thanks for the review. I've applied this change. Landed in r253136: <http://trac.webkit.org/r253136>. 1595661 4 webkit-bug-importer 2019-12-04 17:39:22 -0800 <rdar://problem/57648868> 384868 2019-12-04 17:25:01 -0800 2019-12-04 17:28:29 -0800 proposed patch. bug-204866.patch text/plain 2950 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUzMTM0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE5LTEyLTA0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG aXggYSBicm9rZW4gYXNzZXJ0aW9uIGluIEdldEJ5U3RhdHVzOjpjb21wdXRlRm9yU3R1YkluZm9X aXRob3V0RXhpdFNpdGVGZWVkYmFjaygpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjA0ODY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlIGFzc2VydGlvbiB3cm9uZyBhc3N1bWVzIHRoYXQgYWNjZXNz Lm9mZnNldCgpIGNhbm5vdCBiZSBpbnZhbGlkIHVubGVzcyB0aGUKKyAgICAgICAgYWNjZXNzLnR5 cGUoKSBpcyBhIE1pc3MuICBIb3dldmVyLCBpZiB0aGUgQWNjZXNzQ2FzZSBpcyBhIEN1c3RvbSB2 YWx1ZSBvciBhY2Nlc3NvciwKKyAgICAgICAgdGhlIG9mZnNldCBpcyBhbHdheXMgaW52YWxpZC4g IFRoaXMgcGF0Y2ggZml4ZXMgdGhpcyBhc3NlcnRpb24uCisKKyAgICAgICAgKiBieXRlY29kZS9B Y2Nlc3NDYXNlLmg6CisgICAgICAgIChKU0M6OkFjY2Vzc0Nhc2U6OmlzQ3VzdG9tIGNvbnN0KToK KyAgICAgICAgKiBieXRlY29kZS9HZXRCeVN0YXR1cy5jcHA6CisgICAgICAgIChKU0M6OkdldEJ5 U3RhdHVzOjpjb21wdXRlRm9yU3R1YkluZm9XaXRob3V0RXhpdFNpdGVGZWVkYmFjayk6CisKIDIw MTktMTItMDQgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkLCByb2xsaW5nIG91dCByMjUyNDE2LCB2aW1lbyBkb2VzIG5vdCB3b3JrCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQWNjZXNzQ2FzZS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9BY2Nlc3NDYXNlLmgJKHJldmlzaW9u IDI1MzEwOCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9BY2Nlc3NDYXNlLmgJ KHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDE3 IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxNy0y MDE5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlv biBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAq IG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcg Y29uZGl0aW9ucwpAQCAtMTc5LDYgKzE3OSwxOSBAQCBwdWJsaWM6CiAgICAgLy8gcGFzdCB0aGUg Y2FsbC4KICAgICBib29sIGRvZXNDYWxscyhWZWN0b3I8SlNDZWxsKj4qIGNlbGxzVG9NYXJrID0g bnVsbHB0cikgY29uc3Q7CiAKKyAgICBib29sIGlzQ3VzdG9tKCkgY29uc3QKKyAgICB7CisgICAg ICAgIHN3aXRjaCAodHlwZSgpKSB7CisgICAgICAgIGNhc2UgQ3VzdG9tVmFsdWVHZXR0ZXI6Cisg ICAgICAgIGNhc2UgQ3VzdG9tQWNjZXNzb3JHZXR0ZXI6CisgICAgICAgIGNhc2UgQ3VzdG9tVmFs dWVTZXR0ZXI6CisgICAgICAgIGNhc2UgQ3VzdG9tQWNjZXNzb3JTZXR0ZXI6CisgICAgICAgICAg ICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgZGVmYXVsdDoKKyAgICAgICAgICAgIHJldHVybiBmYWxz ZTsKKyAgICAgICAgfQorICAgIH0KKwogICAgIGJvb2wgaXNHZXR0ZXIoKSBjb25zdAogICAgIHsK ICAgICAgICAgc3dpdGNoICh0eXBlKCkpIHsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9i eXRlY29kZS9HZXRCeVN0YXR1cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb2RlL0dldEJ5U3RhdHVzLmNwcAkocmV2aXNpb24gMjUzMTA4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0dldEJ5U3RhdHVzLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMjkyLDcgKzI5Miw3IEBAIEdldEJ5U3RhdHVzIEdldEJ5U3RhdHVzOjpjb21wdXRlRm9yU3R1 YkkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIEdldEJ5U3RhdHVzKEpTQzo6c2xvd1ZlcnNp b24oc3VtbWFyeSksICpzdHViSW5mbyk7CiAgICAgICAgICAgICAgICAgfSB9CiAKLSAgICAgICAg ICAgICAgICBBU1NFUlQoKEFjY2Vzc0Nhc2U6Ok1pc3MgPT0gYWNjZXNzLnR5cGUoKSkgPT0gKGFj Y2Vzcy5vZmZzZXQoKSA9PSBpbnZhbGlkT2Zmc2V0KSk7CisgICAgICAgICAgICAgICAgQVNTRVJU KGFjY2Vzcy5pc0N1c3RvbSgpIHx8ICgoQWNjZXNzQ2FzZTo6TWlzcyA9PSBhY2Nlc3MudHlwZSgp KSA9PSAoYWNjZXNzLm9mZnNldCgpID09IGludmFsaWRPZmZzZXQpKSk7CiAgICAgICAgICAgICAg ICAgR2V0QnlJZFZhcmlhbnQgdmFyaWFudCgKICAgICAgICAgICAgICAgICAgICAgdHJhY2tJZGVu dGlmaWVycyA9PSBUcmFja0lkZW50aWZpZXJzOjpZZXMgPyBhY2Nlc3MuaWRlbnRpZmllcigpIDog Qm94PElkZW50aWZpZXI+KG51bGxwdHIpLCBTdHJ1Y3R1cmVTZXQoc3RydWN0dXJlKSwgY29tcGxl eEdldFN0YXR1cy5vZmZzZXQoKSwKICAgICAgICAgICAgICAgICAgICAgY29tcGxleEdldFN0YXR1 cy5jb25kaXRpb25TZXQoKSwgV1RGTW92ZShjYWxsTGlua1N0YXR1cyksCg==