204864 2019-12-04 16:53:52 -0800 IPC messages may get processed out of order in some cases 2019-12-04 20:14:19 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen ap beidson commit-queue ggaren rniwa webkit-bug-importer oldest_to_newest 1595639 0 cdumez 2019-12-04 16:53:52 -0800 IPC messages may get processed out of order in some cases. Connection::SyncMessageState::dispatchMessages() puts messages it did not process back at the end of the queue, instead of the beginning. This means that messages added to the queue while Connection::SyncMessageState::dispatchMessages() was running will incorrectly run *before* the ones dispatchMessages() did not process. 1595643 1 384864 cdumez 2019-12-04 16:56:02 -0800 Created attachment 384864 Patch 1595666 2 ap 2019-12-04 18:12:28 -0800 Is this related to bug 141122? 1595667 3 cdumez 2019-12-04 18:17:21 -0800 (In reply to Alexey Proskuryakov from comment #2) > Is this related to bug 141122? I will check if it helps, I have not checked. I just happened to be looking at this code today for perf reasons and noticed the logic was wrong. 1595685 4 384864 commit-queue 2019-12-04 20:13:25 -0800 Comment on attachment 384864 Patch Clearing flags on attachment: 384864 Committed r253138: <https://trac.webkit.org/changeset/253138> 1595686 5 commit-queue 2019-12-04 20:13:27 -0800 All reviewed patches have been landed. Closing bug. 1595687 6 webkit-bug-importer 2019-12-04 20:14:19 -0800 <rdar://problem/57651997> 384864 2019-12-04 16:56:02 -0800 2019-12-04 20:13:25 -0800 Patch bug-204864-20191204165602.patch text/plain 2676 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDViYTU4M2NkZjUyNGY0NDEw NTA5ZTY1OGJhOTFjOThhZWVlYTUwNDYuLjMwMWJjZmJjYjczZTMwMmFhZGJkMDJhOTQ4NTY3NjY0 NzkyZTVkZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMTItMDQgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBJUEMgbWVzc2FnZXMgbWF5IGdldCBw cm9jZXNzZWQgb3V0IG9mIG9yZGVyIGluIHNvbWUgY2FzZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDg2NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElQQyBtZXNzYWdlcyBtYXkgZ2V0IHByb2Nlc3Nl ZCBvdXQgb2Ygb3JkZXIgaW4gc29tZSBjYXNlcy4gQ29ubmVjdGlvbjo6U3luY01lc3NhZ2VTdGF0 ZTo6ZGlzcGF0Y2hNZXNzYWdlcygpCisgICAgICAgIHB1dHMgbWVzc2FnZXMgaXQgZGlkIG5vdCBw cm9jZXNzIGJhY2sgYXQgdGhlIGVuZCBvZiB0aGUgcXVldWUsIGluc3RlYWQgb2YgdGhlIGJlZ2lu bmluZy4gVGhpcyBtZWFucyB0aGF0CisgICAgICAgIG1lc3NhZ2VzIGFkZGVkIHRvIHRoZSBxdWV1 ZSB3aGlsZSBDb25uZWN0aW9uOjpTeW5jTWVzc2FnZVN0YXRlOjpkaXNwYXRjaE1lc3NhZ2VzKCkg d2FzIHJ1bm5pbmcgd2lsbAorICAgICAgICBpbmNvcnJlY3RseSBydW4gKmJlZm9yZSogdGhlIG9u ZXMgZGlzcGF0Y2hNZXNzYWdlcygpIGRpZCBub3QgcHJvY2Vzcy4KKworICAgICAgICAqIFBsYXRm b3JtL0lQQy9Db25uZWN0aW9uLmNwcDoKKyAgICAgICAgKElQQzo6Q29ubmVjdGlvbjo6U3luY01l c3NhZ2VTdGF0ZTo6ZGlzcGF0Y2hNZXNzYWdlcyk6CisKIDIwMTktMTItMDQgIEthdGUgQ2hlbmV5 ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CiAKICAgICAgICAgRXhwb3NlIGJhc2ljIElU UCBkYXRhIGZyb20gdGhlIGRhdGFiYXNlIGZvciBmdXR1cmUgQVBJL1NQSSB1c2UKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uY3BwIGIvU291cmNlL1dl YktpdC9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5jcHAKaW5kZXggOTk4NmZiMzdmYTI0NjM0Yjk3 NmNlYTRjOWE4N2E0MzI2NzRiMWQ3NC4uODg5MDRhYzdlYTQzMzZmYjA1Y2FkYzYzYWUyYmZhZWE2 ZDMxODM0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlv bi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5jcHAKQEAg LTE3Niw5ICsxNzYsNyBAQCB2b2lkIENvbm5lY3Rpb246OlN5bmNNZXNzYWdlU3RhdGU6OmRpc3Bh dGNoTWVzc2FnZXMoQ29ubmVjdGlvbiogYWxsb3dlZENvbm5lY3RpbwogCiAgICAgVmVjdG9yPENv bm5lY3Rpb25BbmRJbmNvbWluZ01lc3NhZ2U+IG1lc3NhZ2VzVG9QdXRCYWNrOwogCi0gICAgZm9y IChzaXplX3QgaSA9IDA7IGkgPCBtZXNzYWdlc1RvRGlzcGF0Y2hXaGlsZVdhaXRpbmdGb3JTeW5j UmVwbHkuc2l6ZSgpOyArK2kpIHsKLSAgICAgICAgQ29ubmVjdGlvbkFuZEluY29taW5nTWVzc2Fn ZSYgY29ubmVjdGlvbkFuZEluY29taW5nTWVzc2FnZSA9IG1lc3NhZ2VzVG9EaXNwYXRjaFdoaWxl V2FpdGluZ0ZvclN5bmNSZXBseVtpXTsKLQorICAgIGZvciAoYXV0byYgY29ubmVjdGlvbkFuZElu Y29taW5nTWVzc2FnZSA6IG1lc3NhZ2VzVG9EaXNwYXRjaFdoaWxlV2FpdGluZ0ZvclN5bmNSZXBs eSkgewogICAgICAgICBpZiAoYWxsb3dlZENvbm5lY3Rpb24gJiYgYWxsb3dlZENvbm5lY3Rpb24g IT0gY29ubmVjdGlvbkFuZEluY29taW5nTWVzc2FnZS5jb25uZWN0aW9uLnB0cigpKSB7CiAgICAg ICAgICAgICAvLyBUaGlzIGluY29taW5nIG1lc3NhZ2UgYmVsb25ncyB0byBhbm90aGVyIGNvbm5l Y3Rpb24gYW5kIHdlIGRvbid0IHdhbnQgdG8gZGlzcGF0Y2ggaXQgbm93CiAgICAgICAgICAgICAv LyBzbyBtYXJrIGl0IHRvIGJlIHB1dCBiYWNrIGluIHRoZSBtZXNzYWdlIHF1ZXVlLgpAQCAtMTkx LDkgKzE4OSw4IEBAIHZvaWQgQ29ubmVjdGlvbjo6U3luY01lc3NhZ2VTdGF0ZTo6ZGlzcGF0Y2hN ZXNzYWdlcyhDb25uZWN0aW9uKiBhbGxvd2VkQ29ubmVjdGlvCiAKICAgICBpZiAoIW1lc3NhZ2Vz VG9QdXRCYWNrLmlzRW1wdHkoKSkgewogICAgICAgICBzdGQ6OmxvY2tfZ3VhcmQ8TG9jaz4gbG9j ayhtX211dGV4KTsKLQotICAgICAgICBmb3IgKGF1dG8mIG1lc3NhZ2UgOiBtZXNzYWdlc1RvUHV0 QmFjaykKLSAgICAgICAgICAgIG1fbWVzc2FnZXNUb0Rpc3BhdGNoV2hpbGVXYWl0aW5nRm9yU3lu Y1JlcGx5LmFwcGVuZChXVEZNb3ZlKG1lc3NhZ2UpKTsKKyAgICAgICAgbWVzc2FnZXNUb1B1dEJh Y2suYXBwZW5kVmVjdG9yKFdURk1vdmUobV9tZXNzYWdlc1RvRGlzcGF0Y2hXaGlsZVdhaXRpbmdG b3JTeW5jUmVwbHkpKTsKKyAgICAgICAgbV9tZXNzYWdlc1RvRGlzcGF0Y2hXaGlsZVdhaXRpbmdG b3JTeW5jUmVwbHkgPSBXVEZNb3ZlKG1lc3NhZ2VzVG9QdXRCYWNrKTsKICAgICB9CiB9CiAK