204848 2019-12-04 05:33:20 -0800 [GStreamer] Crashes in MediaPlayerPrivateGStreamer::ensureGstGLContext 2019-12-09 01:19:03 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=201507 P2 Normal --- 1 mcatanzaro pnormand calvaris cgarcia eric.carlson ews-watchlist glenn gustavo jer.noble mcatanzaro menard philipj pnormand sergio vjaquez webkit-bug-importer oldest_to_newest 1595450 0 mcatanzaro 2019-12-04 05:33:20 -0800 When WebKit has somehow gotten itself into the "bad state" described in bug #201507, webpages that use GStreamerGL crash instead of falling back to non-AC mode. Once the mysterious bad state is achieved, it becomes 100% reproducible by loading https://riot.igalia.com. Program terminated with signal SIGSEGV, Segmentation fault. #0 WebCore::MediaPlayerPrivateGStreamer::ensureGstGLContext ( this=0x7f8c214d5700) at ../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1916 1916 GstGLPlatform glPlatform = webkitContext->isEGLContext() ? GST_GL_PLATFORM_EGL : GST_GL_PLATFORM_GLX; (gdb) bt full #0 0x00007f8ca4020e5a in WebCore::MediaPlayerPrivateGStreamer::ensureGstGLContext() (this=0x7f8c214d5700) at ../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1916 sharedDisplay = <optimized out> shouldAdoptRef = true webkitContext = 0x0 glPlatform = <optimized out> glAPI = <optimized out> contextHandle = <optimized out> previousActiveContext = <optimized out> #1 0x00007f8ca4020e5a in WebCore::MediaPlayerPrivateGStreamer::ensureGstGLContext() (this=0x7f8c214d5700) at ../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1861 #2 0x00007f8ca40213f9 in WebCore::MediaPlayerPrivateGStreamer::requestGLContext(char const*) (this=0x7f8c214d5700, contextType=0x7f8ca42e2725 "gst.gl.GLDisplay") at ../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1838 #3 0x00007f8ca402382c in WebCore::MediaPlayerPrivateGStreamer::ensureGLVideoSinkContext() (this=this@entry=0x7f8c214d5700) at ../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:3700 #4 0x00007f8ca4023af8 in WebCore::MediaPlayerPrivateGStreamer::changePipelineState(GstState) (this=0x7f8c214d5700, newState=GST_STATE_PAUSED) at ../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1187 currentState = GST_STATE_NULL pending = GST_STATE_VOID_PENDING __FUNCTION__ = "changePipelineState" setStateResult = <optimized out> pausedOrPlaying = <optimized out> #5 0x00007f8ca401eff5 in WebCore::MediaPlayerPrivateGStreamer::commitLoad() (this=0x7f8c214d5700) at ../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:591 __FUNCTION__ = "commitLoad" #6 0x00007f8ca402f498 in WebCore::MediaPlayerPrivateGStreamer::loadFull(WTF::String const&, WTF::String const&) (this=0x7f8c214d5700, urlString=..., pipelineName=...) at ../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:550 url = {m_string = {static MaxLength = 2147483647, m_impl = {static isRefPtr = <error reading variable: Missing ELF symbol "WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> >::isRefPtr".>, m_ptr = 0x7f8c318f96f0}}, m_isValid = 1, m_protocolIsInHTTPFamily = 1, m_cannotBeABaseURL = 0, m_portLength = 0, static maxPortLength = 7, static maxSchemeLength = 67108863, m_schemeEnd = 5, m_userStart = 8, m_userEnd = 8, m_passwordEnd = 8, m_hostEnd = 23, m_pathAfterLastSlash = 30, m_pathEnd = 41, m_queryEnd = 41} __FUNCTION__ = "loadFull" #7 0x00007f8ca402f588 in WebCore::MediaPlayerPrivateGStreamer::load(WTF::String const&) (this=<optimized out>, urlString=...) at DerivedSources/ForwardingHeaders/wtf/RefPtr.h:56 #8 0x00007f8ca39d5033 in WebCore::MediaPlayer::loadWithNextMediaEngine(WebCore::MediaPlayerFactory const*) (this=this@entry=0x7f8c31721398, current=current@entry=0x0) at DerivedSources/ForwardingHeaders/wtf/URL.h:94 engine = <optimized out> #9 0x00007f8ca39d533e in WebCore::MediaPlayer::load(WTF::URL const&, WebCore::ContentType const&, WTF::String const&) (this=0x7f8c31721398, url=..., contentType=..., keySystem=...) at ../Source/WebCore/platform/graphics/MediaPlayer.cpp:410 protectedThis = {static isRef = <error reading variable: Missing ELF symbol "WTF::Ref<WebCore::MediaPlayer, WTF::DumbPtrTraits<WebCore::MediaPlayer> >::isRef".>, m_ptr = 0x7f8c31721398} #10 0x00007f8ca3530a22 in WebCore::HTMLMediaElement::loadResource(WTF::URL const&, WebCore::ContentType&, WTF::String const&) (this=this@entry=0x7f8c4a82f390, initialURL=..., contentType=..., keySystem=...) at ../Source/WebCore/html/HTMLMediaElement.cpp:1618 frame = {static isRefPtr = <error reading variable: Missing ELF symbol "WTF::RefPtr<WebCore::Frame, WTF::DumbPtrTraits<WebCore::Frame> >::isRefPtr".>, m_ptr = 0x7f8c9ad87000} page = <optimized out> url = {m_string = {static MaxLength = 2147483647, m_impl = {static isRefPtr = <error reading variable: Missing ELF symbol "WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> >::isRefPtr".>, m_ptr = 0x7f8c318f96f0}}, m_isValid = 1, m_protocolIsInHTTPFamily = 1, m_cannotBeABaseURL = 0, m_portLength = 0, static maxPortLength = 7, static maxSchemeLength = 67108863, m_schemeEnd = 5, m_userStart = 8, m_userEnd = 8, m_passwordEnd = 8, m_hostEnd = 23, m_pathAfterLastSlash = 30, m_pathEnd = 41, m_queryEnd = 41} resource = 0x0 loadAttempted = false #11 0x00007f8ca3531325 in WebCore::HTMLMediaElement::loadNextSourceChild() (this=0x7f8c4a82f390) at ../Source/WebCore/html/HTMLMediaElement.cpp:1499 contentType = {m_type = {static MaxLength = 2147483647, m_impl = {static isRefPtr = <error reading variable: Missing ELF symbol "WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> >::isRefPtr".>, m_ptr = 0x7f8c495cf2c0}}} keySystem = {static MaxLength = 2147483647, m_impl = {static isRefPtr = <error reading variable: Missing ELF symbol "WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> >::isRefPtr".>, m_ptr = 0x0}} mediaURL = {m_string = {static MaxLength = 2147483647, m_impl = {static isRefPtr = <error reading variable: Missing ELF symbol "WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> >::isRefPtr".>, m_ptr = 0x7f8c318f96f0}}, m_isValid = 1, m_protocolIsInHTTPFamily = 1, m_cannotBeABaseURL = 0, m_portLength = 0, static maxPortLength = 7, static maxSchemeLength = 67108863, m_schemeEnd = 5, m_userStart = 8, m_userEnd = 8, m_passwordEnd = 8, m_hostEnd = 23, m_pathAfterLastSlash = 30, m_pathEnd = 41, m_queryEnd = 41} #12 0x00007f8ca3531715 in WebCore::HTMLMediaElement::<lambda()>::operator() (__closure=<optimized out>) at ../Source/WebCore/html/HTMLMediaElement.cpp:1481 mode = WebCore::HTMLMediaElement::<lambda()>::Children #13 0x00007f8ca3531715 in WTF::Detail::CallableWrapper<WebCore::HTMLMediaElement::selectMediaResource()::<lambda()>, void>::call(void) (this=0x7f8c214ccf78) at DerivedSources/ForwardingHeaders/wtf/Function.h:52 #14 0x00007f8ca3922b4d in WTF::Function<void ()>::operator()() const (this=<synthetic pointer>) at DerivedSources/ForwardingHeaders/wtf/Function.h:76 task = {m_callableWrapper = std::unique_ptr<WTF::Detail::CallableWrapperBase<void>> = {get() = 0x7f8c214ccf90}} #15 0x00007f8ca3922b4d in WebCore::TaskDispatcher<WebCore::Timer>::dispatchOneTask() (this=0x7f8c4a82f798) at ../Source/WebCore/platform/GenericTaskQueue.cpp:110 task = {m_callableWrapper = std::unique_ptr<WTF::Detail::CallableWrapperBase<void>> = {get() = 0x7f8c214ccf90}} #16 0x00007f8ca3922c1e in WebCore::TaskDispatcher<WebCore::Timer>::sharedTimerFired() () at ../Source/WebCore/platform/GenericTaskQueue.cpp:85 queuedDispatchers = {m_start = 1, m_end = 5, m_buffer = {<WTF::VectorBufferBase<WTF::WeakPtr<WebCore::TaskDispatcher<WebCore::Timer> > >> = {m_buffer = 0x7f8c22482c00, m_capacity = 16, m_size = <optimized out>}, <No data fields>}} #17 0x00007f8ca394df74 in WebCore::ThreadTimers::sharedTimerFiredInternal() (this=0x7f8c9ad8e370) at ../Source/WebCore/platform/ThreadTimers.h:104 item = {static isRef = <error reading variable: Missing ELF symbol "WTF::Ref<WebCore::ThreadTimerHeapItem, WTF::DumbPtrTraits<WebCore::ThreadTimerHeapItem> >::isRef".>, m_ptr = 0x7f8c214a4600} timer = <optimized out> interval = <optimized out> timeToQuit = <optimized out> #18 0x00007f8ca394df74 in WebCore::ThreadTimers::sharedTimerFiredInternal() (this=0x7f8c9ad8e370) at ../Source/WebCore/platform/ThreadTimers.cpp:101 #19 0x00007f8ca0341448 in WTF::RunLoop::TimerBase::<lambda(gpointer)>::operator() (__closure=0x0, userData=0x7f8ca4e6a9d0 <WebCore::MainThreadSharedTimer::singleton()::instance+16>) at ../Source/WTF/wtf/glib/RunLoopGLib.cpp:177 timer = 0x7f8ca4e6a9d0 <WebCore::MainThreadSharedTimer::singleton()::instance+16> source = 0x55ad6cd8fb10 #20 0x00007f8ca0341448 in WTF::RunLoop::TimerBase::<lambda(gpointer)>::_FUN(gpointer) () at ../Source/WTF/wtf/glib/RunLoopGLib.cpp:183 #21 0x00007f8ca09c358e in g_main_context_remove_poll (context=0x55ad6cad3d90, fd=0x55ad6cd8fae0) at ../glib/gmain.c:4456 __func__ = "g_main_context_remove_poll" #22 0xffffffff06278ef0 in () #23 0x0000000000000001 in () #24 0x0000000000000000 in () 1595452 1 mcatanzaro 2019-12-04 05:35:51 -0800 This also causes every article page on https://vox.com to crash (again, only after the bad UI process state has been achieved). 1595800 2 384903 pnormand 2019-12-05 07:48:53 -0800 Created attachment 384903 Patch 1595802 3 pnormand 2019-12-05 07:51:53 -0800 Untested, since I can't reproduce your bugs. :) So please. Test! 1595804 4 mcatanzaro 2019-12-05 08:11:27 -0800 I can't reproduce it either, Phil. This just seems to happen once every few days. I'll let you know if I still see the crashes in 2.27.4. 1596777 5 pnormand 2019-12-09 01:18:33 -0800 Committed r253284: <https://trac.webkit.org/changeset/253284> 384903 2019-12-05 07:48:53 -0800 2019-12-08 08:11:58 -0800 Patch bug-204848-20191205154851.patch text/plain 2426 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjUyZjhiNzA0Yzk3MWY1 NzQ5YTBmNDI3NzBlYzc1NDBiZGRkYTM5ZS4uNDYzNDkzMjA3ZDJlY2JkZTMyNDY4MWY5Mjg3ZjU1 Y2I3ZjFkYmNkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTEyLTA1ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBDcmFzaGVzIGluIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6ZW5zdXJlR3N0R0xDb250 ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ4 NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtl IHN1cmUgdGhlIEdMIHZpZGVvIHNpbmsgdXNlcyBhIHZhbGlkIFdlYktpdCBzaGFyZWQgR0wgY29u dGV4dC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HTFZpZGVvU2lu a0dTdHJlYW1lci5jcHA6CisgICAgICAgIChlbnN1cmVHc3RHTENvbnRleHQpOgorICAgICAgICAo d2ViS2l0R0xWaWRlb1NpbmtQcm9iZVBsYXRmb3JtKToKKwogMjAxOS0xMi0wNSAgeW91ZW5uIGZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgaW5zcGVjdG9yL3BhZ2Uvb3ZlcnJp ZGVTZXR0aW5nLU1vY2tDYXB0dXJlRGV2aWNlc0VuYWJsZWQuaHRtbCBpcyBmYWlsaW5nIGFmdGVy IHJlbW92YWwgb2YgaW50ZXJuYWxzLnNldE1vY2tNZWRpYUNhcHR1cmVEZXZpY2VzRW5hYmxlZCBB UEkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9HTFZpZGVvU2lua0dTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvR0xWaWRlb1NpbmtHU3RyZWFtZXIuY3BwCmluZGV4IGRiMTNlODgyYzU0 YjE2MTkwZDFiY2E2NTVjOGQwY2U2ZDFjN2ZjMTguLjMyYWE4NTkyMzJiMzdiMTgxZmExY2MwNWFi MGIwZjE4NzJlMjZjMmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9HTFZpZGVvU2lua0dTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dMVmlkZW9TaW5rR1N0cmVhbWVyLmNwcApA QCAtMTkwLDYgKzE5MCwxMiBAQCBzdGF0aWMgYm9vbCBlbnN1cmVHc3RHTENvbnRleHQoV2ViS2l0 R0xWaWRlb1NpbmsqIHNpbmspCiAgICAgfQogCiAgICAgR0xDb250ZXh0KiBzaGFyZWRDb250ZXh0 ID0gc2hhcmVkRGlzcGxheS5zaGFyaW5nR0xDb250ZXh0KCk7CisgICAgaWYgKCFzaGFyZWRDb250 ZXh0KSB7CisgICAgICAgIEdTVF9FTEVNRU5UX0VSUk9SKEdTVF9FTEVNRU5UX0NBU1Qoc2luayks IFJFU09VUkNFLCBOT1RfRk9VTkQsICgoIldlYktpdCBzaGFyZWQgR0wgY29udGV4dCB1bmF2YWls YWJsZSIpKSwKKyAgICAgICAgICAgICgiVGhlIFdlYktpdCBzaGFyZWQgR0wgY29udGV4dCBzb21l aG93IGRpc2FwcGVhcmVkLiBWaWRlbyB0ZXh0dXJlcyByZW5kZXJpbmcgd2lsbCBmYWlsLiIpKTsK KyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKwogICAgIC8vIEVHTCBhbmQgR0xYIGFyZSBt dXR1YWxseSBleGNsdXNpdmUsIG5vIG5lZWQgZm9yIGlmZGVmcyBoZXJlLgogICAgIEdzdEdMUGxh dGZvcm0gZ2xQbGF0Zm9ybSA9IHNoYXJlZENvbnRleHQtPmlzRUdMQ29udGV4dCgpID8gR1NUX0dM X1BMQVRGT1JNX0VHTCA6IEdTVF9HTF9QTEFURk9STV9HTFg7CiAKQEAgLTM0MSw2ICszNDcsMTMg QEAgdm9pZCB3ZWJLaXRHTFZpZGVvU2lua1NldE1lZGlhUGxheWVyUHJpdmF0ZShXZWJLaXRHTFZp ZGVvU2luayogc2luaywgTWVkaWFQbGF5ZXIKIAogYm9vbCB3ZWJLaXRHTFZpZGVvU2lua1Byb2Jl UGxhdGZvcm0oKQogeworICAgIGF1dG8mIHNoYXJlZERpc3BsYXkgPSBQbGF0Zm9ybURpc3BsYXk6 OnNoYXJlZERpc3BsYXlGb3JDb21wb3NpdGluZygpOworICAgIEdMQ29udGV4dCogc2hhcmVkQ29u dGV4dCA9IHNoYXJlZERpc3BsYXkuc2hhcmluZ0dMQ29udGV4dCgpOworICAgIGlmICghc2hhcmVk Q29udGV4dCkgeworICAgICAgICBHU1RfV0FSTklORygiV2ViS2l0IHNoYXJlZCBHTCBjb250ZXh0 IGlzIG5vdCBhdmFpbGFibGUuIik7CisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisKICAg ICByZXR1cm4gaXNHU3RyZWFtZXJQbHVnaW5BdmFpbGFibGUoImFwcCIpICYmIGlzR1N0cmVhbWVy UGx1Z2luQXZhaWxhYmxlKCJvcGVuZ2wiKTsKIH0KIAo=