204837 2019-12-03 21:27:29 -0800 Remove unused DragController::client() 2019-12-03 22:31:20 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates webkit-bug-importer wenson_hsieh oldest_to_newest 1595366 0 dbates 2019-12-03 21:27:29 -0800 Quick authoring check shows that DragController::client() has never been used since its inception in <http://trac.webkit.org/r19039>. Moreover, it exposes DragController internals, which diminishes its encapsulation capabilities. 1595367 1 384787 dbates 2019-12-03 21:29:46 -0800 Created attachment 384787 Patch 1595379 2 384787 dbates 2019-12-03 22:30:25 -0800 Comment on attachment 384787 Patch Clearing flags on attachment: 384787 Committed r253094: <https://trac.webkit.org/changeset/253094> 1595380 3 dbates 2019-12-03 22:30:27 -0800 All reviewed patches have been landed. Closing bug. 1595381 4 webkit-bug-importer 2019-12-03 22:31:20 -0800 <rdar://problem/57615121> 384787 2019-12-03 21:29:46 -0800 2019-12-03 22:30:25 -0800 Patch bug-204837-20191203212945.patch text/plain 1593 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMDkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGYyNDQxYjY4YmU4Zjkz NTcwNTlmNmY5NzMwNDRiNzE1NDUzNGJlMy4uNjMwMmI5YTFjMTRjN2ViOWZjOTVkN2RmNDI1NTE4 YWVjNmExZjg3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTEyLTAzICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW51c2VkIERy YWdDb250cm9sbGVyOjpjbGllbnQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjA0ODM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgSXQgaGFzIG5ldmVyIGJlZW4gdXNlZCBzaW5jZSBpdHMgaW5jZXB0aW9u IGluIHIxOTAzOS4gTW9yZW92ZXIgaXQgZXhwb3NlcyBEcmFnQ29udHJvbGxlcidzCisgICAgICAg IGludGVybmFscywgd2hpY2ggZGltaW5pc2hlcyBpdHMgZW5jYXBzdWxhdGlvbiBjYXBhYmlsaXRp ZXMuCisKKyAgICAgICAgKiBwYWdlL0RyYWdDb250cm9sbGVyLmg6CisgICAgICAgIChXZWJDb3Jl OjpEcmFnQ29udHJvbGxlcjo6Y2xpZW50IGNvbnN0KTogRGVsZXRlZC4KKwogMjAxOS0xMi0wMyAg Unlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXBsYWNlIGN1c3Rv bUphdmFTY3JpcHRVc2VyQWdlbnRBc1NpdGVTcGVjaWZpY1F1aXJrcyB3aXRoIGN1c3RvbVVzZXJB Z2VudEFzU2l0ZVNwZWNpZmljUXVpcmtzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L0RyYWdDb250cm9sbGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmgK aW5kZXggZDJiYTFmY2FiMTFjZjJiOWI4YzRhZDZjYmE3MWYwMzVjMjIzYWQyYS4uNDI1MjZiMTE1 YzQ0NWRkNjcyNGJmYWQyYThmNGE2ZWUxNjg3YWQzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGFnZS9EcmFnQ29udHJvbGxlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRHJhZ0Nv bnRyb2xsZXIuaApAQCAtNTksOCArNTksNiBAQCBzdHJ1Y3QgUHJvbWlzZWRBdHRhY2htZW50SW5m bzsKICAgICAgICAgc3RhdGljIHN0ZDo6dW5pcXVlX3B0cjxEcmFnQ29udHJvbGxlcj4gY3JlYXRl KFBhZ2UmLCBEcmFnQ2xpZW50Jik7CiAgICAgICAgIHN0YXRpYyBEcmFnT3BlcmF0aW9uIHBsYXRm b3JtR2VuZXJpY0RyYWdPcGVyYXRpb24oKTsKIAotICAgICAgICBEcmFnQ2xpZW50JiBjbGllbnQo KSBjb25zdCB7IHJldHVybiBtX2NsaWVudDsgfQotCiAgICAgICAgIFdFQkNPUkVfRVhQT1JUIERy YWdPcGVyYXRpb24gZHJhZ0VudGVyZWQoY29uc3QgRHJhZ0RhdGEmKTsKICAgICAgICAgV0VCQ09S RV9FWFBPUlQgdm9pZCBkcmFnRXhpdGVkKGNvbnN0IERyYWdEYXRhJik7CiAgICAgICAgIFdFQkNP UkVfRVhQT1JUIERyYWdPcGVyYXRpb24gZHJhZ1VwZGF0ZWQoY29uc3QgRHJhZ0RhdGEmKTsK