204833 2019-12-03 20:13:30 -0800 Web Inspector: move the "Add Breakpoint" context menu to be next to the blackboxing context menu item 2019-12-05 12:19:28 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1595349 0 hi 2019-12-03 20:13:30 -0800 Since both items are related to JavaScript debugging, it doesn't make sense to have them so far apart. 1595351 1 384782 hi 2019-12-03 20:14:37 -0800 Created attachment 384782 Patch 1595930 2 384782 commit-queue 2019-12-05 12:18:50 -0800 Comment on attachment 384782 Patch Clearing flags on attachment: 384782 Committed r253162: <https://trac.webkit.org/changeset/253162> 1595931 3 commit-queue 2019-12-05 12:18:51 -0800 All reviewed patches have been landed. Closing bug. 1595933 4 webkit-bug-importer 2019-12-05 12:19:28 -0800 <rdar://problem/57672795> 384782 2019-12-03 20:14:37 -0800 2019-12-05 12:18:50 -0800 Patch bug-204833-20191203201436.patch text/plain 3276 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDVlMWRhMzRhN2ZmNDY0OTQ1MzA0MzhjZTVjNzAz YmM2MWY3ZTdhNjQuLmFiM2FkY2VhODllZGI5OTNjNDljMmMxMzhkZGU4OTk0ZWIyY2Q1MTcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTEyLTAzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBt b3ZlIHRoZSAiQWRkIEJyZWFrcG9pbnQiIGNvbnRleHQgbWVudSB0byBiZSBuZXh0IHRvIHRoZSBi bGFja2JveGluZyBjb250ZXh0IG1lbnUgaXRlbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0ODMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQm90aCBpdGVtcyBhcmUgcmVsYXRlZCB0byBKYXZhU2NyaXB0 IGRlYnVnZ2luZywgc28gdGhleSBzaG91bGQgYmUgY2xvc2VyIHRvZ2V0aGVyLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9WaWV3cy9Db250ZXh0TWVudVV0aWxpdGllcy5qczoKKyAgICAgICAg KFdJLmFwcGVuZENvbnRleHRNZW51SXRlbXNGb3JTb3VyY2VDb2RlKToKKwogMjAxOS0xMi0wMiAg TmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5z cGVjdG9yOiBQcm92aWRlIFVJIHRvIGNvbnZlcnQgYmV0d2VlbiBzUkdCIGFuZCBwMyBjb2xvciBz cGFjZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0NvbnRleHRNZW51VXRpbGl0aWVzLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvQ29udGV4dE1lbnVVdGlsaXRpZXMuanMKaW5kZXggNTM3YTBhODA3ZjNi ZmY5Y2NjNGIwMWYyOTJiMTRmYjMxZmVkNDQ0Yi4uODFkNGQ1MGExOTE2YWQ3YjE4N2ViN2Y0MzUz ZGFlNjQ5ZmE0ODhmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvQ29udGV4dE1lbnVVdGlsaXRpZXMuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29udGV4dE1lbnVVdGlsaXRpZXMuanMKQEAgLTky LDYgKzkyLDE5IEBAIFdJLmFwcGVuZENvbnRleHRNZW51SXRlbXNGb3JTb3VyY2VDb2RlID0gZnVu Y3Rpb24oY29udGV4dE1lbnUsIHNvdXJjZUNvZGVPckxvY2F0CiAKICAgICBjb250ZXh0TWVudS5h cHBlbmRTZXBhcmF0b3IoKTsKIAorICAgIGlmIChsb2NhdGlvbiAmJiAoc291cmNlQ29kZSBpbnN0 YW5jZW9mIFdJLlNjcmlwdCB8fCAoc291cmNlQ29kZSBpbnN0YW5jZW9mIFdJLlJlc291cmNlICYm IHNvdXJjZUNvZGUudHlwZSA9PT0gV0kuUmVzb3VyY2UuVHlwZS5TY3JpcHQgJiYgIXNvdXJjZUNv ZGUuaXNMb2NhbFJlc291cmNlT3ZlcnJpZGUpKSkgeworICAgICAgICBsZXQgZXhpc3RpbmdCcmVh a3BvaW50ID0gV0kuZGVidWdnZXJNYW5hZ2VyLmJyZWFrcG9pbnRGb3JTb3VyY2VDb2RlTG9jYXRp b24obG9jYXRpb24pOworICAgICAgICBpZiAoZXhpc3RpbmdCcmVha3BvaW50KSB7CisgICAgICAg ICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdJLlVJU3RyaW5nKCJEZWxldGUgQnJlYWtwb2lu dCIpLCAoKSA9PiB7CisgICAgICAgICAgICAgICAgV0kuZGVidWdnZXJNYW5hZ2VyLnJlbW92ZUJy ZWFrcG9pbnQoZXhpc3RpbmdCcmVha3BvaW50KTsKKyAgICAgICAgICAgIH0pOworICAgICAgICB9 IGVsc2UgeworICAgICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXSS5VSVN0cmluZygi QWRkIEJyZWFrcG9pbnQiKSwgKCkgPT4geworICAgICAgICAgICAgICAgIFdJLmRlYnVnZ2VyTWFu YWdlci5hZGRCcmVha3BvaW50KG5ldyBXSS5CcmVha3BvaW50KGxvY2F0aW9uKSk7CisgICAgICAg ICAgICB9KTsKKyAgICAgICAgfQorICAgIH0KKwogICAgIGlmIChzb3VyY2VDb2RlLnN1cHBvcnRz U2NyaXB0QmxhY2tib3hpbmcpIHsKICAgICAgICAgbGV0IGJsYWNrYm94RGF0YSA9IFdJLmRlYnVn Z2VyTWFuYWdlci5ibGFja2JveERhdGFGb3JTb3VyY2VDb2RlKHNvdXJjZUNvZGUpOwogICAgICAg ICBpZiAoYmxhY2tib3hEYXRhICYmIGJsYWNrYm94RGF0YS50eXBlID09PSBXSS5EZWJ1Z2dlck1h bmFnZXIuQmxhY2tib3hUeXBlLlBhdHRlcm4pIHsKQEAgLTE0NCwyMSArMTU3LDYgQEAgV0kuYXBw ZW5kQ29udGV4dE1lbnVJdGVtc0ZvclNvdXJjZUNvZGUgPSBmdW5jdGlvbihjb250ZXh0TWVudSwg c291cmNlQ29kZU9yTG9jYXQKICAgICB9KTsKIAogICAgIGNvbnRleHRNZW51LmFwcGVuZFNlcGFy YXRvcigpOwotCi0gICAgaWYgKGxvY2F0aW9uICYmIChzb3VyY2VDb2RlIGluc3RhbmNlb2YgV0ku U2NyaXB0IHx8IChzb3VyY2VDb2RlIGluc3RhbmNlb2YgV0kuUmVzb3VyY2UgJiYgc291cmNlQ29k ZS50eXBlID09PSBXSS5SZXNvdXJjZS5UeXBlLlNjcmlwdCAmJiAhc291cmNlQ29kZS5pc0xvY2Fs UmVzb3VyY2VPdmVycmlkZSkpKSB7Ci0gICAgICAgIGxldCBleGlzdGluZ0JyZWFrcG9pbnQgPSBX SS5kZWJ1Z2dlck1hbmFnZXIuYnJlYWtwb2ludEZvclNvdXJjZUNvZGVMb2NhdGlvbihsb2NhdGlv bik7Ci0gICAgICAgIGlmIChleGlzdGluZ0JyZWFrcG9pbnQpIHsKLSAgICAgICAgICAgIGNvbnRl eHRNZW51LmFwcGVuZEl0ZW0oV0kuVUlTdHJpbmcoIkRlbGV0ZSBCcmVha3BvaW50IiksICgpID0+ IHsKLSAgICAgICAgICAgICAgICBXSS5kZWJ1Z2dlck1hbmFnZXIucmVtb3ZlQnJlYWtwb2ludChl eGlzdGluZ0JyZWFrcG9pbnQpOwotICAgICAgICAgICAgfSk7Ci0gICAgICAgIH0gZWxzZSB7Ci0g ICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdJLlVJU3RyaW5nKCJBZGQgQnJlYWtw b2ludCIpLCAoKSA9PiB7Ci0gICAgICAgICAgICAgICAgV0kuZGVidWdnZXJNYW5hZ2VyLmFkZEJy ZWFrcG9pbnQobmV3IFdJLkJyZWFrcG9pbnQobG9jYXRpb24pKTsKLSAgICAgICAgICAgIH0pOwot ICAgICAgICB9Ci0KLSAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kU2VwYXJhdG9yKCk7Ci0gICAg fQogfTsKIAogV0kuYXBwZW5kQ29udGV4dE1lbnVJdGVtc0ZvclVSTCA9IGZ1bmN0aW9uKGNvbnRl eHRNZW51LCB1cmwsIG9wdGlvbnMgPSB7fSkK