204823 2019-12-03 17:00:26 -0800 Web Inspector: Error: Can't make a ContentView for an unknown representedObject of type: CallFrame 2019-12-12 10:34:25 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 yurys yurys commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1595268 0 yurys 2019-12-03 17:00:26 -0800 resource:///org/webkit/inspector/UserInterface/Views/ContentView.js:193:132: CONSOLE ERROR Error: Can't make a ContentView for an unknown representedObject of type: CallFrame is printed to the console when navigating from a paused page. 1595270 1 384769 yurys 2019-12-03 17:05:48 -0800 Created attachment 384769 Patch 1595279 2 384769 hi 2019-12-03 17:25:17 -0800 Comment on attachment 384769 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384769&action=review > Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:708 > - return true; > + return !!typeIdentifier; I don't really see a problem with this change on its own, but I want to know more about why/how this happens. I'd recommend adding a `console.trace()` in `WI.ContentView.createFromRepresentedObject` to see how this gets here. This solution may just mask an actual problem. Describing the steps to reproduce in the bug would also be appreciated :) 1595391 3 384769 yurys 2019-12-03 23:44:31 -0800 Comment on attachment 384769 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384769&action=review >> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:708 >> + return !!typeIdentifier; > > I don't really see a problem with this change on its own, but I want to know more about why/how this happens. I'd recommend adding a `console.trace()` in `WI.ContentView.createFromRepresentedObject` to see how this gets here. This solution may just mask an actual problem. > > Describing the steps to reproduce in the bug would also be appreciated :) Well, this change was made a month ago, I don't remember exact steps off the top of my head. I can try and reproduce it tomorrow maybe it manifested itself when fix for https://bugs.webkit.org/show_bug.cgi?id=204170 is applied. 1595544 4 384830 yurys 2019-12-04 11:23:14 -0800 Created attachment 384830 test page ok, these are the steps to reproduce it on tip of tree: 1. Open inspector for the attached page 2. Click on 'Debugger' button 3. When execution breaks click on 'Navigate' button 4. Resume debugger Result: message in the console, frontend fails with the following trace Error:​ Can't make a ContentView for an unknown representedObject of type:​ CallFrame (at ContentView.js:​193:​132)​ createFromRepresentedObject @ ContentView.js:​193:​24 contentViewForRepresentedObject @ ContentView.js:​214:​72 showContentViewForRepresentedObject @ ContentBrowser.js:​151:​63 showDefaultContentViewForTreeElement @ NavigationSidebarPanel.js:​202:​82 _checkElementsForPendingViewStateCookie @ NavigationSidebarPanel.js:​728:​79 _checkOutlinesForPendingViewStateCookie @ NavigationSidebarPanel.js:​684:​53 finalAttemptToRestoreViewStateFromCookie @ NavigationSidebarPanel.js:​257:​57 finalAttemptToRestoreViewStateFromCookie @ [native code]​ 1595545 5 384769 yurys 2019-12-04 11:23:36 -0800 Comment on attachment 384769 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384769&action=review >>> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:708 >>> + return !!typeIdentifier; >> >> I don't really see a problem with this change on its own, but I want to know more about why/how this happens. I'd recommend adding a `console.trace()` in `WI.ContentView.createFromRepresentedObject` to see how this gets here. This solution may just mask an actual problem. >> >> Describing the steps to reproduce in the bug would also be appreciated :) > > Well, this change was made a month ago, I don't remember exact steps off the top of my head. I can try and reproduce it tomorrow maybe it manifested itself when fix for https://bugs.webkit.org/show_bug.cgi?id=204170 is applied. Added steps in #c4. 1596410 6 yurys 2019-12-06 15:48:33 -0800 Devin, are you good with landing this? 1597668 7 hi 2019-12-11 10:06:29 -0800 (In reply to Yury Semikhatsky from comment #4) > Created attachment 384830 [details] > test page > > ok, these are the steps to reproduce it on tip of tree: > > 1. Open inspector for the attached page > 2. Click on 'Debugger' button > 3. When execution breaks click on 'Navigate' button > 4. Resume debugger > > Result: message in the console, frontend fails with the following trace > > Error:​ Can't make a ContentView for an unknown representedObject of type:​ > CallFrame (at ContentView.js:​193:​132)​ > createFromRepresentedObject @ ContentView.js:​193:​24 > contentViewForRepresentedObject @ ContentView.js:​214:​72 > showContentViewForRepresentedObject @ ContentBrowser.js:​151:​63 > showDefaultContentViewForTreeElement @ NavigationSidebarPanel.js:​202:​82 > _checkElementsForPendingViewStateCookie @ NavigationSidebarPanel.js:​728:​79 > _checkOutlinesForPendingViewStateCookie @ NavigationSidebarPanel.js:​684:​53 > finalAttemptToRestoreViewStateFromCookie @ NavigationSidebarPanel.js:​257:​57 > finalAttemptToRestoreViewStateFromCookie @ [native code]​ These steps don't reproduce for me. From what I can tell, it looks like the issue is that we're attempting to save/restore a `WI.CallFrame` as the currently selected `representedObject` likely in the `WI.SourcesNavigationSidebarPanel`. Whenever a navigation occurs, we're supposed to automatically resume, so I'm not really sure why/how this is happening. As far as this change, what if instead the check was added to the `if` right before? ``` if (!typeIdentifier || typeIdentifier !== representedObject.constructor.TypeIdentifier) ``` What happens with this patch applied? What is the difference in the UI? Does it end up calling through to `showDefaultContentView` because nothing matches the cookie, or does it do something else? 1597784 8 yurys 2019-12-11 14:07:17 -0800 (In reply to Devin Rousso from comment #7) > (In reply to Yury Semikhatsky from comment #4) > > Created attachment 384830 [details] > > > > Error:​ Can't make a ContentView for an unknown representedObject of type:​ > > CallFrame (at ContentView.js:​193:​132)​ > > createFromRepresentedObject @ ContentView.js:​193:​24 > > contentViewForRepresentedObject @ ContentView.js:​214:​72 > > showContentViewForRepresentedObject @ ContentBrowser.js:​151:​63 > > showDefaultContentViewForTreeElement @ NavigationSidebarPanel.js:​202:​82 > > _checkElementsForPendingViewStateCookie @ NavigationSidebarPanel.js:​728:​79 > > _checkOutlinesForPendingViewStateCookie @ NavigationSidebarPanel.js:​684:​53 > > finalAttemptToRestoreViewStateFromCookie @ NavigationSidebarPanel.js:​257:​57 > > finalAttemptToRestoreViewStateFromCookie @ [native code]​ > These steps don't reproduce for me. > Are you trying to reproduce it on GTK Release build? Maybe there is some difference with other platforms as it's 100% reproducible in that configuration for me. > From what I can tell, it looks like the issue is that we're attempting to > save/restore a `WI.CallFrame` as the currently selected `representedObject` > likely in the `WI.SourcesNavigationSidebarPanel`. Whenever a navigation > occurs, we're supposed to automatically resume, so I'm not really sure > why/how this is happening. > The cookie is empty so I don't think we actually 'save' anything there. It's done as last resort as far as I can tell from this comment: // If the specific tree element wasn't found, we may need to wait for the resources // to be registered. We try one last time (match type only) after an arbitrary amount of timeout. this._finalAttemptToRestoreViewStateTimeout = setTimeout(finalAttemptToRestoreViewStateFromCookie.bind(this), relaxedMatchDelay); and the CallFrame just ends up being current represented object. > As far as this change, what if instead the check was added to the `if` right > before? > ``` > if (!typeIdentifier || typeIdentifier !== > representedObject.constructor.TypeIdentifier) > ``` > > What happens with this patch applied? What is the difference in the UI? > Does it end up calling through to `showDefaultContentView` because nothing > matches the cookie, or does it do something else? I don't see any obvious failures which I think is expected as !typeIdentifier should be equivalent to an empty cookie. If you feel confident about fixing it that way, I can do that. See the new patch. 1597785 9 385436 yurys 2019-12-11 14:07:32 -0800 Created attachment 385436 Patch 1597874 10 385436 hi 2019-12-11 17:05:02 -0800 Comment on attachment 385436 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385436&action=review r=me, I'd still like to how how the GTK and Mac ports differ such that this can happen, but I don't really see any harm in this fix as is, so I think it's fine (with one change, and I apologize in advance) > Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:704 > + if (!typeIdentifier || typeIdentifier !== representedObject.constructor.TypeIdentifier) I feel bad for saying this, but I think what you had before was actually correct. We don't want to return if the cookie doesn't have a `WI.TypeIdentifierCookieKey` value, as many cookies don't have one. It's possible for the navigation sidebar to make it's own cookie that doesn't have anything to do with a `representedObject` type, and as such, this code as is would cause that to fail. I apologize for making you go back and forth. ``` if (matchTypeOnly) return !!typeIdentifier; ``` 1598004 11 384769 commit-queue 2019-12-12 08:57:25 -0800 Comment on attachment 384769 Patch Rejecting attachment 384769 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 384769, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebInspectorUI/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13290561 1598020 12 385503 yurys 2019-12-12 09:37:01 -0800 Created attachment 385503 Patch for landing 1598059 13 385503 commit-queue 2019-12-12 10:33:59 -0800 Comment on attachment 385503 Patch for landing Clearing flags on attachment: 385503 Committed r253437: <https://trac.webkit.org/changeset/253437> 1598060 14 commit-queue 2019-12-12 10:34:00 -0800 All reviewed patches have been landed. Closing bug. 1598062 15 webkit-bug-importer 2019-12-12 10:34:25 -0800 <rdar://problem/57882907> 384769 2019-12-03 17:05:48 -0800 2019-12-12 09:37:00 -0800 Patch bug-204823-20191203170547.patch text/plain 1762 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 ZTFkYTM0YTdmZjQ2NDk0NTMwNDM4Y2U1YzcwM2JjNjFmN2U3YTY0Li5hZWRhY2EwMDk0MmY5ZDQz YWZlMTI1NjUxNjEwNjFlMjc2NDgyMjBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0xMi0wMyAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVt Lm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBFcnJvcjogQ2FuJ3QgbWFrZSBhIENvbnRl bnRWaWV3IGZvciBhbiB1bmtub3duIHJlcHJlc2VudGVkT2JqZWN0IG9mIHR5cGU6IENhbGxGcmFt ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0ODIz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgbm8g dHlwZSBpcyBzdG9yZWQgaW4gdGhlIGNvb2tpZSBtYXRjaGluZyBieSB0eXBlIHNob3VsZCBmYWls LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVs LmpzOgorICAgICAgICAoV0kuTmF2aWdhdGlvblNpZGViYXJQYW5lbC5wcm90b3R5cGUuX2NoZWNr RWxlbWVudHNGb3JQZW5kaW5nVmlld1N0YXRlQ29va2llLnRyZWVFbGVtZW50TWF0Y2hlc0Nvb2tp ZSk6CisgICAgICAgIChXSS5OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLnByb3RvdHlwZS5fY2hlY2tF bGVtZW50c0ZvclBlbmRpbmdWaWV3U3RhdGVDb29raWUpOgorCiAyMDE5LTEyLTAyICBOaWtpdGEg VmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IFByb3ZpZGUgVUkgdG8gY29udmVydCBiZXR3ZWVuIHNSR0IgYW5kIHAzIGNvbG9yIHNwYWNlcwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmF2 aWdhdGlvblNpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL05hdmlnYXRpb25TaWRlYmFyUGFuZWwuanMKaW5kZXggMjJlZDg5NjU4ZDcwMGZm ODM1MDVkNGE0ZGIwNDJiODQ2NDA4Y2ZmYy4uY2E5MzdjZjhmZDA2NTBhNWZlYmY1NjU1NWEyMzFl MzQ1NTg1NDkwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvTmF2aWdhdGlvblNpZGViYXJQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzCkBAIC03 MDUsNyArNzA1LDcgQEAgV0kuTmF2aWdhdGlvblNpZGViYXJQYW5lbCA9IGNsYXNzIE5hdmlnYXRp b25TaWRlYmFyUGFuZWwgZXh0ZW5kcyBXSS5TaWRlYmFyUGFuZWwKICAgICAgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CiAKICAgICAgICAgICAgIGlmIChtYXRjaFR5cGVPbmx5KQotICAgICAgICAg ICAgICAgIHJldHVybiB0cnVlOworICAgICAgICAgICAgICAgIHJldHVybiAhIXR5cGVJZGVudGlm aWVyOwogCiAgICAgICAgICAgICB2YXIgY2FuZGlkYXRlT2JqZWN0Q29va2llID0ge307CiAgICAg ICAgICAgICBpZiAocmVwcmVzZW50ZWRPYmplY3Quc2F2ZUlkZW50aXR5VG9Db29raWUpCg== 384830 2019-12-04 11:23:14 -0800 2019-12-04 11:23:14 -0800 test page inline-debugger.html text/html 586 yurys PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPHRpdGxlPmJyb3duIGJnPC90aXRsZT4KPG1l dGEgbmFtZT0idmlld3BvcnQiIGNvbnRlbnQ9IndpZHRoPTEwMCxpbml0aWFsLXNjYWxlPTEiPgo8 c3R5bGU+CmJvZHkgewogIGJhY2tncm91bmQtY29sb3I6IGdyZXkKfQo8L3N0eWxlPgo8c2NyaXB0 Pgpjb25zb2xlLmxvZygnYmVmb3JlJyk7CmRlYnVnZ2VyOwpjb25zb2xlLmxvZygnYWZ0ZXInKTsK CmZ1bmN0aW9uIGJ0bkNsaWNrKCkgewogIGNvbnNvbGUubG9nKERhdGUubm93KCkpOwogIGRlYnVn Z2VyOwp9CmZ1bmN0aW9uIGhhbmRsZU5hdmlnYXRlKCkgewogIGlmIChsb2NhdGlvbi5ob3N0bmFt ZSA9PT0gJ2xvY2FsaG9zdCcpCiAgICBsb2NhdGlvbi5ob3N0bmFtZSA9ICcxMjcuMC4wLjEnOwog IGVsc2UKICAgIGxvY2F0aW9uLmhvc3RuYW1lID0gJ2xvY2FsaG9zdCc7Cn0KPC9zY3JpcHQ+Cjwv aGVhZD4KPGJvZHk+CjxidXR0b24gb25jbGljaz0iYnRuQ2xpY2soKSI+RGVidWdnZXI8L2J1dHRv bj4KPGJ1dHRvbiBvbmNsaWNrPSJoYW5kbGVOYXZpZ2F0ZSgpIj5OYXZpZ2F0ZTwvYnV0dG9uPgo8 L2JvZHk+CjwvaHRtbD4KCg== 385436 2019-12-11 14:07:32 -0800 2019-12-12 08:56:05 -0800 Patch bug-204823-20191211140731.patch text/plain 1923 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk ZTJlMWQxYjYyZjRiNDlhNWJkMDg2ZDc3MzVhYzVhNjllNDY5YWM1Li4xYmY2MWQ2NjU2MjcyNjkx OTQ2N2E2NDAyMTg0YjIwNDExNTk4NWE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0xMi0wMyAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVt Lm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBFcnJvcjogQ2FuJ3QgbWFrZSBhIENvbnRl bnRWaWV3IGZvciBhbiB1bmtub3duIHJlcHJlc2VudGVkT2JqZWN0IG9mIHR5cGU6IENhbGxGcmFt ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0ODIz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgbm8g dHlwZSBpcyBzdG9yZWQgaW4gdGhlIGNvb2tpZSBtYXRjaGluZyBieSB0eXBlIHNob3VsZCBmYWls LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVs LmpzOgorICAgICAgICAoV0kuTmF2aWdhdGlvblNpZGViYXJQYW5lbC5wcm90b3R5cGUuX2NoZWNr RWxlbWVudHNGb3JQZW5kaW5nVmlld1N0YXRlQ29va2llLnRyZWVFbGVtZW50TWF0Y2hlc0Nvb2tp ZSk6CisgICAgICAgIChXSS5OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLnByb3RvdHlwZS5fY2hlY2tF bGVtZW50c0ZvclBlbmRpbmdWaWV3U3RhdGVDb29raWUpOgorCiAyMDE5LTEyLTEwICBEZXZpbiBS b3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSRUdS RVNTSU9OKHIyNTEwMzgpOiBFbGVtZW50czogQ29tcHV0ZWQ6IGltcGxpY2l0IHNob3J0aGFuZHMg YXJlIG5vdCBzaG93biB3aGVuICJQcmVmZXIgU2hvcnRoYW5kcyIgaXMgZW5hYmxlZApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlv blNpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL05hdmlnYXRpb25TaWRlYmFyUGFuZWwuanMKaW5kZXggMjJlZDg5NjU4ZDcwMGZmODM1MDVk NGE0ZGIwNDJiODQ2NDA4Y2ZmYy4uMjI2MTk4NjYyOWU0YmFlNzM3MmI2MTEyMmUxN2VjZjZhNDZh MjlkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvTmF2aWdhdGlvblNpZGViYXJQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzCkBAIC03MDEsNyAr NzAxLDcgQEAgV0kuTmF2aWdhdGlvblNpZGViYXJQYW5lbCA9IGNsYXNzIE5hdmlnYXRpb25TaWRl YmFyUGFuZWwgZXh0ZW5kcyBXSS5TaWRlYmFyUGFuZWwKICAgICAgICAgICAgICAgICByZXR1cm4g ZmFsc2U7CiAKICAgICAgICAgICAgIHZhciB0eXBlSWRlbnRpZmllciA9IGNvb2tpZVtXSS5UeXBl SWRlbnRpZmllckNvb2tpZUtleV07Ci0gICAgICAgICAgICBpZiAodHlwZUlkZW50aWZpZXIgIT09 IHJlcHJlc2VudGVkT2JqZWN0LmNvbnN0cnVjdG9yLlR5cGVJZGVudGlmaWVyKQorICAgICAgICAg ICAgaWYgKCF0eXBlSWRlbnRpZmllciB8fCB0eXBlSWRlbnRpZmllciAhPT0gcmVwcmVzZW50ZWRP YmplY3QuY29uc3RydWN0b3IuVHlwZUlkZW50aWZpZXIpCiAgICAgICAgICAgICAgICAgcmV0dXJu IGZhbHNlOwogCiAgICAgICAgICAgICBpZiAobWF0Y2hUeXBlT25seSkK 385503 2019-12-12 09:37:01 -0800 2019-12-12 10:33:59 -0800 Patch for landing bug-204823-20191212093700.patch text/plain 1811 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk ZTJlMWQxYjYyZjRiNDlhNWJkMDg2ZDc3MzVhYzVhNjllNDY5YWM1Li5jZWRjOTE1YjE2YTQ3ZTZm NDAxYzVhMDdkZmU0Yjc5ZTFjZjc1OGExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0xMi0wMyAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVt Lm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBFcnJvcjogQ2FuJ3QgbWFrZSBhIENvbnRl bnRWaWV3IGZvciBhbiB1bmtub3duIHJlcHJlc2VudGVkT2JqZWN0IG9mIHR5cGU6IENhbGxGcmFt ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0ODIz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGV2aW4gUm91c3NvLgorCisgICAgICAgIElmIG5vIHR5 cGUgaXMgc3RvcmVkIGluIHRoZSBjb29raWUgbWF0Y2hpbmcgYnkgdHlwZSBzaG91bGQgZmFpbC4K KworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvblNpZGViYXJQYW5lbC5q czoKKyAgICAgICAgKFdJLk5hdmlnYXRpb25TaWRlYmFyUGFuZWwucHJvdG90eXBlLl9jaGVja0Vs ZW1lbnRzRm9yUGVuZGluZ1ZpZXdTdGF0ZUNvb2tpZS50cmVlRWxlbWVudE1hdGNoZXNDb29raWUp OgorICAgICAgICAoV0kuTmF2aWdhdGlvblNpZGViYXJQYW5lbC5wcm90b3R5cGUuX2NoZWNrRWxl bWVudHNGb3JQZW5kaW5nVmlld1N0YXRlQ29va2llKToKKwogMjAxOS0xMi0xMCAgRGV2aW4gUm91 c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVT U0lPTihyMjUxMDM4KTogRWxlbWVudHM6IENvbXB1dGVkOiBpbXBsaWNpdCBzaG9ydGhhbmRzIGFy ZSBub3Qgc2hvd24gd2hlbiAiUHJlZmVyIFNob3J0aGFuZHMiIGlzIGVuYWJsZWQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRpb25T aWRlYmFyUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzCmluZGV4IDIyZWQ4OTY1OGQ3MDBmZjgzNTA1ZDRh NGRiMDQyYjg0NjQwOGNmZmMuLmNhOTM3Y2Y4ZmQwNjUwYTVmZWJmNTY1NTVhMjMxZTM0NTU4NTQ5 MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L05hdmlnYXRpb25TaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvblNpZGViYXJQYW5lbC5qcwpAQCAtNzA1LDcgKzcw NSw3IEBAIFdJLk5hdmlnYXRpb25TaWRlYmFyUGFuZWwgPSBjbGFzcyBOYXZpZ2F0aW9uU2lkZWJh clBhbmVsIGV4dGVuZHMgV0kuU2lkZWJhclBhbmVsCiAgICAgICAgICAgICAgICAgcmV0dXJuIGZh bHNlOwogCiAgICAgICAgICAgICBpZiAobWF0Y2hUeXBlT25seSkKLSAgICAgICAgICAgICAgICBy ZXR1cm4gdHJ1ZTsKKyAgICAgICAgICAgICAgICByZXR1cm4gISF0eXBlSWRlbnRpZmllcjsKIAog ICAgICAgICAgICAgdmFyIGNhbmRpZGF0ZU9iamVjdENvb2tpZSA9IHt9OwogICAgICAgICAgICAg aWYgKHJlcHJlc2VudGVkT2JqZWN0LnNhdmVJZGVudGl0eVRvQ29va2llKQo=