204813 2019-12-03 13:26:24 -0800 REGRESSION (r252778): ASSERT(!m_networkLoad); in ~SpeculativeLoad() 2019-12-03 15:17:53 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen cgarcia commit-queue ews-watchlist ggaren koivisto webkit-bug-importer youennf oldest_to_newest 1595158 0 cdumez 2019-12-03 13:26:24 -0800 ASSERT(!m_networkLoad); in ~SpeculativeLoad(): 4 0x107d0cf9f WebKit::NetworkCache::SpeculativeLoad::~SpeculativeLoad() 5 0x107d0cfe5 WebKit::NetworkCache::SpeculativeLoad::~SpeculativeLoad() 6 0x107d0d00c WebKit::NetworkCache::SpeculativeLoad::~SpeculativeLoad() 7 0x107c8110f std::__1::default_delete<WebKit::NetworkCache::SpeculativeLoad>::operator()(WebKit::NetworkCache::SpeculativeLoad*) const 8 0x107c8108f std::__1::unique_ptr<WebKit::NetworkCache::SpeculativeLoad, std::__1::default_delete<WebKit::NetworkCache::SpeculativeLoad> >::reset(WebKit::NetworkCache::SpeculativeLoad*) 9 0x107c81029 std::__1::unique_ptr<WebKit::NetworkCache::SpeculativeLoad, std::__1::default_delete<WebKit::NetworkCache::SpeculativeLoad> >::~unique_ptr() 10 0x107c47405 std::__1::unique_ptr<WebKit::NetworkCache::SpeculativeLoad, std::__1::default_delete<WebKit::NetworkCache::SpeculativeLoad> >::~unique_ptr() 11 0x107d11093 WebKit::NetworkCache::SpeculativeLoadManager::revalidateSubresource(WebKit::NetworkCache::SubresourceInfo const&, std::__1::unique_ptr<WebKit::NetworkCache::Entry, std::__1::default_delete<WebKit::NetworkCache::Entry> >, WebKit::NetworkCache::GlobalFrameID const&) 12 0x107d46c45 WebKit::NetworkCache::SpeculativeLoadManager::revalidateSubresource(WebKit::NetworkCache::SubresourceInfo const&, std::__1::unique_ptr<WebKit::NetworkCache::Entry, std::__1::default_delete<WebKit::NetworkCache::Entry> >, WebKit::NetworkCache::GlobalFrameID const&)::$_10::operator()() 13 0x107d46ade WTF::Detail::CallableWrapper<WebKit::NetworkCache::SpeculativeLoadManager::revalidateSubresource(WebKit::NetworkCache::SubresourceInfo const&, std::__1::unique_ptr<WebKit::NetworkCache::Entry, std::__1::default_delete<WebKit::NetworkCache::Entry> >, WebKit::NetworkCache::GlobalFrameID const&)::$_10, void>::call() 14 0x1077df4e2 WTF::Function<void ()>::operator()() const 15 0x107d0fa3a WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::markMainResourceResponseAsReceived() 16 0x107d0f9d2 WebKit::NetworkCache::SpeculativeLoadManager::registerMainResourceLoadResponse(WebKit::NetworkCache::GlobalFrameID const&, WebCore::ResourceRequest const&, WebCore::ResourceResponse const&) 17 0x107a88b4f WebKit::NetworkResourceLoader::didReceiveMainResourceResponse(WebCore::ResourceResponse const&) 18 0x107a8596c WebKit::NetworkResourceLoader::didRetrieveCacheEntry(std::__1::unique_ptr<WebKit::NetworkCache::Entry, std::__1::default_delete<WebKit::NetworkCache::Entry> >) 19 0x107a897fc WebKit::NetworkResourceLoader::didFinishLoading(WebCore::NetworkLoadMetrics const&) 20 0x107a6605e WebKit::NetworkLoad::didCompleteWithError(WebCore::ResourceError const&, WebCore::NetworkLoadMetrics const&) 21 0x107a2be08 WebKit::NetworkDataTaskCocoa::didCompleteWithError(WebCore::ResourceError const&, WebCore::NetworkLoadMetrics const&) 22 0x107a31445 -[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:] 23 0x7fff2fb30235 CFHTTPCookieStorageUnscheduleFromRunLoop 24 0x7fff339391b5 __NSBLOCKOPERATION_IS_CALLING_OUT_TO_A_BLOCK__ 25 0x7fff339390d6 -[NSBlockOperation main] 26 0x7fff33aaa761 __NSOPERATION_IS_INVOKING_MAIN__ 27 0x7fff3390fc73 -[NSOperation start] 28 0x7fff33aaab59 __NSOPERATIONQUEUE_IS_STARTING_AN_OPERATION__ 29 0x7fff33938eb9 __NSOQSchedule_f 30 0x7fff690252b9 _dispatch_block_async_invoke2 31 0x7fff69019658 _dispatch_client_callout 1595159 1 cdumez 2019-12-03 13:26:42 -0800 <rdar://problem/57581082> 1595163 2 384749 cdumez 2019-12-03 13:32:20 -0800 Created attachment 384749 Patch 1595216 3 384749 commit-queue 2019-12-03 15:17:52 -0800 Comment on attachment 384749 Patch Clearing flags on attachment: 384749 Committed r253065: <https://trac.webkit.org/changeset/253065> 1595217 4 commit-queue 2019-12-03 15:17:53 -0800 All reviewed patches have been landed. Closing bug. 384749 2019-12-03 13:32:20 -0800 2019-12-03 15:17:52 -0800 Patch bug-204813-20191203133220.patch text/plain 3110 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMDA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJkMWI2ZDM3YjNmNGRlN2U5 OTFmNThiZGQxYWZmNDJhNzI4MmQzNDguLjNlNWFlMWQ3NGI4ZTliNjhmN2ZhYTAxNTQ5MDAzODIw NjBmZjk1NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTktMTItMDMgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjUyNzc4KTog QVNTRVJUKCFtX25ldHdvcmtMb2FkKTsgaW4gflNwZWN1bGF0aXZlTG9hZCgpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ4MTMKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzU3NTgxMDgyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFmdGVyIHIyNTI3NzgsIFNwZWN1bGF0aXZlTG9hZE1hbmFnZXI6OnJl dmFsaWRhdGVTdWJyZXNvdXJjZSgpIG1heSBkZWxheSB0aGUgcmV2YWxpZGF0aW9uIHVudGlsIHdl IHJlY2VpdmUKKyAgICAgICAgdGhlIHJlc3BvbnNlIGZvciB0aGUgbWFpbiByZXNvdXJjZS4gV2Ug Y2FuIGhpdCB0aGUgYXNzZXJ0aW9uIGluIHRoZSBTcGVjdWxhdGl2ZUxvYWQgZGVzdHJ1Y3RvciBp ZiBhIHNwZWN1bGF0aXZlCisgICAgICAgIHJldmFsaWRhdGlvbiBmb3IgdGhlIFNBTUUgcmVzb3Vy Y2UgZ2V0cyBzY2hlZHVsZWQgd2hpbGUgd2UncmUgd2FpdGluZyBmb3IgdGhlIG1haW4gcmVzb3Vy Y2UgcmVzcG9uc2UuIFdoZW4gd2UKKyAgICAgICAgZXZlbnR1YWxseSByZWNlaXZlIHRoZSBtYWlu IHJlc291cmNlIHJlc3BvbnNlLCB3ZSB3b3VsZCBjYWxsIHJldmFsaWRhdGVTdWJyZXNvdXJjZSgp IGFnYWluLCB3aGljaCB3b3VsZCBjcmVhdGUKKyAgICAgICAgYSBTcGVjdWxhdGl2ZUxvYWQgYW5k IHRyeSB0byBhZGQgaXQgdG8gbV9wZW5kaW5nUHJlbG9hZHMuIEJlY2F1c2UgbV9wZW5kaW5nUHJl bG9hZHMgd291bGQgYWxyZWFkeSBjb250YWluIGEKKyAgICAgICAgcHJlbG9hZCBmb3IgdGhpcyBz YW1lIHJlc291cmNlLCB0aGUgU3BlY3VsYXRpdmVMb2FkIHdvdWxkIG5vdCBnZXQgYWRkZWQgdG8g dGhlIG1hcCBhbmQgaXQgd291bGQgZ2V0IGRlc3Ryb3llZAorICAgICAgICByaWdodCBhd2F5LCBi ZWZvcmUgY29tcGxldGluZyAodGh1cyBoaXR0aW5nIHRoZSBhc3NlcnQpLiBUaGlzIHVubmVjZXNz YXJ5IGNyZWF0aW9uIG9mIHRoZSBTcGVjdWxhdGl2ZUxvYWQgaXMKKyAgICAgICAgaW5lZmZpY2ll bnQgYW5kIGl0IGlzIHRodXMgYmVzdCB0byBhdm9pZCBpdC4KKworICAgICAgICBUbyBhZGRyZXNz IHRoZSBpc3N1ZSwgd2hlbiB3ZSByZWNlaXZlIHRoZSByZXNwb25zZSwgd2Ugbm93IG1ha2Ugc3Vy ZSB0aGF0IG1fcGVuZGluZ1ByZWxvYWRzIGRvZXMgbm90IGFscmVhZHkKKyAgICAgICAgY29udGFp biBhIHByZWxvYWQgZm9yIHRoaXMgcmVzb3VyY2UgYmVmb3JlIGNhbGxpbmcgcmV2YWxpZGF0ZVN1 YnJlc291cmNlKCkgYWdhaW4sIHNpbWlsYXJseSB0byB3aGF0IHdhcworICAgICAgICBhbHJlYWR5 IGRvbmUgYXQgdGhlIGJlZ2lubmluZyBvZiBTcGVjdWxhdGl2ZUxvYWRNYW5hZ2VyOjpwcmVsb2Fk RW50cnkoKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHVua25vd24gaG93IHRvIHJlcHJvZHVj ZS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVNwZWN1bGF0 aXZlTG9hZE1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OlNwZWN1 bGF0aXZlTG9hZE1hbmFnZXI6OnJldmFsaWRhdGVTdWJyZXNvdXJjZSk6CisKIDIwMTktMTItMDIg IFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10g SW50cm9kdWNlIGEgZ2VzdHVyZSByZWNvZ25pemVyIHRoYXQgY2FuIGJlIHVzZWQgdG8gZGVmZXIg cmVjb2duaXRpb24gb2Ygb3RoZXIgZ2VzdHVyZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkTWFuYWdlci5j cHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVNwZWN1 bGF0aXZlTG9hZE1hbmFnZXIuY3BwCmluZGV4IDY3MDQ3YmZlMDQ1ZjljYTUwMDFhMjU3ZDJiMDYw YjM5YmE1MDlkYTcuLjM3NzM4ZDgyMmI4NzAzYzU0MjQ0ZTU4NDBiZmFlYjRiOGQwN2MxZDUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hl U3BlY3VsYXRpdmVMb2FkTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVjdWxhdGl2ZUxvYWRNYW5hZ2VyLmNwcApAQCAtNDg2 LDYgKzQ4Niw5IEBAIHZvaWQgU3BlY3VsYXRpdmVMb2FkTWFuYWdlcjo6cmV2YWxpZGF0ZVN1YnJl c291cmNlKGNvbnN0IFN1YnJlc291cmNlSW5mbyYgc3VicmVzCiAgICAgaWYgKHBlbmRpbmdMb2Fk ICYmICFwZW5kaW5nTG9hZC0+ZGlkUmVjZWl2ZU1haW5SZXNvdXJjZVJlc3BvbnNlKCkgJiYgc3Vi cmVzb3VyY2VJbmZvLmlzRmlyc3RQYXJ0eSgpKSB7CiAgICAgICAgIHByZWNvbm5lY3RGb3JTdWJy ZXNvdXJjZShzdWJyZXNvdXJjZUluZm8sIGVudHJ5LmdldCgpLCBmcmFtZUlEKTsKICAgICAgICAg cGVuZGluZ0xvYWQtPmFkZFBvc3RNYWluUmVzb3VyY2VSZXNwb25zZVRhc2soW3RoaXMsIHN1YnJl c291cmNlSW5mbywgZW50cnkgPSBXVEZNb3ZlKGVudHJ5KSwgZnJhbWVJRF0oKSBtdXRhYmxlIHsK KyAgICAgICAgICAgIGlmIChtX3BlbmRpbmdQcmVsb2Fkcy5jb250YWlucyhzdWJyZXNvdXJjZUlu Zm8ua2V5KCkpKQorICAgICAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICAgICAgcmV2YWxp ZGF0ZVN1YnJlc291cmNlKHN1YnJlc291cmNlSW5mbywgV1RGTW92ZShlbnRyeSksIGZyYW1lSUQp OwogICAgICAgICB9KTsKICAgICAgICAgcmV0dXJuOwo=