204802 2019-12-03 11:20:05 -0800 Enable security assertions on all ASAN builds 2019-12-07 14:06:27 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Enhancement --- 1 sunny_he webkit-unassigned benjamin cdumez cmarcelo commit-queue dbates ews-watchlist rniwa webkit-bug-importer oldest_to_newest 1595086 0 sunny_he 2019-12-03 11:20:05 -0800 <rdar://57433774> To enable more effective testing, enable security assertions on all ASAN builds including release. This affects blocks guarded by ENABLE(SECURITY_ASSERTIONS) and ASSERT_WITH_SECURITY_IMPLICATION. Since ASAN builds are inherently for finding bugs at the cost of performance, the additional performance impact of enabling security assertions on ASAN builds should be acceptable. 1595109 1 384734 sunny_he 2019-12-03 12:04:32 -0800 Created attachment 384734 Patch 1595179 2 rniwa 2019-12-03 14:02:27 -0800 Windows bot failure is: C:\cygwin\home\buildbot\worker\Windows-EWS\build\Tools\DumpRenderTree\win\DumpRenderTree.cpp(800,61): error C2039: 'setWebAnimationsCompositeOperationsEnabled': is not a member of 'IWebPreferencesPrivate7' [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj] JSWrapper.cpp Do you think it might be related to your patch?? 1595180 3 rniwa 2019-12-03 14:03:36 -0800 iOS test failure is probably nothing to do with it. 1595213 4 rniwa 2019-12-03 15:08:55 -0800 Oh looks, like Windows bot failure was an exciting issue. 1595280 5 384734 commit-queue 2019-12-03 17:27:08 -0800 Comment on attachment 384734 Patch Clearing flags on attachment: 384734 Committed r253072: <https://trac.webkit.org/changeset/253072> 1595281 6 commit-queue 2019-12-03 17:27:09 -0800 All reviewed patches have been landed. Closing bug. 1596625 7 ap 2019-12-07 14:06:27 -0800 > Since ASAN builds are inherently for finding bugs at the cost of performance, the additional performance impact of enabling security assertions on ASAN builds should be acceptable. This obviously depends on what the performance impact is. Looking at test runtime, it seems acceptable in this case (very roughly, 1-2%). 384734 2019-12-03 12:04:32 -0800 2019-12-03 17:27:08 -0800 Patch bug-204802-20191203120431.patch text/plain 1292 sunny_he U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyOTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDZjOTMxZjFkMzIyNjVjNTI2ODU0OWVl MTcyZDJlMWQyYjBlYzc1MGQuLjMyMjAyMDk5ZWFhN2M0MTBmYmZjODZmNDQxMjc1MjI2ZWU1MjAy OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTktMTItMDMgIFN1bm55IEhlICA8c3VubnlfaGVA YXBwbGUuY29tPgorCisgICAgICAgIEVuYWJsZSBzZWN1cml0eSBhc3NlcnRpb25zIG9uIGFsbCBB U0FOIGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA0ODAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiB3dGYvRmVhdHVyZURlZmluZXMuaDoKKwogMjAxOS0xMS0yOCAgRnVqaWkgSGlyb25vcmkg IDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBSZW1vdmUgRU5BQkxFX0tFWUJP QVJEX0NPREVfQVRUUklCVVRFIGFuZCBFTkFCTEVfS0VZQk9BUkRfS0VZX0FUVFJJQlVURSBtYWNy b3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmggYi9Tb3VyY2Uv V1RGL3d0Zi9GZWF0dXJlRGVmaW5lcy5oCmluZGV4IDY2ZjBiYmM3YWU3MjIzNzBhY2ZhOGMyMDU3 MTc5YjZmODAwOTM4MDQuLmY5YmU0NDE0NjA5ZGI1ODY4YjhiMzQwOTM3NzE1ODFkNTMyNzdjYjIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmgKKysrIGIvU291cmNl L1dURi93dGYvRmVhdHVyZURlZmluZXMuaApAQCAtNjYzLDYgKzY2MywxMyBAQCB0aGUgcHVibGlj IGlPUyBTREsuIFNlZSA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTc5MTY3Pi4gKi8KICNkZWZpbmUg RU5BQkxFX1JVQkJFUl9CQU5ESU5HIDAKICNlbmRpZgogCisjaWYgIWRlZmluZWQoRU5BQkxFX1NF Q1VSSVRZX0FTU0VSVElPTlMpCisvKiBFbmFibGUgc2VjdXJpdHkgYXNzZXJ0aW9ucyBvbiBhbGwg QVNBTiBidWlsZHMgYW5kIGRlYnVnIGJ1aWxkcy4gKi8KKyNpZiBBU0FOX0VOQUJMRUQgfHwgIWRl ZmluZWQoTkRFQlVHKQorI2RlZmluZSBFTkFCTEVfU0VDVVJJVFlfQVNTRVJUSU9OUyAxCisjZW5k aWYKKyNlbmRpZgorCiAjaWYgIWRlZmluZWQoRU5BQkxFX1NNT09USF9TQ1JPTExJTkcpCiAjZGVm aW5lIEVOQUJMRV9TTU9PVEhfU0NST0xMSU5HIDAKICNlbmRpZgo=