204778 2019-12-02 18:44:10 -0800 run-jsc should exit with the same signal or exit status that the `jsc` shell does 2020-01-07 22:49:22 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=205907 InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ross.kirsling ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1594879 0 saam 2019-12-02 18:44:10 -0800 ... 1594885 1 384677 saam 2019-12-02 18:59:42 -0800 Created attachment 384677 patch 1594889 2 384677 keith_miller 2019-12-02 19:09:02 -0800 Comment on attachment 384677 patch View in context: https://bugs.webkit.org/attachment.cgi?id=384677&action=review r=me > Tools/Scripts/run-jsc:70 > + system("kill -" . $signal . " " . $PID); # We kill ourselves with the same signal that the `jsc` process was killed with to make it look like `jsc` was directly invoked. Beautiful! 1594897 3 384677 saam 2019-12-02 20:22:40 -0800 Comment on attachment 384677 patch View in context: https://bugs.webkit.org/attachment.cgi?id=384677&action=review >> Tools/Scripts/run-jsc:70 >> + system("kill -" . $signal . " " . $PID); # We kill ourselves with the same signal that the `jsc` process was killed with to make it look like `jsc` was directly invoked. > > Beautiful! Thanks to your beautiful idea :-) 1594909 4 384677 commit-queue 2019-12-02 21:07:22 -0800 Comment on attachment 384677 patch Clearing flags on attachment: 384677 Committed r253024: <https://trac.webkit.org/changeset/253024> 1594910 5 commit-queue 2019-12-02 21:07:23 -0800 All reviewed patches have been landed. Closing bug. 1594911 6 webkit-bug-importer 2019-12-02 21:08:18 -0800 <rdar://problem/57580636> 1600055 7 ross.kirsling 2019-12-18 16:41:39 -0800 This patch seems to have introduced a strange result when exiting the shell. Direct case: > λ DYLD_FRAMEWORK_PATH=./WebKitBuild/Release ./WebKitBuild/Release/jsc --useDollarVM=1 > >>> <Ctrl+C> > Indirect case: > λ Tools/Scripts/run-jsc > Running 1 time(s): DYLD_FRAMEWORK_PATH=./WebKitBuild/Release ./WebKitBuild/Release/jsc --useDollarVM=1 > >>> <Ctrl+C> > ... I should not be here ... > Obviously a cosmetic issue but it's weird to see every time I exit, hehe. 1603967 8 saam 2020-01-07 22:40:01 -0800 (In reply to Ross Kirsling from comment #7) > This patch seems to have introduced a strange result when exiting the shell. > > Direct case: > > λ DYLD_FRAMEWORK_PATH=./WebKitBuild/Release ./WebKitBuild/Release/jsc --useDollarVM=1 > > >>> <Ctrl+C> > > > > Indirect case: > > λ Tools/Scripts/run-jsc > > Running 1 time(s): DYLD_FRAMEWORK_PATH=./WebKitBuild/Release ./WebKitBuild/Release/jsc --useDollarVM=1 > > >>> <Ctrl+C> > > ... I should not be here ... > > > > Obviously a cosmetic issue but it's weird to see every time I exit, hehe. yeah, that's annoying... Let me remove that. 384677 2019-12-02 18:59:42 -0800 2019-12-02 21:07:22 -0800 patch b-backup.diff text/plain 1698 saam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MzAyMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTEyLTAyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgor CisgICAgICAgIHJ1bi1qc2Mgc2hvdWxkIGV4aXQgd2l0aCB0aGUgc2FtZSBzaWduYWwgb3IgZXhp dCBzdGF0dXMgdGhhdCB0aGUgYGpzY2Agc2hlbGwgZG9lcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0Nzc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1qc2M6CisKIDIwMTktMTIt MDIgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmVy dCAtIFtFV1NdIERvIG5vdCByZXRyeSBsYXlvdXQtdGVzdHMgYnVpbGQgaWYgdGhlIGZsYWt5IHRl c3QgZmFpbHVyZXMgYXJlIGFsc28gcHJlc2VudCBpbiBjbGVhbiB0cmVlIHJ1bgpJbmRleDogVG9v bHMvU2NyaXB0cy9ydW4tanNjCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvcnVuLWpzYwko cmV2aXNpb24gMjUyODAwKQorKysgVG9vbHMvU2NyaXB0cy9ydW4tanNjCSh3b3JraW5nIGNvcHkp CkBAIC0zNyw2ICszNyw4IEBAIHVzZSBHZXRvcHQ6Okxvbmc7CiB1c2Ugd2Via2l0ZGlyczsKIEdl dG9wdDo6TG9uZzo6Q29uZmlndXJlKCJub19hdXRvX2FiYnJldiIsICJwYXNzX3Rocm91Z2giKTsK IAordXNlIEVuZ2xpc2g7CisKIG15ICR1c2FnZSA9ICJVc2FnZTogcnVuLWpzYyBbLS1jb3VudCBy dW5fY291bnRdIFstLWRlYnVnZ2VyXSBzaGVsbF9maWxlIFtmaWxlMi4uLl0iOwogCiBteSAkY291 bnQgPSAxOwpAQCAtNjEsNyArNjMsMTMgQEAgJEVOVnsiRFlMRF9GUkFNRVdPUktfUEFUSCJ9ID0g JGR5bGQ7CiBwcmludCBTVERFUlIgIlJ1bm5pbmcgJGNvdW50IHRpbWUocyk6IERZTERfRlJBTUVX T1JLX1BBVEg9JGR5bGQgJGpzY1xuIjsKIAogd2hpbGUgKCRjb3VudC0tKSB7Ci0gICAgbXkgJHN0 YXR1cyA9IHN5c3RlbSgiJGpzYyIpID4+IDg7CisgICAgc3lzdGVtKCIkanNjIik7CisgICAgbXkg JHNpZ25hbCA9ICQ/ICYgMHg3ZjsKKyAgICBteSAkc3RhdHVzID0gKCQ/ID4+IDgpICYgMHhmZjsK KyAgICBpZiAoJHNpZ25hbCAhPSAwKSB7CisgICAgICAgIHN5c3RlbSgia2lsbCAtIiAuICRzaWdu YWwgLiAiICIgLiAkUElEKTsgIyBXZSBraWxsIG91cnNlbHZlcyB3aXRoIHRoZSBzYW1lIHNpZ25h bCB0aGF0IHRoZSBganNjYCBwcm9jZXNzIHdhcyBraWxsZWQgd2l0aCB0byBtYWtlIGl0IGxvb2sg bGlrZSBganNjYCB3YXMgZGlyZWN0bHkgaW52b2tlZC4KKyAgICAgICAgcHJpbnQgU1RERVJSICJc bi4uLiBJIHNob3VsZCBub3QgYmUgaGVyZSAuLi5cbiI7CisgICAgfQogICAgIGlmICgkc3RhdHVz ICE9IDApIHsKICAgICAgICAgcHJpbnQgU1RERVJSICJcbmpzYyBleGl0ZWQgd2l0aCBub24temVy byBzdGF0dXM6ICRzdGF0dXNcbiI7CiAgICAgICAgIGV4aXQgJHN0YXR1czsK