204760 2019-12-02 11:33:10 -0800 [JSC] Remove BytecodeCacheVersion.h 2019-12-02 15:24:49 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo annulen commit-queue ews-watchlist gyuyoung.kim keith_miller mark.lam msaboff ryuan.choi saam sergio webkit-bug-importer oldest_to_newest 1594718 0 tzagallo 2019-12-02 11:33:10 -0800 ... 1594756 1 384651 tzagallo 2019-12-02 13:21:46 -0800 Created attachment 384651 Patch 1594761 2 384651 mark.lam 2019-12-02 13:32:01 -0800 Comment on attachment 384651 Patch Are we guaranteed that the 2 places that "call" jscBytecodeCacheVersion() will produce the same value? Is there any chance that the time stamp changed by a small fraction between those 2? 1594771 3 tzagallo 2019-12-02 13:49:30 -0800 (In reply to Mark Lam from comment #2) > Comment on attachment 384651 [details] > Patch > > Are we guaranteed that the 2 places that "call" jscBytecodeCacheVersion() > will produce the same value? Is there any chance that the time stamp > changed by a small fraction between those 2? There are two calls to the function, but since __TIMESTAMP__ is a preprocessor macro[1] it will be replaced by a constant string before the parser runs, so it should always produce the same value. [1]: https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html 1594774 4 384651 mark.lam 2019-12-02 13:52:17 -0800 Comment on attachment 384651 Patch r=me 1594801 5 384651 commit-queue 2019-12-02 14:45:32 -0800 Comment on attachment 384651 Patch Clearing flags on attachment: 384651 Committed r253010: <https://trac.webkit.org/changeset/253010> 1594802 6 commit-queue 2019-12-02 14:45:34 -0800 All reviewed patches have been landed. Closing bug. 1594805 7 webkit-bug-importer 2019-12-02 14:46:28 -0800 <rdar://problem/57571599> 1594821 8 saam 2019-12-02 15:21:13 -0800 Why is this correct? What about collisions? 1594825 9 saam 2019-12-02 15:23:48 -0800 (In reply to Saam Barati from comment #8) > Why is this correct? What about collisions? This patch looks wrong. Before, we had a monotonically increasing number. Now, we’re using a hash function which is bound to have collisions. 1594826 10 mark.lam 2019-12-02 15:24:49 -0800 (In reply to Saam Barati from comment #9) > (In reply to Saam Barati from comment #8) > > Why is this correct? What about collisions? > > This patch looks wrong. Before, we had a monotonically increasing number. > Now, we’re using a hash function which is bound to have collisions. Hmmm, I agree. I should have thought of that. 384651 2019-12-02 13:21:46 -0800 2019-12-02 14:45:32 -0800 Patch bug-204760-20191202132146.patch text/plain 4972 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyOTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi OGUwN2MxNWI1MjQyNzVhMTZiOTQyMGExYjRhODk1NmY2NThmYzI5Li4zMDhhZDY3NjE4OWVkNWJk ZTJlM2ZjNzFlZmNjYjQ5ZDMwYmJmYTE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxOS0xMi0wMiAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBbSlNDXSBSZW1vdmUgQnl0ZWNvZGVDYWNoZVZlcnNpb24uaAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0NzYwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSGF2aW5nIHRoYXQgYXMg YSBwaG9ueSBtYWtlIHRhcmdldCBjYXVzZXMgYSBsb3Qgb2YgdW5uZWNlc3NhcnkgcmVidWlsZHMu IFRoYXQgd2FzIGEgd29ya2Fyb3VuZAorICAgICAgICB0aGUgZmFjdCB0aGF0IHdlIG9ubHkgbmVl ZCBhIG5ldyBjYWNoZSB2ZXJzaW9uIHdoZW4gd2UgcmVidWlsZCBDYWNoZWRUeXBlcy5jcHAsIGJ1 dCB0aGVyZSB3YXMKKyAgICAgICAgbm8gc3RyYWlnaHRmb3J3YXJkIHdheSB0byBnZXQgdGhlIGN1 cnJlbnQgdGltZXN0YW1wIGFzIGFuIGludGVnZXIgYXQgdGhhdCBwb2ludC4gSW5zdGVhZCwgd2Ug bm93CisgICAgICAgIGp1c3QgdXNlIGEgY29uc3RleHByIGZ1bmN0aW9uIHRoYXQgaGFzaGVzIF9f VElNRVNUQU1QX18uCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKyAgICAgICAgKiBEZXJp dmVkU291cmNlcy1vdXRwdXQueGNmaWxlbGlzdDoKKyAgICAgICAgKiBEZXJpdmVkU291cmNlcy5t YWtlOgorICAgICAgICAqIHJ1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwOgorICAgICAgICAoSlNDOjpq c2NCeXRlY29kZUNhY2hlVmVyc2lvbik6CisgICAgICAgIChKU0M6OkdlbmVyaWNDYWNoZUVudHJ5 Ojppc1VwVG9EYXRlIGNvbnN0KToKKwogMjAxOS0xMi0wMSAgVHVvbWFzIEthcmtrYWluZW4gIDx0 dW9tYXMud2Via2l0QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgRnV6emVyQWdlbnQgdGhhdCBy ZWFkcyBwcmVkaWN0aW9ucyBmcm9tIGEgZmlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMu dHh0CmluZGV4IGM4ZmVjOTQ2YjU3ZmFkZWY5OWRkNDU1ZGE4ZDVlYjI3NGVmMTE3NTUuLjQyMTll MjM1MGY4YjJkMmNiMTZhYzM3MDc0ZDQ1MWQyMTNlNTFkOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv Q01ha2VMaXN0cy50eHQKQEAgLTIyNSwxMCArMjI1LDcgQEAgZWxzZSAoKQogICAgIHN0cmluZyhU SU1FU1RBTVAgQlVJTERfVElNRSAiJXMiKQogZW5kaWYgKCkKIAotZmlsZShXUklURSAke0phdmFT Y3JpcHRDb3JlX0RFUklWRURfU09VUkNFU19ESVJ9L0J5dGVjb2RlQ2FjaGVWZXJzaW9uLmggIiNk ZWZpbmUgSlNDX0JZVEVDT0RFX0NBQ0hFX1ZFUlNJT04gJHtCVUlMRF9USU1FfVxuIikKLQogbGlz dChBUFBFTkQgSmF2YVNjcmlwdENvcmVfSEVBREVSUwotICAgICR7SmF2YVNjcmlwdENvcmVfREVS SVZFRF9TT1VSQ0VTX0RJUn0vQnl0ZWNvZGVDYWNoZVZlcnNpb24uaAogICAgICR7SmF2YVNjcmlw dENvcmVfREVSSVZFRF9TT1VSQ0VTX0RJUn0vQnl0ZWNvZGVTdHJ1Y3RzLmgKICAgICAke0phdmFT Y3JpcHRDb3JlX0RFUklWRURfU09VUkNFU19ESVJ9L0J5dGVjb2Rlcy5oCiApCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvRGVyaXZlZFNvdXJjZXMtb3V0cHV0LnhjZmlsZWxpc3Qg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvRGVyaXZlZFNvdXJjZXMtb3V0cHV0LnhjZmlsZWxpc3QK aW5kZXggMTRhYTQyMGNmM2Y0YzI3M2Q5YThhYWIzOTEwODMwZjk2YzhkNGY0My4uODA1OWE4NjQ1 ODA2MGJjMzQ3MTcwNWE3Y2E2M2YxYzQ5Mjk5Y2U3YSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL0Rlcml2ZWRTb3VyY2VzLW91dHB1dC54Y2ZpbGVsaXN0CisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9EZXJpdmVkU291cmNlcy1vdXRwdXQueGNmaWxlbGlzdApAQCAtOCw3ICs4 LDYgQEAgJChCVUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3Jl L0FzeW5jR2VuZXJhdG9yUHJvdG90eXBlLmx1dC4KICQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJp dmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZS9CaWdJbnRDb25zdHJ1Y3Rvci5sdXQuaAogJChCVUlM VF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlL0JpZ0ludFByb3Rv dHlwZS5sdXQuaAogJChCVUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL0phdmFTY3Jp cHRDb3JlL0Jvb2xlYW5Qcm90b3R5cGUubHV0LmgKLSQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJp dmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZS9CeXRlY29kZUNhY2hlVmVyc2lvbi5oCiAkKEJVSUxU X1BST0RVQ1RTX0RJUikvRGVyaXZlZFNvdXJjZXMvSmF2YVNjcmlwdENvcmUvQnl0ZWNvZGVJbmRp Y2VzLmgKICQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVkU291cmNlcy9KYXZhU2NyaXB0Q29y ZS9CeXRlY29kZVN0cnVjdHMuaAogJChCVUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2Vz L0phdmFTY3JpcHRDb3JlL0J5dGVjb2Rlcy5oCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvRGVyaXZlZFNvdXJjZXMubWFrZSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9EZXJpdmVk U291cmNlcy5tYWtlCmluZGV4IGY1OTIxMmZmMDFjYzlkODJhMjEwMDViMjEyODU3MWU3ZDIzMDNl NzQuLjk5ODc0NjQ5NjY0N2FmMDBhOTYzYTM3MmEwOTVmODg0YzVmMWJmOWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9EZXJpdmVkU291cmNlcy5tYWtlCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9EZXJpdmVkU291cmNlcy5tYWtlCkBAIC0zNjMsMTAgKzM2MywzIEBAIFdh c21CM0lSR2VuZXJhdG9ySW5saW5lcy5oOiAkKEphdmFTY3JpcHRDb3JlKS93YXNtL2dlbmVyYXRl V2FzbUIzSVJHZW5lcmF0b3JJbmxpCiBhbGwgOiBcCiAgICAgJChPQkpFQ1RfTFVUX0hFQURFUlMp IFwKICMKLQotLlBIT05ZIDogQnl0ZWNvZGVDYWNoZVZlcnNpb24uaAotCi1CeXRlY29kZUNhY2hl VmVyc2lvbi5oOgotCWVjaG8gIiNkZWZpbmUgSlNDX0JZVEVDT0RFX0NBQ0hFX1ZFUlNJT04gJChz aGVsbCBkYXRlICcrJXMnKSIgPiBCeXRlY29kZUNhY2hlVmVyc2lvbi5oCi0KLWFsbCA6IEJ5dGVj b2RlQ2FjaGVWZXJzaW9uLmgKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0NhY2hlZFR5cGVzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NhY2hl ZFR5cGVzLmNwcAppbmRleCBlYjlkOTkzYjI1MTRjNjcyOWUxMDJmNjVlNzIwYTcyOGFmMmMyNDM5 Li5mOGQ5Nzk5NTg3NDUyMjZhNDdlNmY4YjZjNTU4NjBjMThmY2U4N2ExIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9DYWNoZWRUeXBlcy5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwCkBAIC0yNyw3ICsyNyw2IEBA CiAjaW5jbHVkZSAiQ2FjaGVkVHlwZXMuaCIKIAogI2luY2x1ZGUgIkJ5dGVjb2RlQ2FjaGVFcnJv ci5oIgotI2luY2x1ZGUgIkJ5dGVjb2RlQ2FjaGVWZXJzaW9uLmgiCiAjaW5jbHVkZSAiQnl0ZWNv ZGVMaXZlbmVzc0FuYWx5c2lzLmgiCiAjaW5jbHVkZSAiSlNDSW5saW5lcy5oIgogI2luY2x1ZGUg IkpTSW1tdXRhYmxlQnV0dGVyZmx5LmgiCkBAIC02NSw2ICs2NCwxMSBAQCBzdHJ1Y3QgU291cmNl VHlwZUltcGw8VCwgc3RkOjplbmFibGVfaWZfdDwhc3RkOjppc19mdW5kYW1lbnRhbDxUPjo6dmFs dWUgJiYgIXN0ZAogdGVtcGxhdGU8dHlwZW5hbWUgVD4KIHVzaW5nIFNvdXJjZVR5cGUgPSB0eXBl bmFtZSBTb3VyY2VUeXBlSW1wbDxUPjo6dHlwZTsKIAorc3RhdGljIGNvbnN0ZXhwciB1bnNpZ25l ZCBqc2NCeXRlY29kZUNhY2hlVmVyc2lvbigpCit7CisgICAgcmV0dXJuIFN0cmluZ0hhc2hlcjo6 Y29tcHV0ZUhhc2goX19USU1FU1RBTVBfXyk7Cit9CisKIGNsYXNzIEVuY29kZXIgewogICAgIFdU Rl9NQUtFX05PTkNPUFlBQkxFKEVuY29kZXIpOwogICAgIFdURl9GT1JCSURfSEVBUF9BTExPQ0FU SU9OOwpAQCAtMjI2NSw3ICsyMjY5LDcgQEAgcHJvdGVjdGVkOgogCiAgICAgYm9vbCBpc1VwVG9E YXRlKERlY29kZXImIGRlY29kZXIpIGNvbnN0CiAgICAgewotICAgICAgICBpZiAobV9jYWNoZVZl cnNpb24gIT0gSlNDX0JZVEVDT0RFX0NBQ0hFX1ZFUlNJT04pCisgICAgICAgIGlmIChtX2NhY2hl VmVyc2lvbiAhPSBqc2NCeXRlY29kZUNhY2hlVmVyc2lvbigpKQogICAgICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgICAgICBpZiAobV9ib290U2Vzc2lvblVVSUQuZGVjb2RlKGRlY29kZXIpICE9 IGJvb3RTZXNzaW9uVVVJRFN0cmluZygpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAt MjI3Myw3ICsyMjc3LDcgQEAgcHJvdGVjdGVkOgogICAgIH0KIAogcHJpdmF0ZToKLSAgICB1aW50 MzJfdCBtX2NhY2hlVmVyc2lvbiB7IEpTQ19CWVRFQ09ERV9DQUNIRV9WRVJTSU9OIH07CisgICAg dWludDMyX3QgbV9jYWNoZVZlcnNpb24geyBqc2NCeXRlY29kZUNhY2hlVmVyc2lvbigpIH07CiAg ICAgQ2FjaGVkU3RyaW5nIG1fYm9vdFNlc3Npb25VVUlEOwogICAgIENhY2hlZENvZGVCbG9ja1Rh ZyBtX3RhZzsKIH07Cg==