<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>204739</bug_id>
          
          <creation_ts>2019-12-02 01:59:19 -0800</creation_ts>
          <short_desc>[GTK] Fix some warnings</short_desc>
          <delta_ts>2019-12-02 07:43:58 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Rob Buis">rbuis</reporter>
          <assigned_to name="Rob Buis">rbuis</assigned_to>
          <cc>alecflett</cc>
    
    <cc>beidson</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>fred.wang</cc>
    
    <cc>jsbell</cc>
    
    <cc>koivisto</cc>
    
    <cc>svillar</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1594530</commentid>
    <comment_count>0</comment_count>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2019-12-02 01:59:19 -0800</bug_when>
    <thetext>I see this in a recent build:

In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-4babe430-6.cpp:4:
../../Source/WebCore/Modules/indexeddb/IDBDatabase.cpp: In member function ‘void WebCore::IDBDatabase::connectionToServerLost(const WebCore::IDBError&amp;)’:
../../Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:281:15: warning: unused variable ‘context’ [-Wunused-variable]
     if (auto* context = scriptExecutionContext())
               ^~~~~~~
../../Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:287:15: warning: unused variable ‘context’ [-Wunused-variable]
     if (auto* context = scriptExecutionContext())
               ^~~~~~~
[2894/3859] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource-207b877e-4.cpp.o
In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-207b877e-4.cpp:4:
../../Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:267:17: warning: multi-line comment [-Wcomment]
                 //              \</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1594532</commentid>
    <comment_count>1</comment_count>
      <attachid>384601</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2019-12-02 02:01:42 -0800</bug_when>
    <thetext>Created attachment 384601
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1594542</commentid>
    <comment_count>2</comment_count>
      <attachid>384601</attachid>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2019-12-02 02:54:40 -0800</bug_when>
    <thetext>Comment on attachment 384601
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384601&amp;action=review

&gt; Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:-267
&gt; -                //              \

I can&apos;t see anything on https://webkit.org/code-style-guidelines/ saying we shouldn&apos;t use &quot;C style&quot; but maybe an alternative is to change this &apos;\&apos;. For example use &apos;/&apos; instead and move inline-block to the right.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1594544</commentid>
    <comment_count>3</comment_count>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2019-12-02 02:58:16 -0800</bug_when>
    <thetext>(In reply to Frédéric Wang (:fredw) from comment #2)
&gt; Comment on attachment 384601 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=384601&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:-267
&gt; &gt; -                //              \
&gt; 
&gt; I can&apos;t see anything on https://webkit.org/code-style-guidelines/ saying we
&gt; shouldn&apos;t use &quot;C style&quot; but maybe an alternative is to change this &apos;\&apos;. For
&gt; example use &apos;/&apos; instead and move inline-block to the right.

I have a hard time understanding that part of the ASCII art. I think I&apos;ll try your suggestion and CC zalan/antii whether they like it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1594549</commentid>
    <comment_count>4</comment_count>
      <attachid>384609</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2019-12-02 04:40:37 -0800</bug_when>
    <thetext>Created attachment 384609
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1594566</commentid>
    <comment_count>5</comment_count>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2019-12-02 06:36:03 -0800</bug_when>
    <thetext>@zalan, antti, is the new ASCII art acceptable? :) It fixes the warning.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1594567</commentid>
    <comment_count>6</comment_count>
    <who name="alan">zalan</who>
    <bug_when>2019-12-02 06:41:30 -0800</bug_when>
    <thetext>(In reply to Rob Buis from comment #5)
&gt; @zalan, antti, is the new ASCII art acceptable? :) It fixes the warning.

Let&apos;s just remove those 2 lines:
+++ b/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp
@@ -264,8 +264,6 @@ void LineBuilder::alignContentVertically(RunList&amp; runList)
                 ASSERT(!formattingState.lineBoxes().isEmpty());
                 auto inlineBlockBaselineOffset = formattingState.lineBoxes().last().baselineOffset();
                 // The inline-block&apos;s baseline offset is relative to its content box. Let&apos;s convert it relative to the margin box.
-                //   inline-block
-                //              \
                 //           _______________ &lt;- margin box
                 //          |
                 //          |  ____________  &lt;- border box</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1594568</commentid>
    <comment_count>7</comment_count>
      <attachid>384615</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2019-12-02 06:44:05 -0800</bug_when>
    <thetext>Created attachment 384615
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1594570</commentid>
    <comment_count>8</comment_count>
      <attachid>384615</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-12-02 06:46:17 -0800</bug_when>
    <thetext>Comment on attachment 384615
Patch

Rejecting attachment 384615 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.webkit.org&apos;, &apos;--bot-id=webkit-cq-01&apos;, &apos;validate-changelog&apos;, &apos;--check-oops&apos;, &apos;--non-interactive&apos;, 384615, &apos;--port=mac&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13284915</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1594579</commentid>
    <comment_count>9</comment_count>
      <attachid>384615</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-12-02 07:36:16 -0800</bug_when>
    <thetext>Comment on attachment 384615
Patch

Clearing flags on attachment: 384615

Committed r252982: &lt;https://trac.webkit.org/changeset/252982&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1594580</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-12-02 07:36:17 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1594581</commentid>
    <comment_count>11</comment_count>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2019-12-02 07:37:42 -0800</bug_when>
    <thetext>Reopening to attach new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1594582</commentid>
    <comment_count>12</comment_count>
      <attachid>384617</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2019-12-02 07:37:44 -0800</bug_when>
    <thetext>Created attachment 384617
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1594583</commentid>
    <comment_count>13</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-12-02 07:37:58 -0800</bug_when>
    <thetext>&lt;rdar://problem/57557807&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1594584</commentid>
    <comment_count>14</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-12-02 07:37:58 -0800</bug_when>
    <thetext>&lt;rdar://problem/57557808&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1594585</commentid>
    <comment_count>15</comment_count>
      <attachid>384617</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-12-02 07:39:47 -0800</bug_when>
    <thetext>Comment on attachment 384617
Patch

Rejecting attachment 384617 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.webkit.org&apos;, &apos;--bot-id=webkit-cq-03&apos;, &apos;apply-attachment&apos;, &apos;--no-update&apos;, &apos;--non-interactive&apos;, 384617, &apos;--port=mac&apos;]&quot; exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=384617&amp;action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=204739&amp;ctype=xml&amp;excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 384617 from bug 204739.
Fetching: https://bugs.webkit.org/attachment.cgi?id=384617
Failed to run &quot;[u&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply&apos;, &apos;--force&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 3 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/Modules/indexeddb/IDBDatabase.cpp
Hunk #1 FAILED at 278.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/Modules/indexeddb/IDBDatabase.cpp.rej
patching file Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp
Hunk #1 FAILED at 263.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp.rej

Failed to run &quot;[u&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply&apos;, &apos;--force&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13284944</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1594586</commentid>
    <comment_count>16</comment_count>
      <attachid>384618</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2019-12-02 07:40:40 -0800</bug_when>
    <thetext>Created attachment 384618
Patch</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>384601</attachid>
            <date>2019-12-02 02:01:42 -0800</date>
            <delta_ts>2019-12-02 04:40:34 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-204739-20191202110141.patch</filename>
            <type>text/plain</type>
            <size>4388</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyOTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjI5ZGJmNDFlN2Q3ZDFl
ZDBmYTE1NzIwODJiMzViODUyZTRiMTZlMS4uNDNiNGU3ZjJiY2QxZjY3MTUzZTk5YWI0ZDVlMTc3
NjQxOWIxMzE2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTEyLTAyICBSb2Ig
QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRml4IHNvbWUgd2Fybmlu
Z3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDcz
OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9k
dWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCRGF0
YWJhc2U6OmNvbm5lY3Rpb25Ub1NlcnZlckxvc3QpOgorICAgICAgICAqIGxheW91dC9pbmxpbmVm
b3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91
dDo6TGluZUJ1aWxkZXI6OmFsaWduQ29udGVudFZlcnRpY2FsbHkpOgorCiAyMDE5LTEyLTAyICBB
bnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtSZW5kZXIg
dHJlZV0gU3VwcG9ydCBMRkMgaW4gTGluZUxheW91dFRyYXZlcnNhbApkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2UuY3BwIGIvU291cmNlL1dl
YkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2UuY3BwCmluZGV4IGNmNGExMDIwOGNi
YzYwN2RkNjUwMjJlNjVjMWM5Y2JiZWM5YWQ2NjAuLmRiMTUyNmI5NjJiNWZiMjJmOTYwOGYxZTM1
NTg2NTQyNWEwY2NiN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhl
ZGRiL0lEQkRhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRk
Yi9JREJEYXRhYmFzZS5jcHAKQEAgLTI3OCwxMyArMjc4LDEzIEBAIHZvaWQgSURCRGF0YWJhc2U6
OmNvbm5lY3Rpb25Ub1NlcnZlckxvc3QoY29uc3QgSURCRXJyb3ImIGVycm9yKQogICAgIGF1dG8g
ZXJyb3JFdmVudCA9IEV2ZW50OjpjcmVhdGUobV9ldmVudE5hbWVzLmVycm9yRXZlbnQsIEV2ZW50
OjpDYW5CdWJibGU6OlllcywgRXZlbnQ6OklzQ2FuY2VsYWJsZTo6Tm8pOwogICAgIGVycm9yRXZl
bnQtPnNldFRhcmdldCh0aGlzKTsKIAotICAgIGlmIChhdXRvKiBjb250ZXh0ID0gc2NyaXB0RXhl
Y3V0aW9uQ29udGV4dCgpKQorICAgIGlmIChzY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpCiAgICAg
ICAgIHF1ZXVlVGFza1RvRGlzcGF0Y2hFdmVudCgqdGhpcywgVGFza1NvdXJjZTo6RGF0YWJhc2VB
Y2Nlc3MsIFdURk1vdmUoZXJyb3JFdmVudCkpOwogCiAgICAgYXV0byBjbG9zZUV2ZW50ID0gRXZl
bnQ6OmNyZWF0ZShtX2V2ZW50TmFtZXMuY2xvc2VFdmVudCwgRXZlbnQ6OkNhbkJ1YmJsZTo6WWVz
LCBFdmVudDo6SXNDYW5jZWxhYmxlOjpObyk7CiAgICAgY2xvc2VFdmVudC0+c2V0VGFyZ2V0KHRo
aXMpOwogCi0gICAgaWYgKGF1dG8qIGNvbnRleHQgPSBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCkp
CisgICAgaWYgKHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSkKICAgICAgICAgcXVldWVUYXNrVG9E
aXNwYXRjaEV2ZW50KCp0aGlzLCBUYXNrU291cmNlOjpEYXRhYmFzZUFjY2VzcywgV1RGTW92ZShj
bG9zZUV2ZW50KSk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxp
bmVmb3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91
dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcAppbmRleCBhZDNkY2I4NGEx
ZWM5YTg1MTc4NzQ4YzY0OTYyNzkzNTBjOTgyZjMxLi4yZDg4ZDVhYjc0N2QyMzUwMWI3M2RmYTky
YjNmOTI1ZDg5MzIxZGEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5l
Zm9ybWF0dGluZy9JbmxpbmVMaW5lQnVpbGRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5
b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1aWxkZXIuY3BwCkBAIC0yNjIsMjAgKzI2
MiwyMCBAQCB2b2lkIExpbmVCdWlsZGVyOjphbGlnbkNvbnRlbnRWZXJ0aWNhbGx5KFJ1bkxpc3Qm
IHJ1bkxpc3QpCiAgICAgICAgICAgICAgICAgYXV0byYgZm9ybWF0dGluZ1N0YXRlID0gZG93bmNh
c3Q8SW5saW5lRm9ybWF0dGluZ1N0YXRlPihsYXlvdXRTdGF0ZSgpLmVzdGFibGlzaGVkRm9ybWF0
dGluZ1N0YXRlKGRvd25jYXN0PENvbnRhaW5lcj4obGF5b3V0Qm94KSkpOwogICAgICAgICAgICAg
ICAgIC8vIFNwZWMgbWFrZXMgdXMgZ2VuZXJhdGUgYXQgbGVhc3Qgb25lIGxpbmUgLWV2ZW4gaWYg
aXQgaXMgZW1wdHkuCiAgICAgICAgICAgICAgICAgYXV0byBpbmxpbmVCbG9ja0Jhc2VsaW5lT2Zm
c2V0ID0gZm9ybWF0dGluZ1N0YXRlLmRpc3BsYXlJbmxpbmVDb250ZW50KCktPmxpbmVCb3hlcy5s
YXN0KCkuYmFzZWxpbmVPZmZzZXQoKTsKLSAgICAgICAgICAgICAgICAvLyBUaGUgaW5saW5lLWJs
b2NrJ3MgYmFzZWxpbmUgb2Zmc2V0IGlzIHJlbGF0aXZlIHRvIGl0cyBjb250ZW50IGJveC4gTGV0
J3MgY29udmVydCBpdCByZWxhdGl2ZSB0byB0aGUgbWFyZ2luIGJveC4KLSAgICAgICAgICAgICAg
ICAvLyAgIGlubGluZS1ibG9jawotICAgICAgICAgICAgICAgIC8vICAgICAgICAgICAgICBcCi0g
ICAgICAgICAgICAgICAgLy8gICAgICAgICAgIF9fX19fX19fX19fX19fXyA8LSBtYXJnaW4gYm94
Ci0gICAgICAgICAgICAgICAgLy8gICAgICAgICAgfAotICAgICAgICAgICAgICAgIC8vICAgICAg
ICAgIHwgIF9fX19fX19fX19fXyAgPC0gYm9yZGVyIGJveAotICAgICAgICAgICAgICAgIC8vICAg
ICAgICAgIHwgfAotICAgICAgICAgICAgICAgIC8vICAgICAgICAgIHwgfCAgX19fX19fX19fICA8
LSBjb250ZW50IGJveAotICAgICAgICAgICAgICAgIC8vICAgICAgICAgIHwgfCB8ICAgXgotICAg
ICAgICAgICAgICAgIC8vICAgICAgICAgIHwgfCB8ICAgfCAgPC0gYmFzZWxpbmUgb2Zmc2V0Ci0g
ICAgICAgICAgICAgICAgLy8gICAgICAgICAgfCB8IHwgICB8Ci0gICAgICAgICAgICAgICAgLy8g
ICAgIHRleHQgfCB8IHwgICB2IHRleHQKLSAgICAgICAgICAgICAgICAvLyAgICAgLS0tLS18LXwt
fC0tLS0tLS0tLS0gPC0gYmFzZWxpbmUKLSAgICAgICAgICAgICAgICAvLworICAgICAgICAgICAg
ICAgIC8qIFRoZSBpbmxpbmUtYmxvY2sncyBiYXNlbGluZSBvZmZzZXQgaXMgcmVsYXRpdmUgdG8g
aXRzIGNvbnRlbnQgYm94LiBMZXQncyBjb252ZXJ0IGl0IHJlbGF0aXZlIHRvIHRoZSBtYXJnaW4g
Ym94LgorICAgICAgICAgICAgICAgICAgICAgaW5saW5lLWJsb2NrCisgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIFwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgX19fX19fX19f
X19fX19fIDwtIG1hcmdpbiBib3gKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8CisgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgfCAgX19fX19fX19fX19fICA8LSBib3JkZXIgYm94Cisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCB8CisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgfCB8ICBfX19fX19fX18gIDwtIGNvbnRlbnQgYm94CisgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgfCB8IHwgICBeCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCB8IHwgICB8ICA8
LSBiYXNlbGluZSBvZmZzZXQKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IHwgfCAgIHwK
KyAgICAgICAgICAgICAgICAgICAgICAgdGV4dCB8IHwgfCAgIHYgdGV4dAorICAgICAgICAgICAg
ICAgICAgICAgICAtLS0tLXwtfC18LS0tLS0tLS0tLSA8LSBiYXNlbGluZQorICAgICAgICAgICAg
ICAgICovCiAgICAgICAgICAgICAgICAgYXV0byYgYm94R2VvbWV0cnkgPSBmb3JtYXR0aW5nQ29u
dGV4dCgpLmdlb21ldHJ5Rm9yQm94KGxheW91dEJveCk7CiAgICAgICAgICAgICAgICAgYXV0byBi
YXNlbGluZU9mZnNldEZyb21NYXJnaW5Cb3ggPSBib3hHZW9tZXRyeS5tYXJnaW5CZWZvcmUoKSAr
IGJveEdlb21ldHJ5LmJvcmRlclRvcCgpICsgYm94R2VvbWV0cnkucGFkZGluZ1RvcCgpLnZhbHVl
T3IoMCkgKyBpbmxpbmVCbG9ja0Jhc2VsaW5lT2Zmc2V0OwogICAgICAgICAgICAgICAgIGxvZ2lj
YWxUb3AgPSBiYXNlbGluZU9mZnNldCgpIC0gYmFzZWxpbmVPZmZzZXRGcm9tTWFyZ2luQm94Owo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>384609</attachid>
            <date>2019-12-02 04:40:37 -0800</date>
            <delta_ts>2019-12-02 06:44:02 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-204739-20191202134036.patch</filename>
            <type>text/plain</type>
            <size>2930</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyOTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjI5ZGJmNDFlN2Q3ZDFl
ZDBmYTE1NzIwODJiMzViODUyZTRiMTZlMS4uNDNiNGU3ZjJiY2QxZjY3MTUzZTk5YWI0ZDVlMTc3
NjQxOWIxMzE2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTEyLTAyICBSb2Ig
QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRml4IHNvbWUgd2Fybmlu
Z3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDcz
OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9k
dWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCRGF0
YWJhc2U6OmNvbm5lY3Rpb25Ub1NlcnZlckxvc3QpOgorICAgICAgICAqIGxheW91dC9pbmxpbmVm
b3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91
dDo6TGluZUJ1aWxkZXI6OmFsaWduQ29udGVudFZlcnRpY2FsbHkpOgorCiAyMDE5LTEyLTAyICBB
bnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtSZW5kZXIg
dHJlZV0gU3VwcG9ydCBMRkMgaW4gTGluZUxheW91dFRyYXZlcnNhbApkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2UuY3BwIGIvU291cmNlL1dl
YkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2UuY3BwCmluZGV4IGNmNGExMDIwOGNi
YzYwN2RkNjUwMjJlNjVjMWM5Y2JiZWM5YWQ2NjAuLmRiMTUyNmI5NjJiNWZiMjJmOTYwOGYxZTM1
NTg2NTQyNWEwY2NiN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhl
ZGRiL0lEQkRhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRk
Yi9JREJEYXRhYmFzZS5jcHAKQEAgLTI3OCwxMyArMjc4LDEzIEBAIHZvaWQgSURCRGF0YWJhc2U6
OmNvbm5lY3Rpb25Ub1NlcnZlckxvc3QoY29uc3QgSURCRXJyb3ImIGVycm9yKQogICAgIGF1dG8g
ZXJyb3JFdmVudCA9IEV2ZW50OjpjcmVhdGUobV9ldmVudE5hbWVzLmVycm9yRXZlbnQsIEV2ZW50
OjpDYW5CdWJibGU6OlllcywgRXZlbnQ6OklzQ2FuY2VsYWJsZTo6Tm8pOwogICAgIGVycm9yRXZl
bnQtPnNldFRhcmdldCh0aGlzKTsKIAotICAgIGlmIChhdXRvKiBjb250ZXh0ID0gc2NyaXB0RXhl
Y3V0aW9uQ29udGV4dCgpKQorICAgIGlmIChzY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpCiAgICAg
ICAgIHF1ZXVlVGFza1RvRGlzcGF0Y2hFdmVudCgqdGhpcywgVGFza1NvdXJjZTo6RGF0YWJhc2VB
Y2Nlc3MsIFdURk1vdmUoZXJyb3JFdmVudCkpOwogCiAgICAgYXV0byBjbG9zZUV2ZW50ID0gRXZl
bnQ6OmNyZWF0ZShtX2V2ZW50TmFtZXMuY2xvc2VFdmVudCwgRXZlbnQ6OkNhbkJ1YmJsZTo6WWVz
LCBFdmVudDo6SXNDYW5jZWxhYmxlOjpObyk7CiAgICAgY2xvc2VFdmVudC0+c2V0VGFyZ2V0KHRo
aXMpOwogCi0gICAgaWYgKGF1dG8qIGNvbnRleHQgPSBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCkp
CisgICAgaWYgKHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSkKICAgICAgICAgcXVldWVUYXNrVG9E
aXNwYXRjaEV2ZW50KCp0aGlzLCBUYXNrU291cmNlOjpEYXRhYmFzZUFjY2VzcywgV1RGTW92ZShj
bG9zZUV2ZW50KSk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxp
bmVmb3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91
dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcAppbmRleCBhZDNkY2I4NGEx
ZWM5YTg1MTc4NzQ4YzY0OTYyNzkzNTBjOTgyZjMxLi43OTNhZWU4N2VkY2Q1YWI0OTRjM2I0ZWY4
MGFlNjU4MjBmNTBmOWI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5l
Zm9ybWF0dGluZy9JbmxpbmVMaW5lQnVpbGRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5
b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1aWxkZXIuY3BwCkBAIC0yNjMsOCArMjYz
LDggQEAgdm9pZCBMaW5lQnVpbGRlcjo6YWxpZ25Db250ZW50VmVydGljYWxseShSdW5MaXN0JiBy
dW5MaXN0KQogICAgICAgICAgICAgICAgIC8vIFNwZWMgbWFrZXMgdXMgZ2VuZXJhdGUgYXQgbGVh
c3Qgb25lIGxpbmUgLWV2ZW4gaWYgaXQgaXMgZW1wdHkuCiAgICAgICAgICAgICAgICAgYXV0byBp
bmxpbmVCbG9ja0Jhc2VsaW5lT2Zmc2V0ID0gZm9ybWF0dGluZ1N0YXRlLmRpc3BsYXlJbmxpbmVD
b250ZW50KCktPmxpbmVCb3hlcy5sYXN0KCkuYmFzZWxpbmVPZmZzZXQoKTsKICAgICAgICAgICAg
ICAgICAvLyBUaGUgaW5saW5lLWJsb2NrJ3MgYmFzZWxpbmUgb2Zmc2V0IGlzIHJlbGF0aXZlIHRv
IGl0cyBjb250ZW50IGJveC4gTGV0J3MgY29udmVydCBpdCByZWxhdGl2ZSB0byB0aGUgbWFyZ2lu
IGJveC4KLSAgICAgICAgICAgICAgICAvLyAgIGlubGluZS1ibG9jawotICAgICAgICAgICAgICAg
IC8vICAgICAgICAgICAgICBcCisgICAgICAgICAgICAgICAgLy8gICAgICAgICAgICAgIGlubGlu
ZS1ibG9jaworICAgICAgICAgICAgICAgIC8vICAgICAgICAgICAgICAvCiAgICAgICAgICAgICAg
ICAgLy8gICAgICAgICAgIF9fX19fX19fX19fX19fXyA8LSBtYXJnaW4gYm94CiAgICAgICAgICAg
ICAgICAgLy8gICAgICAgICAgfAogICAgICAgICAgICAgICAgIC8vICAgICAgICAgIHwgIF9fX19f
X19fX19fXyAgPC0gYm9yZGVyIGJveAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>384615</attachid>
            <date>2019-12-02 06:44:05 -0800</date>
            <delta_ts>2019-12-02 07:37:37 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-204739-20191202154404.patch</filename>
            <type>text/plain</type>
            <size>2831</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyOTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjQxMGMyN2I0MzJlMDFm
MTg0ZDRjNjdiMzExM2JjZGRiY2ZiNmIyNi4uNmFlNDBlMWMwNjYxOGExMDkyZDhjYzY0OWVhYjgz
MTcxMjY2OWZmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTEyLTAyICBSb2Ig
QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRml4IHNvbWUgd2Fybmlu
Z3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDcz
OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9k
dWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCRGF0
YWJhc2U6OmNvbm5lY3Rpb25Ub1NlcnZlckxvc3QpOgorICAgICAgICAqIGxheW91dC9pbmxpbmVm
b3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91
dDo6TGluZUJ1aWxkZXI6OmFsaWduQ29udGVudFZlcnRpY2FsbHkpOgorCiAyMDE5LTEyLTAyICB5
b3Vlbm4gZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgTWVkaWFT
dHJlYW1UcmFjayBldmVudCBxdWV1ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxl
cy9pbmRleGVkZGIvSURCRGF0YWJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRl
eGVkZGIvSURCRGF0YWJhc2UuY3BwCmluZGV4IGNmNGExMDIwOGNiYzYwN2RkNjUwMjJlNjVjMWM5
Y2JiZWM5YWQ2NjAuLmRiMTUyNmI5NjJiNWZiMjJmOTYwOGYxZTM1NTg2NTQyNWEwY2NiN2YgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkRhdGFiYXNlLmNw
cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFzZS5jcHAK
QEAgLTI3OCwxMyArMjc4LDEzIEBAIHZvaWQgSURCRGF0YWJhc2U6OmNvbm5lY3Rpb25Ub1NlcnZl
ckxvc3QoY29uc3QgSURCRXJyb3ImIGVycm9yKQogICAgIGF1dG8gZXJyb3JFdmVudCA9IEV2ZW50
OjpjcmVhdGUobV9ldmVudE5hbWVzLmVycm9yRXZlbnQsIEV2ZW50OjpDYW5CdWJibGU6Olllcywg
RXZlbnQ6OklzQ2FuY2VsYWJsZTo6Tm8pOwogICAgIGVycm9yRXZlbnQtPnNldFRhcmdldCh0aGlz
KTsKIAotICAgIGlmIChhdXRvKiBjb250ZXh0ID0gc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKQor
ICAgIGlmIChzY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpCiAgICAgICAgIHF1ZXVlVGFza1RvRGlz
cGF0Y2hFdmVudCgqdGhpcywgVGFza1NvdXJjZTo6RGF0YWJhc2VBY2Nlc3MsIFdURk1vdmUoZXJy
b3JFdmVudCkpOwogCiAgICAgYXV0byBjbG9zZUV2ZW50ID0gRXZlbnQ6OmNyZWF0ZShtX2V2ZW50
TmFtZXMuY2xvc2VFdmVudCwgRXZlbnQ6OkNhbkJ1YmJsZTo6WWVzLCBFdmVudDo6SXNDYW5jZWxh
YmxlOjpObyk7CiAgICAgY2xvc2VFdmVudC0+c2V0VGFyZ2V0KHRoaXMpOwogCi0gICAgaWYgKGF1
dG8qIGNvbnRleHQgPSBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpCisgICAgaWYgKHNjcmlwdEV4
ZWN1dGlvbkNvbnRleHQoKSkKICAgICAgICAgcXVldWVUYXNrVG9EaXNwYXRjaEV2ZW50KCp0aGlz
LCBUYXNrU291cmNlOjpEYXRhYmFzZUFjY2VzcywgV1RGTW92ZShjbG9zZUV2ZW50KSk7CiB9CiAK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGlu
ZUxpbmVCdWlsZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5n
L0lubGluZUxpbmVCdWlsZGVyLmNwcAppbmRleCBhZDNkY2I4NGExZWM5YTg1MTc4NzQ4YzY0OTYy
NzkzNTBjOTgyZjMxLi42NWIzY2QzOWI3OGIwYTA3YjdkMGU3ZDE4ZmNkNjExZDMyOGQ1NDg5IDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVM
aW5lQnVpbGRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRp
bmcvSW5saW5lTGluZUJ1aWxkZXIuY3BwCkBAIC0yNjMsOCArMjYzLDYgQEAgdm9pZCBMaW5lQnVp
bGRlcjo6YWxpZ25Db250ZW50VmVydGljYWxseShSdW5MaXN0JiBydW5MaXN0KQogICAgICAgICAg
ICAgICAgIC8vIFNwZWMgbWFrZXMgdXMgZ2VuZXJhdGUgYXQgbGVhc3Qgb25lIGxpbmUgLWV2ZW4g
aWYgaXQgaXMgZW1wdHkuCiAgICAgICAgICAgICAgICAgYXV0byBpbmxpbmVCbG9ja0Jhc2VsaW5l
T2Zmc2V0ID0gZm9ybWF0dGluZ1N0YXRlLmRpc3BsYXlJbmxpbmVDb250ZW50KCktPmxpbmVCb3hl
cy5sYXN0KCkuYmFzZWxpbmVPZmZzZXQoKTsKICAgICAgICAgICAgICAgICAvLyBUaGUgaW5saW5l
LWJsb2NrJ3MgYmFzZWxpbmUgb2Zmc2V0IGlzIHJlbGF0aXZlIHRvIGl0cyBjb250ZW50IGJveC4g
TGV0J3MgY29udmVydCBpdCByZWxhdGl2ZSB0byB0aGUgbWFyZ2luIGJveC4KLSAgICAgICAgICAg
ICAgICAvLyAgIGlubGluZS1ibG9jawotICAgICAgICAgICAgICAgIC8vICAgICAgICAgICAgICBc
CiAgICAgICAgICAgICAgICAgLy8gICAgICAgICAgIF9fX19fX19fX19fX19fXyA8LSBtYXJnaW4g
Ym94CiAgICAgICAgICAgICAgICAgLy8gICAgICAgICAgfAogICAgICAgICAgICAgICAgIC8vICAg
ICAgICAgIHwgIF9fX19fX19fX19fXyAgPC0gYm9yZGVyIGJveAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>384617</attachid>
            <date>2019-12-02 07:37:44 -0800</date>
            <delta_ts>2019-12-02 07:40:36 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-204739-20191202163743.patch</filename>
            <type>text/plain</type>
            <size>2832</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyOTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjQxMGMyN2I0MzJlMDFm
MTg0ZDRjNjdiMzExM2JjZGRiY2ZiNmIyNi4uYmVlMThiYzUwZmI2ZmY1MDFkYmVlY2I3OWY1ZTE3
OTY1NDJlMmViOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTEyLTAyICBSb2Ig
QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRml4IHNvbWUgd2Fybmlu
Z3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDcz
OQorCisgICAgICAgIFJldmlld2VkIGJ5IEZyw6lkw6lyaWMgV2FuZy4KKworICAgICAgICAqIE1v
ZHVsZXMvaW5kZXhlZGRiL0lEQkRhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQkRh
dGFiYXNlOjpjb25uZWN0aW9uVG9TZXJ2ZXJMb3N0KToKKyAgICAgICAgKiBsYXlvdXQvaW5saW5l
Zm9ybWF0dGluZy9JbmxpbmVMaW5lQnVpbGRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlv
dXQ6OkxpbmVCdWlsZGVyOjphbGlnbkNvbnRlbnRWZXJ0aWNhbGx5KToKKwogMjAxOS0xMi0wMiAg
eW91ZW5uIGZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIE1lZGlh
U3RyZWFtVHJhY2sgZXZlbnQgcXVldWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVs
ZXMvaW5kZXhlZGRiL0lEQkRhdGFiYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5k
ZXhlZGRiL0lEQkRhdGFiYXNlLmNwcAppbmRleCBjZjRhMTAyMDhjYmM2MDdkZDY1MDIyZTY1YzFj
OWNiYmVjOWFkNjYwLi5kYjE1MjZiOTYyYjVmYjIyZjk2MDhmMWUzNTU4NjU0MjVhMGNjYjdmIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFzZS5j
cHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2UuY3Bw
CkBAIC0yNzgsMTMgKzI3OCwxMyBAQCB2b2lkIElEQkRhdGFiYXNlOjpjb25uZWN0aW9uVG9TZXJ2
ZXJMb3N0KGNvbnN0IElEQkVycm9yJiBlcnJvcikKICAgICBhdXRvIGVycm9yRXZlbnQgPSBFdmVu
dDo6Y3JlYXRlKG1fZXZlbnROYW1lcy5lcnJvckV2ZW50LCBFdmVudDo6Q2FuQnViYmxlOjpZZXMs
IEV2ZW50OjpJc0NhbmNlbGFibGU6Ok5vKTsKICAgICBlcnJvckV2ZW50LT5zZXRUYXJnZXQodGhp
cyk7CiAKLSAgICBpZiAoYXV0byogY29udGV4dCA9IHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSkK
KyAgICBpZiAoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKQogICAgICAgICBxdWV1ZVRhc2tUb0Rp
c3BhdGNoRXZlbnQoKnRoaXMsIFRhc2tTb3VyY2U6OkRhdGFiYXNlQWNjZXNzLCBXVEZNb3ZlKGVy
cm9yRXZlbnQpKTsKIAogICAgIGF1dG8gY2xvc2VFdmVudCA9IEV2ZW50OjpjcmVhdGUobV9ldmVu
dE5hbWVzLmNsb3NlRXZlbnQsIEV2ZW50OjpDYW5CdWJibGU6OlllcywgRXZlbnQ6OklzQ2FuY2Vs
YWJsZTo6Tm8pOwogICAgIGNsb3NlRXZlbnQtPnNldFRhcmdldCh0aGlzKTsKIAotICAgIGlmIChh
dXRvKiBjb250ZXh0ID0gc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKQorICAgIGlmIChzY3JpcHRF
eGVjdXRpb25Db250ZXh0KCkpCiAgICAgICAgIHF1ZXVlVGFza1RvRGlzcGF0Y2hFdmVudCgqdGhp
cywgVGFza1NvdXJjZTo6RGF0YWJhc2VBY2Nlc3MsIFdURk1vdmUoY2xvc2VFdmVudCkpOwogfQog
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9Jbmxp
bmVMaW5lQnVpbGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGlu
Zy9JbmxpbmVMaW5lQnVpbGRlci5jcHAKaW5kZXggYWQzZGNiODRhMWVjOWE4NTE3ODc0OGM2NDk2
Mjc5MzUwYzk4MmYzMS4uNjViM2NkMzliNzhiMGEwN2I3ZDBlN2QxOGZjZDYxMWQzMjhkNTQ4OSAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5l
TGluZUJ1aWxkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0
aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcApAQCAtMjYzLDggKzI2Myw2IEBAIHZvaWQgTGluZUJ1
aWxkZXI6OmFsaWduQ29udGVudFZlcnRpY2FsbHkoUnVuTGlzdCYgcnVuTGlzdCkKICAgICAgICAg
ICAgICAgICAvLyBTcGVjIG1ha2VzIHVzIGdlbmVyYXRlIGF0IGxlYXN0IG9uZSBsaW5lIC1ldmVu
IGlmIGl0IGlzIGVtcHR5LgogICAgICAgICAgICAgICAgIGF1dG8gaW5saW5lQmxvY2tCYXNlbGlu
ZU9mZnNldCA9IGZvcm1hdHRpbmdTdGF0ZS5kaXNwbGF5SW5saW5lQ29udGVudCgpLT5saW5lQm94
ZXMubGFzdCgpLmJhc2VsaW5lT2Zmc2V0KCk7CiAgICAgICAgICAgICAgICAgLy8gVGhlIGlubGlu
ZS1ibG9jaydzIGJhc2VsaW5lIG9mZnNldCBpcyByZWxhdGl2ZSB0byBpdHMgY29udGVudCBib3gu
IExldCdzIGNvbnZlcnQgaXQgcmVsYXRpdmUgdG8gdGhlIG1hcmdpbiBib3guCi0gICAgICAgICAg
ICAgICAgLy8gICBpbmxpbmUtYmxvY2sKLSAgICAgICAgICAgICAgICAvLyAgICAgICAgICAgICAg
XAogICAgICAgICAgICAgICAgIC8vICAgICAgICAgICBfX19fX19fX19fX19fX18gPC0gbWFyZ2lu
IGJveAogICAgICAgICAgICAgICAgIC8vICAgICAgICAgIHwKICAgICAgICAgICAgICAgICAvLyAg
ICAgICAgICB8ICBfX19fX19fX19fX18gIDwtIGJvcmRlciBib3gK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>384618</attachid>
            <date>2019-12-02 07:40:40 -0800</date>
            <delta_ts>2019-12-02 07:40:40 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-204739-20191202164039.patch</filename>
            <type>text/plain</type>
            <size>2832</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyOTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjQxMGMyN2I0MzJlMDFm
MTg0ZDRjNjdiMzExM2JjZGRiY2ZiNmIyNi4uYmVlMThiYzUwZmI2ZmY1MDFkYmVlY2I3OWY1ZTE3
OTY1NDJlMmViOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTEyLTAyICBSb2Ig
QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRml4IHNvbWUgd2Fybmlu
Z3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDcz
OQorCisgICAgICAgIFJldmlld2VkIGJ5IEZyw6lkw6lyaWMgV2FuZy4KKworICAgICAgICAqIE1v
ZHVsZXMvaW5kZXhlZGRiL0lEQkRhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQkRh
dGFiYXNlOjpjb25uZWN0aW9uVG9TZXJ2ZXJMb3N0KToKKyAgICAgICAgKiBsYXlvdXQvaW5saW5l
Zm9ybWF0dGluZy9JbmxpbmVMaW5lQnVpbGRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlv
dXQ6OkxpbmVCdWlsZGVyOjphbGlnbkNvbnRlbnRWZXJ0aWNhbGx5KToKKwogMjAxOS0xMi0wMiAg
eW91ZW5uIGZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIE1lZGlh
U3RyZWFtVHJhY2sgZXZlbnQgcXVldWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVs
ZXMvaW5kZXhlZGRiL0lEQkRhdGFiYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5k
ZXhlZGRiL0lEQkRhdGFiYXNlLmNwcAppbmRleCBjZjRhMTAyMDhjYmM2MDdkZDY1MDIyZTY1YzFj
OWNiYmVjOWFkNjYwLi5kYjE1MjZiOTYyYjVmYjIyZjk2MDhmMWUzNTU4NjU0MjVhMGNjYjdmIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFzZS5j
cHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2UuY3Bw
CkBAIC0yNzgsMTMgKzI3OCwxMyBAQCB2b2lkIElEQkRhdGFiYXNlOjpjb25uZWN0aW9uVG9TZXJ2
ZXJMb3N0KGNvbnN0IElEQkVycm9yJiBlcnJvcikKICAgICBhdXRvIGVycm9yRXZlbnQgPSBFdmVu
dDo6Y3JlYXRlKG1fZXZlbnROYW1lcy5lcnJvckV2ZW50LCBFdmVudDo6Q2FuQnViYmxlOjpZZXMs
IEV2ZW50OjpJc0NhbmNlbGFibGU6Ok5vKTsKICAgICBlcnJvckV2ZW50LT5zZXRUYXJnZXQodGhp
cyk7CiAKLSAgICBpZiAoYXV0byogY29udGV4dCA9IHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSkK
KyAgICBpZiAoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKQogICAgICAgICBxdWV1ZVRhc2tUb0Rp
c3BhdGNoRXZlbnQoKnRoaXMsIFRhc2tTb3VyY2U6OkRhdGFiYXNlQWNjZXNzLCBXVEZNb3ZlKGVy
cm9yRXZlbnQpKTsKIAogICAgIGF1dG8gY2xvc2VFdmVudCA9IEV2ZW50OjpjcmVhdGUobV9ldmVu
dE5hbWVzLmNsb3NlRXZlbnQsIEV2ZW50OjpDYW5CdWJibGU6OlllcywgRXZlbnQ6OklzQ2FuY2Vs
YWJsZTo6Tm8pOwogICAgIGNsb3NlRXZlbnQtPnNldFRhcmdldCh0aGlzKTsKIAotICAgIGlmIChh
dXRvKiBjb250ZXh0ID0gc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKQorICAgIGlmIChzY3JpcHRF
eGVjdXRpb25Db250ZXh0KCkpCiAgICAgICAgIHF1ZXVlVGFza1RvRGlzcGF0Y2hFdmVudCgqdGhp
cywgVGFza1NvdXJjZTo6RGF0YWJhc2VBY2Nlc3MsIFdURk1vdmUoY2xvc2VFdmVudCkpOwogfQog
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9Jbmxp
bmVMaW5lQnVpbGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGlu
Zy9JbmxpbmVMaW5lQnVpbGRlci5jcHAKaW5kZXggYWQzZGNiODRhMWVjOWE4NTE3ODc0OGM2NDk2
Mjc5MzUwYzk4MmYzMS4uNjViM2NkMzliNzhiMGEwN2I3ZDBlN2QxOGZjZDYxMWQzMjhkNTQ4OSAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5l
TGluZUJ1aWxkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0
aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcApAQCAtMjYzLDggKzI2Myw2IEBAIHZvaWQgTGluZUJ1
aWxkZXI6OmFsaWduQ29udGVudFZlcnRpY2FsbHkoUnVuTGlzdCYgcnVuTGlzdCkKICAgICAgICAg
ICAgICAgICAvLyBTcGVjIG1ha2VzIHVzIGdlbmVyYXRlIGF0IGxlYXN0IG9uZSBsaW5lIC1ldmVu
IGlmIGl0IGlzIGVtcHR5LgogICAgICAgICAgICAgICAgIGF1dG8gaW5saW5lQmxvY2tCYXNlbGlu
ZU9mZnNldCA9IGZvcm1hdHRpbmdTdGF0ZS5kaXNwbGF5SW5saW5lQ29udGVudCgpLT5saW5lQm94
ZXMubGFzdCgpLmJhc2VsaW5lT2Zmc2V0KCk7CiAgICAgICAgICAgICAgICAgLy8gVGhlIGlubGlu
ZS1ibG9jaydzIGJhc2VsaW5lIG9mZnNldCBpcyByZWxhdGl2ZSB0byBpdHMgY29udGVudCBib3gu
IExldCdzIGNvbnZlcnQgaXQgcmVsYXRpdmUgdG8gdGhlIG1hcmdpbiBib3guCi0gICAgICAgICAg
ICAgICAgLy8gICBpbmxpbmUtYmxvY2sKLSAgICAgICAgICAgICAgICAvLyAgICAgICAgICAgICAg
XAogICAgICAgICAgICAgICAgIC8vICAgICAgICAgICBfX19fX19fX19fX19fX18gPC0gbWFyZ2lu
IGJveAogICAgICAgICAgICAgICAgIC8vICAgICAgICAgIHwKICAgICAgICAgICAgICAgICAvLyAg
ICAgICAgICB8ICBfX19fX19fX19fX18gIDwtIGJvcmRlciBib3gK
</data>

          </attachment>
      

    </bug>

</bugzilla>