204723 2019-11-30 18:37:26 -0800 [LFC][IFC] Add support for word-spacing property 2019-12-01 07:27:13 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1594381 0 zalan 2019-11-30 18:37:26 -0800 ssia 1594382 1 webkit-bug-importer 2019-11-30 18:37:47 -0800 <rdar://problem/57541871> 1594383 2 384564 zalan 2019-11-30 18:42:36 -0800 Created attachment 384564 Patch 1594392 3 384564 koivisto 2019-12-01 00:55:17 -0800 Comment on attachment 384564 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384564&action=review No tests enabled? > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:714 > + itemRunWidth = std::max({ }, itemRunWidth); I think 0_lu would read better than { } 1594393 4 384564 koivisto 2019-12-01 00:56:37 -0800 Comment on attachment 384564 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384564&action=review > Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:50 > + auto wordSpacing = inlineTextItem.isWhitespace() ? LayoutUnit(inlineTextItem.style().fontCascade().wordSpacing()) : LayoutUnit(); 0_lu would work here too 1594411 5 zalan 2019-12-01 07:27:13 -0800 Committed r252967: <https://trac.webkit.org/changeset/252967> 384564 2019-11-30 18:42:36 -0800 2019-12-01 00:55:37 -0800 Patch bug-204723-20191130184204.patch text/plain 3340 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyOTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWYxOTg3NTE4M2Y1ZjRi MDNjNjU2NTAyYjI3NDc0Y2Y1ZTA1OTc3MC4uNzg0ZmVjNmI5NGNjZDA2YmQxOWQ0Mzc3MDRjNjdi Nzg5Y2Y2MjY2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTExLTMwICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBBZGQgc3Vw cG9ydCBmb3Igd29yZC1zcGFjaW5nIHByb3BlcnR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ3MjMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU3 NTQxODcxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1aWxkZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lQnVpbGRlcjo6VHJpbW1hYmxlQ29udGVudDo6YXBwZW5k KToKKyAgICAgICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9MaW5lTGF5b3V0Q29udGV4dC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OmlubGluZUl0ZW1XaWR0aCk6CisKIDIwMTkt MTEtMzAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAg UmVpbXBsZW1lbnQgc29tZSBQbGF0Zm9ybUNBTGF5ZXIgbWV0aG9kcyB1c2luZyBHcmFwaGljc0Nv bnRleHQgaW5zdGVhZCBvZiBDR0NvbnRleHRSZWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcAppbmRl eCBjZmNhZDVmNTFlMmQ1ZDE0OTI1YzViYzBhY2RhODdlMTk2Y2E4MWNkLi5hMTVjNDRiNzM4ZDhj NWNiYTg2NzBhZmY2NjQxYzU0NDlhYjA4YTFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQnVpbGRlci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1aWxkZXIuY3BwCkBA IC03MTAsNyArNzEwLDggQEAgY29uc3QgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQmIExpbmVCdWls ZGVyOjpmb3JtYXR0aW5nQ29udGV4dCgpIGNvbnN0CiAKIHZvaWQgTGluZUJ1aWxkZXI6OlRyaW1t YWJsZUNvbnRlbnQ6OmFwcGVuZChMYXlvdXRVbml0IGl0ZW1SdW5XaWR0aCwgc2l6ZV90IHJ1bklu ZGV4KQogewotICAgIEFTU0VSVChpdGVtUnVuV2lkdGggPj0gMCk7CisgICAgLy8gd29yZC1zcGFj aW5nIGNvdWxkIHZlcnkgd2VsbCBiZSBuZWdhdGl2ZSwgYnV0IGl0IGRvZXMgbm90IG1lYW4gdGhh dCB0aGUgbGluZSBnYWlucyB0aGF0IG11Y2ggZXh0cmEgc3BhY2Ugd2hlbiB0aGUgY29udGVudCBp cyB0cmltbWVkLgorICAgIGl0ZW1SdW5XaWR0aCA9IHN0ZDo6bWF4KHsgfSwgaXRlbVJ1bldpZHRo KTsKICAgICBtX3dpZHRoICs9IGl0ZW1SdW5XaWR0aDsKICAgICBtX3J1bkluZGV4ZXMuYXBwZW5k KHJ1bkluZGV4KTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVm b3JtYXR0aW5nL0xpbmVMYXlvdXRDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9p bmxpbmVmb3JtYXR0aW5nL0xpbmVMYXlvdXRDb250ZXh0LmNwcAppbmRleCA4NTk2ZTMyMzEwMGRm MzA1NzgzZmM2M2FlOTc2YjQwNmQ4YTM3ZjcwLi4xYjE2ZTlkNWRlZTYzZjg3NzUwODk1YjQ2YzU5 NzVlNzM4YmNjNDgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9y bWF0dGluZy9MaW5lTGF5b3V0Q29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2lubGluZWZvcm1hdHRpbmcvTGluZUxheW91dENvbnRleHQuY3BwCkBAIC0zOCwxNCArMzgsMTcg QEAgbmFtZXNwYWNlIExheW91dCB7CiBzdGF0aWMgTGF5b3V0VW5pdCBpbmxpbmVJdGVtV2lkdGgo Y29uc3QgRm9ybWF0dGluZ0NvbnRleHQmIGZvcm1hdHRpbmdDb250ZXh0LCBjb25zdCBJbmxpbmVJ dGVtJiBpbmxpbmVJdGVtLCBMYXlvdXRVbml0IGNvbnRlbnRMb2dpY2FsTGVmdCkKIHsKICAgICBp ZiAoaW5saW5lSXRlbS5pc0ZvcmNlZExpbmVCcmVhaygpKQotICAgICAgICByZXR1cm4gMDsKKyAg ICAgICAgcmV0dXJuIHsgfTsKIAogICAgIGlmIChpczxJbmxpbmVUZXh0SXRlbT4oaW5saW5lSXRl bSkpIHsKICAgICAgICAgYXV0byYgaW5saW5lVGV4dEl0ZW0gPSBkb3duY2FzdDxJbmxpbmVUZXh0 SXRlbT4oaW5saW5lSXRlbSk7Ci0gICAgICAgIGlmIChhdXRvIGNvbnRlbnRXaWR0aCA9IGlubGlu ZVRleHRJdGVtLndpZHRoKCkpCi0gICAgICAgICAgICByZXR1cm4gKmNvbnRlbnRXaWR0aDsKLSAg ICAgICAgYXV0byBlbmQgPSBpbmxpbmVUZXh0SXRlbS5pc0NvbGxhcHNpYmxlKCkgPyBpbmxpbmVU ZXh0SXRlbS5zdGFydCgpICsgMSA6IGlubGluZVRleHRJdGVtLmVuZCgpOwotICAgICAgICByZXR1 cm4gVGV4dFV0aWw6OndpZHRoKGlubGluZVRleHRJdGVtLmxheW91dEJveCgpLCBpbmxpbmVUZXh0 SXRlbS5zdGFydCgpLCBlbmQsIGNvbnRlbnRMb2dpY2FsTGVmdCk7CisgICAgICAgIGF1dG8gY29u dGVudFdpZHRoID0gaW5saW5lVGV4dEl0ZW0ud2lkdGgoKTsKKyAgICAgICAgaWYgKCFjb250ZW50 V2lkdGgpIHsKKyAgICAgICAgICAgIGF1dG8gZW5kID0gaW5saW5lVGV4dEl0ZW0uaXNDb2xsYXBz aWJsZSgpID8gaW5saW5lVGV4dEl0ZW0uc3RhcnQoKSArIDEgOiBpbmxpbmVUZXh0SXRlbS5lbmQo KTsKKyAgICAgICAgICAgIGNvbnRlbnRXaWR0aCA9IFRleHRVdGlsOjp3aWR0aChpbmxpbmVUZXh0 SXRlbS5sYXlvdXRCb3goKSwgaW5saW5lVGV4dEl0ZW0uc3RhcnQoKSwgZW5kLCBjb250ZW50TG9n aWNhbExlZnQpOworICAgICAgICB9CisgICAgICAgIGF1dG8gd29yZFNwYWNpbmcgPSBpbmxpbmVU ZXh0SXRlbS5pc1doaXRlc3BhY2UoKSA/IExheW91dFVuaXQoaW5saW5lVGV4dEl0ZW0uc3R5bGUo KS5mb250Q2FzY2FkZSgpLndvcmRTcGFjaW5nKCkpIDogTGF5b3V0VW5pdCgpOworICAgICAgICBy ZXR1cm4gKmNvbnRlbnRXaWR0aCArIHdvcmRTcGFjaW5nOwogICAgIH0KIAogICAgIGF1dG8mIGxh eW91dEJveCA9IGlubGluZUl0ZW0ubGF5b3V0Qm94KCk7Cg==