204703 2019-11-29 08:02:44 -0800 [GTK][PSON] Crash in NetworkProcessProxy::openNetworkProcessConnection 2019-12-02 01:40:40 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro webkit-unassigned berto bugs-noreply cgarcia ews-watchlist gustavo mcatanzaro oldest_to_newest 1594198 0 mcatanzaro 2019-11-29 08:02:44 -0800 This crash occurs since 2.27.3 when opening the address bar dropdown and scrolling through results. It doesn't happen always, but it occurs so frequently during regular browser usage that I'll likely roll Epiphany back to 2.26.2. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007f01c2b2369b in WebKit::WebProcessProxy::sessionID ( this=this@entry=0x7f00566f8000) at ../Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:112 112 PAL::SessionID sessionID() const { return m_sessionID; } #0 0x00007f01c2b2369b in WebKit::WebProcessProxy::sessionID() const (this=this@entry=0x7f00566f8000) at ../Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:112 #1 0x00007f01c2c0bccc in WebKit::NetworkProcessProxy::openNetworkProcessConnection(unsigned long, WebKit::WebProcessProxy&) (this=this@entry=0x7f0148204000, connectionRequestIdentifier=<optimized out>, webProcessProxy=...) at ../Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:111 #2 0x00007f01c2c10797 in WebKit::NetworkProcessProxy::getNetworkProcessConnection(WebKit::WebProcessProxy&, WTF::CompletionHandler<void (WebKit::NetworkProcessConnectionInfo const&)>&&) (reply=..., webProcessProxy=..., this=0x7f0148204000) at ../Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:145 #3 0x00007f01c2c10797 in WebKit::NetworkProcessProxy::getNetworkProcessConnection(WebKit::WebProcessProxy&, WTF::CompletionHandler<void (WebKit::NetworkProcessConnectionInfo const&)>&&) (this=0x7f0148204000, webProcessProxy=..., reply=...) at ../Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:140 #4 0x00007f01c2b38c7e in WebKit::WebProcessPool::getNetworkProcessConnection(WebKit::WebProcessProxy&, WTF::CompletionHandler<void (WebKit::NetworkProcessConnectionInfo const&)>&&) (this=<optimized out>, webProcessProxy=..., reply=...) at /usr/include/c++/9.2.0/bits/unique_ptr.h:352 #5 0x00007f01c2b38ca2 in WebKit::WebProcessProxy::getNetworkProcessConnection(WTF::CompletionHandler<void (WebKit::NetworkProcessConnectionInfo const&)>&&) (this=this@entry=0x7f00566f8000, reply=...) at DerivedSources/ForwardingHeaders/wtf/WeakPtr.h:100 #6 0x00007f01c28ad137 in IPC::callMemberFunctionImpl<WebKit::WebProcessProxy, void (WebKit::WebProcessProxy::*)(WTF::CompletionHandler<void (WebKit::NetworkProcessConnectionInfo const&)>&&), void (WebKit::NetworkProcessConnectionInfo const&), std::tuple<>>(WebKit::WebProcessProxy*, void (WebKit::WebProcessProxy::*)(WTF::CompletionHandler<void (WebKit::NetworkProcessConnectionInfo const&)>&&), WTF::CompletionHandler<void (WebKit::NetworkProcessConnectionInfo const&)>&&, std::tuple<>&&, std::integer_sequence<unsigned long>) (args=<synthetic pointer>, completionHandler=..., function=<optimized out>, object=0x7f00566f8000) at ../Source/WebKit/Platform/IPC/HandleMessage.h:59 completionHandler = {m_function = {m_callableWrapper = std::unique_ptr<WTF::Detail::CallableWrapperBase<void, WebKit::NetworkProcessConnectionInfo const&>> = {get() = 0x0}}} protectedThis = {static isRef = <error reading variable: Missing ELF symbol "WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >::isRef".>, m_ptr = 0x7f00566f8000} #7 0x00007f01c28ad137 in IPC::callMemberFunction<WebKit::WebProcessProxy, void (WebKit::WebProcessProxy::*)(WTF::CompletionHandler<void (WebKit::NetworkProcessConnectionInfo const&)>&&), void (WebKit::NetworkProcessConnectionInfo const&), std::tuple<>, std::integer_sequence<unsigned long> >(std::tuple<>&&, WTF::CompletionHandler<void (WebKit::NetworkProcessConnectionInfo const&)>&&, WebKit::WebProcessProxy*, void (WebKit::WebProcessProxy::*)(WTF::CompletionHandler<void (WebKit::NetworkProcessConnectionInfo const&)>&&)) (args=<synthetic pointer>, function=<optimized out>, object=0x7f00566f8000, completionHandler=...) at ../Source/WebKit/Platform/IPC/HandleMessage.h:61 completionHandler = {m_function = {m_callableWrapper = std::unique_ptr<WTF::Detail::CallableWrapperBase<void, WebKit::NetworkProcessConnectionInfo const&>> = {get() = 0x0}}} protectedThis = {static isRef = <error reading variable: Missing ELF symbol "WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >::isRef".>, m_ptr = 0x7f00566f8000} #8 0x00007f01c28ad137 in IPC::handleMessageSynchronous<Messages::WebProcessProxy::GetNetworkProcessConnection, WebKit::WebProcessProxy, void (WebKit::WebProcessProxy::*)(WTF::CompletionHandler<void (WebKit::NetworkProcessConnectionInfo const&)>&&)>(IPC::Connection&, IPC::Decoder&, std::unique_ptr<IPC::Encoder, std::default_delete<IPC::Encoder> >&, WebKit::WebProcessProxy*, void (WebKit::WebProcessProxy::*)(WTF::CompletionHandler<void (WebKit::NetworkProcessConnectionInfo const&)>&&)) (function=<optimized out>, object=0x7f00566f8000, replyEncoder=..., decoder=..., connection=...) at ../Source/WebKit/Platform/IPC/HandleMessage.h:148 completionHandler = {m_function = {m_callableWrapper = std::unique_ptr<WTF::Detail::CallableWrapperBase<void, WebKit::NetworkProcessConnectionInfo const&>> = {get() = 0x0}}} protectedThis = {static isRef = <error reading variable: Missing ELF symbol "WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >::isRef".>, m_ptr = 0x7f00566f8000} #9 0x00007f01c28ad137 in WebKit::WebProcessProxy::didReceiveSyncWebProcessProxyMessage(IPC::Connection&, IPC::Decoder&, std::unique_ptr<IPC::Encoder, std::default_delete<IPC::Encoder> >&) (this=0x7f00566f8000, connection=..., decoder=..., replyEncoder=...) at DerivedSources/WebKit/WebProcessProxyMessageReceiver.cpp:291 protectedThis = {static isRef = <error reading variable: Missing ELF symbol "WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >::isRef".>, m_ptr = 0x7f00566f8000} #10 0x00007f01c2a15d5d in IPC::Connection::dispatchSyncMessage(IPC::Decoder&) (this=0x7f007a470320, decoder=...) at ../Source/WebKit/Platform/IPC/Encoder.h:40 syncRequestID = 1 replyEncoder = std::unique_ptr<IPC::Encoder> = {get() = 0x0} #11 0x00007f01c2a15ea1 in IPC::Connection::dispatchMessage(std::unique_ptr<IPC::Decoder, std::default_delete<IPC::Decoder> >) (this=0x7f007a470320, message=std::unique_ptr<IPC::Decoder> = {...}) at /usr/include/c++/9.2.0/bits/unique_ptr.h:352 isDispatchingMessageWhileWaitingForSyncReply = <optimized out> oldDidReceiveInvalidMessage = false #12 0x00007f01c2a160d7 in IPC::Connection::SyncMessageState::dispatchMessages(IPC::Connection*) (this=this@entry=0x7f01c53fb820 <IPC::Connection::SyncMessageState::singleton()::syncMessageState>, allowedConnection=allowedConnection@entry=0x7f007a470320) at /usr/include/c++/9.2.0/bits/move.h:74 connectionAndIncomingMessage = @0x7f00566e0100: {connection = {static isRef = <error reading variable: Missing ELF symbol "WTF::Ref<IPC::Connection, WTF::DumbPtrTraits<IPC::Connection> >::isRef".>, m_ptr = 0x7f007a470320}, message = std::unique_ptr<IPC::Decoder> = {get() = 0x0}} i = <optimized out> messagesToPutBack = {<WTF::VectorBuffer<IPC::Connection::SyncMessageState::ConnectionAndIncomingMessage, 0>> = {<WTF::VectorBufferBase<IPC::Connection::SyncMessageState::ConnectionAndIncomingMessage>> = {m_buffer = 0x0, m_capacity = 0, m_size = 0}, <No data fields>}, <No data fields>} #13 0x00007f01c2a16545 in IPC::Connection::SyncMessageState::dispatchMessageAndResetDidScheduleDispatchMessagesForConnection(IPC::Connection&) (this=0x7f01c53fb820 <IPC::Connection::SyncMessageState::singleton()::syncMessageState>, connection=...) at ../Source/WebKit/Platform/IPC/Connection.cpp:208 #14 0x00007f01c1de7865 in WTF::Function<void ()>::operator()() const (this=<synthetic pointer>) at ../Source/WTF/wtf/Lock.h:84 function = {m_callableWrapper = std::unique_ptr<WTF::Detail::CallableWrapperBase<void>> = {get() = 0x7f00566eb018}} functionsToHandle = 1 #15 0x00007f01c1de7865 in WTF::RunLoop::performWork() (this=0x7f01bc2f5000) at ../Source/WTF/wtf/RunLoop.cpp:107 function = {m_callableWrapper = std::unique_ptr<WTF::Detail::CallableWrapperBase<void>> = {get() = 0x7f00566eb018}} functionsToHandle = 1 #16 0x00007f01c1e33e1d in WTF::RunLoop::<lambda(gpointer)>::operator() (__closure=0x0, userData=<optimized out>) at ../Source/WTF/wtf/glib/RunLoopGLib.cpp:68 #17 0x00007f01c1e33e1d in WTF::RunLoop::<lambda(gpointer)>::_FUN(gpointer) () at ../Source/WTF/wtf/glib/RunLoopGLib.cpp:70 #18 0x00007f01c5e4458e in g_main_dispatch (context=0x55eadaadfd90) at ../glib/gmain.c:3185 dispatch = 0x7f01c1e33e30 <WTF::<lambda(GSource*, GSourceFunc, gpointer)>::_FUN(GSource *, GSourceFunc, gpointer)> prev_source = 0x0 was_in_call = 0 user_data = 0x7f01bc2f5000 callback = 0x7f01c1e33e10 <WTF::RunLoop::<lambda(gpointer)>::_FUN(gpointer)> cb_funcs = 0x7f01c5f19280 <g_source_callback_funcs> cb_data = 0x55eadac44370 need_destroy = <optimized out> source = 0x55eadac09d50 current = 0x55eadaae8e10 i = 0 __func__ = "g_main_dispatch" #19 0x00007f01c5e4458e in g_main_context_dispatch (context=context@entry=0x55eadaadfd90) at ../glib/gmain.c:3850 #20 0x00007f01c5e44940 in g_main_context_iterate (context=context@entry=0x55eadaadfd90, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib/gmain.c:3923 max_priority = 2147483647 timeout = 697 some_ready = 1 nfds = <optimized out> allocated_nfds = <optimized out> fds = 0x55eadad7edd0 #21 0x00007f01c5e449e3 in g_main_context_iteration (context=context@entry=0x55eadaadfd90, may_block=may_block@entry=1) at ../glib/gmain.c:3984 retval = <optimized out> #22 0x00007f01c605e4f5 in g_application_run (application=0x55eadaad4720 [EphyShell], argc=<optimized out>, argv=<optimized out>) at ../gio/gapplication.c:2559 arguments = 0x55eadabf38e0 status = 0 context = 0x55eadaadfd90 acquired_context = 1 __func__ = "g_application_run" #23 0x000055eada08d0cd in main (argc=1, argv=0x7ffd680c1648) at ../src/ephy-main.c:427 option_context = 0x55eadaa939b0 option_group = 0x55eadaa93a30 error = 0x0 user_time = 0 arbitrary_url = 0 ctx = 0x55eadac018f0 mode = EPHY_EMBED_SHELL_MODE_BROWSER status = 32765 flags = EPHY_FILE_HELPERS_ENSURE_EXISTS desktop_info = 0x0 1594234 1 mcatanzaro 2019-11-29 10:35:54 -0800 I think it would be an assertion failure in debug builds. WebProcessProxy::sessionID() gets called before m_websiteDataStore is set. 1594240 2 mcatanzaro 2019-11-29 11:03:52 -0800 OK, here's a 100% reproducer: * Load a website in the web view, e.g. https://webkit.org * Load a different website in the same web view, e.g. https://gnome.org. This triggers the creation of a new WebProcessProxy and a process swap. The new WebProcessProxy uses the same WebsiteDataStore as the original, and all works fine. * Ctrl+L to open the address bar dropdown, hold the down arrow key. A new WebProcessProxy is created (not sure why, is it for prewarming?) without any WebsiteDataStore. Then WebProcessProxy::getNetworkProcessConnection() gets called from somewhere, and we crash because WebProcessProxy::setWebsiteDataStore() has not been called yet. 1594241 3 mcatanzaro 2019-11-29 11:04:13 -0800 (In reply to Michael Catanzaro from comment #0) > It doesn't happen always, but it occurs so > frequently during regular browser usage that I'll likely roll Epiphany back > to 2.26.2. I'll just disable PSON for now. 1594243 4 mcatanzaro 2019-11-29 11:07:31 -0800 (In reply to Michael Catanzaro from comment #2) > * Load a different website in the same web view, e.g. https://gnome.org. > This triggers the creation of a new WebProcessProxy and a process swap. The > new WebProcessProxy uses the same WebsiteDataStore as the original, and all > works fine. > * Ctrl+L to open the address bar dropdown, hold the down arrow key. A new > WebProcessProxy is created (not sure why, is it for prewarming?) without any > WebsiteDataStore. I missed a step here. After you Ctrl+L, you have to type some characters to display history results. Just pressing the down arrow does nothing unless you type first. 1594310 5 cgarcia 2019-11-30 06:49:02 -0800 (In reply to Michael Catanzaro from comment #2) > OK, here's a 100% reproducer: > > * Load a website in the web view, e.g. https://webkit.org > * Load a different website in the same web view, e.g. https://gnome.org. > This triggers the creation of a new WebProcessProxy and a process swap. The > new WebProcessProxy uses the same WebsiteDataStore as the original, and all > works fine. > * Ctrl+L to open the address bar dropdown, hold the down arrow key. A new > WebProcessProxy is created (not sure why, is it for prewarming?) without any > WebsiteDataStore. If it only happens with the keyboard, but not with the mouse, I would blame the DNS prefetch that we start when selecting entries of the dropdown list. > Then WebProcessProxy::getNetworkProcessConnection() gets called from > somewhere, and we crash because WebProcessProxy::setWebsiteDataStore() has > not been called yet. 1594315 6 384542 cgarcia 2019-11-30 07:25:47 -0800 Created attachment 384542 Patch 1594316 7 ews-watchlist 2019-11-30 07:26:47 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1594318 8 384542 mcatanzaro 2019-11-30 07:41:50 -0800 Comment on attachment 384542 Patch Nice, thanks 1594319 9 mcatanzaro 2019-11-30 07:43:07 -0800 (In reply to Michael Catanzaro from comment #1) > I think it would be an assertion failure in debug builds. > WebProcessProxy::sessionID() gets called before m_websiteDataStore is set. I think I would change this to be a RELEASE_ASSERT(). It seems somewhat fragile and that will likely help debugging in the future. 1594526 10 cgarcia 2019-12-02 01:40:40 -0800 Committed r252980: <https://trac.webkit.org/changeset/252980> 384542 2019-11-30 07:25:47 -0800 2019-11-30 07:41:50 -0800 Patch wk2-dns-prefetch-crash.diff text/plain 3938 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNzcyNTE1MWZiNjMuLjZiMTBkMDlmZmQxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE4IEBACisyMDE5LTExLTMwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXVtQU09OXSBDcmFzaCBpbiBOZXR3b3JrUHJvY2Vzc1Byb3h5 OjpvcGVuTmV0d29ya1Byb2Nlc3NDb25uZWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ3MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBTdG9wIHNlbmRpbmcgYSBtZXNzYWdlIHRvIGFsbCB3ZWIg cHJvY2VzcyB0byBwcmVmZXRjaCBETlMgZm9yIGEgaG9zdG5hbWUuIEFsbCB3ZWIgcHJvY2Vzc2Vz IHRoZW4gc2VuZCBhIG1lc3NhYWdlCisgICAgICAgIHRvIHRoZWlyIG5ldHdvcmsgcHJvY2VzcyB0 byBwcmVmZXRjaCB0aGUgRE5TLiBJbnN0ZWFkLCBzZW5kIGEgbWVzc2FnZSBkaXJlY3RseSB0byB0 aGUgbmV0d29yayBwcm9jZXNzLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya1By b2Nlc3MubWVzc2FnZXMuaW46CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdl YkNvbnRleHQuY3BwOgorICAgICAgICAod2Via2l0X3dlYl9jb250ZXh0X3ByZWZldGNoX2Rucyk6 CisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ2xpYi9XZWJLaXRXZWJF eHRlbnNpb24uY3BwOgorCiAyMDE5LTExLTI5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJj aWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBXZWJEcml2ZXI6IHRlc3RzIGlzX2VsZW1lbnRfZW5h YmxlZC9lbmFibGVkLnB5Ojp0ZXN0X2ZpZWxkc2V0X2Rpc2FibGVkX2Rlc2NlbmRhbnQgYXJlIGZh aWxpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1By b2Nlc3MubWVzc2FnZXMuaW4gYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQ cm9jZXNzLm1lc3NhZ2VzLmluCmluZGV4IGFlMDM2MTljMzQ0Li5lMWVlMTc0MGZkOSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5tZXNzYWdl cy5pbgorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLm1l c3NhZ2VzLmluCkBAIC0zMSw2ICszMSw3IEBAIG1lc3NhZ2VzIC0+IE5ldHdvcmtQcm9jZXNzIExl Z2FjeVJlY2VpdmVyIHsKICAgICBTZXRJZ25vcmVUTFNFcnJvcnMoYm9vbCBpZ25vcmVUTFNFcnJv cnMpCiAgICAgVXNlclByZWZlcnJlZExhbmd1YWdlc0NoYW5nZWQoVmVjdG9yPFN0cmluZz4gbGFu Z3VhZ2VzKQogICAgIFNldE5ldHdvcmtQcm94eVNldHRpbmdzKHN0cnVjdCBXZWJDb3JlOjpTb3Vw TmV0d29ya1Byb3h5U2V0dGluZ3Mgc2V0dGluZ3MpCisgICAgUHJlZmV0Y2hETlMoU3RyaW5nIGhv c3RuYW1lKQogI2VuZGlmCiAKICNpZiBVU0UoQ1VSTCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYkNvbnRleHQuY3BwIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29udGV4dC5jcHAKaW5kZXggMTI2YmNjZjEz MTQuLmIwMDgxODM3NmU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv Z2xpYi9XZWJLaXRXZWJDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvZ2xpYi9XZWJLaXRXZWJDb250ZXh0LmNwcApAQCAtMjcsNiArMjcsNyBAQAogI2luY2x1ZGUg IkFQSVByb2Nlc3NQb29sQ29uZmlndXJhdGlvbi5oIgogI2luY2x1ZGUgIkFQSVN0cmluZy5oIgog I2luY2x1ZGUgIkxlZ2FjeUdsb2JhbFNldHRpbmdzLmgiCisjaW5jbHVkZSAiTmV0d29ya1Byb2Nl c3NNZXNzYWdlcy5oIgogI2luY2x1ZGUgIlRleHRDaGVja2VyLmgiCiAjaW5jbHVkZSAiVGV4dENo ZWNrZXJTdGF0ZS5oIgogI2luY2x1ZGUgIldlYkF1dG9tYXRpb25TZXNzaW9uLmgiCkBAIC0xNTUy LDkgKzE1NTMsNyBAQCB2b2lkIHdlYmtpdF93ZWJfY29udGV4dF9wcmVmZXRjaF9kbnMoV2ViS2l0 V2ViQ29udGV4dCogY29udGV4dCwgY29uc3QgY2hhciogaG9zdAogICAgIGdfcmV0dXJuX2lmX2Zh aWwoV0VCS0lUX0lTX1dFQl9DT05URVhUKGNvbnRleHQpKTsKICAgICBnX3JldHVybl9pZl9mYWls KGhvc3RuYW1lKTsKIAotICAgIEFQSTo6RGljdGlvbmFyeTo6TWFwVHlwZSBtZXNzYWdlOwotICAg IG1lc3NhZ2Uuc2V0KFN0cmluZzo6ZnJvbVVURjgoIkhvc3RuYW1lIiksIEFQSTo6U3RyaW5nOjpj cmVhdGUoU3RyaW5nOjpmcm9tVVRGOChob3N0bmFtZSkpKTsKLSAgICBjb250ZXh0LT5wcml2LT5w cm9jZXNzUG9vbC0+cG9zdE1lc3NhZ2VUb0luamVjdGVkQnVuZGxlKFN0cmluZzo6ZnJvbVVURjgo IlByZWZldGNoRE5TIiksIEFQSTo6RGljdGlvbmFyeTo6Y3JlYXRlKFdURk1vdmUobWVzc2FnZSkp LnB0cigpKTsKKyAgICBjb250ZXh0LT5wcml2LT5wcm9jZXNzUG9vbC0+c2VuZFRvTmV0d29ya2lu Z1Byb2Nlc3MoTWVzc2FnZXM6Ok5ldHdvcmtQcm9jZXNzOjpQcmVmZXRjaEROUyhTdHJpbmc6OmZy b21VVEY4KGhvc3RuYW1lKSkpOwogfQogCiAvKioKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ2xpYi9XZWJLaXRXZWJFeHRlbnNpb24uY3Bw IGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9nbGliL1dlYktp dFdlYkV4dGVuc2lvbi5jcHAKaW5kZXggOGViNTE3OWZiZjIuLjhiNzcyOWQwOTNjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2dsaWIvV2Vi S2l0V2ViRXh0ZW5zaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0 ZWRCdW5kbGUvQVBJL2dsaWIvV2ViS2l0V2ViRXh0ZW5zaW9uLmNwcApAQCAtMTk4LDE3ICsxOTgs NiBAQCBwcml2YXRlOgogI2VuZGlmCiAgICAgfQogCi0gICAgdm9pZCBkaWRSZWNlaXZlTWVzc2Fn ZShJbmplY3RlZEJ1bmRsZSYsIGNvbnN0IFN0cmluZyYgbWVzc2FnZU5hbWUsIEFQSTo6T2JqZWN0 KiBtZXNzYWdlQm9keSkgb3ZlcnJpZGUKLSAgICB7Ci0gICAgICAgIEFTU0VSVChtZXNzYWdlQm9k eS0+dHlwZSgpID09IEFQSTo6T2JqZWN0OjpUeXBlOjpEaWN0aW9uYXJ5KTsKLSAgICAgICAgQVBJ OjpEaWN0aW9uYXJ5JiBtZXNzYWdlID0gKnN0YXRpY19jYXN0PEFQSTo6RGljdGlvbmFyeSo+KG1l c3NhZ2VCb2R5KTsKLSAgICAgICAgaWYgKG1lc3NhZ2VOYW1lID09IFN0cmluZzo6ZnJvbVVURjgo IlByZWZldGNoRE5TIikpIHsKLSAgICAgICAgICAgIEFQSTo6U3RyaW5nKiBob3N0bmFtZSA9IHN0 YXRpY19jYXN0PEFQSTo6U3RyaW5nKj4obWVzc2FnZS5nZXQoU3RyaW5nOjpmcm9tVVRGOCgiSG9z dG5hbWUiKSkpOwotICAgICAgICAgICAgV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkucHJlZmV0Y2hE TlMoaG9zdG5hbWUtPnN0cmluZygpKTsKLSAgICAgICAgfSBlbHNlCi0gICAgICAgICAgICBBU1NF UlRfTk9UX1JFQUNIRUQoKTsKLSAgICB9Ci0KICAgICB2b2lkIGRpZFJlY2VpdmVNZXNzYWdlVG9Q YWdlKEluamVjdGVkQnVuZGxlJiwgV2ViUGFnZSYgcGFnZSwgY29uc3QgU3RyaW5nJiBtZXNzYWdl TmFtZSwgQVBJOjpPYmplY3QqIG1lc3NhZ2VCb2R5KSBvdmVycmlkZQogICAgIHsKICAgICAgICAg QVNTRVJUKG1lc3NhZ2VCb2R5LT50eXBlKCkgPT0gQVBJOjpPYmplY3Q6OlR5cGU6OkRpY3Rpb25h cnkpOwo=