204696 2019-11-29 01:51:10 -0800 [CMake] Ninja can't build WebKitQuartzCoreAdditions of AppleWin port 2019-12-01 18:21:18 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen annulen bfulgham don.olmstead ews-watchlist gyuyoung.kim pvollan ross.kirsling ryuan.choi sergio webkit-bug-importer oldest_to_newest 1594154 0 fujii 2019-11-29 01:51:10 -0800 [CMake] Ninja can't build WebKitQuartzCoreAdditions of AppleWin port build error: > ninja: error: build.ninja:35570: bad $-escape (literal $ must be written as $$) This $ comes from Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CMakeLists.txt: > if (${MSVC_CXX_ARCHITECTURE_ID} STREQUAL "X86") > link_directories($(WINDOWSSDKDIR)Lib/$(WINDOWSSDKLIBVERSION)/um/x86) > else () > link_directories($(WINDOWSSDKDIR)Lib/$(WINDOWSSDKLIBVERSION)/um/x64) > endif () 1594155 1 384491 fujii 2019-11-29 01:57:46 -0800 Created attachment 384491 Patch 1594471 2 384491 fujii 2019-12-01 18:20:25 -0800 Comment on attachment 384491 Patch Clearing flags on attachment: 384491 Committed r252973: <https://trac.webkit.org/changeset/252973> 1594472 3 fujii 2019-12-01 18:20:28 -0800 All reviewed patches have been landed. Closing bug. 1594473 4 webkit-bug-importer 2019-12-01 18:21:18 -0800 <rdar://problem/57547855> 384491 2019-11-29 01:57:46 -0800 2019-12-01 18:20:25 -0800 Patch bug-204696-20191129185745.patch text/plain 1753 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyOTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L3dpbi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9DaGFuZ2VMb2cKaW5k ZXggZTdhMGIzODc3Y2JhNTliZWQwMTVlM2Y3MDY4MTc4MDU0MGIzM2NkMi4uNjEzYjcyYmI4NjQy NzljZGJmZjQxY2U2MGY5MmMzNjY5NGQzZDA3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS93aW4vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTExLTI5ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3Jp LkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtDTWFrZV0gTmluamEgY2FuJ3QgYnVpbGQgV2Vi S2l0UXVhcnR6Q29yZUFkZGl0aW9ucyBvZiBBcHBsZVdpbiBwb3J0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ2OTYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBzZWVtcyB1bm5lY2Vzc2FyeSB0byBl eHBsaWNpdGx5IGFkZCBXaW5kb3dzIFNESyB0byBsaW5rX2RpcmVjdG9yaWVzLgorCisgICAgICAg ICogV2ViS2l0UXVhcnR6Q29yZUFkZGl0aW9ucy9DTWFrZUxpc3RzLnR4dDogUmVtb3ZlZCBsaW5r X2RpcmVjdG9yaWVzIGZvciBXaW5kb3dzIFNESy4KKwogMjAxOS0xMC0zMSAgUnlvc3VrZSBOaXdh ICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBXaW5kb3dzIGJ1aWxkIGZpeCBhdHRlbXB0 IGFmdGVyIHIyNTE3OTguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9XZWJL aXRRdWFydHpDb3JlQWRkaXRpb25zL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYktpdExlZ2Fj eS93aW4vV2ViS2l0UXVhcnR6Q29yZUFkZGl0aW9ucy9DTWFrZUxpc3RzLnR4dAppbmRleCBmMTVk NTNmYzU2MTY5MjgwZmRlNjMwODhiYzJhN2Q4ZjFhOTNhODRlLi40OTBjNDZlZmVmNjUwYWJkMzJj ZDU0ZmYwMTMzZDgxMzAyOGIwMWJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dp bi9XZWJLaXRRdWFydHpDb3JlQWRkaXRpb25zL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9X ZWJLaXRMZWdhY3kvd2luL1dlYktpdFF1YXJ0ekNvcmVBZGRpdGlvbnMvQ01ha2VMaXN0cy50eHQK QEAgLTQ5LDEyICs0OSw2IEBAIGluY2x1ZGVfZGlyZWN0b3JpZXMoCiAgICAgIiR7Q01BS0VfQklO QVJZX0RJUn0vLi4vaW5jbHVkZS9wcml2YXRlIgogKQogCi1pZiAoJHtNU1ZDX0NYWF9BUkNISVRF Q1RVUkVfSUR9IFNUUkVRVUFMICJYODYiKQotICAgIGxpbmtfZGlyZWN0b3JpZXMoJChXSU5ET1dT U0RLRElSKUxpYi8kKFdJTkRPV1NTREtMSUJWRVJTSU9OKS91bS94ODYpCi1lbHNlICgpCi0gICAg bGlua19kaXJlY3RvcmllcygkKFdJTkRPV1NTREtESVIpTGliLyQoV0lORE9XU1NES0xJQlZFUlNJ T04pL3VtL3g2NCkKLWVuZGlmICgpCi0KIGFkZF9saWJyYXJ5KFdlYktpdFF1YXJ0ekNvcmVBZGRp dGlvbnMgU0hBUkVEICR7V2ViS2l0UXVhcnR6Q29yZUFkZGl0aW9uc19TT1VSQ0VTfSkKIHNldF90 YXJnZXRfcHJvcGVydGllcyhXZWJLaXRRdWFydHpDb3JlQWRkaXRpb25zIFBST1BFUlRJRVMgT1VU UFVUX05BTUUgV2ViS2l0UXVhcnR6Q29yZUFkZGl0aW9ucyR7REVCVUdfU1VGRklYfSkKIHRhcmdl dF9saW5rX2xpYnJhcmllcyhXZWJLaXRRdWFydHpDb3JlQWRkaXRpb25zCg==