204688 2019-11-28 10:24:29 -0800 [LFC][IFC] Remove m_inlineRunToLineMap 2019-11-28 12:07:19 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1594076 0 koivisto 2019-11-28 10:24:29 -0800 Add line index to Display::Run and use it to locate the line it is on. 1594078 1 384465 koivisto 2019-11-28 10:37:31 -0800 Created attachment 384465 patch 1594100 2 384465 commit-queue 2019-11-28 12:06:56 -0800 Comment on attachment 384465 patch Clearing flags on attachment: 384465 Committed r252932: <https://trac.webkit.org/changeset/252932> 1594101 3 commit-queue 2019-11-28 12:06:58 -0800 All reviewed patches have been landed. Closing bug. 1594102 4 webkit-bug-importer 2019-11-28 12:07:19 -0800 <rdar://problem/57522801> 384465 2019-11-28 10:37:31 -0800 2019-11-28 12:06:56 -0800 patch lfc-remove-inlineRunToLineMap.patch text/plain 5999 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NzEzNDI1M2UwZi4uNmJhMmNlMGFkZDcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxOS0xMS0yOCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgW0xGQ11bSUZDXSBSZW1vdmUgbV9pbmxpbmVSdW5Ub0xpbmVNYXAKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDY4OAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBsaW5lIGluZGV4 IHRvIERpc3BsYXk6OlJ1biBhbmQgdXNlIGl0IHRvIGxvY2F0ZSB0aGUgbGluZSBpdCBpcyBvbi4K KworICAgICAgICBUaGlzIGlzIDQtNSUgcHJvZ3Jlc3Npb24gaW4gUGVyZm9ybWFuY2VUZXN0cy9M YXlvdXQvbGluZS1sYXlvdXQtc2ltcGxlLmh0bWwKKworICAgICAgICAqIGxheW91dC9kaXNwbGF5 dHJlZS9EaXNwbGF5UnVuLmg6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5OjpSdW46OmxpbmVJ bmRleCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5OjpSdW46OlJ1bik6CisgICAg ICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6c2V0 RGlzcGxheUJveGVzRm9yTGluZSk6CisgICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcv SW5saW5lRm9ybWF0dGluZ1N0YXRlLmg6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OklubGlu ZUZvcm1hdHRpbmdTdGF0ZTo6bGluZUJveEZvclJ1biBjb25zdCk6CisgICAgICAgIChXZWJDb3Jl OjpMYXlvdXQ6OklubGluZUZvcm1hdHRpbmdTdGF0ZTo6YWRkSW5saW5lUnVuKToKKyAgICAgICAg KFdlYkNvcmU6OkxheW91dDo6SW5saW5lRm9ybWF0dGluZ1N0YXRlOjpyZXNldElubGluZVJ1bnMp OgorCiAyMDE5LTExLTI4ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAg ICAgICBbTEZDXVtJRkNdIFZlY3RvciBhbGxvY2F0ZSBJbmxpbmVJdGVtUnVucwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Rpc3BsYXl0cmVlL0Rpc3BsYXlSdW4uaCBiL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9kaXNwbGF5dHJlZS9EaXNwbGF5UnVuLmgKaW5kZXggZTc5OTdkNGJm MDQuLmI2NTc5MTA0OTlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZGlzcGxh eXRyZWUvRGlzcGxheVJ1bi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9kaXNwbGF5dHJl ZS9EaXNwbGF5UnVuLmgKQEAgLTY3LDcgKzY3LDkgQEAgc3RydWN0IFJ1biB7CiAgICAgICAgIE9w dGlvbmFsPEV4cGFuc2lvbkNvbnRleHQ+IG1fZXhwYW5zaW9uQ29udGV4dDsKICAgICB9OwogCi0g ICAgUnVuKGNvbnN0IFJlbmRlclN0eWxlJiwgY29uc3QgUmVjdCYgbG9naWNhbFJlY3QsIE9wdGlv bmFsPFRleHRDb250ZXh0PiA9IFdURjo6bnVsbG9wdCk7CisgICAgUnVuKHNpemVfdCBsaW5lSW5k ZXgsIGNvbnN0IFJlbmRlclN0eWxlJiwgY29uc3QgUmVjdCYgbG9naWNhbFJlY3QsIE9wdGlvbmFs PFRleHRDb250ZXh0PiA9IFdURjo6bnVsbG9wdCk7CisKKyAgICBzaXplX3QgbGluZUluZGV4KCkg Y29uc3QgeyByZXR1cm4gbV9saW5lSW5kZXg7IH0KIAogICAgIGNvbnN0IFJlY3QmIGxvZ2ljYWxS ZWN0KCkgY29uc3QgeyByZXR1cm4gbV9sb2dpY2FsUmVjdDsgfQogCkBAIC05OSwxNCArMTAxLDE2 IEBAIHN0cnVjdCBSdW4gewogCiBwcml2YXRlOgogICAgIC8vIEZJWE1FOiBGaW5kIG91dCB0aGUg RGlzcGxheTo6UnVuIDwtPiBwYWludCBzdHlsZSBzZXR1cC4KKyAgICBjb25zdCBzaXplX3QgbV9s aW5lSW5kZXg7CiAgICAgY29uc3QgUmVuZGVyU3R5bGUmIG1fc3R5bGU7CiAgICAgQ2FjaGVkSW1h Z2UqIG1fY2FjaGVkSW1hZ2UgeyBudWxscHRyIH07CiAgICAgUmVjdCBtX2xvZ2ljYWxSZWN0Owog ICAgIE9wdGlvbmFsPFRleHRDb250ZXh0PiBtX3RleHRDb250ZXh0OwogfTsKIAotaW5saW5lIFJ1 bjo6UnVuKGNvbnN0IFJlbmRlclN0eWxlJiBzdHlsZSwgY29uc3QgUmVjdCYgbG9naWNhbFJlY3Qs IE9wdGlvbmFsPFRleHRDb250ZXh0PiB0ZXh0Q29udGV4dCkKLSAgICA6IG1fc3R5bGUoc3R5bGUp CitpbmxpbmUgUnVuOjpSdW4oc2l6ZV90IGxpbmVJbmRleCwgY29uc3QgUmVuZGVyU3R5bGUmIHN0 eWxlLCBjb25zdCBSZWN0JiBsb2dpY2FsUmVjdCwgT3B0aW9uYWw8VGV4dENvbnRleHQ+IHRleHRD b250ZXh0KQorICAgIDogbV9saW5lSW5kZXgobGluZUluZGV4KQorICAgICwgbV9zdHlsZShzdHls ZSkKICAgICAsIG1fbG9naWNhbFJlY3QobG9naWNhbFJlY3QpCiAgICAgLCBtX3RleHRDb250ZXh0 KHRleHRDb250ZXh0KQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGlu ZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUv bGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQuY3BwCmluZGV4 IDQwODk1ZGEwYWVhLi5mOTE3MDI4YjgxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250 ZXh0LmNwcApAQCAtNDI2LDggKzQyNiw5IEBAIHZvaWQgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6 OnNldERpc3BsYXlCb3hlc0ZvckxpbmUoY29uc3QgTGluZUxheW91dENvbnRleHQ6OkxpCiAgICAg ICAgIH0KICAgICB9CiAKKyAgICBhdXRvIGxpbmVJbmRleCA9IGZvcm1hdHRpbmdTdGF0ZS5saW5l Qm94ZXMoKS5zaXplKCk7CiAgICAgZm9ybWF0dGluZ1N0YXRlLmFkZExpbmVCb3gobGluZUNvbnRl bnQubGluZUJveCk7Ci0gICAgYXV0byYgY3VycmVudExpbmUgPSAqZm9ybWF0dGluZ1N0YXRlLmxp bmVCb3hlcygpLmxhc3QoKTsKKwogICAgIC8vIENvbXB1dGUgYm94IGZpbmFsIGdlb21ldHJ5Lgog ICAgIGF1dG8mIGxpbmVSdW5zID0gbGluZUNvbnRlbnQucnVuTGlzdDsKICAgICBmb3IgKHVuc2ln bmVkIGluZGV4ID0gMDsgaW5kZXggPCBsaW5lUnVucy5zaXplKCk7ICsraW5kZXgpIHsKQEAgLTQ0 MCw3ICs0NDEsNyBAQCB2b2lkIElubGluZUZvcm1hdHRpbmdDb250ZXh0OjpzZXREaXNwbGF5Qm94 ZXNGb3JMaW5lKGNvbnN0IExpbmVMYXlvdXRDb250ZXh0OjpMaQogICAgICAgICAvLyBJbmxpbmUg bGV2ZWwgY29udGFpbmVycyAoPHNwYW4+KSBkb24ndCBnZW5lcmF0ZSBkaXNwbGF5IHJ1bnMgYW5k IG5laXRoZXIgZG8gY29tcGxldGVseSBjb2xsYXBzZWQgcnVucy4KICAgICAgICAgYXV0byBpbml0 aWF0ZXNJbmxpbmVSdW4gPSAhbGluZVJ1bi5pc0NvbnRhaW5lclN0YXJ0KCkgJiYgIWxpbmVSdW4u aXNDb250YWluZXJFbmQoKSAmJiAhbGluZVJ1bi5pc0NvbGxhcHNlZFRvVmlzdWFsbHlFbXB0eSgp OwogICAgICAgICBpZiAoaW5pdGlhdGVzSW5saW5lUnVuKQotICAgICAgICAgICAgZm9ybWF0dGlu Z1N0YXRlLmFkZElubGluZVJ1bihtYWtlVW5pcXVlPERpc3BsYXk6OlJ1bj4obGluZVJ1bi5sYXlv dXRCb3goKS5zdHlsZSgpLCBsaW5lUnVuLmxvZ2ljYWxSZWN0KCksIGxpbmVSdW4udGV4dENvbnRl eHQoKSksIGN1cnJlbnRMaW5lKTsKKyAgICAgICAgICAgIGZvcm1hdHRpbmdTdGF0ZS5hZGRJbmxp bmVSdW4obWFrZVVuaXF1ZTxEaXNwbGF5OjpSdW4+KGxpbmVJbmRleCwgbGluZVJ1bi5sYXlvdXRC b3goKS5zdHlsZSgpLCBsaW5lUnVuLmxvZ2ljYWxSZWN0KCksIGxpbmVSdW4udGV4dENvbnRleHQo KSkpOwogCiAgICAgICAgIGlmIChsaW5lUnVuLmlzRm9yY2VkTGluZUJyZWFrKCkpIHsKICAgICAg ICAgICAgIGRpc3BsYXlCb3guc2V0VG9wTGVmdChsb2dpY2FsUmVjdC50b3BMZWZ0KCkpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9y bWF0dGluZ1N0YXRlLmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9J bmxpbmVGb3JtYXR0aW5nU3RhdGUuaAppbmRleCBkZGEyYTkwNjJiYy4uMTk0NGU0Yzc1ZjYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZv cm1hdHRpbmdTdGF0ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0 aW5nL0lubGluZUZvcm1hdHRpbmdTdGF0ZS5oCkBAIC01NCwyNiArNTQsMjMgQEAgcHVibGljOgog CiAgICAgY29uc3QgSW5saW5lUnVucyYgaW5saW5lUnVucygpIGNvbnN0IHsgcmV0dXJuIG1faW5s aW5lUnVuczsgfQogICAgIElubGluZVJ1bnMmIGlubGluZVJ1bnMoKSB7IHJldHVybiBtX2lubGlu ZVJ1bnM7IH0KLSAgICB2b2lkIGFkZElubGluZVJ1bihzdGQ6OnVuaXF1ZV9wdHI8RGlzcGxheTo6 UnVuPiYmLCBjb25zdCBMaW5lQm94Jik7CisgICAgdm9pZCBhZGRJbmxpbmVSdW4oc3RkOjp1bmlx dWVfcHRyPERpc3BsYXk6OlJ1bj4mJik7CiAgICAgdm9pZCByZXNldElubGluZVJ1bnMoKTsKIAog ICAgIGNvbnN0IExpbmVCb3hlcyYgbGluZUJveGVzKCkgY29uc3QgeyByZXR1cm4gbV9saW5lQm94 ZXM7IH0KICAgICBMaW5lQm94ZXMmIGxpbmVCb3hlcygpIHsgcmV0dXJuIG1fbGluZUJveGVzOyB9 CiAgICAgdm9pZCBhZGRMaW5lQm94KGNvbnN0IExpbmVCb3gmIGxpbmVCb3gpIHsgbV9saW5lQm94 ZXMuYXBwZW5kKG1ha2VVbmlxdWU8TGluZUJveD4obGluZUJveCkpOyB9CiAKLSAgICBjb25zdCBM aW5lQm94JiBsaW5lQm94Rm9yUnVuKGNvbnN0IERpc3BsYXk6OlJ1biYgaW5saW5lUnVuKSBjb25z dCB7IHJldHVybiAqbV9pbmxpbmVSdW5Ub0xpbmVNYXAuZ2V0KCZpbmxpbmVSdW4pOyB9CisgICAg Y29uc3QgTGluZUJveCYgbGluZUJveEZvclJ1bihjb25zdCBEaXNwbGF5OjpSdW4mIGlubGluZVJ1 bikgY29uc3QgeyByZXR1cm4gKm1fbGluZUJveGVzW2lubGluZVJ1bi5saW5lSW5kZXgoKV07IH0K IAogcHJpdmF0ZToKICAgICBJbmxpbmVJdGVtcyBtX2lubGluZUl0ZW1zOwogICAgIElubGluZVJ1 bnMgbV9pbmxpbmVSdW5zOwogICAgIExpbmVCb3hlcyBtX2xpbmVCb3hlczsKLSAgICAvLyBUaGlz IGlzIHRlbXBvcmFyeSB1bnRpbCBhZnRlciB3ZSBmaWd1cmUgb3V0IHRoZSBkaXNwbGF5IHJ1bi9s aW5lIHJlbGF0aW9uc2hpcHMuCi0gICAgSGFzaE1hcDxjb25zdCBEaXNwbGF5OjpSdW4qLCBjb25z dCBMaW5lQm94Kj4gbV9pbmxpbmVSdW5Ub0xpbmVNYXA7CiB9OwogCi1pbmxpbmUgdm9pZCBJbmxp bmVGb3JtYXR0aW5nU3RhdGU6OmFkZElubGluZVJ1bihzdGQ6OnVuaXF1ZV9wdHI8RGlzcGxheTo6 UnVuPiYmIGRpc3BsYXlSdW4sIGNvbnN0IExpbmVCb3gmIGxpbmUpCitpbmxpbmUgdm9pZCBJbmxp bmVGb3JtYXR0aW5nU3RhdGU6OmFkZElubGluZVJ1bihzdGQ6OnVuaXF1ZV9wdHI8RGlzcGxheTo6 UnVuPiYmIGRpc3BsYXlSdW4pCiB7Ci0gICAgbV9pbmxpbmVSdW5Ub0xpbmVNYXAuc2V0KGRpc3Bs YXlSdW4uZ2V0KCksICZsaW5lKTsKICAgICBtX2lubGluZVJ1bnMuYXBwZW5kKFdURk1vdmUoZGlz cGxheVJ1bikpOwogfQogCkBAIC04Miw3ICs3OSw2IEBAIGlubGluZSB2b2lkIElubGluZUZvcm1h dHRpbmdTdGF0ZTo6cmVzZXRJbmxpbmVSdW5zKCkKICAgICBtX2lubGluZVJ1bnMuY2xlYXIoKTsK ICAgICAvLyBSZXNldHRpbmcgdGhlIHJ1bnMgbWVhbnMgbm8gbW9yZSBsaW5lIGJveGVzIGVpdGhl ci4KICAgICBtX2xpbmVCb3hlcy5jbGVhcigpOwotICAgIG1faW5saW5lUnVuVG9MaW5lTWFwLmNs ZWFyKCk7CiAKIH0KIAo=