204683 2019-11-28 07:58:15 -0800 Removed ENABLED_QUEUES logic from ews-app 2019-11-28 08:04:18 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard pmatos webkit-bug-importer oldest_to_newest 1594045 0 aakash_jain 2019-11-28 07:58:15 -0800 Now that ALL_QUEUES and ENABLED_QUEUES are same in ews-app, we should remove the concept of ENABLED_QUEUES, and only rely on ALL_QUEUES. ENABLED_QUEUES concept was added in https://trac.webkit.org/r242880 to hide bubbles for queues which were not deployed in production. Now that all the queues are in production on new EWS (except commit-queue), we don't need this concept anymore. 1594046 1 384457 aakash_jain 2019-11-28 08:02:56 -0800 Created attachment 384457 Patch 1594047 2 aakash_jain 2019-11-28 08:03:38 -0800 Committed r252926: <https://trac.webkit.org/changeset/252926> 1594050 3 webkit-bug-importer 2019-11-28 08:04:18 -0800 <rdar://problem/57521035> 384457 2019-11-28 08:02:56 -0800 2019-11-28 08:02:56 -0800 Patch bug-204683-20191128110255.patch text/plain 2628 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MjkyNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTExLTI4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBSZW1vdmVkIEVOQUJMRURfUVVFVUVTIGxvZ2ljIGZyb20gZXdzLWFwcAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0NjgzCisK KyAgICAgICAgVW5yZXZpZXdlZCBtaW5vciBmaXguCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJibGUucHk6CisgICAgICAgIChTdGF0dXNC dWJibGUpOiBSZW1vdmVkIEVOQUJMRURfUVVFVUVTLgorICAgICAgICAoU3RhdHVzQnViYmxlLl9i dWlsZF9idWJibGVzX2Zvcl9wYXRjaCk6CisgICAgICAgIChTdGF0dXNCdWJibGUuX3Nob3VsZF9z aG93X2J1YmJsZV9mb3JfcXVldWUpOiBEZWxldGVkLgorCiAyMDE5LTExLTI4ICBBYWthc2ggSmFp biAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbZXdzXSBFbmFibGUgV2luZG93 cyBxdWV1ZSBvbiBuZXcgRVdTCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBw L2V3cy92aWV3cy9zdGF0dXNidWJibGUucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mvc3RhdHVzYnViYmxlLnB5CShyZXZpc2lvbiAyNTI5 MjUpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNi dWJibGUucHkJKHdvcmtpbmcgY29weSkKQEAgLTQxLDggKzQxLDYgQEAgY2xhc3MgU3RhdHVzQnVi YmxlKFZpZXcpOgogICAgICMgRklYTUU6IEF1dG8tZ2VuZXJhdGUgdGhpcyBsaXN0IGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU2NDAKICAgICBBTExfUVVFVUVTID0g WydzdHlsZScsICdpb3MnLCAnaW9zLXNpbScsICdtYWMnLCAnbWFjLWRlYnVnJywgJ2d0aycsICd3 cGUnLCAnd2luY2Fpcm8nLCAnd2luJywKICAgICAgICAgICAgICAgICAgICdpb3Mtd2syJywgJ21h Yy13azEnLCAnbWFjLXdrMicsICdtYWMtZGVidWctd2sxJywgJ2FwaS1pb3MnLCAnYXBpLW1hYycs ICdiaW5kaW5ncycsICdqc2MnLCAnanNjLWFybXY3JywgJ2pzYy1taXBzJywgJ3dlYmtpdHBlcmwn LCAnd2Via2l0cHknLCAnc2VydmljZXMnXQotICAgIEVOQUJMRURfUVVFVUVTID0gWydzdHlsZScs ICdpb3MnLCAnaW9zLXNpbScsICdtYWMnLCAnbWFjLWRlYnVnJywgJ2d0aycsICd3cGUnLCAnd2lu Y2Fpcm8nLCAnd2luJywKLSAgICAgICAgICAgICAgICAgICAgICAnaW9zLXdrMicsICdtYWMtd2sx JywgJ21hYy13azInLCAnbWFjLWRlYnVnLXdrMScsICdhcGktaW9zJywgJ2FwaS1tYWMnLCAnYmlu ZGluZ3MnLCAnanNjJywgJ2pzYy1hcm12NycsICdqc2MtbWlwcycsICd3ZWJraXRwZXJsJywgJ3dl YmtpdHB5JywgJ3NlcnZpY2VzJ10KICAgICAjIEZJWE1FOiBBdXRvLWdlbmVyYXRlIHRoZSBxdWV1 ZSdzIHRyaWdnZXIgcmVsYXRpb25zaGlwCiAgICAgUVVFVUVfVFJJR0dFUlMgPSB7CiAgICAgICAg ICdhcGktaW9zJzogJ2lvcy1zaW0nLApAQCAtMjQ5LDkgKzI0Nyw2IEBAIGNsYXNzIFN0YXR1c0J1 YmJsZShWaWV3KToKICAgICAgICAgICAgIHJldHVybiBGYWxzZQogICAgICAgICByZXR1cm4gVHJ1 ZQogCi0gICAgZGVmIF9zaG91bGRfc2hvd19idWJibGVfZm9yX3F1ZXVlKHNlbGYsIHF1ZXVlKToK LSAgICAgICAgcmV0dXJuIHF1ZXVlIGluIFN0YXR1c0J1YmJsZS5FTkFCTEVEX1FVRVVFUwotCiAg ICAgZGVmIF9xdWV1ZV9wb3NpdGlvbihzZWxmLCBwYXRjaCwgcXVldWUsIHBhcmVudF9xdWV1ZT1O b25lKToKICAgICAgICAgIyBGSVhNRTogSGFuZGxlIHJldHJpZWQgYnVpbGRzIGFuZCBjYW5jZWxs ZWQgYnVpbGQtcmVxdWVzdHMgYXMgd2VsbC4KICAgICAgICAgZnJvbV90aW1lc3RhbXAgPSB0aW1l em9uZS5ub3coKSAtIGRhdGV0aW1lLnRpbWVkZWx0YShkYXlzPVN0YXR1c0J1YmJsZS5EQVlTX1RP X0NIRUNLKQpAQCAtMjkwLDkgKzI4NSw2IEBAIGNsYXNzIFN0YXR1c0J1YmJsZShWaWV3KToKICAg ICAgICAgICAgIHJldHVybiAoTm9uZSwgc2hvd19zdWJtaXRfdG9fZXdzLCBmYWlsZWRfdG9fYXBw bHksIHNob3dfcmV0cnkpCiAKICAgICAgICAgZm9yIHF1ZXVlIGluIFN0YXR1c0J1YmJsZS5BTExf UVVFVUVTOgotICAgICAgICAgICAgaWYgbm90IHNlbGYuX3Nob3VsZF9zaG93X2J1YmJsZV9mb3Jf cXVldWUocXVldWUpOgotICAgICAgICAgICAgICAgIGNvbnRpbnVlCi0KICAgICAgICAgICAgIGJ1 YmJsZSA9IHNlbGYuX2J1aWxkX2J1YmJsZShwYXRjaCwgcXVldWUsIGhpZGVfaWNvbnMpCiAgICAg ICAgICAgICBpZiBidWJibGU6CiAgICAgICAgICAgICAgICAgc2hvd19zdWJtaXRfdG9fZXdzID0g RmFsc2UK