20467 2008-08-20 15:21:50 -0700 Should allow 0 (without units) as a time value for durations and delays 2008-08-21 16:37:52 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Enhancement --- 1 cmarrin webkit-unassigned dino mitz simon.fraser oldest_to_newest 88953 0 cmarrin 2008-08-20 15:21:50 -0700 The CSS spec allows '0' without units for length values. WebKit has extended this by allowing the same unitless value for angles. It should also allow the same for time values. A value of '0' should be parsed the same as '0s'. 88955 1 22903 cmarrin 2008-08-20 15:45:58 -0700 Created attachment 22903 Patch, including LayoutTest files 88957 2 22903 hyatt 2008-08-20 15:49:36 -0700 Comment on attachment 22903 Patch, including LayoutTest files How odd. I know I wrote this same patch ages ago (back when I was first doing transitions). Did I never land it? r=me 88964 3 simon.fraser 2008-08-20 16:18:51 -0700 Testcase needs wording changes, and changelog entries have tabs. 88965 4 mitz 2008-08-20 16:21:13 -0700 (In reply to comment #2) > (From update of attachment 22903 [edit]) > How odd. I know I wrote this same patch ages ago (back when I was first doing > transitions). Did I never land it? Weird, I am also almost certain that "0" used to work at some point. 89031 5 dino 2008-08-21 16:35:54 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/css1/units/zero-duration-without-units-expected.txt A LayoutTests/css1/units/zero-duration-without-units.html M WebCore/ChangeLog M WebCore/css/CSSParser.cpp Committed r35879 89034 6 cmarrin 2008-08-21 16:37:52 -0700 patch committed 22903 2008-08-20 15:45:58 -0700 2008-08-20 15:49:36 -0700 Patch, including LayoutTest files 20467.patch text/plain 4077 cmarrin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTg2MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDgtMjAgIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisJRml4IGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQ2NworCisgICAgICAgIFRlc3Q6 IGNzczEvdW5pdHMvemVyby1kdXJhdGlvbi13aXRob3V0LXVuaXRzLmh0bWwKKworICAgICAgICAq IGNzcy9DU1NQYXJzZXIuY3BwOiAKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6dmFsaWRV bml0KToKKwogMjAwOC0wOC0yMCAgQ2hyaXMgVGVhZ3VlICA8Y2hyaXMudGVhZ3VlQGdtYWlsLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJrIFJvd2UuCkluZGV4OiBXZWJDb3JlL2Nzcy9D U1NQYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAJKHJl dmlzaW9uIDM1ODYxKQorKysgV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDA4LDggKzQwOCw5IEBAIGJvb2wgQ1NTUGFyc2VyOjp2YWxpZFVuaXQoQ1NTUGFyc2Vy VmFsdWUKICAgICBzd2l0Y2godmFsdWUtPnVuaXQpIHsKICAgICBjYXNlIENTU1ByaW1pdGl2ZVZh bHVlOjpDU1NfTlVNQkVSOgogICAgICAgICBiID0gKHVuaXRmbGFncyAmIEZOdW1iZXIpOwotICAg ICAgICBpZiAoIWIgJiYgKCh1bml0ZmxhZ3MgJiAoRkxlbmd0aCB8IEZBbmdsZSkpICYmICh2YWx1 ZS0+ZlZhbHVlID09IDAgfHwgIXN0cmljdCkpKSB7Ci0gICAgICAgICAgICB2YWx1ZS0+dW5pdCA9 ICh1bml0ZmxhZ3MgJiBGTGVuZ3RoKSA/IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfUFggOiBDU1NQ cmltaXRpdmVWYWx1ZTo6Q1NTX0RFRzsKKyAgICAgICAgaWYgKCFiICYmICgodW5pdGZsYWdzICYg KEZMZW5ndGggfCBGQW5nbGUgfCBGVGltZSkpICYmICh2YWx1ZS0+ZlZhbHVlID09IDAgfHwgIXN0 cmljdCkpKSB7CisgICAgICAgICAgICB2YWx1ZS0+dW5pdCA9ICh1bml0ZmxhZ3MgJiBGTGVuZ3Ro KSA/IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfUFggOiAKKyAgICAgICAgICAgICAgICAgICAgICAg ICgodW5pdGZsYWdzICYgRkFuZ2xlKSA/IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfREVHIDogQ1NT UHJpbWl0aXZlVmFsdWU6OkNTU19TKTsKICAgICAgICAgICAgIGIgPSB0cnVlOwogICAgICAgICB9 CiAgICAgICAgIGlmICghYiAmJiAodW5pdGZsYWdzICYgRkludGVnZXIpICYmIHZhbHVlLT5pc0lu dCkKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDM1ODYzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgtMDgtMjAgIENocmlzIE1hcnJpbiAg PGNtYXJyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisJRml4IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0 NjcKKworICAgICAgICAqIGNzczEvdW5pdHMvemVyby1kdXJhdGlvbi13aXRob3V0LXVuaXRzLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogY3NzMS91bml0cy96ZXJvLWR1cmF0aW9uLXdp dGhvdXQtdW5pdHMuaHRtbDogQWRkZWQuCisKIDIwMDgtMDgtMjAgIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dApJ bmRleDogTGF5b3V0VGVzdHMvY3NzMS91bml0cy96ZXJvLWR1cmF0aW9uLXdpdGhvdXQtdW5pdHMt ZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2NzczEvdW5pdHMvemVyby1k dXJhdGlvbi13aXRob3V0LXVuaXRzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91 dFRlc3RzL2NzczEvdW5pdHMvemVyby1kdXJhdGlvbi13aXRob3V0LXVuaXRzLWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzIEBACitCb3ggc2hvdWxkIHN0YXJ0IG1vdmluZyBs ZWZ0IGFmdGVyIGxlZnQgc3R5bGUgaXMgcmVzZXQgYWZ0ZXIgNTAwbXMKKworUEFTUwpJbmRleDog TGF5b3V0VGVzdHMvY3NzMS91bml0cy96ZXJvLWR1cmF0aW9uLXdpdGhvdXQtdW5pdHMuaHRtbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9jc3MxL3VuaXRzL3plcm8tZHVyYXRpb24td2l0aG91 dC11bml0cy5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvY3NzMS91bml0cy96ZXJv LWR1cmF0aW9uLXdpdGhvdXQtdW5pdHMuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0NCBA QAorPCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlv bmFsLy9FTiIKKyAgICJodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNC9sb29zZS5kdGQiPgorCis8 aHRtbCBsYW5nPSJlbiI+Cis8aGVhZD4KKyAgPG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBl IiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9dXRmLTgiPgorICA8dGl0bGU+WmVybyBEdXJh dGlvbiBXaXRob3V0IFVuaXRzPC90aXRsZT4KKyAgPHN0eWxlIHR5cGU9InRleHQvY3NzIiBtZWRp YT0ic2NyZWVuIj4KKyAgICAjYm94IHsKKyAgICAgIGhlaWdodDogMTAwcHg7CisgICAgICB3aWR0 aDogMTAwcHg7CisgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOworICAgICAgLXdlYmtpdC10 cmFuc2l0aW9uLXByb3BlcnR5OiB0b3AsIGxlZnQ7CisgICAgICAtd2Via2l0LXRyYW5zaXRpb24t ZHVyYXRpb246IDFzOworICAgICAgLXdlYmtpdC10cmFuc2l0aW9uLWR1cmF0aW9uOiAwOworICAg ICAgLXdlYmtpdC10cmFuc2l0aW9uLXRpbWluZy1mdW5jdGlvbjogbGluZWFyOworICAgIH0KKyAg PC9zdHlsZT4KKyAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIGNoYXJzZXQ9InV0Zi04 Ij4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53 YWl0VW50aWxEb25lKCk7CisgICAgfQorCisgICAgZnVuY3Rpb24gdGVzdCgpCisgICAgeworICAg ICAgICB2YXIgYm94ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2JveCcpOworICAgICAgICB2 YXIgZHVyID0gcGFyc2VJbnQod2luZG93LmdldENvbXB1dGVkU3R5bGUoYm94KS53ZWJraXRUcmFu c2l0aW9uRHVyYXRpb24pOworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVzdWx0 JykuaW5uZXJIVE1MID0gKGR1ciA9PSAwKSA/ICJQQVNTIiA6ICJGQUlMIjsKKyAgICAgICAgaWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgIGxheW91dFRlc3RDb250 cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgICB9CisgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIo J2xvYWQnLCB0ZXN0LCBmYWxzZSkKKyAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKworPHA+ Qm94IHNob3VsZCBzdGFydCBtb3ZpbmcgbGVmdCBhZnRlciBsZWZ0IHN0eWxlIGlzIHJlc2V0IGFm dGVyIDUwMG1zPC9wPgorICA8ZGl2IGlkPSJib3giPgorICA8L2Rpdj4KKzxkaXYgaWQ9InJlc3Vs dCI+Cis8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4K